create-sdd-project 0.16.5 → 0.16.7

package/lib/doctor.js

@@ -70,6 +70,9 @@ function runDoctor(cwd) {
   // 11. Autonomy/Skills Consistency
   results.push(checkAutonomySkillConsistency(cwd, aiTools));
 
+  // 12. Gemini Settings Format
+  results.push(checkGeminiSettings(cwd, aiTools));
+
   return results;
 }
 
@@ -529,6 +532,87 @@ function checkAutonomySkillConsistency(cwd, aiTools) {
   };
 }
 
+function checkGeminiSettings(cwd, aiTools) {
+  if (aiTools === 'claude') {
+    return {
+      status: PASS,
+      message: 'Gemini settings: N/A (Claude only)',
+      details: [],
+    };
+  }
+
+  const settingsPath = path.join(cwd, '.gemini', 'settings.json');
+  if (!fs.existsSync(settingsPath)) {
+    return {
+      status: WARN,
+      message: 'Gemini settings: .gemini/settings.json missing',
+      details: ['Run: npx create-sdd-project --upgrade to recreate from template'],
+    };
+  }
+
+  let settings;
+  try {
+    settings = JSON.parse(fs.readFileSync(settingsPath, 'utf8'));
+  } catch (e) {
+    return {
+      status: FAIL,
+      message: 'Gemini settings: invalid JSON',
+      details: [e.message],
+    };
+  }
+
+  // Detectably-broken formats only — do NOT enforce stricter rules than upstream Gemini.
+  if (typeof settings.model === 'string') {
+    return {
+      status: FAIL,
+      message: 'Gemini settings: obsolete model format (string instead of object)',
+      details: [
+        `Found: "model": "${settings.model}"`,
+        `Expected: "model": { "name": "${settings.model}" }`,
+        'Gemini CLI silently falls back to defaults when model is a string, ignoring this file.',
+        'Verified against Gemini CLI 0.34.0. Run: npx create-sdd-project --upgrade',
+      ],
+    };
+  }
+
+  if (settings.model !== undefined && (
+    settings.model === null ||
+    Array.isArray(settings.model) ||
+    typeof settings.model !== 'object'
+  )) {
+    const got = Array.isArray(settings.model)
+      ? 'array'
+      : settings.model === null
+        ? 'null'
+        : typeof settings.model;
+    return {
+      status: FAIL,
+      message: 'Gemini settings: model field has invalid type',
+      details: [
+        'Expected: object with a "name" property (or absent)',
+        `Got: ${got}`,
+        'Run: npx create-sdd-project --upgrade',
+      ],
+    };
+  }
+
+  if (typeof settings.model === 'object' && !settings.model.name) {
+    return {
+      status: WARN,
+      message: 'Gemini settings: model object is missing "name" property',
+      details: [
+        'Gemini accepts this but the model is unset. Add: { "name": "gemini-2.5-pro" }',
+      ],
+    };
+  }
+
+  return {
+    status: PASS,
+    message: 'Gemini settings: valid',
+    details: [],
+  };
+}
+
 module.exports = {
   runDoctor,
   printResults,

package/lib/upgrade-generator.js

@@ -255,17 +255,40 @@ function generateUpgrade(config) {
         }
       }
 
-      // Merge settings.json — update hooks from template, preserve user's permissions/additionalDirectories
+      // Merge settings.json — strategy depends on the tool:
+      // .claude: template-owned (hooks from template), preserve user permissions/additionalDirectories
+      // .gemini: user-owned, only migrate the model field if it's in the obsolete string format
       const settingsSrc = path.join(templateToolDir, 'settings.json');
       const settingsDest = path.join(base, 'settings.json');
       if (fs.existsSync(settingsSrc)) {
         const templateSettings = JSON.parse(fs.readFileSync(settingsSrc, 'utf8'));
         if (fs.existsSync(settingsDest)) {
           const userSettings = JSON.parse(fs.readFileSync(settingsDest, 'utf8'));
-          // Keep user's permissions and additionalDirectories, take template's hooks
-          const merged = { ...templateSettings };
-          if (userSettings.permissions) merged.permissions = userSettings.permissions;
-          if (userSettings.additionalDirectories) merged.additionalDirectories = userSettings.additionalDirectories;
+          let merged;
+          if (dir === '.claude') {
+            // Claude: take template, restore user's permissions/additionalDirectories
+            merged = { ...templateSettings };
+            if (userSettings.permissions) merged.permissions = userSettings.permissions;
+            if (userSettings.additionalDirectories) merged.additionalDirectories = userSettings.additionalDirectories;
+          } else {
+            // Gemini: preserve all user keys, only migrate model field
+            merged = { ...userSettings };
+            if (typeof userSettings.model === 'string') {
+              // Obsolete format: convert "model": "name" → "model": { "name": "name" }
+              merged.model = { name: userSettings.model };
+            } else if (
+              userSettings.model !== undefined && (
+                userSettings.model === null ||
+                Array.isArray(userSettings.model) ||
+                typeof userSettings.model !== 'object' ||
+                !userSettings.model.name
+              )
+            ) {
+              // Malformed (null, array, primitive, object without name) → reset to template default
+              merged.model = { ...templateSettings.model };
+            }
+            // Otherwise (valid object with name, or absent): leave as-is
+          }
           fs.writeFileSync(settingsDest, JSON.stringify(merged, null, 2) + '\n', 'utf8');
         } else {
           fs.copyFileSync(settingsSrc, settingsDest);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "create-sdd-project",
-  "version": "0.16.5",
+  "version": "0.16.7",
   "description": "Create a new SDD DevFlow project with AI-assisted development workflow",
   "bin": {
     "create-sdd-project": "bin/cli.js"

package/template/.gemini/settings.json

@@ -1,5 +1,5 @@
 {
-  "model": "gemini-2.5-pro",
+  "model": { "name": "gemini-2.5-pro" },
   "temperature": 0.2,
   "instructions": "Follow the development standards in ai-specs/specs/base-standards.mdc. Use the agent instructions in .gemini/agents/ for specialized tasks. Use the workflow skills in .gemini/skills/ for task orchestration. Custom commands are available in .gemini/commands/."
 }

package/template/.github/workflows/ci.yml

@@ -54,3 +54,32 @@ jobs:
 
       - name: Build
         run: npm run build --if-present
+
+# ===========================================
+# Scaling tips
+# ===========================================
+# When this project grows and you split CI into multiple jobs with path
+# filters (e.g., test-api, test-frontend triggered only when relevant files
+# change), enabling branch protection that requires those individual checks
+# will create a deadlock for docs-only PRs: no code changed → no jobs run →
+# required checks never report → merge blocked.
+#
+# Solution: add a rollup job that always runs and aggregates the others.
+# Then configure branch protection to require ONLY the rollup, not the
+# individual jobs:
+#
+#   ci-success:
+#     runs-on: ubuntu-latest
+#     needs: [test-api, test-frontend]   # list all jobs to aggregate
+#     if: always()
+#     steps:
+#       - name: All required jobs passed or were skipped
+#         run: |
+#           if [[ "${{ contains(needs.*.result, 'failure') }}" == "true" ]]; then
+#             echo "One or more required jobs failed"
+#             exit 1
+#           fi
+#
+# The rollup passes when all dependencies pass OR were skipped due to path
+# filters. This is the standard pattern for path-filtered CI + required
+# checks. Avoid `|| true` and `continue-on-error` — they silence real failures.