create-react-on-rails-app 16.7.0-rc.3 → 17.0.0-rc.1

package/lib/create-app.js

@@ -138,9 +138,10 @@ function buildGeneratorArgs(options) {
     if (options.template === 'typescript') {
         args.push('--typescript');
     }
-    if (options.rspack) {
-        args.push('--rspack');
-    }
+    // Always forward an explicit --rspack / --no-rspack so the generator never falls back to
+    // its own default. This keeps create-app's resolved choice authoritative regardless of what
+    // the generator's fresh-install default happens to be (now, or if it changes again later).
+    args.push(options.rspack ? '--rspack' : '--no-rspack');
     // --rsc supersedes --pro because RSC mode already requires Pro and the generator accepts a single mode flag.
     if (options.pro && !options.rsc) {
         args.push('--pro');

package/lib/index.js

@@ -13,7 +13,7 @@ const prompt_js_1 = require("./prompt.js");
 // Use require() for CJS compatibility - avoids __dirname + fs.readFileSync
 // eslint-disable-next-line @typescript-eslint/no-require-imports, global-require
 const packageJson = require('../package.json');
-async function run(appName, rawOpts) {
+async function run(appName, rawOpts, command) {
     const { template } = rawOpts;
     if (typeof template !== 'string' || (template !== 'javascript' && template !== 'typescript')) {
         (0, utils_js_1.logError)(`Invalid template "${String(template)}". Must be "javascript" or "typescript".`);
@@ -33,6 +33,15 @@ async function run(appName, rawOpts) {
         (0, utils_js_1.logError)('--standard cannot be combined with --pro or --rsc.');
         process.exit(1);
     }
+    // --webpack is a friendly alias for --no-rspack. Commander reports --no-rspack's declared
+    // default as rawOpts.rspack === true, so we use the option source to distinguish an explicit
+    // --rspack from the default and reject contradictory flags (--rspack --webpack).
+    const rspackExplicitlyTrue = rawOpts.rspack === true && command?.getOptionValueSource('rspack') === 'cli';
+    const webpackRequested = rawOpts.webpack === true;
+    if (webpackRequested && rspackExplicitlyTrue) {
+        (0, utils_js_1.logError)('Conflicting bundler flags: pass either --rspack or --webpack (alias for --no-rspack), not both.');
+        process.exit(1);
+    }
     let pro = Boolean(rawOpts.pro);
     let rsc = Boolean(rawOpts.rsc);
     console.log('');
@@ -59,7 +68,15 @@ async function run(appName, rawOpts) {
     const options = {
         template,
         packageManager: packageManager,
-        rspack: Boolean(rawOpts.rspack),
+        // Rspack is the default; an explicit --no-rspack or its --webpack alias selects Webpack.
+        // (rawOpts.rspack ?? true) makes the three inputs explicit: undefined (no flag) -> true,
+        // true (--rspack) -> true, false (--no-rspack) -> false.
+        // Footgun: re-adding `.option('--rspack', desc, false)` would default rawOpts.rspack to
+        // false and silently flip the default back to Webpack.
+        // Note: buildGeneratorArgs always forwards an explicit --rspack/--no-rspack to the Ruby
+        // generator, so the generator's own fresh-install fallback (fresh_install_rspack_default,
+        // which consults the Shakapacker version) is never reached via create-react-on-rails-app.
+        rspack: webpackRequested ? false : (rawOpts.rspack ?? true) === true,
         pro,
         rsc,
     };
@@ -100,7 +117,7 @@ async function run(appName, rawOpts) {
     else if (options.pro) {
         modeLabel = ', mode: pro';
     }
-    (0, utils_js_1.logInfo)(`Creating "${appName}" with template: ${options.template}, package manager: ${options.packageManager}${options.rspack ? ', bundler: rspack' : ''}${modeLabel}`);
+    (0, utils_js_1.logInfo)(`Creating "${appName}" with template: ${options.template}, package manager: ${options.packageManager}, bundler: ${options.rspack ? 'rspack' : 'webpack'}${modeLabel}`);
     (0, create_app_js_1.createApp)(appName, options);
 }
 const program = new commander_1.Command();
@@ -113,7 +130,9 @@ program
     .argument('<app-name>', 'Name of the application to create')
     .option('-t, --template <type>', 'javascript or typescript', 'typescript')
     .option('-p, --package-manager <pm>', 'npm or pnpm (auto-detected if not specified)')
-    .option('--rspack', 'Use Rspack instead of Webpack (~20x faster builds)', false)
+    .option('--rspack', 'Use Rspack as the bundler (default, ~20x faster builds)')
+    .option('--no-rspack', 'Use Webpack instead of Rspack')
+    .option('--webpack', 'Use Webpack as the bundler (alias for --no-rspack)')
     .option('--standard', 'Generate open-source React on Rails setup (skip prompt)')
     .option('--pro', 'Generate React on Rails Pro setup (installs react_on_rails_pro)')
     .option('--rsc', 'Generate React Server Components setup (installs react_on_rails_pro)')
@@ -124,8 +143,9 @@ Examples:
   $ npx create-react-on-rails-app my-app --pro                  # skip prompt, use Pro
   $ npx create-react-on-rails-app my-app --standard             # skip prompt, use Standard
   $ npx create-react-on-rails-app my-app --template javascript
-  $ npx create-react-on-rails-app my-app --rspack
-  $ npx create-react-on-rails-app my-app --rspack --rsc
+  $ npx create-react-on-rails-app my-app --no-rspack             # use Webpack instead of Rspack
+  $ npx create-react-on-rails-app my-app --webpack               # same as --no-rspack
+  $ npx create-react-on-rails-app my-app --no-rspack --rsc
   $ npx create-react-on-rails-app my-app --package-manager pnpm
 
 When no mode flag (--standard, --pro, or --rsc) is given, an interactive prompt
@@ -152,9 +172,9 @@ The generated app includes one git commit per logical setup step.`)
 --pro and --rsc support both JavaScript and TypeScript templates.
 
 Documentation: https://reactonrails.com/docs/`)
-    .action(async (appName, opts) => {
+    .action(async (appName, opts, command) => {
     try {
-        await run(appName, opts);
+        await run(appName, opts, command);
     }
     catch (error) {
         if (error instanceof Error && error.message === prompt_js_1.PROMPT_CANCELLED) {

package/lib/validators.js

@@ -9,7 +9,7 @@ exports.validateAll = validateAll;
 const utils_js_1 = require("./utils.js");
 const MIN_NODE_VERSION = 18;
 const MIN_RUBY_MAJOR = 3;
-const MIN_RUBY_MINOR = 0;
+const MIN_RUBY_MINOR = 3;
 const MIN_RAILS_MAJOR = 7;
 const MIN_RAILS_MINOR = 0;
 function validateNode() {
@@ -30,7 +30,7 @@ function validateRuby() {
         return {
             valid: false,
             message: 'Ruby is not installed or not found in PATH.\n\n' +
-                'React on Rails requires Ruby 3.0+.\n\n' +
+                `React on Rails requires Ruby ${MIN_RUBY_MAJOR}.${MIN_RUBY_MINOR}+.\n\n` +
                 'Popular installation options:\n' +
                 '  - mise:   https://mise.jdx.dev/ (recommended)\n' +
                 '  - rbenv:  https://github.com/rbenv/rbenv\n' +

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "create-react-on-rails-app",
-  "version": "16.7.0-rc.3",
+  "version": "17.0.0-rc.1",
   "description": "Create React on Rails applications with a single command",
   "bin": {
     "create-react-on-rails-app": "./bin/create-react-on-rails-app.js"