create-quiver 0.14.0 → 0.15.0

package/src/create-quiver/commands/spec.js

@@ -2,6 +2,9 @@ const fs = require('node:fs');
 const path = require('node:path');
 
 const { checkHandoff } = require('../lib/handoff');
+const { openEditor } = require('../lib/cli/editor');
+const { selectOption } = require('../lib/cli/selectors');
+const { createUx } = require('../lib/cli/ux');
 const { parseJsonWithComments } = require('../lib/json');
 const { assertPathInsideRoot, validateProjectRelativePaths } = require('../lib/paths');
 const { resolveReviewedTechnicalPlanInput } = require('../lib/ai/plan-review');
@@ -362,6 +365,10 @@ function formatSpecCreateDryRun(preview) {
     lines.push(`- ${file}`);
   }
 
+  if (preview.reviewRequested) {
+    lines.push('Review requested: yes (dry-run preview only; no editor opened and no files written).');
+  }
+
   lines.push(...formatNextCommands(preview.relativeSpecDir));
   lines.push('No files will be written in dry-run mode.');
   return `${lines.join('\n')}\n`;
@@ -384,11 +391,162 @@ function formatSpecCreateResult(result, repoRoot) {
   return `${lines.join('\n')}\n`;
 }
 
-function runCreateSpec(repoRoot, options = {}) {
+function createSpecReviewFile(preview, options = {}) {
+  const os = require('node:os');
+  const reviewDir = options.reviewDir || fs.mkdtempSync(path.join(os.tmpdir(), 'quiver-spec-create-review-'));
+  const reviewPath = path.join(reviewDir, 'spec-create-preview.md');
+  fs.mkdirSync(reviewDir, { recursive: true });
+  fs.writeFileSync(reviewPath, formatSpecCreateDryRun({ ...preview, reviewRequested: false }));
+  return reviewPath;
+}
+
+const SPEC_METHODOLOGY_OPTIONS = Object.freeze([
+  {
+    label: 'WDD + SDD',
+    value: 'wdd-sdd',
+    hint: 'Workflow Driven Development + Spec Driven Development',
+    default: true,
+  },
+]);
+
+async function resolveInteractiveSpecCreateOptions(repoRoot, preview, options = {}) {
+  if (options.interactive !== true) {
+    return options;
+  }
+
+  const ux = options.ux || createUx({
+    interactive: true,
+    promptConfirm: options.promptConfirm,
+    stdinIsTTY: options.stdinIsTTY,
+    stdoutIsTTY: options.stdoutIsTTY,
+    stderrIsTTY: options.stderrIsTTY,
+    write: options.write,
+  });
+
+  if (!ux.mode.usePrompts) {
+    throw new Error(formatError('spec create --interactive requires an interactive TTY. Use --input, --spec, --review, and --dry-run for non-interactive automation.'));
+  }
+
+  const selectorOptions = {
+    env: options.env,
+    input: options.inputStream,
+    interactive: true,
+    noColor: options.noColor,
+    output: options.output,
+    prompts: options.prompts,
+    promptSelect: options.promptSelect,
+    stderrIsTTY: options.stderrIsTTY,
+    stdinIsTTY: options.stdinIsTTY,
+    stdoutIsTTY: options.stdoutIsTTY,
+  };
+  const selectedMethodology = await selectOption('¿Qué metodología aplica esta spec?', SPEC_METHODOLOGY_OPTIONS, {
+    ...selectorOptions,
+    defaultValue: 'wdd-sdd',
+    flag: '--methodology',
+    name: 'methodology',
+    value: options.methodology || '',
+  });
+  const selectedInput = await selectOption('¿Qué plan aprobado querés usar?', [
+    {
+      label: preview.inputPath,
+      value: preview.inputPath,
+      hint: 'Plan técnico revisado y aprobado',
+      default: true,
+    },
+  ], {
+    ...selectorOptions,
+    defaultValue: preview.inputPath,
+    flag: '--input',
+    name: 'approved technical plan input',
+    value: options.input || '',
+  });
+  const selectedReview = await selectOption('¿Cómo querés revisar antes de escribir?', [
+    {
+      label: 'Crear despues de confirmar',
+      value: 'direct',
+      hint: 'Muestra resumen y pide aprobacion final',
+      default: options.review !== true,
+    },
+    {
+      label: 'Abrir preview de review',
+      value: 'review',
+      hint: 'Usa $VISUAL o $EDITOR antes de escribir',
+      default: options.review === true,
+    },
+  ], {
+    ...selectorOptions,
+    defaultValue: options.review === true ? 'review' : 'direct',
+    flag: '--review',
+    name: 'spec create review mode',
+  });
+
+  ux.summary([
+    { label: 'Spec', value: preview.manifest.slug },
+    { label: 'Metodologia', value: selectedMethodology.label },
+    { label: 'Input', value: selectedInput.value },
+    { label: 'Target', value: preview.relativeSpecDir },
+    { label: 'Archivos planificados', value: preview.preview.files.length },
+    { label: 'Revision', value: selectedReview.value === 'review' ? 'abrir preview' : 'confirmacion directa' },
+  ], { title: 'Spec create' });
+
+  return {
+    ...options,
+    input: selectedInput.value,
+    methodology: selectedMethodology.value,
+    review: selectedReview.value === 'review',
+    ux,
+  };
+}
+
+async function confirmSpecCreate(message, options = {}) {
+  if (options.interactive !== true) {
+    return;
+  }
+
+  const ux = options.ux || createUx({
+    interactive: true,
+    promptConfirm: options.promptConfirm,
+    stdinIsTTY: options.stdinIsTTY,
+    stdoutIsTTY: options.stdoutIsTTY,
+    stderrIsTTY: options.stderrIsTTY,
+    write: options.write,
+  });
+  const confirmed = await ux.promptConfirm(message, { initialValue: false });
+  if (!confirmed) {
+    throw new Error(formatError('spec create interactive approval declined. No files were written.'));
+  }
+}
+
+async function reviewSpecCreatePreview(repoRoot, preview, options = {}) {
+  if (options.review !== true) {
+    return '';
+  }
+
+  const reviewPath = createSpecReviewFile(preview, options);
+  const hasEditorRunner = typeof options.openEditorFn === 'function';
+  const canOpenEditor = hasEditorRunner || options.stdinIsTTY === true || (options.stdinIsTTY !== false && Boolean(process.stdin.isTTY));
+
+  if (!canOpenEditor) {
+    throw new Error(formatError(`spec create --review requires an interactive terminal or an injected editor runner.\nReview artifact: ${reviewPath}`));
+  }
+
+  const editorResult = hasEditorRunner
+    ? options.openEditorFn(reviewPath, { cwd: repoRoot, env: options.env || process.env })
+    : openEditor(reviewPath, { cwd: repoRoot, env: options.env || process.env });
+
+  if (!editorResult || editorResult.ok !== true) {
+    throw new Error(formatError(`${editorResult?.reason || 'spec create review was canceled.'}\nReview artifact: ${reviewPath}`));
+  }
+
+  return reviewPath;
+}
+
+async function runCreateSpec(repoRoot, options = {}) {
   const preview = buildSpecCreatePreview(repoRoot, options);
+  const resolvedOptions = await resolveInteractiveSpecCreateOptions(repoRoot, preview, options);
 
-  if (options.dryRun) {
-    process.stdout.write(formatSpecCreateDryRun(preview));
+  if (resolvedOptions.dryRun) {
+    process.stdout.write(formatSpecCreateDryRun({ ...preview, reviewRequested: resolvedOptions.review === true }));
     return {
       task: 'spec-create',
       dryRun: true,
@@ -398,9 +556,12 @@ function runCreateSpec(repoRoot, options = {}) {
     };
   }
 
+  const reviewPath = await reviewSpecCreatePreview(repoRoot, preview, resolvedOptions);
+  await confirmSpecCreate(`Create spec '${preview.manifest.slug}'?`, resolvedOptions);
+
   const result = generateSpecArtifacts(repoRoot, {
-    input: preview.inputPath,
-    specSlug: options.specSlug,
+    input: resolvedOptions.input || preview.inputPath,
+    specSlug: resolvedOptions.specSlug,
   });
   process.stdout.write(formatSpecCreateResult(result, repoRoot));
 
@@ -411,6 +572,7 @@ function runCreateSpec(repoRoot, options = {}) {
     specDir: toRelativePosix(repoRoot, result.specDir),
     files: result.files.map((filePath) => toRelativePosix(repoRoot, filePath)),
     manifest: result.manifest,
+    reviewPath,
   };
 }