create-quiver 0.12.1 → 0.14.0

package/src/create-quiver/lib/ai/artifacts.js

@@ -0,0 +1,318 @@
+const fs = require('node:fs');
+const os = require('node:os');
+const path = require('node:path');
+
+const { redactSecrets } = require('../evidence');
+const { quiverInternalPaths } = require('../init-layout');
+
+const RAW_ARTIFACT_SCHEMA_VERSION = 1;
+const DEFAULT_MAX_PROVIDER_PROMPT_BYTES = 1024 * 1024;
+const DEFAULT_MAX_REVISION_INPUT_BYTES = 400 * 1024;
+const DEFAULT_COMPACTED_REVISION_INPUT_BYTES = 120 * 1024;
+
+const IMPORTANT_REVISION_LINE = /\b(acceptance|criteri[ao]s?|decision|decisi[o\u00f3]n|risk|riesgo|file|archivo|changed|cambio|scope|alcance|validation|validaci[o\u00f3]n|test|blocker|bloque|dependency|dependencia|assumption|supuesto|pending|pendiente|error|rollback|evidence|evidencia)\b/i;
+const PROVIDER_LOG_LINE = /^\s*(?:\[?(?:debug|info|notice|trace|warn|warning)\]?[:\s-]|(?:codex|claude|gemini)\b.*(?:provider|model|prompt|token|running|loading|thinking)|(?:using|loading)\s+(?:model|provider)\b|prompt\s+(?:length|transport)\s*:)/i;
+
+function formatError(message) {
+  return `create-quiver: ${message}`;
+}
+
+function byteLength(value) {
+  return Buffer.byteLength(String(value || ''), 'utf8');
+}
+
+function normalizeText(value) {
+  return String(value || '')
+    .replace(/\r\n/g, '\n')
+    .replace(/\r/g, '\n')
+    .replace(/\u001b\[[0-9;]*m/g, '');
+}
+
+function escapeRegExp(value) {
+  return String(value).replace(/[.*+?^${}()|[\]\\]/g, '\\$&');
+}
+
+function redactSensitiveLocalValues(text, options = {}) {
+  let result = redactSecrets(text);
+  const replacements = [];
+
+  if (options.projectRoot) {
+    replacements.push({
+      value: path.resolve(options.projectRoot),
+      label: '[PROJECT_ROOT]',
+    });
+  }
+
+  if (os.homedir()) {
+    replacements.push({
+      value: os.homedir(),
+      label: '[HOME]',
+    });
+  }
+
+  for (const replacement of replacements) {
+    if (!replacement.value) {
+      continue;
+    }
+    result = result.replace(new RegExp(escapeRegExp(replacement.value), 'g'), replacement.label);
+  }
+
+  return result;
+}
+
+function normalizePositiveInteger(value, fallback) {
+  if (value === undefined || value === null || value === '') {
+    return fallback;
+  }
+  const parsed = Number(value);
+  if (!Number.isFinite(parsed) || parsed <= 0) {
+    return fallback;
+  }
+  return Math.floor(parsed);
+}
+
+function resolveAiArtifactLimits(options = {}) {
+  return {
+    maxProviderPromptBytes: normalizePositiveInteger(
+      options.maxProviderPromptBytes ?? process.env.QUIVER_AI_MAX_PROMPT_BYTES,
+      DEFAULT_MAX_PROVIDER_PROMPT_BYTES,
+    ),
+    maxRevisionInputBytes: normalizePositiveInteger(
+      options.maxRevisionInputBytes ?? process.env.QUIVER_AI_MAX_REVISION_INPUT_BYTES,
+      DEFAULT_MAX_REVISION_INPUT_BYTES,
+    ),
+    compactedRevisionInputBytes: normalizePositiveInteger(
+      options.compactedRevisionInputBytes ?? process.env.QUIVER_AI_COMPACTED_REVISION_INPUT_BYTES,
+      DEFAULT_COMPACTED_REVISION_INPUT_BYTES,
+    ),
+  };
+}
+
+function stripPromptEcho(text, prompt) {
+  const normalizedText = normalizeText(text);
+  const normalizedPrompt = normalizeText(prompt).trim();
+
+  if (!normalizedPrompt || normalizedPrompt.length < 80) {
+    return normalizedText;
+  }
+
+  const directIndex = normalizedText.indexOf(normalizedPrompt);
+  if (directIndex >= 0) {
+    return `${normalizedText.slice(0, directIndex)}${normalizedText.slice(directIndex + normalizedPrompt.length)}`;
+  }
+
+  return normalizedText;
+}
+
+function stripProviderLogEdges(text) {
+  const lines = normalizeText(text).split('\n');
+
+  while (lines.length > 0 && (PROVIDER_LOG_LINE.test(lines[0]) || lines[0].trim() === '')) {
+    lines.shift();
+  }
+
+  while (lines.length > 0 && (PROVIDER_LOG_LINE.test(lines[lines.length - 1]) || lines[lines.length - 1].trim() === '')) {
+    lines.pop();
+  }
+
+  return lines.join('\n').trim();
+}
+
+function normalizeDraftOutput(text, sourceText = text) {
+  const value = normalizeText(text).trim();
+  if (!value) {
+    return '';
+  }
+  return /\n\s*$/.test(String(sourceText || '')) ? `${value}\n` : value;
+}
+
+function extractCleanProviderOutput(result, options = {}) {
+  const stdout = redactSensitiveLocalValues(result?.stdout || '', options);
+  const stderr = redactSensitiveLocalValues(result?.stderr || '', options);
+  const primary = stdout.trim() ? stdout : stderr;
+  const cleaned = stripProviderLogEdges(stripPromptEcho(primary, options.prompt || ''));
+  const cleanOutput = normalizeDraftOutput(cleaned, primary);
+
+  if (cleanOutput) {
+    return {
+      cleanOutput,
+      source: stdout.trim() ? 'stdout' : 'stderr',
+      strippedPromptEcho: primary !== stripPromptEcho(primary, options.prompt || ''),
+    };
+  }
+
+  return {
+    cleanOutput: normalizeDraftOutput(primary || [stdout, stderr].filter(Boolean).join('\n'), primary),
+    source: stdout.trim() ? 'stdout' : stderr.trim() ? 'stderr' : 'empty',
+    strippedPromptEcho: false,
+  };
+}
+
+function safeArtifactName(scope, now = new Date()) {
+  const slug = String(scope || 'provider-output')
+    .trim()
+    .toLowerCase()
+    .replace(/[^a-z0-9._-]+/g, '-')
+    .replace(/^-+|-+$/g, '') || 'provider-output';
+  const stamp = now.toISOString()
+    .replace(/\.\d{3}Z$/, 'z')
+    .replace(/[^0-9a-z]+/gi, '-')
+    .toLowerCase()
+    .replace(/^-+|-+$/g, '');
+  return `${stamp}-${slug}.json`;
+}
+
+function toRelativePosix(root, filePath) {
+  return path.relative(root, filePath).split(path.sep).join('/');
+}
+
+function writeRawProviderArtifact(projectRoot, runId, scope, result, options = {}) {
+  if (!runId) {
+    throw new Error(formatError('missing AI run id for raw provider artifact'));
+  }
+
+  const now = options.now || new Date();
+  const rawDir = path.join(quiverInternalPaths(projectRoot).runsDir, String(runId), 'raw');
+  const rawPath = path.join(rawDir, safeArtifactName(scope, now));
+  const serializedError = result?.error
+    ? {
+        code: result.error.code || null,
+        message: result.error.message || String(result.error),
+        provider: result.error.provider || null,
+        command: result.error.command || null,
+      }
+    : null;
+  const artifact = {
+    schema_version: RAW_ARTIFACT_SCHEMA_VERSION,
+    kind: 'provider-output',
+    scope: String(scope || 'provider-output'),
+    created_at: now.toISOString(),
+    provider: result?.provider || null,
+    command: result?.command || null,
+    args: Array.isArray(result?.args) ? result.args.slice() : [],
+    cwd: result?.cwd ? redactSensitiveLocalValues(result.cwd, { projectRoot }) : null,
+    ok: Boolean(result?.ok),
+    dry_run: Boolean(result?.dryRun),
+    exit_code: typeof result?.exitCode === 'number' ? result.exitCode : null,
+    signal: result?.signal || null,
+    timeout_ms: typeof result?.timeoutMs === 'number' ? result.timeoutMs : null,
+    prompt_transport: result?.promptTransport || null,
+    stdout: redactSensitiveLocalValues(result?.stdout || '', { projectRoot }),
+    stderr: redactSensitiveLocalValues(result?.stderr || '', { projectRoot }),
+    error: serializedError ? JSON.parse(redactSensitiveLocalValues(JSON.stringify(serializedError), { projectRoot })) : null,
+    metadata: options.metadata || {},
+  };
+
+  fs.mkdirSync(rawDir, { recursive: true });
+  fs.writeFileSync(rawPath, `${JSON.stringify(artifact, null, 2)}\n`);
+
+  return {
+    filePath: rawPath,
+    path: toRelativePosix(projectRoot, rawPath),
+    artifact,
+  };
+}
+
+function compactTextToByteLimit(text, maxBytes) {
+  let value = normalizeText(text).trim();
+  if (byteLength(value) <= maxBytes) {
+    return value;
+  }
+
+  while (byteLength(value) > maxBytes && value.length > 0) {
+    value = value.slice(0, Math.max(0, value.length - Math.ceil((byteLength(value) - maxBytes) / 2) - 32)).trimEnd();
+  }
+
+  return value;
+}
+
+function compactRevisionInput(inputText, options = {}) {
+  const limits = resolveAiArtifactLimits(options);
+  const originalText = normalizeText(inputText);
+  const originalBytes = byteLength(originalText);
+
+  if (originalBytes <= limits.maxRevisionInputBytes) {
+    return {
+      text: originalText,
+      compaction: null,
+    };
+  }
+
+  const lines = originalText.split('\n');
+  const selected = [];
+  const seen = new Set();
+  const addLine = (line) => {
+    const key = line;
+    if (seen.has(key)) {
+      return;
+    }
+    seen.add(key);
+    selected.push(line);
+  };
+
+  lines.slice(0, 24).forEach(addLine);
+  for (const line of lines) {
+    if (/^\s*#{1,6}\s+/.test(line) || IMPORTANT_REVISION_LINE.test(line)) {
+      addLine(line);
+    }
+  }
+  lines.slice(-24).forEach(addLine);
+
+  const preface = [
+    `[Quiver compacted oversized revise input from ${originalBytes} bytes before provider execution.]`,
+    '[Preserved headings and lines mentioning decisions, risks, files, acceptance criteria, validation, blockers, dependencies, assumptions, pending work, rollback, and evidence.]',
+    '',
+  ].join('\n');
+  const compacted = `${preface}${selected.join('\n')}`;
+  const targetBytes = Math.min(limits.compactedRevisionInputBytes, limits.maxRevisionInputBytes);
+  const finalText = compactTextToByteLimit(compacted, targetBytes);
+  const compactedBytes = byteLength(finalText);
+
+  if (compactedBytes > limits.maxRevisionInputBytes) {
+    const error = new Error(formatError(`ai revise input is too large after compaction (${compactedBytes} bytes; limit ${limits.maxRevisionInputBytes}). Reduce feedback size and retry.`));
+    error.code = 'AI_INPUT_TOO_LARGE';
+    throw error;
+  }
+
+  return {
+    text: `${finalText.trimEnd()}\n`,
+    compaction: {
+      compacted: true,
+      original_bytes: originalBytes,
+      compacted_bytes: compactedBytes,
+      max_revision_input_bytes: limits.maxRevisionInputBytes,
+      preserved: ['headings', 'decisions', 'risks', 'files', 'acceptance criteria', 'validation', 'blockers', 'dependencies', 'assumptions', 'rollback', 'evidence'],
+    },
+  };
+}
+
+function assertProviderPromptWithinLimit(prompt, options = {}) {
+  const limits = resolveAiArtifactLimits(options);
+  const promptBytes = byteLength(prompt);
+
+  if (promptBytes <= limits.maxProviderPromptBytes) {
+    return {
+      prompt,
+      bytes: promptBytes,
+      maxProviderPromptBytes: limits.maxProviderPromptBytes,
+    };
+  }
+
+  const error = new Error(formatError(`provider prompt is too large (${promptBytes} bytes; limit ${limits.maxProviderPromptBytes}). Reduce the input, split the work, or run ai revise with focused feedback before invoking the provider.`));
+  error.code = 'AI_PROMPT_TOO_LARGE';
+  throw error;
+}
+
+module.exports = {
+  DEFAULT_COMPACTED_REVISION_INPUT_BYTES,
+  DEFAULT_MAX_PROVIDER_PROMPT_BYTES,
+  DEFAULT_MAX_REVISION_INPUT_BYTES,
+  RAW_ARTIFACT_SCHEMA_VERSION,
+  assertProviderPromptWithinLimit,
+  byteLength,
+  compactRevisionInput,
+  extractCleanProviderOutput,
+  redactSensitiveLocalValues,
+  resolveAiArtifactLimits,
+  writeRawProviderArtifact,
+};

package/src/create-quiver/lib/ai/context-packs.js

@@ -27,14 +27,14 @@ const CONTEXT_PACKS = Object.freeze({
     description: 'Executor context for a single slice handoff.',
     role: ROLES.EXECUTOR,
     tokenBudgetHint: 3200,
-    roleGuidance: 'Use slice handoff, allowed files, acceptance criteria, and validation commands only.',
+    roleGuidance: 'Use the slice.json, EXECUTION_BRIEF, CLOSURE_BRIEF, allowed files, acceptance criteria, and validation commands only. Do not request the full spec unless the slice brief explicitly requires it.',
   }),
   minimal: Object.freeze({
     name: 'minimal',
     description: 'Smallest executor context for narrowly-scoped tasks.',
     role: ROLES.EXECUTOR,
     tokenBudgetHint: 1200,
-    roleGuidance: 'Use the smallest safe set of slice details and avoid onboarding context.',
+    roleGuidance: 'Use the smallest safe set of slice details, avoid onboarding context, and avoid full-spec context by default.',
   }),
 });
 

package/src/create-quiver/lib/ai/execution-plan.js

@@ -3,6 +3,7 @@ const path = require('node:path');
 
 const { resolveProfileProvider } = require('../agent-profiles');
 const { branchDelete, runGit, statusPorcelain, worktreeAdd, worktreePrune, worktreeRemove } = require('../git');
+const { withLock } = require('../locks');
 const { safeBranchName, worktreesRootForRepo } = require('../slice');
 const { buildGraph, computeLevels, detectFileConflicts, isFoundationSliceId, readAllSlices, topoSort, SliceGraphError } = require('../slice-graph');
 const { runExecuteSlice } = require('./executor');
@@ -486,6 +487,13 @@ async function runParallelGroupInWorktrees(repoRoot, level, group, options = {})
   const slices = group.slice_refs.map((ref) => level.slices.find((item) => item.ref === ref));
   const workspaces = slices.map((slice, index) => buildDelegatedWorkspace(repoRoot, slice, runId, index, options));
 
+  return withLock(repoRoot, `execute-plan-${runId}`, {
+    command: 'ai execute-plan',
+    metadata: {
+      mode: 'delegated',
+      slices: group.slice_refs,
+    },
+  }, async () => {
   let runResults;
   try {
     worktreePrune(repoRoot);
@@ -542,6 +550,7 @@ async function runParallelGroupInWorktrees(repoRoot, level, group, options = {})
     workspace: item.workspace.worktreePath,
     integratedCommit: item.commit,
   }));
+  });
 }
 
 async function runExecutePlan(repoRoot, options = {}) {

package/src/create-quiver/lib/ai/executor.js

@@ -9,6 +9,7 @@ const { currentBranch, runGit } = require('../git');
 const { redactSecrets, truncateText } = require('../evidence');
 const { captureWorktreeSnapshot, validateScopeSnapshot } = require('../scope');
 const { resolveSliceContext } = require('../slice');
+const { validateProjectRelativePaths } = require('../paths');
 
 const DEFAULT_EXECUTE_PROVIDER = 'codex';
 const DEFAULT_EXECUTE_ROLE = 'executor';
@@ -303,8 +304,8 @@ function buildExecuteSliceContext({ repoRoot, slicePath, role, context }) {
   });
   const relativeSlicePath = toRelativePath(canonicalRepoRoot, slice.sliceAbs);
   const relativeBriefPath = toRelativePath(canonicalRepoRoot, briefPath);
-  const allowedFiles = Array.isArray(slice.files) ? slice.files.map((file) => String(file)) : [];
-  const expectedReadPaths = Array.isArray(slice.expectedReadPaths) ? slice.expectedReadPaths.map((file) => String(file)) : [];
+  const allowedFiles = validateProjectRelativePaths(Array.isArray(slice.files) ? slice.files.map((file) => String(file)) : [], 'slice write scope');
+  const expectedReadPaths = validateProjectRelativePaths(Array.isArray(slice.expectedReadPaths) ? slice.expectedReadPaths.map((file) => String(file)) : [], 'slice read scope');
   const acceptance = Array.isArray(slice.acceptance) ? slice.acceptance.map((item) => String(item)) : [];
   const validationCommands = Array.isArray(slice.tests) ? slice.tests.map((item) => String(item)) : [];
   const validationHints = Array.isArray(slice.validationHints) ? slice.validationHints.map((item) => String(item)) : [];