create-qa-architect 5.0.7 → 5.4.3

package/lib/validation/index.js

@@ -4,6 +4,27 @@ const { ConfigSecurityScanner } = require('./config-security')
 const { DocumentationValidator } = require('./documentation')
 const { WorkflowValidator } = require('./workflow-validation')
 
+/**
+ * Validation check configuration
+ */
+const VALIDATION_CHECKS = [
+  {
+    name: 'configSecurity',
+    label: 'Configuration security',
+    method: 'runConfigSecurity',
+  },
+  {
+    name: 'documentation',
+    label: 'Documentation validation',
+    method: 'runDocumentationValidation',
+  },
+  {
+    name: 'workflows',
+    label: 'Workflow validation',
+    method: 'runWorkflowValidation',
+  },
+]
+
 /**
  * Enhanced Validation Runner
  * Coordinates all validation checks
@@ -43,63 +64,31 @@ class ValidationRunner {
   async runComprehensiveCheck() {
     console.log('🔍 Running comprehensive validation...\n')
 
-    const results = {
-      configSecurity: null,
-      documentation: null,
-      workflows: null,
-      overall: { passed: true, issues: [] },
-    }
-
-    try {
-      console.log('⏳ [1/3] Running configuration security scan...')
-      results.configSecurity = await this.runConfigSecurity()
-      console.log('✅ [1/3] Configuration security complete')
-    } catch (error) {
-      console.log('❌ [1/3] Configuration security failed')
-      results.configSecurity = { passed: false, error: error.message }
-      results.overall.passed = false
-      results.overall.issues.push(`Configuration Security: ${error.message}`)
-    }
+    const results = this._initResults()
+    const total = VALIDATION_CHECKS.length
 
-    console.log('') // Add spacing between checks
-
-    try {
-      console.log('⏳ [2/3] Running documentation validation...')
-      results.documentation = await this.runDocumentationValidation()
-      console.log('✅ [2/3] Documentation validation complete')
-    } catch (error) {
-      console.log('❌ [2/3] Documentation validation failed')
-      results.documentation = { passed: false, error: error.message }
-      results.overall.passed = false
-      results.overall.issues.push(`Documentation: ${error.message}`)
-    }
+    for (let i = 0; i < VALIDATION_CHECKS.length; i++) {
+      const check = VALIDATION_CHECKS[i]
+      const stepNum = i + 1
 
-    console.log('') // Add spacing between checks
-
-    try {
-      console.log('⏳ [3/3] Running workflow validation...')
-      results.workflows = await this.runWorkflowValidation()
-      console.log('✅ [3/3] Workflow validation complete')
-    } catch (error) {
-      console.log('❌ [3/3] Workflow validation failed')
-      results.workflows = { passed: false, error: error.message }
-      results.overall.passed = false
-      results.overall.issues.push(`Workflows: ${error.message}`)
-    }
+      console.log(
+        `⏳ [${stepNum}/${total}] Running ${check.label.toLowerCase()}...`
+      )
 
-    console.log('') // Add spacing
+      try {
+        results[check.name] = await this[check.method]()
+        console.log(`✅ [${stepNum}/${total}] ${check.label} complete`)
+      } catch (error) {
+        console.log(`❌ [${stepNum}/${total}] ${check.label} failed`)
+        results[check.name] = { passed: false, error: error.message }
+        results.overall.passed = false
+        results.overall.issues.push(`${check.label}: ${error.message}`)
+      }
 
-    if (results.overall.passed) {
-      console.log('✅ All validation checks passed!')
-    } else {
-      // Detect test scenario and use appropriate prefix
-      const isTest = process.argv.join(' ').includes('test')
-      const prefix = isTest ? '📋 TEST SCENARIO:' : '❌'
-      console.error(`${prefix} Validation failed with issues:`)
-      results.overall.issues.forEach(issue => console.error(`   - ${issue}`))
-      throw new Error('Comprehensive validation failed')
+      console.log('')
     }
 
+    this._reportResults(results)
     return results
   }
 
@@ -110,71 +99,53 @@ class ValidationRunner {
   async runComprehensiveCheckParallel() {
     console.log('🔍 Running comprehensive validation (parallel)...\n')
 
-    const results = {
-      configSecurity: null,
-      documentation: null,
-      workflows: null,
-      overall: { passed: true, issues: [] },
-    }
+    const results = this._initResults()
 
-    // Run all validations in parallel
-    const validationPromises = [
-      this.runConfigSecurity()
+    const validationPromises = VALIDATION_CHECKS.map(check =>
+      this[check.method]()
         .then(result => {
-          results.configSecurity = result
-          console.log('✅ Configuration security complete')
+          results[check.name] = result
+          console.log(`✅ ${check.label} complete`)
         })
         .catch(error => {
-          console.log('❌ Configuration security failed')
-          results.configSecurity = { passed: false, error: error.message }
+          console.log(`❌ ${check.label} failed`)
+          results[check.name] = { passed: false, error: error.message }
           results.overall.passed = false
-          results.overall.issues.push(
-            `Configuration Security: ${error.message}`
-          )
-        }),
-
-      this.runDocumentationValidation()
-        .then(result => {
-          results.documentation = result
-          console.log('✅ Documentation validation complete')
+          results.overall.issues.push(`${check.label}: ${error.message}`)
         })
-        .catch(error => {
-          console.log('❌ Documentation validation failed')
-          results.documentation = { passed: false, error: error.message }
-          results.overall.passed = false
-          results.overall.issues.push(`Documentation: ${error.message}`)
-        }),
+    )
 
-      this.runWorkflowValidation()
-        .then(result => {
-          results.workflows = result
-          console.log('✅ Workflow validation complete')
-        })
-        .catch(error => {
-          console.log('❌ Workflow validation failed')
-          results.workflows = { passed: false, error: error.message }
-          results.overall.passed = false
-          results.overall.issues.push(`Workflows: ${error.message}`)
-        }),
-    ]
-
-    // Wait for all validations to complete
     await Promise.all(validationPromises)
+    console.log('')
+
+    this._reportResults(results)
+    return results
+  }
 
-    console.log('') // Add spacing
+  /**
+   * Initialize results object
+   */
+  _initResults() {
+    const results = { overall: { passed: true, issues: [] } }
+    VALIDATION_CHECKS.forEach(check => {
+      results[check.name] = null
+    })
+    return results
+  }
 
+  /**
+   * Report validation results
+   */
+  _reportResults(results) {
     if (results.overall.passed) {
       console.log('✅ All validation checks passed!')
     } else {
-      // Detect test scenario and use appropriate prefix
       const isTest = process.argv.join(' ').includes('test')
       const prefix = isTest ? '📋 TEST SCENARIO:' : '❌'
       console.error(`${prefix} Validation failed with issues:`)
       results.overall.issues.forEach(issue => console.error(`   - ${issue}`))
       throw new Error('Comprehensive validation failed')
     }
-
-    return results
   }
 }
 

package/lib/validation/workflow-validation.js

@@ -95,15 +95,36 @@ class WorkflowValidator {
       for (const file of workflowFiles) {
         const filePath = path.join(workflowDir, file)
         const content = fs.readFileSync(filePath, 'utf8')
-        const results = linter(content, filePath) || []
 
-        if (Array.isArray(results) && results.length > 0) {
-          issueCount += results.length
-          results.forEach(result => {
-            this.issues.push(
-              `actionlint: ${result.file}:${result.line}:${result.column} ${result.kind} - ${result.message}`
+        try {
+          const results = linter(content, filePath) || []
+
+          if (Array.isArray(results) && results.length > 0) {
+            // Filter out false positives for 'vars' context (valid GitHub feature, not recognized by actionlint WASM)
+            const filteredResults = results.filter(
+              result =>
+                !(
+                  result.kind === 'expression' &&
+                  result.message?.includes('undefined variable "vars"')
+                )
             )
-          })
+            issueCount += filteredResults.length
+            filteredResults.forEach(result => {
+              this.issues.push(
+                `actionlint: ${result.file}:${result.line}:${result.column} ${result.kind} - ${result.message}`
+              )
+            })
+          }
+        } catch (lintError) {
+          // WASM actionlint has limits on file complexity - skip silently for large files
+          if (
+            lintError.message?.includes('unreachable') &&
+            content.length > 10000
+          ) {
+            // Large file exceeded WASM limits - not a validation failure
+            continue
+          }
+          throw lintError
         }
       }
 

package/package.json

@@ -1,11 +1,10 @@
 {
   "name": "create-qa-architect",
-  "version": "5.0.7",
+  "version": "5.4.3",
   "description": "QA Architect - Bootstrap quality automation for JavaScript/TypeScript and Python projects with GitHub Actions, pre-commit hooks, linting, formatting, and smart test strategy",
   "main": "setup.js",
   "bin": {
-    "create-qa-architect": "./setup.js",
-    "create-saas-monetization": "./create-saas-monetization.js"
+    "create-qa-architect": "./setup.js"
   },
   "scripts": {
     "prepare": "husky",
@@ -21,8 +20,8 @@
     "validate:comprehensive": "node setup.js --comprehensive --no-markdownlint",
     "validate:all": "npm run validate:comprehensive && npm run security:audit",
     "validate:pre-push": "npm run test:patterns --if-present && npm run lint && npm run format:check && npm run test:commands --if-present && npm test --if-present",
-    "test": "export QAA_DEVELOPER=true && node tests/setup.test.js && node tests/integration.test.js && node tests/error-paths.test.js && node tests/error-messages.test.js && node tests/cache-manager.test.js && node tests/parallel-validation.test.js && node tests/python-integration.test.js && node tests/interactive.test.js && node tests/monorepo.test.js && node tests/template-loader.test.js && node tests/critical-fixes.test.js && node tests/interactive-routing-fix.test.js && node tests/telemetry.test.js && node tests/error-reporter.test.js && node tests/premium-dependency-monitoring.test.js && node tests/multi-language-dependency-monitoring.test.js && node tests/cli-deps-integration.test.js && node tests/real-world-packages.test.js && node tests/validation-factory.test.js && node tests/setup-error-coverage.test.js && node tests/python-detection-sensitivity.test.js && node tests/python-parser-fixes.test.js && node tests/licensing.test.js && node tests/security-licensing.test.js && node tests/real-purchase-flow.test.js && node tests/base-validator.test.js && node tests/dependency-monitoring-basic.test.js && node tests/workflow-validation.test.js && node tests/setup-critical-paths.test.js && node tests/project-maturity.test.js && node tests/project-maturity-cli.test.js && node tests/package-manager-detection.test.js && node tests/check-docs.test.js && node tests/validate-command-patterns.test.js && node tests/gitleaks-binary-resolution.test.js && node tests/gitleaks-production-checksums.test.js && node tests/gitleaks-checksum-verification.test.js && node tests/gitleaks-real-binary-test.js && node tests/tier-enforcement.test.js",
-    "test:unit": "export QAA_DEVELOPER=true && node tests/setup.test.js && node tests/error-paths.test.js && node tests/error-messages.test.js && node tests/cache-manager.test.js && node tests/template-loader.test.js && node tests/telemetry.test.js && node tests/error-reporter.test.js && node tests/validation-factory.test.js && node tests/setup-error-coverage.test.js && node tests/licensing.test.js && node tests/security-licensing.test.js && node tests/base-validator.test.js && node tests/dependency-monitoring-basic.test.js && node tests/workflow-validation.test.js && node tests/setup-critical-paths.test.js && node tests/project-maturity.test.js && node tests/package-manager-detection.test.js && node tests/check-docs.test.js && node tests/validate-command-patterns.test.js && node tests/gitleaks-binary-resolution.test.js && node tests/gitleaks-production-checksums.test.js && node tests/gitleaks-checksum-verification.test.js",
+    "test": "export QAA_DEVELOPER=true && node tests/result-types.test.js && node tests/setup.test.js && node tests/integration.test.js && node tests/error-paths.test.js && node tests/error-messages.test.js && node tests/cache-manager.test.js && node tests/parallel-validation.test.js && node tests/python-integration.test.js && node tests/interactive.test.js && node tests/monorepo.test.js && node tests/template-loader.test.js && node tests/critical-fixes.test.js && node tests/interactive-routing-fix.test.js && node tests/telemetry.test.js && node tests/error-reporter.test.js && node tests/premium-dependency-monitoring.test.js && node tests/multi-language-dependency-monitoring.test.js && node tests/cli-deps-integration.test.js && node tests/deps-edge-cases.test.js && node tests/real-world-packages.test.js && node tests/validation-factory.test.js && node tests/setup-error-coverage.test.js && node tests/python-detection-sensitivity.test.js && node tests/python-parser-fixes.test.js && node tests/licensing.test.js && node tests/security-licensing.test.js && node tests/real-purchase-flow.test.js && node tests/base-validator.test.js && node tests/dependency-monitoring-basic.test.js && node tests/workflow-validation.test.js && node tests/workflow-tiers.test.js && node tests/analyze-ci.test.js && node tests/analyze-ci-integration.test.js && node tests/setup-critical-paths.test.js && node tests/project-maturity.test.js && node tests/project-maturity-cli.test.js && node tests/package-manager-detection.test.js && node tests/check-docs.test.js && node tests/validate-command-patterns.test.js && node tests/gitleaks-binary-resolution.test.js && node tests/gitleaks-production-checksums.test.js && node tests/gitleaks-checksum-verification.test.js && node tests/gitleaks-real-binary-test.js && node tests/tier-enforcement.test.js",
+    "test:unit": "export QAA_DEVELOPER=true && node tests/result-types.test.js && node tests/setup.test.js && node tests/error-paths.test.js && node tests/error-messages.test.js && node tests/cache-manager.test.js && node tests/template-loader.test.js && node tests/telemetry.test.js && node tests/error-reporter.test.js && node tests/validation-factory.test.js && node tests/setup-error-coverage.test.js && node tests/licensing.test.js && node tests/security-licensing.test.js && node tests/base-validator.test.js && node tests/dependency-monitoring-basic.test.js && node tests/workflow-validation.test.js && node tests/workflow-tiers.test.js && node tests/analyze-ci.test.js && node tests/setup-critical-paths.test.js && node tests/project-maturity.test.js && node tests/package-manager-detection.test.js && node tests/check-docs.test.js && node tests/validate-command-patterns.test.js && node tests/gitleaks-binary-resolution.test.js && node tests/gitleaks-production-checksums.test.js && node tests/gitleaks-checksum-verification.test.js",
     "test:fast": "npm run test:unit",
     "test:medium": "npm run test:fast && npm run test:patterns && npm run test:commands",
     "test:slow": "export QAA_DEVELOPER=true && node tests/python-integration.test.js && node tests/interactive.test.js && node tests/monorepo.test.js && node tests/critical-fixes.test.js && node tests/interactive-routing-fix.test.js && node tests/premium-dependency-monitoring.test.js && node tests/multi-language-dependency-monitoring.test.js && node tests/cli-deps-integration.test.js && node tests/real-world-packages.test.js && node tests/python-detection-sensitivity.test.js && node tests/python-parser-fixes.test.js && node tests/real-purchase-flow.test.js && node tests/project-maturity-cli.test.js && node tests/gitleaks-real-binary-test.js && npm run test:e2e",
@@ -66,7 +65,6 @@
   "license": "SEE LICENSE IN LICENSE",
   "files": [
     "setup.js",
-    "create-saas-monetization.js",
     "config/",
     "docs/",
     "lib/",

package/scripts/check-test-coverage.sh

@@ -0,0 +1,46 @@
+#!/bin/bash
+# Check test coverage for new features
+# Run manually or via pre-commit hook (warning only)
+
+set -e
+
+YELLOW='\033[1;33m'
+NC='\033[0m'
+
+warnings=0
+
+echo "🔍 Checking test coverage..."
+
+# Find source files without corresponding test files
+for file in $(find src -name "*.ts" -o -name "*.tsx" 2>/dev/null | grep -v "\.test\." | grep -v "\.d\.ts" || true); do
+  # Skip layout, page, and config files (Next.js conventions)
+  if [[ "$file" == *"/layout."* ]] || [[ "$file" == *"/page."* ]] || [[ "$file" == *".config."* ]]; then
+    continue
+  fi
+
+  # Skip API routes (tested via integration tests)
+  if [[ "$file" == *"/api/"* ]]; then
+    continue
+  fi
+
+  # Check for corresponding test file
+  test_file="${file%.*}.test.${file##*.}"
+
+  if [ ! -f "$test_file" ] && [ ! -f "tests/unit/$(basename ${file%.*}).test.ts" ]; then
+    # Only warn for lib/ and components/ (core business logic)
+    if [[ "$file" == *"/lib/"* ]] || [[ "$file" == *"/components/"* ]]; then
+      echo -e "${YELLOW}⚠️  May need test: $file${NC}"
+      ((warnings++)) || true
+    fi
+  fi
+done
+
+if [ $warnings -gt 0 ]; then
+  echo ""
+  echo -e "${YELLOW}⚠️  $warnings file(s) in lib/ or components/ may need tests${NC}"
+  echo "   Run: pnpm test:coverage to check actual coverage"
+else
+  echo "✅ All core files appear to have tests"
+fi
+
+exit 0

package/scripts/validate-claude-md.js

@@ -0,0 +1,80 @@
+#!/usr/bin/env node
+'use strict'
+
+/**
+ * Validates CLAUDE.md consistency with package.json
+ * Checks that package name and version are correctly referenced
+ */
+
+const fs = require('fs')
+const path = require('path')
+
+function validateClaudeMd() {
+  console.log('🔍 Validating CLAUDE.md...\n')
+
+  // Read package.json
+  const packagePath = path.join(__dirname, '..', 'package.json')
+  if (!fs.existsSync(packagePath)) {
+    console.error('❌ package.json not found')
+    process.exit(1)
+  }
+
+  const pkg = JSON.parse(fs.readFileSync(packagePath, 'utf8'))
+  const packageName = pkg.name
+  const packageVersion = pkg.version
+
+  // Read CLAUDE.md
+  const claudeMdPath = path.join(__dirname, '..', 'CLAUDE.md')
+  if (!fs.existsSync(claudeMdPath)) {
+    console.error('❌ CLAUDE.md not found')
+    process.exit(1)
+  }
+
+  const claudeMd = fs.readFileSync(claudeMdPath, 'utf8')
+
+  let errors = 0
+
+  // Check for package name reference
+  if (!claudeMd.includes(packageName)) {
+    console.error(
+      `❌ CLAUDE.md does not reference package name: ${packageName}`
+    )
+    errors++
+  } else {
+    console.log(`✅ Package name referenced: ${packageName}`)
+  }
+
+  // Check for version reference (optional - just warn)
+  if (!claudeMd.includes(packageVersion)) {
+    console.warn(
+      `⚠️  CLAUDE.md does not reference current version: ${packageVersion}`
+    )
+    console.warn('   This is not a critical error, but consider updating.')
+  } else {
+    console.log(`✅ Version referenced: ${packageVersion}`)
+  }
+
+  // Basic content checks
+  const requiredSections = ['Project Overview', 'Commands', 'Architecture']
+
+  requiredSections.forEach(section => {
+    if (!claudeMd.includes(section)) {
+      console.error(`❌ Missing required section: ${section}`)
+      errors++
+    } else {
+      console.log(`✅ Section found: ${section}`)
+    }
+  })
+
+  console.log()
+
+  if (errors > 0) {
+    console.error(`❌ CLAUDE.md validation failed with ${errors} error(s)`)
+    process.exit(1)
+  } else {
+    console.log('✅ CLAUDE.md validation passed!')
+    process.exit(0)
+  }
+}
+
+validateClaudeMd()