create-principles-disciple 1.97.1 → 1.98.0

package/console/dist/server/models/ActivationsConsoleModel.js

@@ -1,4 +1,4 @@
-import { SqliteConnection, SqliteActivationStateStore, SqlitePIArtifactStore, } from '@principles/core/runtime-v2';
+import { SqliteConnection, SqliteActivationStateStore, SqlitePIArtifactStore, extractPrincipleId, } from '@principles/core/runtime-v2';
 import * as fs from 'node:fs';
 import * as path from 'node:path';
 function isMissingTableError(err) {
@@ -6,6 +6,26 @@ function isMissingTableError(err) {
         return false;
     return err.message.includes('no such table');
 }
+/**
+ * Bug-O L2 fix: adapt PIArtifactRecord (DB row) to PIArtifactSnapshot (activation
+ * contract type). The two interfaces have identical fields but different names —
+ * we use explicit field copy instead of `as` to comply with rc-2-no-as-bypass
+ * and to surface future field drift as a compile error.
+ */
+function toSnapshot(record) {
+    return {
+        artifactId: record.artifactId,
+        artifactKind: record.artifactKind,
+        sourceTaskId: record.sourceTaskId,
+        sourcePrincipleId: record.sourcePrincipleId,
+        sourceRuleId: record.sourceRuleId,
+        lineageArtifactIds: record.lineageArtifactIds,
+        validationStatus: record.validationStatus,
+        contentJson: record.contentJson,
+        createdAt: record.createdAt,
+        updatedAt: record.updatedAt,
+    };
+}
 export class ActivationsConsoleModel {
     workspaceDir;
     constructor(workspaceDir) {
@@ -30,13 +50,19 @@ export class ActivationsConsoleModel {
                 }
                 throw err;
             }
-            // Build artifactId → sourcePrincipleId map from PIArtifactSnapshot
+            // Build artifactId → principleId map. Bug-O L2 fix: use extractPrincipleId
+            // (4-step fallback: column → parsed.principleId → parsed.sourcePrincipleId
+            // → parsed.principleDraft.title) instead of only reading the column.
+            // Without this, dreamer artifacts whose sourcePrincipleId was stripped
+            // (non-core-principle case) would show 'unlinked' even when contentJson
+            // carries a resolvable principleId.
             const artifactPrincipleMap = new Map();
             for (const activation of allActivations) {
                 if (!artifactPrincipleMap.has(activation.artifactId)) {
                     try {
                         const artifact = await artifactStore.getArtifactById(activation.artifactId);
-                        artifactPrincipleMap.set(activation.artifactId, artifact?.sourcePrincipleId ?? null);
+                        const principleId = artifact ? extractPrincipleId(toSnapshot(artifact)) : null;
+                        artifactPrincipleMap.set(activation.artifactId, principleId);
                     }
                     catch (err) {
                         if (isMissingTableError(err)) {

package/console/dist/server/models/ApprovalsConsoleModel.d.ts

@@ -38,6 +38,19 @@ export declare class ApprovalsConsoleModel {
         isMvpProven: boolean;
     }) | null>;
     approve(approvalId: string, decidedBy: string, note?: string): Promise<ApproveWithActivationResult>;
+    /**
+     * Bug-O L3b fix: upgrade the ledger principle linked to `artifactId` from
+     * 'candidate' to 'active'. Called by {@link approve} after a successful
+     * activation. Non-fatal on failure — the activation is already committed;
+     * ledger failure is surfaced as a warning string (rc-9).
+     *
+     * The principleId is resolved via {@link extractPrincipleId}'s 4-step
+     * fallback (column → parsed.principleId → parsed.sourcePrincipleId →
+     * parsed.principleDraft.title) so dreamer artifacts whose
+     * sourcePrincipleId column was stripped by stripFabricatedCorePrincipleIds
+     * can still be linked via contentJson.
+     */
+    private upgradeLedgerPrinciple;
     /**
      * Edit a pending approval's artifact to a new version (P1 #2 fix).
      *

package/console/dist/server/models/ApprovalsConsoleModel.js

@@ -1,6 +1,6 @@
 import * as fs from 'node:fs';
 import * as path from 'node:path';
-import { SqliteConnection, SqliteApprovalQueueStore, SqliteActivationStateStore, SqlitePIArtifactStore, ActivationDispatcher, PromptWriter, DeferArchiveWriter, RuleHostWriter, createProductionGateDeps, ApprovalCompletionService, ApprovalQueue, mapConfidenceToLabel, isArtifactRevisionOf, MVP_CHANNELS, } from '@principles/core/runtime-v2';
+import { SqliteConnection, SqliteApprovalQueueStore, SqliteActivationStateStore, SqlitePIArtifactStore, ActivationDispatcher, PromptWriter, DeferArchiveWriter, RuleHostWriter, createProductionGateDeps, ApprovalCompletionService, ApprovalQueue, mapConfidenceToLabel, isArtifactRevisionOf, extractPrincipleId, PrincipleTreeLedgerAdapter, MVP_CHANNELS, } from '@principles/core/runtime-v2';
 import { loadPdConfig, computeFlagsFromLoadResult } from '../config/pd-config-store.js';
 const MVP_PROVEN_CHANNELS = new Set(MVP_CHANNELS);
 const EMPTY_STATS = { pending: 0, approved: 0, rejected: 0, cancelled: 0 };
@@ -12,6 +12,26 @@ function isMissingTableError(err) {
 function isActivationSuccess(activation) {
     return activation.decision === 'activated' || activation.decision === 'already_activated';
 }
+/**
+ * Bug-O L3b fix: adapt a PIArtifactRecord (DB row) to a PIArtifactSnapshot
+ * (activation contract type). The two interfaces have identical fields but
+ * different names — explicit field copy surfaces future field drift as a
+ * compile error and complies with rc-2-no-as-bypass.
+ */
+function toArtifactSnapshot(record) {
+    return {
+        artifactId: record.artifactId,
+        artifactKind: record.artifactKind,
+        sourceTaskId: record.sourceTaskId,
+        sourcePrincipleId: record.sourcePrincipleId,
+        sourceRuleId: record.sourceRuleId,
+        lineageArtifactIds: record.lineageArtifactIds,
+        validationStatus: record.validationStatus,
+        contentJson: record.contentJson,
+        createdAt: record.createdAt,
+        updatedAt: record.updatedAt,
+    };
+}
 function stateDbExists(workspaceDir) {
     return fs.existsSync(path.join(workspaceDir, '.pd', 'state.db'));
 }
@@ -133,7 +153,75 @@ export class ApprovalsConsoleModel {
                 warning: 'activation_skipped_feature_flag_disabled: approval is recorded but activation was not dispatched. Enable story_a_approval_completion flag or manually run "pd runtime activation dispatch" to activate.',
             };
         }
-        return { ok: true, record: approvalResult.record, activation };
+        // Bug-O L3b fix: after a successful activation, upgrade the corresponding
+        // ledger principle from 'candidate' to 'active'. The activation is already
+        // committed to SQLite; a ledger failure here is non-fatal and surfaced as
+        // a warning (rc-9-no-silent-fallback) — the owner is informed that the
+        // ledger state may be out of sync and can be repaired separately.
+        //
+        // CodeRabbit review fix: use approvalResult.record.artifactId (post-approve
+        // source of truth) instead of the pre-read `existing.artifactId`. If
+        // editApproval() changed the artifact pointer between read and write, the
+        // pre-read value would bind the ledger upgrade to the wrong artifact while
+        // the returned record points to the new one.
+        let ledgerWarning;
+        if (isActivationSuccess(activation)) {
+            ledgerWarning = await this.upgradeLedgerPrinciple(approvalResult.record.artifactId);
+        }
+        return { ok: true, record: approvalResult.record, activation, warning: ledgerWarning };
+    }
+    /**
+     * Bug-O L3b fix: upgrade the ledger principle linked to `artifactId` from
+     * 'candidate' to 'active'. Called by {@link approve} after a successful
+     * activation. Non-fatal on failure — the activation is already committed;
+     * ledger failure is surfaced as a warning string (rc-9).
+     *
+     * The principleId is resolved via {@link extractPrincipleId}'s 4-step
+     * fallback (column → parsed.principleId → parsed.sourcePrincipleId →
+     * parsed.principleDraft.title) so dreamer artifacts whose
+     * sourcePrincipleId column was stripped by stripFabricatedCorePrincipleIds
+     * can still be linked via contentJson.
+     */
+    async upgradeLedgerPrinciple(artifactId) {
+        const stateDir = path.join(this.workspaceDir, '.state');
+        const { connection } = this.createReadContext();
+        try {
+            const piArtifactStore = new SqlitePIArtifactStore(connection);
+            const artifact = await piArtifactStore.getArtifactById(artifactId);
+            if (!artifact) {
+                // rc-9: surface the reason instead of silently returning.
+                return `ledger_activate_skipped: artifact ${artifactId} not found in artifact store`;
+            }
+            const principleId = extractPrincipleId(toArtifactSnapshot(artifact));
+            if (!principleId) {
+                // No principleId resolvable from any source — this is a legitimate
+                // skip (e.g. rule-only artifact), not an error. Surface it so the
+                // owner can verify whether the link was supposed to exist.
+                return `ledger_activate_skipped: artifact ${artifactId} has no resolvable principleId`;
+            }
+            const ledger = new PrincipleTreeLedgerAdapter({ stateDir });
+            const result = ledger.activatePrinciple(principleId);
+            if (!result.ok) {
+                // Reason is already prefixed with `ledger_activate_failed:`.
+                return result.reason;
+            }
+            return undefined;
+        }
+        catch (err) {
+            // CodeRabbit review fix: read-side failures (getArtifactById, missing
+            // table, connection errors) must NOT propagate upward and fail the
+            // approval flow after activation is already committed. The activation
+            // succeeded; ledger upgrade is a non-fatal post-step. Surface the error
+            // as a warning so the owner can repair the ledger separately (rc-9).
+            const message = err instanceof Error ? err.message : String(err);
+            return `ledger_activate_failed: ${message}`;
+        }
+        finally {
+            try {
+                connection.close();
+            }
+            catch { /* best-effort */ }
+        }
     }
     /**
      * Edit a pending approval's artifact to a new version (P1 #2 fix).
@@ -254,7 +342,10 @@ export class ApprovalsConsoleModel {
             const dispatcher = new ActivationDispatcher(artifactReadModel, activationStateStore, {
                 writers: [
                     new PromptWriter(),
-                    new RuleHostWriter({ gateDeps: createProductionGateDeps() }),
+                    new RuleHostWriter({
+                        gateDeps: createProductionGateDeps(),
+                        featureFlagProbe: (flagId) => pdFlags.flags[flagId]?.enabled === true,
+                    }),
                     new DeferArchiveWriter(),
                 ],
                 approvalQueueStore,