create-principles-disciple 1.97.0 → 1.98.0

package/plugin/dist/hooks/gate.js

@@ -8,11 +8,9 @@
  * 1. Early Return: Skip if not write/bash/agent tool or no workspace
  * 2. Rule Host: Dynamic principle-based evaluation (sole gate)
  */
-import { normalizePath } from '../utils/io.js';
 import { WorkspaceContext } from '../core/workspace-context.js';
 import { recordGateBlockAndReturn } from './gate-block-helper.js';
-import { RuleHost } from '../core/rule-host.js';
-import { validateCorrectionProposal, validateProposedPathBounds, computeFeatureFlagsFromConfig, UNAVAILABLE_RULE_CONTEXT } from '@principles/core/runtime-v2';
+import { buildRuleHostAction, validateCorrectionProposal, validateProposedPathBounds, computeFeatureFlagsFromConfig, UNAVAILABLE_RULE_CONTEXT } from '@principles/core/runtime-v2';
 import { AGENT_TOOLS, BASH_TOOLS_SET, WRITE_TOOLS } from '../constants/tools.js';
 import { getSession, hasRecentThinking } from '../core/session-tracker.js';
 import { getEvolutionEngine } from '../core/evolution-engine.js';
@@ -30,41 +28,27 @@ export function handleBeforeToolCall(event, ctx) {
         return;
     }
     const wctx = WorkspaceContext.fromHookContext(ctx);
-    // 2. Resolve the target file path
-    let filePath = event.params?.file_path || event.params?.path || event.params?.file || event.params?.target;
-    // Heuristic for bash mutation detection
-    if (isBash && !filePath) {
-        const command = String(event.params?.command || event.params?.args || '');
-        const mutationMatch = /(?:>|>>|sed\s+-i|rm|mv|mkdir|touch|cp)\s+(?:-[a-zA-Z]+\s+)*([^\s;&|<>]+)/.exec(command);
-        if (mutationMatch) {
-            filePath = mutationMatch[1];
-        }
-        else {
-            // Bash command without a clear file target — let it through to Rule Host
-            filePath = command;
-        }
-    }
-    // Write tools without a file path must still go through RuleHost evaluation.
-    // Use a synthetic path so RuleHost can evaluate and potentially block.
-    if (!filePath && isWriteTool) {
-        filePath = `<tool:${event.toolName}>`;
-    }
-    if (typeof filePath !== 'string')
+    // 2. Use the same action builder as Golden Trace replay. This is the single
+    // path extraction + normalization contract for production and evaluation.
+    const action = buildRuleHostAction(event.toolName, event.params ?? {}, ctx.workspaceDir, {
+        isBashTool: isBash,
+        isWriteTool,
+    });
+    const relPath = action.normalizedPath;
+    // buildRuleHostAction returns null when no path can be extracted (e.g. bash
+    // command with no file target and no clear mutation operator). Mirror the
+    // legacy guard: no path → no gate evaluation, let the tool through.
+    if (relPath === null)
         return;
-    const relPath = normalizePath(filePath, ctx.workspaceDir);
     // 3. Rule Host Evaluation — sole gate
     try {
-        const ruleHost = new RuleHost(wctx.stateDir, logger, { workspaceDir: ctx.workspaceDir });
+        const ruleHost = wctx.getRuleHost(logger);
         // PRI-483 Phase 4: assemble RuleContextV2 when `rulecode_context_v2` flag is ON.
         // flag OFF → undefined (v1 zero-change, no trajectory access).
         // flag ON  → RuleContextV2 (available or unavailable). Never throws (ERR-024).
         const ruleContext = _buildRuleContextIfEnabled(wctx, relPath, ctx.sessionId, logger);
         const hostInput = {
-            action: {
-                toolName: event.toolName,
-                normalizedPath: relPath,
-                paramsSummary: _extractParamsSummary(event.params ?? {}),
-            },
+            action,
             workspace: {
                 isRiskPath: false, // Rule Host determines risk dynamically
                 // DEPRECATED (PRI-286): planStatus/hasPlanFile are legacy compatibility fields.
@@ -88,7 +72,27 @@ export function handleBeforeToolCall(event, ctx) {
             },
             context: ruleContext,
         };
-        const hostResult = ruleHost.evaluate(hostInput);
+        const report = typeof ruleHost.evaluateDetailed === 'function'
+            ? ruleHost.evaluateDetailed(hostInput)
+            : { liveDecision: ruleHost.evaluate(hostInput), shadowDecisions: [] };
+        const hostResult = report.liveDecision;
+        for (const shadowDecision of report.shadowDecisions) {
+            try {
+                const eventLog = EventLogService.get(wctx.stateDir, logger);
+                eventLog.recordRuleHostEvaluated({
+                    toolName: event.toolName,
+                    filePath: relPath,
+                    matched: shadowDecision.matched,
+                    decision: shadowDecision.decision,
+                    ruleId: shadowDecision.ruleId,
+                    activationId: shadowDecision.activationId,
+                    activationMode: 'shadow',
+                });
+            }
+            catch (evErr) {
+                logger?.warn?.(`[PD_GATE] Failed to record shadow rulehost_evaluated: ${String(evErr)}`);
+            }
+        }
         // Always emit rulehost_evaluated
         try {
             const eventLog = EventLogService.get(wctx.stateDir, logger);
@@ -98,6 +102,7 @@ export function handleBeforeToolCall(event, ctx) {
                 matched: hostResult?.matched ?? false,
                 decision: hostResult?.decision ?? 'allow',
                 ruleId: hostResult?.ruleId,
+                activationMode: 'live',
             });
         }
         catch (evErr) {
@@ -321,25 +326,6 @@ export function handleBeforeToolCall(event, ctx) {
 // ---------------------------------------------------------------------------
 // Private helpers
 // ---------------------------------------------------------------------------
-function _extractParamsSummary(params) {
-    const summary = {};
-    // NOTE: Do NOT redact here — this feeds into RuleHost.evaluate() which
-    // may match against paramsSummary.command. Redaction happens at
-    // EventLog.record() before persistence.
-    if (params.file_path)
-        summary.file_path = params.file_path;
-    if (params.path)
-        summary.path = params.path;
-    if (params.command)
-        summary.command = params.command;
-    if (params.args)
-        summary.args = params.args;
-    if (params.old_string)
-        summary.old_string = params.old_string;
-    if (params.new_string)
-        summary.new_string = params.new_string;
-    return summary;
-}
 function _getCurrentGfi(sessionId) {
     if (!sessionId)
         return 0;

package/plugin/package.json

@@ -57,7 +57,7 @@
     "@types/better-sqlite3": "^7.6.13",
     "@types/js-yaml": "^4.0.9",
     "@types/micromatch": "^4.0.10",
-    "@types/node": "^25.6.2",
+    "@types/node": "^26.0.1",
     "@types/ws": "^8.5.13",
     "@typescript-eslint/eslint-plugin": "^8.61.0",
     "@typescript-eslint/parser": "^8.58.0",
@@ -83,7 +83,7 @@
     "@sinclair/typebox": "^0.34.48",
     "better-sqlite3": "^12.9.0",
     "commander": "^12.0.0",
-    "js-yaml": "^4.1.1",
+    "js-yaml": "^5.2.0",
     "micromatch": "^4.0.8"
   }
 }