create-principles-disciple 1.94.0 → 1.96.0

package/core/dist/runtime-v2/__tests__/architecture-regression.test.js

@@ -23,6 +23,8 @@ const REQUIRED_SOURCE_FILES = [
     'internalization/rule-host-contracts.ts',
     'internalization/rule-host-helpers.ts',
     'internalization/index.ts',
+    // PRI-480 (RuleContext v2 — Phase 1 Core ABI)
+    'internalization/rule-context-v2.ts',
     // PRI-43
     'internalization/internalization-route.ts',
     // PRI-44
@@ -98,6 +100,8 @@ const REQUIRED_SOURCE_FILES = [
     // RuleHost MVP Activation (PRI-421..428, ADR-0014 Amendment 2026-06-17)
     'internalization/adversarial-case.ts',
     'internalization/adversarial-feedback.ts',
+    // PRI-485 Phase 6: v2 adversarial case generator (pure logic)
+    'internalization/v2-adversarial-cases.ts',
     'internalization/artificer-prompt-builder.ts',
     'adversarial-loop.ts',
     // Phase 2 migration: evolution types
@@ -201,6 +205,10 @@ const REQUIRED_SOURCE_FILES = [
     'pain-gate/index.ts',
     'detection/detection-funnel-policy.ts',
     'detection/index.ts',
+    // PRI-470: IntentDecisionRecord durable store + types (SPEC §21.7)
+    'intent/intent-decision-record.ts',
+    'store/intent/sqlite-intent-decision-store.ts',
+    'store/intent/index.ts',
 ];
 // ── PRI-212: Plugin core anti-growth guard ────────────────────────────────────
 //
@@ -278,6 +286,16 @@ const KNOWN_PLUGIN_CORE_FILES = new Set([
     'schema/migrations/001-init-trajectory.ts',
     // ── I/O Boundary ────────────────────────────────────────────────────────
     'trajectory.ts',
+    // PRI-482: Plugin I/O boundary — converts raw TrajectoryDatabase rows into
+    // validated RuleHistoryWindow. Pure logic (canonicalize, validate, facts)
+    // delegated to @principles/core. Assembler stays in plugin because it
+    // consumes DB row shapes (I/O data).
+    'rule-context-assembler.ts',
+    // PRI-484: Plugin I/O boundary — assembles a BehaviorExamplePack for the
+    // Artificer by reading pain lineage + trajectory from TrajectoryDatabase.
+    // Pure logic (type + validator) lives in @principles/core; this module
+    // owns the DB row → pack mapping and fail-loud validation.
+    'behavior-example-pack-assembler.ts',
     'evolution-reducer.ts',
     'focus-history.ts',
     'training-program.ts',
@@ -302,25 +320,33 @@ const KNOWN_PLUGIN_CORE_FILES = new Set([
     // with crypto.createHash + PainDictionary. Kept here because it owns the
     // crypto + dictionary I/O boundary.
     'detection-funnel.ts',
-    'risk-calculator.ts',
     'migration.ts',
     'file-store.ts',
     'pd-task-store.ts',
-    'evolution-migration.ts',
     'empathy-keyword-matcher.ts',
     'pain-lifecycle.ts',
     'session-tracker.ts',
+    // PRI-459: now a thin re-export adapter over @principles/core/principle-tree-ledger.
+    // Kept in the plugin baseline so existing relative imports (./principle-tree-ledger.js)
+    // still resolve. No parsing/serialization/mutation logic may live here — enforced by
+    // tests/ledger-schema-diff.test.ts.
     'principle-tree-ledger.ts',
     'evolution-logger.ts',
     'evolution-engine.ts',
     // ── Runtime V2 ──────────────────────────────────────────────────────────
     'runtime-v2-prompt-activation-reader.ts',
     'workspace-guidance-migrator.ts',
-    'surface-guard.ts',
     // PRI-307: Plugin I/O boundary — reads .pd/config.yaml, delegates validation to core
     'pd-config-loader.ts',
     // PRI-346: Pure function for checking conversation access config (extracted for circular import avoidance)
     'config-health.ts',
+    // PRI-467: Plugin I/O boundary — reads .principles/INTENT.md with TTL+mtime cache,
+    // delegates parsing/validation/hashing to @principles/core. Never throws.
+    'intent-doc-reader.ts',
+    // PRI-468: Plugin adapter implementing core IntentDocReader port — pure type
+    // mapping from safeReadIntentDoc result to the core-owned IntentDocReadResult.
+    // No new I/O; delegates to intent-doc-reader.ts above.
+    'intent-doc-reader-adapter.ts',
     // ── Test Files ──────────────────────────────────────────────────────────
     '__tests__/focus-history.test.ts',
     'principle-compiler/__tests__/compiler-replay-gate.test.ts',
@@ -362,7 +388,7 @@ describe('PRI-212 plugin core anti-growth guard', () => {
             expect.fail(msg);
         }
     });
-    it('known baseline count is self-consistent (97 files)', async () => {
+    it('known baseline count is self-consistent (92 files)', async () => {
         // Sanity check: if the baseline grows, update this number.
         // Prevents accidental baseline bloat from going unnoticed.
         // See docs/reviews/plugin-core-inventory-2026-05.md §7
@@ -376,7 +402,22 @@ describe('PRI-212 plugin core anti-growth guard', () => {
         // PRI-446: pain-diagnostic-gate.ts and detection-funnel.ts remain at 92 —
         // they are now thin adapters delegating pure logic to core, but still live
         // in plugin src/core/ and own I/O side effects, so they stay classified.
-        expect(KNOWN_PLUGIN_CORE_FILES.size).toBe(92);
+        // PRI-467: Added intent-doc-reader.ts (92 → 93) — plugin I/O boundary for
+        // reading .principles/INTENT.md with TTL+mtime cache for prompt injection.
+        // PRI-468: Added intent-doc-reader-adapter.ts (93 → 94) — plugin adapter
+        // implementing core IntentDocReader port (pure type mapping, no new I/O).
+        // Stage-1 cleanup: Removed evolution-migration.ts (94 → 93) — dead code,
+        // zero production references after refactor to @principles/core.
+        // PRI-482: Added rule-context-assembler.ts (93 → 94) — plugin I/O boundary
+        // converting TrajectoryDatabase rows to validated RuleHistoryWindow.
+        // Stage-3: Removed risk-calculator.ts (94 → 93) — pure logic sunk to
+        // core runtime-v2/risk/, dead code (assessRiskLevel/getTargetFileLineCount/
+        // calculatePercentageThreshold) removed.
+        // Stage-3 sink: Removed surface-guard.ts (93 → 92) — pure guard logic
+        // migrated to @principles/core/runtime-v2/feature-flags/surface-guard-policy.
+        // PRI-484: Added behavior-example-pack-assembler.ts (92 → 93) — plugin I/O
+        // boundary assembling BehaviorExamplePack from pain lineage + trajectory.
+        expect(KNOWN_PLUGIN_CORE_FILES.size).toBe(93);
     });
 });
 const REQUIRED_TEST_FILES = [
@@ -456,6 +497,11 @@ const REQUIRED_TEST_FILES = [
     '../internalization/__tests__/diag-chain-e2e.test.ts',
     // PRI-431
     'build-l2-principle-reader.test.ts',
+    // PRI-469
+    'evidence-chain-intent-tension.test.ts',
+    // PRI-470: IntentDecisionRecord types + SQLite store
+    '../intent/__tests__/intent-decision-record.test.ts',
+    '../store/intent/__tests__/sqlite-intent-decision-store.test.ts',
 ];
 const REQUIRED_DOC_FILES = [];
 for (const file of REQUIRED_SOURCE_FILES) {
@@ -521,6 +567,8 @@ describe('runtime-v2 public API (index.ts barrel)', () => {
         'buildL2PrincipleReaderFromLedger',
         // LLM output hardening — shared utility
         'stripFabricatedCorePrincipleIds',
+        // PRI-470: IntentDecisionRecord durable SQLite store
+        'SqliteIntentDecisionStore',
     ];
     for (const name of REQUIRED_EXPORTS) {
         it(`exports ${name}`, async () => {
@@ -581,13 +629,6 @@ describe('openclaw-plugin pain hook integration', () => {
 });
 // ── PRI-42: Internalization boundary guards ──────────────────────────────────
 describe('PRI-42 internalization boundary', () => {
-    const CONTRACT_TYPES = [
-        'RuleHostInput',
-        'RuleHostResult',
-        'RuleHostDecision',
-        'RuleHostMeta',
-        'LoadedImplementation',
-    ];
     it('core internalization has zero openclaw-plugin imports', async () => {
         const { existsSync, readdirSync, readFileSync } = await import('node:fs');
         const { resolve, join } = await import('node:path');
@@ -636,29 +677,6 @@ describe('PRI-42 internalization boundary', () => {
             expect(src).not.toContain('../../../openclaw-plugin');
         }
     });
-    it('plugin does not re-define RuleHost contract types locally', async () => {
-        const { existsSync, readFileSync } = await import('node:fs');
-        const { resolve } = await import('node:path');
-        const typesPath = resolve(__dirname, '../../../../openclaw-plugin/src/core/rule-host-types.ts');
-        expect(existsSync(typesPath)).toBe(true);
-        const src = readFileSync(typesPath, 'utf-8');
-        // After PRI-42, rule-host-types.ts should re-export from core, not define interfaces
-        for (const typeName of CONTRACT_TYPES) {
-            expect(src).toContain(typeName);
-            expect(src).toContain("from '@principles/core/runtime-v2'");
-        }
-    });
-    it('plugin does not re-define RuleHostHelpers locally', async () => {
-        const { existsSync, readFileSync } = await import('node:fs');
-        const { resolve } = await import('node:path');
-        const helpersPath = resolve(__dirname, '../../../../openclaw-plugin/src/core/rule-host-helpers.ts');
-        expect(existsSync(helpersPath)).toBe(true);
-        const src = readFileSync(helpersPath, 'utf-8');
-        // After PRI-42, rule-host-helpers.ts should re-export from core, not define interface
-        expect(src).toContain('RuleHostHelpers');
-        expect(src).toContain('createRuleHostHelpers');
-        expect(src).toContain("from '@principles/core/runtime-v2'");
-    });
     it('plugin rule-host.ts imports contracts from core barrel', async () => {
         const { existsSync, readFileSync } = await import('node:fs');
         const { resolve } = await import('node:path');
@@ -3192,33 +3210,31 @@ describe('PRI-443: pure module boundary guards', () => {
         expect(src).not.toMatch(/export\s+type\s+\{\s*LedgerTreeStore\s*\}\s*from\s*['"]\.\.\/principle-tree-ledger\.js['"]/);
     });
 });
-// ── PRI-450: Core I/O whitelist guard ──────────────────────────────────────────
-//
-// Scans all production (.ts, non-test) files under packages/principles-core/src/
-// for fs/path imports and verifies they match an explicit whitelist. Any new file
-// that needs I/O must be added to ALLOWED_IO_FILES here — otherwise CI fails.
-// This forces developers to explain "why does this file need I/O?" in their PR.
-describe('PRI-450: core I/O whitelist guard', () => {
-    // Whitelist of production files allowed to import fs/path.
-    // Paths are relative to packages/principles-core/src/.
-    const ALLOWED_IO_FILES = new Set([
-        'principle-tree-ledger.ts',
-        'evolution-store.ts',
-        'trajectory-store.ts',
-        'workflow-funnel-loader.ts',
-        'runtime-v2/store/sqlite-connection.ts',
-        'runtime-v2/store/runtime-state-manager.ts',
-        'runtime-v2/adapter/openclaw-cli-runtime-adapter.ts',
-        'runtime-v2/candidate-audit.ts',
-        'runtime-v2/pain-signal-observability.ts',
-        'runtime-v2/internalization-chain-integrity-read-model.ts',
-        'runtime-v2/internalization-integrity-remediation.ts',
-        'runtime-v2/operator-health-read-model.ts',
-        'runtime-v2/pain-chain-read-model.ts',
-        'runtime-v2/pruning-read-model.ts',
-        'runtime-v2/pruning-review-log.ts',
-        'runtime-v2/schema-conformance-read-model.ts',
-    ]);
+describe('PRI-450 / PRI-462: core I/O seam registry guard', () => {
+    // Registry lives at packages/principles-core/io-seam-registry.json
+    // (3 levels up from __tests__: __tests__ → runtime-v2 → src → principles-core)
+    const registryPath = pathSync.resolve(__dirname, '..', '..', '..', 'io-seam-registry.json');
+    const registryRaw = fsSync.readFileSync(registryPath, 'utf-8');
+    const registry = JSON.parse(registryRaw);
+    // Runtime-validate the registry shape (Runtime Contract Rule 1+2: treat
+    // parsed JSON as unknown, validate with typeof/Array.isArray before access).
+    // `as` is used only for type narrowing AFTER runtime checks, not to bypass them.
+    function isValidRegistry(v) {
+        if (typeof v !== 'object' || v === null || !Object.hasOwn(v, 'seams'))
+            return false;
+        const { seams } = v;
+        if (!Array.isArray(seams))
+            return false;
+        return seams.every((s) => typeof s === 'object' && s !== null &&
+            typeof s.name === 'string' &&
+            typeof s.description === 'string' &&
+            Array.isArray(s.files) &&
+            s.files.every((f) => typeof f === 'string'));
+    }
+    // Flatten all registry files into a Set (relative to packages/principles-core/src/).
+    const ALLOWED_IO_FILES = new Set(isValidRegistry(registry)
+        ? registry.seams.flatMap((s) => s.files)
+        : []);
     // Extract all import module paths from source code.
     // Handles: import ... from 'mod', import 'mod' (side-effect), and multiline imports.
     // Reuses the same pattern proven in the PRI-215 extractImportModulePaths helper.
@@ -3257,7 +3273,52 @@ describe('PRI-450: core I/O whitelist guard', () => {
             }
         }
     }
-    it('core/src/ production files: only whitelisted files import fs/path', () => {
+    // ── Registry validity (PRI-462) ───────────────────────────────────────────
+    it('io-seam-registry.json is valid: seams array with name/description/files', () => {
+        expect(isValidRegistry(registry)).toBe(true);
+        if (!isValidRegistry(registry))
+            return; // type narrowing
+        expect(registry.seams.length).toBeGreaterThan(0);
+        for (const seam of registry.seams) {
+            expect(seam.name.length).toBeGreaterThan(0);
+            expect(seam.description.length).toBeGreaterThan(0);
+            expect(seam.files.length).toBeGreaterThan(0);
+        }
+    });
+    it('registry has no duplicate files across seams', () => {
+        if (!isValidRegistry(registry)) {
+            // isValidRegistry test above will fail with details; skip here.
+            expect(isValidRegistry(registry)).toBe(true);
+            return;
+        }
+        const seen = new Set();
+        const dupes = [];
+        for (const seam of registry.seams) {
+            for (const f of seam.files) {
+                if (seen.has(f))
+                    dupes.push(f);
+                seen.add(f);
+            }
+        }
+        expect(dupes).toEqual([]);
+    });
+    it('every seam description explains why the I/O is allowed (non-trivial)', () => {
+        if (!isValidRegistry(registry)) {
+            expect(isValidRegistry(registry)).toBe(true);
+            return;
+        }
+        const weak = [];
+        for (const seam of registry.seams) {
+            // Description must be at least 20 chars — a single word like "legacy" is
+            // not an explanation. This forces maintainers to write a real rationale.
+            if (seam.description.trim().length < 20) {
+                weak.push(`${seam.name}: "${seam.description}"`);
+            }
+        }
+        expect(weak).toEqual([]);
+    });
+    // ── Registry ↔ production files (PRI-450, EP-02) ──────────────────────────
+    it('core/src/ production files: only registry-listed files import fs/path', () => {
         const coreSrcDir = pathSync.resolve(__dirname, '..', '..');
         const allFiles = [];
         collectTsFiles(coreSrcDir, allFiles);
@@ -3271,9 +3332,13 @@ describe('PRI-450: core I/O whitelist guard', () => {
                 }
             }
         }
-        expect(violations).toEqual([]);
+        if (violations.length > 0) {
+            throw new Error(`Found ${violations.length} file(s) importing fs/path that are NOT in io-seam-registry.json.\n` +
+                `Add them to the appropriate seam in packages/principles-core/io-seam-registry.json.\n` +
+                `Violations:\n  ` + violations.join('\n  '));
+        }
     });
-    it('ALLOWED_IO_FILES whitelist entries all exist on disk', () => {
+    it('registry-listed files all exist on disk', () => {
         const coreSrcDir = pathSync.resolve(__dirname, '..', '..');
         const missing = [];
         for (const relPath of ALLOWED_IO_FILES) {
@@ -3284,6 +3349,19 @@ describe('PRI-450: core I/O whitelist guard', () => {
         }
         expect(missing).toEqual([]);
     });
+    // ── Registry ↔ ESLint exemption (PRI-462, EP-06 single source of truth) ───
+    //
+    // ESLint's no-restricted-imports exemption list must be DERIVED from the
+    // registry, not hand-maintained. This test verifies eslint.config.js
+    // references the registry file, proving the two stay in sync.
+    it('eslint.config.js derives fs/path exemption from the registry (no shadow list)', () => {
+        const eslintPath = pathSync.resolve(__dirname, '..', '..', '..', '..', '..', 'eslint.config.js');
+        const eslintSrc = fsSync.readFileSync(eslintPath, 'utf-8');
+        // The eslint config must read the registry JSON — if this reference is
+        // removed, someone has reintroduced a hand-maintained shadow list.
+        expect(eslintSrc).toContain('io-seam-registry.json');
+    });
+    // ── Helper unit tests ─────────────────────────────────────────────────────
     it('importsFsOrPath detects sub-path imports (fs/promises) and side-effect imports', () => {
         // Sub-path import
         expect(importsFsOrPath(`import { mkdir } from 'node:fs/promises';`)).toBe(true);