create-principles-disciple 1.93.0 → 1.95.0

package/console/dist/ui/pages/pain/pain-card-helpers.js

@@ -37,6 +37,8 @@ export function buildCardLayers(record) {
         failureReason: record.failureReason ?? null,
         degradedReason: record.degradedReason ?? null,
         nextAction: record.nextAction ?? null,
+        // PRI-469: pass intentTension through to Layer 2 for the IntentTensionPanel.
+        intentTension: record.intentTension ?? null,
     };
     const layer3 = {
         id: record.id,
@@ -101,3 +103,79 @@ export function isLayer2EffectivelyEmpty(record) {
         return true;
     return false;
 }
+// ── PRI-469: Intent Tension panel rendering helpers (SPEC §22.1) ─────────────
+/**
+ * Whether the IntentTensionPanel should render a high-salience decision panel.
+ *
+ * SPEC §22.1.3: when `source = none`, do NOT render a high-salience decision
+ * panel. The tension may still be shown in technical details as "no intent
+ * tension", but it must not compete for the Owner's attention.
+ *
+ * This helper is pure and tested independently of the React component.
+ */
+export function shouldRenderIntentTensionPanel(tension) {
+    if (!tension)
+        return false;
+    // source='none' means no tension detected — suppress the high-salience panel.
+    if (tension.source === 'none')
+        return false;
+    return true;
+}
+/**
+ * Whether follow-up actions (precipitate candidate principle, promote to
+ * RuleHost, view Intent Patch Proposal) should be visible.
+ *
+ * SPEC §22.1.4: follow-up actions are NOT the first-layer decision. They only
+ * appear after the Owner has confirmed a decision (an IntentDecisionRecord
+ * has been persisted for this tension).
+ *
+ * PRI-470: replaced the PRI-469 stub. Now returns true only when a non-empty
+ * decisions array exists — i.e., at least one IntentDecisionRecord has been
+ * persisted for this tension.
+ */
+export function shouldRenderFollowUpActions(decisions) {
+    if (!Array.isArray(decisions))
+        return false;
+    return decisions.length > 0;
+}
+/**
+ * Build an IntentDecisionInputPayload from an IntentTension and the Owner's
+ * chosen action. The payload is sent to POST /api/v1/intent-decisions.
+ *
+ * - `id` is the caller-supplied decision UUID (P0 fix: server requires this).
+ * - `taskId` falls back to `recordId` when not provided.
+ * - Optional fields (painId, intentDocHash, note) are omitted when empty.
+ * - `note` is trimmed before being included.
+ * - `evidenceRefs` is passed through as-is; truncation is the backend's job
+ *   (the frontend must not silently drop evidence the Owner might rely on).
+ * - `ownerAction` overrides `tension.suggestedOwnerAction` — the Owner may
+ *   choose a different action than the one PD suggested.
+ *
+ * P0 fix (PRI-471): the previous payload used `evidence` + `explanation` +
+ * `suggestedAction` and omitted `id`, which did not match the server's
+ * `IntentDecisionInput` contract (SPEC §21.7). The server requires `id` and
+ * `evidenceRefs`, and does not accept `explanation` or `suggestedAction` —
+ * those are snapshot fields the server persists from the tension, not inputs.
+ */
+export function buildIntentDecisionPayload(tension, context, choice) {
+    const { ownerAction, note } = choice;
+    const payload = {
+        id: context.id,
+        taskId: context.taskId ?? context.recordId,
+        source: tension.source,
+        evidenceStrength: tension.evidenceStrength,
+        relatedIntentFields: tension.relatedIntentFields,
+        evidenceRefs: tension.evidence,
+        ownerAction,
+    };
+    if (context.painId !== undefined && context.painId.length > 0) {
+        payload.painId = context.painId;
+    }
+    if (context.intentDocHash !== undefined && context.intentDocHash.length > 0) {
+        payload.intentDocHash = context.intentDocHash;
+    }
+    if (note !== undefined && note.trim().length > 0) {
+        payload.note = note.trim();
+    }
+    return payload;
+}

package/console/dist/ui/pages/principles/PrinciplesPage.js

@@ -6,6 +6,7 @@ import { PageShell } from "../../components/layout/page-shell.js";
 import { SectionTitle } from "../../components/layout/section-title.js";
 import { Button } from "../../components/ui/button.js";
 import { Skeleton } from "../../components/ui/skeleton.js";
+import { ShinyText } from "../../components/ui/shiny-text.js";
 import { fetchPrinciples, fetchApprovalsGrouped, } from "../../api.js";
 import { enumLabel } from "../../utils/enum-labels.js";
 // ── Map principle status to review status ───────────────────────────────────
@@ -215,7 +216,7 @@ export function PrinciplesPage() {
         { value: "rejected", label: t("principles.statusRejected") },
         { value: "parked", label: t("principles.statusParked") },
     ];
-    return (_jsxs(PageShell, { children: [_jsx(SectionTitle, { children: t("principles.reviewTitle") }), _jsx("h1", { className: "text-[29px] font-semibold tracking-tight text-ink mb-2", children: t("principles.reviewSubtitle") }), _jsx("p", { className: "text-ink-3 text-[14px] leading-relaxed mb-6", children: t("principles.reviewDescription") }), _jsxs("div", { className: "flex flex-wrap items-center gap-3 mb-6", children: [_jsxs("div", { className: "flex gap-1", role: "group", "aria-label": "Filter mode", children: [_jsxs("button", { onClick: () => setFilterMode('actionable'), className: "font-mono text-[11px] uppercase tracking-[0.02em] border rounded-[2px] px-2 py-1 transition-colors focus-visible:outline-2 focus-visible:outline-offset-2 focus-visible:outline-gov " +
+    return (_jsxs(PageShell, { children: [_jsx(SectionTitle, { children: t("principles.reviewTitle") }), _jsx(ShinyText, { as: "h1", className: "text-[29px] font-semibold tracking-tight text-ink mb-2", duration: 4.5, brightness: 0.5, disabled: !(filterMode === 'actionable' && (categories?.owner_actionable ?? 0) > 0), children: t("principles.reviewSubtitle") }), _jsx("p", { className: "text-ink-3 text-[14px] leading-relaxed mb-6", children: t("principles.reviewDescription") }), _jsxs("div", { className: "flex flex-wrap items-center gap-3 mb-6", children: [_jsxs("div", { className: "flex gap-1", role: "group", "aria-label": "Filter mode", children: [_jsxs("button", { onClick: () => setFilterMode('actionable'), className: "font-mono text-[11px] uppercase tracking-[0.02em] border rounded-[2px] px-2 py-1 transition-colors focus-visible:outline-2 focus-visible:outline-offset-2 focus-visible:outline-gov " +
                                     (filterMode === 'actionable'
                                         ? "bg-gov text-paper border-gov"
                                         : "bg-surface text-ink-3 border-line hover:border-line-2"), children: [t("principles.filterActionable", { defaultValue: "Actionable" }), categories?.owner_actionable ? ` (${categories.owner_actionable})` : ''] }), _jsxs("button", { onClick: () => setFilterMode('all'), className: "font-mono text-[11px] uppercase tracking-[0.02em] border rounded-[2px] px-2 py-1 transition-colors focus-visible:outline-2 focus-visible:outline-offset-2 focus-visible:outline-gov " +

package/console/dist/ui/utils/validators.d.ts

@@ -127,6 +127,11 @@ export interface AgentBindingUpdateData {
     enabled: boolean;
 }
 export declare function validateAgentBindingUpdate(v: unknown): AgentBindingUpdateData | null;
+export interface FeatureFlagUpdateData {
+    feature: string;
+    enabled: boolean;
+}
+export declare function validateFeatureFlagUpdate(v: unknown): FeatureFlagUpdateData | null;
 export interface ReadinessCheckData {
     agent: string;
     readiness: ReadinessStatus;
@@ -354,7 +359,138 @@ export interface EvidenceChainRecordData {
     /** PRI-380: internalization task linkage */
     internalizationTaskId?: string;
     dreamerTaskStatus?: string;
+    /** PRI-469: optional intent tension from diagnostician artifact (SPEC §16). */
+    intentTension?: IntentTensionData;
+}
+export interface IntentTensionData {
+    source: string;
+    evidenceStrength: string;
+    relatedIntentFields: string[];
+    evidence: string[];
+    explanation: string;
+    suggestedOwnerAction: string;
+    intentDocHash?: string;
+}
+/**
+ * Validate an untrusted `intentTension` object from the EvidenceChain API
+ * response. Returns `null` when malformed; the caller (validateEvidenceChainRecord)
+ * treats a `null` intentTension as "not present" so the record is still usable.
+ *
+ * SPEC §16.3: `confidence` is forbidden — explicitly rejected here.
+ * SPEC §16.4: evidence is capped at 3 items; we accept up to 3 and reject
+ * arrays with non-string elements (ERR-005/007).
+ */
+export declare function validateIntentTension(v: unknown): IntentTensionData | null;
+export interface IntentDecisionRecordData {
+    id: string;
+    painId?: string;
+    taskId?: string;
+    runId?: string;
+    intentDocHash?: string;
+    source: string;
+    evidenceStrength: string;
+    relatedIntentFields: string[];
+    ownerAction: string;
+    evidenceRefs: string[];
+    resultingCandidateId?: string;
+    resultingRuleCandidateId?: string;
+    patchProposalId?: string;
+    createdAt: string;
+}
+/**
+ * Validate an untrusted IntentDecisionRecord object from the API.
+ * Returns null when malformed (Rule 3: fail loud on missing/wrong-type fields).
+ *
+ * Enum fields (source, evidenceStrength, ownerAction) are validated against
+ * the same sets used by validateIntentTension. relatedIntentFields elements
+ * are validated against VALID_INTENT_RELATED_FIELDS.
+ */
+export declare function validateIntentDecisionRecord(v: unknown): IntentDecisionRecordData | null;
+/**
+ * Validate a list of IntentDecisionRecord objects. Returns null if any
+ * element is malformed (ERR-005/007: validate array element types).
+ */
+export declare function validateIntentDecisionList(v: unknown): IntentDecisionRecordData[] | null;
+export interface IntentDecisionResultData {
+    record: IntentDecisionRecordData;
+    created: boolean;
+}
+/**
+ * Validate the POST /api/v1/intent-decisions response envelope.
+ * Shape: { record: IntentDecisionRecord, created: boolean }
+ */
+export declare function validateIntentDecisionResult(v: unknown): IntentDecisionResultData | null;
+export interface IntentDecisionSummaryData {
+    counts: {
+        confirm_drift: number;
+        revise_intent: number;
+        observe: number;
+        dismiss: number;
+        promote_to_principle: number;
+        promote_to_rulehost: number;
+    };
+    lastDecisionAt: string | null;
+}
+/**
+ * Validate the GET /api/v1/intent-decisions/summary response.
+ * All 6 count keys must be present with non-negative finite numbers.
+ * lastDecisionAt: null is valid, string is valid, anything else returns null.
+ */
+export declare function validateIntentDecisionSummary(v: unknown): IntentDecisionSummaryData | null;
+export type FollowUpResponseType = 'link_candidate' | 'guide_rulehost' | 'generate_patch_proposal';
+/**
+ * Response for `link_candidate` follow-up.
+ * - `record` is the updated IntentDecisionRecord with `resultingCandidateId` set.
+ * - `linkedCandidateId` echoes the candidate id that was linked.
+ */
+export interface LinkCandidateFollowUpData {
+    type: 'link_candidate';
+    decisionId: string;
+    record: IntentDecisionRecordData;
+    linkedCandidateId: string;
+}
+/**
+ * Response for `guide_rulehost` follow-up.
+ * - `cliCommand` is the command the Owner should run in their terminal.
+ * - `note` explains what happens next (RuleHost approval will be created).
+ *
+ * No DB write occurs for this follow-up type — the response is pure guidance.
+ */
+export interface GuideRulehostFollowUpData {
+    type: 'guide_rulehost';
+    decisionId: string;
+    cliCommand: string;
+    note: string;
+}
+/**
+ * Response for `generate_patch_proposal` follow-up.
+ * - `record` is the updated IntentDecisionRecord with `patchProposalId` set.
+ * - `patchProposal.markdown` is the SPEC §10 formatted proposal text.
+ *
+ * The proposal is read-only — PD never auto-applies it to `.principles/INTENT.md`.
+ */
+export interface GeneratePatchProposalFollowUpData {
+    type: 'generate_patch_proposal';
+    decisionId: string;
+    record: IntentDecisionRecordData;
+    patchProposal: {
+        id: string;
+        markdown: string;
+    };
 }
+export type FollowUpResponseData = LinkCandidateFollowUpData | GuideRulehostFollowUpData | GeneratePatchProposalFollowUpData;
+/**
+ * Validate the POST /api/v1/intent-decisions/:id/follow-up response.
+ *
+ * The response is a discriminated union on the `type` field. Each branch has
+ * its own required fields (Rule 3: fail loud on missing required fields).
+ *
+ * Common required fields: `type`, `decisionId`.
+ * - link_candidate: + `record` (IntentDecisionRecordData), `linkedCandidateId`
+ * - guide_rulehost: + `cliCommand`, `note`
+ * - generate_patch_proposal: + `record`, `patchProposal: { id, markdown }`
+ */
+export declare function validateFollowUpResponse(v: unknown): FollowUpResponseData | null;
 export interface EvidenceChainData {
     records: EvidenceChainRecordData[];
     generatedAt: string;
@@ -404,3 +540,30 @@ export interface TrajectoryData {
     };
 }
 export declare function validateTrajectoryData(v: unknown): TrajectoryData | null;
+export interface IntentDocWarningData {
+    code: string;
+    section?: string;
+    message: string;
+}
+export interface IntentSectionsData {
+    why?: string;
+    desiredOutcome?: string;
+    nonNegotiables?: string;
+    stopEscalation?: string;
+    currentStrategicFocus?: string;
+}
+export interface IntentSummaryData {
+    ok: boolean;
+    found: boolean;
+    flagEnabled: boolean;
+    reason?: string;
+    nextAction?: string;
+    path?: string;
+    contentHash?: string;
+    lastEditedAt?: string;
+    sections?: IntentSectionsData;
+    warnings: IntentDocWarningData[];
+}
+export declare function validateIntentWarning(v: unknown): IntentDocWarningData | null;
+export declare function validateIntentSections(v: unknown): IntentSectionsData | null;
+export declare function validateIntentSummary(v: unknown): IntentSummaryData | null;