create-principles-disciple 1.92.0 → 1.94.0

package/plugin/dist/hooks/raw-observation-adapter.d.ts

@@ -1,57 +1,16 @@
 /**
- * Raw Observation Adapter — PRI-362
+ * Raw Observation Adapter — PRI-362 / PRI-446
  *
- * Unified source-kind resolution from RawObservation.
+ * The source-kind resolution logic and RawObservation builders have been
+ * migrated to principles-core (runtime-v2/evidence-triage/observation-resolver.ts).
  *
- * Replaces scattered resolveSourceKindFrom* functions with a single
- * field-driven adapter that maps observation fields to SourceKind.
- *
- * Field precedence (highest to lowest):
- * 1. isManualEntry → owner_reported
- * 2. isGateBlock → rulehost_block
- * 3. isSubagentError → subagent_error
- * 4. isRateLimit → rate_limit (if true)
- * 5. toolName === 'pain' / 'skill:pain' → agent_on_owner_request (with openclaw_context_bound) / owner_reported
- * 6. failureSource → tool_failure / dispatch_error
- * 7. isGfiTriggered → gfi_threshold
- * 8. detectionSource → llm_paralysis / semantic / empathy_inferred / unknown
- * 9. Fallback → unknown
+ * This file is now a thin re-export adapter. It preserves the original export
+ * names (resolveSourceKind, buildToolFailureObservation, buildLlmDetectionObservation,
+ * RawObservation) so all existing import sites and the source-string
+ * characterization tests keep working without changes.
  *
  * ERR checklist:
- * - ERR-001: Source kind resolved from runtime values, no `as` casts.
- * - ERR-002: Every path returns a valid SourceKind (fallback to 'unknown').
- * - EP-01: Runtime values validated before use.
+ * - ERR-011: re-export adapter, not a local re-definition of migrated logic.
  */
-import type { SourceKind } from '@principles/core/runtime-v2';
-import type { RawObservation } from './raw-observation-types.js';
+export { resolveSourceKind, buildToolFailureObservation, buildLlmDetectionObservation, buildEmpathyObservation, buildManualPainObservation, } from '@principles/core/runtime-v2';
 export type { RawObservation } from './raw-observation-types.js';
-/**
- * Resolve SourceKind from a unified RawObservation.
- *
- * This function replaces the scattered resolveSourceKindFrom* functions
- * and provides a single entry point for source-kind classification.
- *
- * Field precedence is explicitly defined in the function body to ensure
- * deterministic behavior and make the logic easy to understand and test.
- */
-export declare function resolveSourceKind(observation: RawObservation): SourceKind;
-/**
- * Build a RawObservation for a tool failure context.
- *
- * This replaces classifyToolFailureSource and the inline classification
- * in after-tool-call-helpers. All tool error → dispatch/tool_failure
- * classification is centralized here.
- */
-export declare function buildToolFailureObservation(options: {
-    toolName: string | undefined;
-    error: unknown;
-    exitCode?: number;
-    provenance?: RawObservation['provenance'];
-}): RawObservation;
-/**
- * Build a RawObservation for an LLM detection context.
- */
-export declare function buildLlmDetectionObservation(options: {
-    detectionSource: string;
-    isGfiTriggered: boolean;
-}): RawObservation;

package/plugin/dist/hooks/raw-observation-adapter.js

@@ -1,170 +1,15 @@
 /**
- * Raw Observation Adapter — PRI-362
+ * Raw Observation Adapter — PRI-362 / PRI-446
  *
- * Unified source-kind resolution from RawObservation.
+ * The source-kind resolution logic and RawObservation builders have been
+ * migrated to principles-core (runtime-v2/evidence-triage/observation-resolver.ts).
  *
- * Replaces scattered resolveSourceKindFrom* functions with a single
- * field-driven adapter that maps observation fields to SourceKind.
- *
- * Field precedence (highest to lowest):
- * 1. isManualEntry → owner_reported
- * 2. isGateBlock → rulehost_block
- * 3. isSubagentError → subagent_error
- * 4. isRateLimit → rate_limit (if true)
- * 5. toolName === 'pain' / 'skill:pain' → agent_on_owner_request (with openclaw_context_bound) / owner_reported
- * 6. failureSource → tool_failure / dispatch_error
- * 7. isGfiTriggered → gfi_threshold
- * 8. detectionSource → llm_paralysis / semantic / empathy_inferred / unknown
- * 9. Fallback → unknown
+ * This file is now a thin re-export adapter. It preserves the original export
+ * names (resolveSourceKind, buildToolFailureObservation, buildLlmDetectionObservation,
+ * RawObservation) so all existing import sites and the source-string
+ * characterization tests keep working without changes.
  *
  * ERR checklist:
- * - ERR-001: Source kind resolved from runtime values, no `as` casts.
- * - ERR-002: Every path returns a valid SourceKind (fallback to 'unknown').
- * - EP-01: Runtime values validated before use.
- */
-/**
- * Resolve SourceKind from a unified RawObservation.
- *
- * This function replaces the scattered resolveSourceKindFrom* functions
- * and provides a single entry point for source-kind classification.
- *
- * Field precedence is explicitly defined in the function body to ensure
- * deterministic behavior and make the logic easy to understand and test.
- */
-export function resolveSourceKind(observation) {
-    const { isManualEntry, isGateBlock, isSubagentError, isRateLimit, toolName, failureSource, isGfiTriggered, detectionSource, nonZeroExit, timedOut, toolNotFound, } = observation;
-    // Priority 1: Manual entry (CLI, owner-reported)
-    if (isManualEntry) {
-        return 'owner_reported';
-    }
-    // Priority 2: Gate block
-    if (isGateBlock) {
-        return 'rulehost_block';
-    }
-    // Priority 3: Subagent error
-    if (isSubagentError) {
-        return 'subagent_error';
-    }
-    // Priority 4: Provider rate limit (explicit true/false)
-    if (isRateLimit === true) {
-        return 'rate_limit';
-    }
-    if (isRateLimit === false) {
-        return 'provider_failure';
-    }
-    // Priority 5: Manual pain tool
-    if (toolName === 'pain' || toolName === 'skill:pain') {
-        // Match resolveSourceKindFromToolFailure behavior:
-        // openclaw_context_bound → agent_on_owner_request
-        // other provenance or undefined → owner_reported
-        if (observation.provenance === 'openclaw_context_bound') {
-            return 'agent_on_owner_request';
-        }
-        return 'owner_reported';
-    }
-    // Priority 6: GFI threshold (must check before failure source for LLM detection path)
-    if (isGfiTriggered) {
-        return 'gfi_threshold';
-    }
-    // Priority 7: Tool failure / dispatch error
-    if (failureSource) {
-        // Match resolveSourceKindFromToolFailure behavior:
-        // dispatch_error → dispatch_error, anything else → tool_failure
-        if (failureSource === 'dispatch_error') {
-            return 'dispatch_error';
-        }
-        return 'tool_failure';
-    }
-    // Infer failureSource from tool failure indicators if not explicitly set
-    if (toolNotFound) {
-        return 'dispatch_error';
-    }
-    // Match classifyToolFailureSource behavior: unknown tool name → dispatch_error
-    // BUT only if this looks like a tool failure context (has other tool fields)
-    // Otherwise, this is likely a non-tool observation (e.g., LLM detection)
-    const hasToolContext = toolName !== undefined || nonZeroExit || timedOut || toolNotFound;
-    if (hasToolContext && (!toolName || toolName.trim() === '')) {
-        return 'dispatch_error';
-    }
-    // Exit code-based detection: non-zero exit or timeout → tool_failure
-    if (nonZeroExit || timedOut) {
-        return 'tool_failure';
-    }
-    // Priority 8: LLM detection source
-    if (detectionSource) {
-        // Match resolveSourceKindFromLlmDetection behavior:
-        if (detectionSource === 'llm_paralysis') {
-            return 'llm_paralysis';
-        }
-        if (detectionSource.startsWith('llm_')) {
-            return 'semantic';
-        }
-        if (detectionSource === 'user_empathy') {
-            return 'empathy_inferred';
-        }
-    }
-    // Fallback: unknown
-    return 'unknown';
-}
-// ── Builder Functions ──────────────────────────────────────────────────────
-//
-// PRI-360 S1: These builders construct RawObservation from specific contexts,
-// centralizing source classification rules in the adapter layer.
-// Hooks should NOT hold source classification logic — use these builders.
-/**
- * Classify error message as dispatch_error vs tool_failure.
- *
- * This centralizes the regex-based classification that was previously
- * scattered in classifyToolFailureSource and after-tool-call-helpers.
- * Now hooks call this builder + resolveSourceKind instead of holding rules.
- */
-function classifyErrorForDispatch(error) {
-    if (!error)
-        return 'tool_failure';
-    const msg = String(error);
-    if (/\btool\s+(?:\S+\s+)?not\s+found\b/i.test(msg) || /\bunknown\s+tool\b/i.test(msg)) {
-        return 'dispatch_error';
-    }
-    return 'tool_failure';
-}
-/**
- * Build a RawObservation for a tool failure context.
- *
- * This replaces classifyToolFailureSource and the inline classification
- * in after-tool-call-helpers. All tool error → dispatch/tool_failure
- * classification is centralized here.
- */
-export function buildToolFailureObservation(options) {
-    const { toolName, error, provenance } = options;
-    const nonZeroExit = typeof options.exitCode === 'number' && options.exitCode !== 0;
-    // Classify dispatch vs tool_failure centrally
-    let failureSource;
-    if (!toolName || toolName.trim() === '') {
-        // Empty/whitespace tool name → dispatch error
-        failureSource = 'dispatch_error';
-    }
-    else {
-        failureSource = classifyErrorForDispatch(error);
-    }
-    // If neither error nor non-zero exit, this is not a failure context
-    if (!error && !nonZeroExit) {
-        failureSource = undefined;
-    }
-    return {
-        observedAt: new Date().toISOString(),
-        toolName,
-        failureSource,
-        nonZeroExit,
-        provenance,
-    };
-}
-/**
- * Build a RawObservation for an LLM detection context.
+ * - ERR-011: re-export adapter, not a local re-definition of migrated logic.
  */
-export function buildLlmDetectionObservation(options) {
-    return {
-        observedAt: new Date().toISOString(),
-        detectionSource: options.detectionSource,
-        isGfiTriggered: options.isGfiTriggered,
-    };
-}
+export { resolveSourceKind, buildToolFailureObservation, buildLlmDetectionObservation, buildEmpathyObservation, buildManualPainObservation, } from '@principles/core/runtime-v2';

package/plugin/dist/hooks/raw-observation-types.d.ts

@@ -1,62 +1,11 @@
 /**
- * Raw Observation Types — PRI-362
+ * Raw Observation Types — PRI-362 / PRI-446
  *
- * Source adapter layer that normalizes diverse hook contexts into a unified
- * observation model before mapping to SourceKind.
- *
- * This replaces scattered resolveSourceKindFrom* functions with a single
- * field-driven adapter.
+ * The RawObservation type has been migrated to principles-core
+ * (runtime-v2/evidence-triage/observation-resolver.ts). This file re-exports it
+ * so existing plugin import sites keep working unchanged.
  *
  * ERR checklist:
- * - ERR-001: No `as` casts; validate unknown payload field-by-field.
- * - ERR-002: Every decision carries reason + nextAction.
- * - EP-01: Source adapter validates before use.
- */
-/**
- * Raw observation from a source adapter.
- *
- * This is the input to resolveSourceKind. It contains all possible
- * context fields that different sources may provide. The adapter
- * reads only the fields it needs based on the observation source.
+ * - ERR-011: this is a re-export adapter, not a local re-definition.
  */
-export interface RawObservation {
-    /** When the observation was made (ISO timestamp) */
-    readonly observedAt: string;
-    /** Workspace identifier */
-    readonly workspaceId?: string;
-    /** Session identifier */
-    readonly sessionId?: string;
-    /** Trace identifier for correlation */
-    readonly traceId?: string;
-    /** Tool name (for after_tool_call hook) */
-    readonly toolName?: string;
-    /** Failure source classification */
-    readonly failureSource?: 'tool_failure' | 'dispatch_error';
-    /** Whether the tool call exited with non-zero code */
-    readonly nonZeroExit?: boolean;
-    /** Whether the tool call timed out */
-    readonly timedOut?: boolean;
-    /** Whether the tool does not exist */
-    readonly toolNotFound?: boolean;
-    /** Detection source identifier */
-    readonly detectionSource?: string;
-    /** Whether GFI threshold was crossed */
-    readonly isGfiTriggered?: boolean;
-    /** Whether the failure was a rate limit (429) */
-    readonly isRateLimit?: boolean;
-    /** Whether this observation came from a gate block */
-    readonly isGateBlock?: boolean;
-    /** Whether this was a manual CLI entry */
-    readonly isManualEntry?: boolean;
-    /** Provenance: how trustworthy and context-bound is the observation */
-    readonly provenance?: 'openclaw_context_bound' | 'owner_reported_no_host_trace' | 'automatic_hook';
-    /** Whether this observation came from a subagent error */
-    readonly isSubagentError?: boolean;
-    /**
-     * Raw payload from the source.
-     *
-     * This is always `unknown` (ERR-005). Source adapters validate only
-     * enough to identify the source and capture bounded context.
-     */
-    readonly payload?: unknown;
-}
+export type { RawObservation } from '@principles/core/runtime-v2';

package/plugin/dist/hooks/raw-observation-types.js

@@ -1,15 +1,11 @@
 /**
- * Raw Observation Types — PRI-362
+ * Raw Observation Types — PRI-362 / PRI-446
  *
- * Source adapter layer that normalizes diverse hook contexts into a unified
- * observation model before mapping to SourceKind.
- *
- * This replaces scattered resolveSourceKindFrom* functions with a single
- * field-driven adapter.
+ * The RawObservation type has been migrated to principles-core
+ * (runtime-v2/evidence-triage/observation-resolver.ts). This file re-exports it
+ * so existing plugin import sites keep working unchanged.
  *
  * ERR checklist:
- * - ERR-001: No `as` casts; validate unknown payload field-by-field.
- * - ERR-002: Every decision carries reason + nextAction.
- * - EP-01: Source adapter validates before use.
+ * - ERR-011: this is a re-export adapter, not a local re-definition.
  */
 export {};

package/plugin/dist/hooks/trajectory-collector.d.ts

@@ -1,9 +1,23 @@
 /**
  * Trajectory Collector - message write trajectory recording
  *
- * Records message data to memory/trajectories/ JSONL files.
- * PRI-347 removed tool_call and llm_output JSONL writers (no consumers).
- * PRI-346 will repurpose handleBeforeMessageWrite for SQLite collection.
+ * Fallback trajectory collection when llm_output is blocked by missing
+ * allowConversationAccess. before_message_write is NOT in
+ * CONVERSATION_HOOK_NAMES so OpenClaw always delivers it.
+ *
+ * SQLite writes are enqueued to an async queue because before_message_write is
+ * a SYNCHRONOUS OpenClaw hook — the handler must return immediately. better-sqlite3
+ * is synchronous, so calling it directly would block the message-write main path.
+ * Trade-off: in degradation mode the last few queued writes may be lost on
+ * process exit; this is acceptable because degradation mode is already caused
+ * by a config problem (missing allowConversationAccess), and the primary
+ * llm_output path is authoritative when authorized.
+ *
+ * JSONL writing was removed (no consumers — verified zero readers across the
+ * codebase; PRI-347 already removed tool_call/llm_output JSONL writers).
+ *
+ * ERR-002: fallback errors are logged, never silent.
+ * ERR-001/005: content is sanitized before persisting.
  */
 import type { PluginHookAgentContext, PluginHookBeforeMessageWriteEvent } from '../openclaw-sdk.js';
 /**
@@ -14,7 +28,9 @@ import type { PluginHookAgentContext, PluginHookBeforeMessageWriteEvent } from '
  * CONVERSATION_HOOK_NAMES, so it always fires — making it the natural fallback.
  *
  * De-duplication: only writes to SQLite when llm_output is blocked (unauthorized).
- * When llm_output is working (authorized), this hook degrades to JSONL-only.
+ * When llm_output is working (authorized), this hook is a no-op.
+ *
+ * SQLite writes are async-queued (see file header) to avoid blocking the sync hook.
  *
  * ERR-002: structured observability when fallback fires.
  * ERR-001/005: content is sanitized before persisting.