create-principles-disciple 1.85.0 → 1.87.0

package/core/dist/runtime-v2/__tests__/architecture-regression.test.js

@@ -4,7 +4,7 @@
  *
  * Add entries here whenever a new service/read-model boundary is established.
  */
-import { describe, it, expect } from 'vitest';
+import { describe, it, expect, beforeAll } from 'vitest';
 // ── Source-file existence ──────────────────────────────────────────────────
 const REQUIRED_SOURCE_FILES = [
     'pain-to-principle-service.ts',
@@ -93,6 +93,11 @@ const REQUIRED_SOURCE_FILES = [
     'internalization/refiner-sandbox-wrapper.ts',
     // PRI-173
     'internalization/refiner-rulehost-gate.ts',
+    // RuleHost MVP Activation (PRI-421..428, ADR-0014 Amendment 2026-06-17)
+    'internalization/adversarial-case.ts',
+    'internalization/adversarial-feedback.ts',
+    'internalization/artificer-prompt-builder.ts',
+    'adversarial-loop.ts',
     // Phase 2 migration: evolution types
     'evolution/evolution-types.ts',
     'evolution/index.ts',
@@ -150,6 +155,9 @@ const REQUIRED_SOURCE_FILES = [
     // PRI-239
     'feature-flags/feature-flag-contract.ts',
     'feature-flags/index.ts',
+    // PRI-367
+    'core-principles/core-principle-registry.ts',
+    'core-principles/index.ts',
     // PRI-285: MVP seed feedback channel — privacy-preserving report contract.
     // Pure logic only; no I/O. Server I/O lives in pd-console under
     // <workspace>/.pd/feedback/drafts/. No automatic upload.
@@ -159,9 +167,32 @@ const REQUIRED_SOURCE_FILES = [
     'feedback/render-markdown.ts',
     'feedback/render-github-url.ts',
     'feedback/privacy-preview.ts',
-    'feedback/create-report.ts',
     'feedback/safe-stringify.ts',
+    'feedback/create-report.ts',
     'feedback/index.ts',
+    // PRI-372 (T-G)
+    'diagnostician/diag-rootcause-output.ts',
+    'diagnostician/diag-distiller-output.ts',
+    'diagnostician/rootcause-prompt-builder.ts',
+    'diagnostician/distiller-prompt-builder.ts',
+    'diagnostician/router-prompt-builder.ts',
+    'internalization/diag-rootcause-runner.ts',
+    'internalization/diag-distiller-runner.ts',
+    'internalization/diag-router-runner.ts',
+    // PRI-419: L2 agent loop adapter (core, pure orchestration of pi-agent-core; no node:* imports)
+    'adapter/l2-agent-loop-adapter.ts',
+    // PRI-419: L2 agent loop tool contract + typebox output redeclaration (pure logic, no I/O)
+    'tools/agent-tool-contract.ts',
+    'tools/dreamer-output-typebox.ts',
+    // PRI-439: Artificer L2 agent loop tool contract + typebox output redeclaration (pure logic, no I/O)
+    'tools/artificer-l2-tool-contract.ts',
+    'tools/artificer-output-typebox.ts',
+    // PRI-408: Production gate deps factory — canonical vm-based rule compilation
+    'activation/production-gate-deps.ts',
+    // PRI-408: Formal approval-completion production service
+    'activation/approval-completion-service.ts',
+    // PRI-431: L2 principle reader (pure logic, extracted from pd-cli + plugin duplicates)
+    'build-l2-principle-reader.ts',
 ];
 // ── PRI-212: Plugin core anti-growth guard ────────────────────────────────────
 //
@@ -201,6 +232,7 @@ const KNOWN_PLUGIN_CORE_FILES = new Set([
     'principle-internalization/lifecycle-read-model.ts',
     'principle-internalization/filesystem-lifecycle-datasource.ts',
     'config-service.ts',
+    'config-health.ts', // PRI-346: Pure conversation access config check — plugin-specific due to OpenClaw config shape dependency
     'principle-compiler/index.ts',
     'principle-internalization/lifecycle-refresh.ts',
     // ── Do Not Move — intrinsically plugin-specific ─────────────────────────
@@ -279,6 +311,8 @@ const KNOWN_PLUGIN_CORE_FILES = new Set([
     'surface-guard.ts',
     // PRI-307: Plugin I/O boundary — reads .pd/config.yaml, delegates validation to core
     'pd-config-loader.ts',
+    // PRI-346: Pure function for checking conversation access config (extracted for circular import avoidance)
+    'config-health.ts',
     // ── Test Files ──────────────────────────────────────────────────────────
     '__tests__/focus-history.test.ts',
     'principle-compiler/__tests__/compiler-replay-gate.test.ts',
@@ -320,13 +354,14 @@ describe('PRI-212 plugin core anti-growth guard', () => {
             expect.fail(msg);
         }
     });
-    it('known baseline count is self-consistent (94 files)', async () => {
+    it('known baseline count is self-consistent (98 files)', async () => {
         // Sanity check: if the baseline grows, update this number.
         // Prevents accidental baseline bloat from going unnoticed.
         // See docs/reviews/plugin-core-inventory-2026-05.md §7
         // PRI-286: Removed confirm-first-gate.ts (95 → 94)
         // PRI-307: Added pd-config-loader.ts (96 → 97)
-        expect(KNOWN_PLUGIN_CORE_FILES.size).toBe(97);
+        // PRI-346: Added config-health.ts (97 → 98)
+        expect(KNOWN_PLUGIN_CORE_FILES.size).toBe(98);
     });
 });
 const REQUIRED_TEST_FILES = [
@@ -394,6 +429,18 @@ const REQUIRED_TEST_FILES = [
     '../feature-flags/__tests__/feature-flag-contract.test.ts',
     // PRI-295
     '../activation/__tests__/prompt-activation-reader-contract.test.ts',
+    // PRI-372 (T-G)
+    '../diagnostician/__tests__/diag-rootcause-output.test.ts',
+    '../diagnostician/__tests__/diag-distiller-output.test.ts',
+    '../diagnostician/__tests__/rootcause-prompt-builder.test.ts',
+    '../diagnostician/__tests__/distiller-prompt-builder.test.ts',
+    '../diagnostician/__tests__/router-prompt-builder.test.ts',
+    '../internalization/__tests__/diag-rootcause-runner.test.ts',
+    '../internalization/__tests__/diag-distiller-runner.test.ts',
+    '../internalization/__tests__/diag-router-runner.test.ts',
+    '../internalization/__tests__/diag-chain-e2e.test.ts',
+    // PRI-431
+    'build-l2-principle-reader.test.ts',
 ];
 const REQUIRED_DOC_FILES = [];
 for (const file of REQUIRED_SOURCE_FILES) {
@@ -442,6 +489,7 @@ describe('runtime-v2 public API (index.ts barrel)', () => {
         // PRI-44
         'generateFromTemplate',
         'checkForbiddenPatterns',
+        'checkReturnStatementsMissingFields',
         // PRI-45
         'mergeDecisions',
         // PRI-149 Tier 2
@@ -454,6 +502,10 @@ describe('runtime-v2 public API (index.ts barrel)', () => {
         'resolvePrincipleFromArtifact',
         'trimToBudget',
         'renderPrinciplesToDirectives',
+        // PRI-431
+        'buildL2PrincipleReaderFromLedger',
+        // LLM output hardening — shared utility
+        'stripFabricatedCorePrincipleIds',
     ];
     for (const name of REQUIRED_EXPORTS) {
         it(`exports ${name}`, async () => {
@@ -578,6 +630,19 @@ describe('PRI-42 internalization boundary', () => {
         expect(src).toContain('@principles/core/runtime-v2');
         expect(src).not.toContain("from './rule-host-types.js'");
     });
+    it('PRI-436: plugin rule-host.ts does NOT import filesystem ledger or implementation storage', async () => {
+        const { existsSync, readFileSync } = await import('node:fs');
+        const { resolve } = await import('node:path');
+        const ruleHostPath = resolve(__dirname, '../../../../openclaw-plugin/src/core/rule-host.ts');
+        expect(existsSync(ruleHostPath)).toBe(true);
+        const src = readFileSync(ruleHostPath, 'utf-8');
+        // PRI-436: SQLite is the sole RuleHost source. No filesystem imports allowed.
+        expect(src).not.toContain("from './principle-tree-ledger.js'");
+        expect(src).not.toContain("from './code-implementation-storage.js'");
+        expect(src).not.toContain('listImplementationsByLifecycleState');
+        expect(src).not.toContain('loadEntrySource');
+        expect(src).not.toContain("import * as fs from 'fs'");
+    });
     it('plugin gate.ts imports RuleHostInput from core barrel', async () => {
         const { existsSync, readFileSync } = await import('node:fs');
         const { resolve } = await import('node:path');
@@ -1303,72 +1368,6 @@ describe('PRI-62 Internalization State Machine Guards', () => {
         expect(result === null || typeof result === 'object').toBe(true);
     });
 });
-// ── PRI-63: Internalization Dumb Trigger Adapter ─────────────────────────────
-describe('PRI-63 Internalization Dumb Trigger Adapter', () => {
-    const PRI63_REQUIRED_FILES = [
-        'internalization-trigger-adapter.ts',
-    ];
-    it('adapter source file exists in plugin service directory', async () => {
-        const { existsSync } = await import('node:fs');
-        const { resolve } = await import('node:path');
-        const pluginRoot = resolve(__dirname, '..', '..', '..', '..', 'openclaw-plugin', 'src', 'service');
-        for (const file of PRI63_REQUIRED_FILES) {
-            expect(existsSync(resolve(pluginRoot, file))).toBe(true);
-        }
-    });
-    it('adapter does not import nocturnal-trinity', async () => {
-        const { readFileSync } = await import('node:fs');
-        const { resolve } = await import('node:path');
-        const src = readFileSync(resolve(__dirname, '..', '..', '..', '..', 'openclaw-plugin', 'src', 'service', 'internalization-trigger-adapter.ts'), 'utf-8');
-        expect(src).not.toContain('nocturnal-trinity');
-    });
-    it('adapter does not import runTrinity or runTrinityAsync', async () => {
-        const { readFileSync } = await import('node:fs');
-        const { resolve } = await import('node:path');
-        const src = readFileSync(resolve(__dirname, '..', '..', '..', '..', 'openclaw-plugin', 'src', 'service', 'internalization-trigger-adapter.ts'), 'utf-8');
-        expect(src).not.toContain('runTrinity');
-        expect(src).not.toContain('runTrinityAsync');
-    });
-    it('adapter does not import Dreamer/Philosopher/Scribe executors', async () => {
-        const { readFileSync } = await import('node:fs');
-        const { resolve } = await import('node:path');
-        const src = readFileSync(resolve(__dirname, '..', '..', '..', '..', 'openclaw-plugin', 'src', 'service', 'internalization-trigger-adapter.ts'), 'utf-8');
-        expect(src).not.toContain("from 'dreamer'");
-        expect(src).not.toContain("from 'philosopher'");
-        expect(src).not.toContain("from 'scribe'");
-    });
-    it('adapter does not use PDRuntimeAdapter', async () => {
-        const { readFileSync } = await import('node:fs');
-        const { resolve } = await import('node:path');
-        const src = readFileSync(resolve(__dirname, '..', '..', '..', '..', 'openclaw-plugin', 'src', 'service', 'internalization-trigger-adapter.ts'), 'utf-8');
-        expect(src).not.toContain('PDRuntimeAdapter');
-    });
-    it('adapter imports TaskRecord from @principles/core/runtime-v2', async () => {
-        const { readFileSync } = await import('node:fs');
-        const { resolve } = await import('node:path');
-        const src = readFileSync(resolve(__dirname, '..', '..', '..', '..', 'openclaw-plugin', 'src', 'service', 'internalization-trigger-adapter.ts'), 'utf-8');
-        expect(src).toContain('TaskRecord');
-        expect(src).toContain('@principles/core/runtime-v2');
-    });
-    it('PLUGIN_NO_INLINE_EXECUTION: adapter does not call mutating store methods (read-only probe)', async () => {
-        const { readFileSync } = await import('node:fs');
-        const { resolve } = await import('node:path');
-        const src = readFileSync(resolve(__dirname, '..', '..', '..', '..', 'openclaw-plugin', 'src', 'service', 'internalization-trigger-adapter.ts'), 'utf-8');
-        // wake() should only read, not update/create/delete tasks
-        expect(src).not.toContain('updateTask');
-        expect(src).not.toContain('createTask');
-        expect(src).not.toContain('deleteTask');
-        expect(src).not.toContain('leaseTask');
-    });
-    it('PLUGIN_NO_INLINE_EXECUTION: adapter does not use setInterval/setTimeout for scheduling (core responsibility)', async () => {
-        const { readFileSync } = await import('node:fs');
-        const { resolve } = await import('node:path');
-        const src = readFileSync(resolve(__dirname, '..', '..', '..', '..', 'openclaw-plugin', 'src', 'service', 'internalization-trigger-adapter.ts'), 'utf-8');
-        // setInterval is used in start() to trigger wake() periodically — this is plugin responsibility
-        // Core state machine should NOT use setInterval (CORE_NO_SCHEDULING)
-        expect(src).not.toContain('node:cron');
-    });
-});
 describe('PRI-68 InternalizationOrchestrator', () => {
     it('orchestrator source file exists in internalization directory', async () => {
         const { existsSync } = await import('node:fs');
@@ -1775,20 +1774,21 @@ describe('PRI-111 ArtificerRunner boundary', () => {
         expect(src).not.toContain('node:fs');
         expect(src).not.toContain('node:cron');
     });
-    it('BARREL_EXPORTS: internalization/index.ts exports ArtificerRunner and ArtificerOutput', async () => {
+    it('BARREL_EXPORTS: internalization/index.ts exports ArtificerRunner and ArtificerRuleOutput', async () => {
         const { readFileSync } = await import('node:fs');
         const { resolve } = await import('node:path');
         const src = readFileSync(resolve(__dirname, '..', 'internalization', 'index.ts'), 'utf-8');
         expect(src).toContain('ArtificerRunner');
-        expect(src).toContain('ArtificerOutput');
+        expect(src).toContain('ArtificerRuleOutput');
         expect(src).toContain('DefaultArtificerValidator');
     });
-    it('SCHEMA_REGISTRY: pi-ai-runtime-adapter.ts registers artificer-output-v1 schema', async () => {
+    it('SCHEMA_REGISTRY: pi-ai-runtime-adapter.ts registers unified artificer-rule-output-v2 schema', async () => {
         const { readFileSync } = await import('node:fs');
         const { resolve } = await import('node:path');
         const src = readFileSync(resolve(__dirname, '..', 'adapter', 'pi-ai-runtime-adapter.ts'), 'utf-8');
-        expect(src).toContain('artificer-output-v1');
-        expect(src).toContain('ArtificerOutputV1Schema');
+        expect(src).toContain('artificer-rule-output-v2');
+        expect(src).not.toContain('artificer-rule-output-v1');
+        expect(src).toContain('ArtificerRuleOutputSchema');
     });
 });
 // ── PRI-EVAL: EvaluatorRunner boundary guards ──────────────────────────────────
@@ -2415,12 +2415,6 @@ describe('Phase 2.4 types directory migration', () => {
         const src = readFileSync(resolve(__dirname, '../../../../openclaw-plugin/src/types/event-types.ts'), 'utf-8');
         expect(src).toContain("@principles/core/runtime-v2");
     });
-    it('plugin types/event-payload.ts re-exports from core', async () => {
-        const { readFileSync } = await import('node:fs');
-        const { resolve } = await import('node:path');
-        const src = readFileSync(resolve(__dirname, '../../../../openclaw-plugin/src/types/event-payload.ts'), 'utf-8');
-        expect(src).toContain("@principles/core/runtime-v2");
-    });
 });
 // ── Phase 2 Migration: Principle-Tree Data Structures ─────────────────────────
 describe('Phase 2.6 principle-tree data structures migration', () => {
@@ -2548,12 +2542,13 @@ describe('PRI-139 L1 Hard Cap & LRU Eviction', () => {
 });
 // ── PRI-142: IntakeToInternalizationBridge ──────────────────────────────────────
 describe('PRI-142 IntakeToInternalizationBridge', () => {
-    it('core barrel exports computeBridgeDecision, buildDreamerTaskSeed, seedIntakeTask, ROUTE_CHANNEL_MAP', async () => {
+    it('core barrel exports computeBridgeDecision, buildDreamerTaskSeed, buildDreamerSeedFromCandidate, seedIntakeTask, ROUTE_CHANNEL_MAP', async () => {
         const { readFileSync } = await import('node:fs');
         const { resolve } = await import('node:path');
         const src = readFileSync(resolve(__dirname, '..', 'index.ts'), 'utf-8');
         expect(src).toContain('computeBridgeDecision');
         expect(src).toContain('buildDreamerTaskSeed');
+        expect(src).toContain('buildDreamerSeedFromCandidate');
         expect(src).toContain('seedIntakeTask');
         expect(src).toContain('ROUTE_CHANNEL_MAP');
     });
@@ -2581,6 +2576,7 @@ describe('PRI-142 IntakeToInternalizationBridge', () => {
         const src = readFileSync(resolve(__dirname, '..', 'internalization', 'index.ts'), 'utf-8');
         expect(src).toContain('computeBridgeDecision');
         expect(src).toContain('buildDreamerTaskSeed');
+        expect(src).toContain('buildDreamerSeedFromCandidate');
         expect(src).toContain('seedIntakeTask');
         expect(src).toContain('ROUTE_CHANNEL_MAP');
         expect(src).toContain('IntakeToInternalizationBridgeInput');
@@ -2852,7 +2848,11 @@ const FORBIDDEN_RUNTIME_ORCHESTRATION_CLASSES = new Set([
     'SqliteHistoryQuery',
     'SqliteDiagnosticianCommitter',
     'PainSignalBridge',
-    'DiagnosticianRunner',
+    'SplitDiagnosticianRunner',
+    'DisabledDiagnosticianRunner',
+    'DiagRootCauseRunner',
+    'DiagDistillerRunner',
+    'DiagRouterRunner',
     'TestDoubleRuntimeAdapter',
     'OperatorHealthReadModel',
     'createInternalizationQueueReadModel',
@@ -3064,4 +3064,96 @@ describe('PRI-304: PD-Owned Config Contract barrel exports and purity', () => {
         }
     });
 });
+describe('PRI-372: split diagnostician runners extend BasePeerRunner', () => {
+    it('DiagRootCauseRunner extends BasePeerRunner', async () => {
+        const { DiagRootCauseRunner } = await import('../internalization/diag-rootcause-runner.js');
+        const { BasePeerRunner } = await import('../runner/base-peer-runner.js');
+        expect(DiagRootCauseRunner.prototype).toBeInstanceOf(BasePeerRunner);
+    });
+    it('DiagDistillerRunner extends BasePeerRunner', async () => {
+        const { DiagDistillerRunner } = await import('../internalization/diag-distiller-runner.js');
+        const { BasePeerRunner } = await import('../runner/base-peer-runner.js');
+        expect(DiagDistillerRunner.prototype).toBeInstanceOf(BasePeerRunner);
+    });
+    it('DiagRouterRunner extends BasePeerRunner', async () => {
+        const { DiagRouterRunner } = await import('../internalization/diag-router-runner.js');
+        const { BasePeerRunner } = await import('../runner/base-peer-runner.js');
+        expect(DiagRouterRunner.prototype).toBeInstanceOf(BasePeerRunner);
+    });
+});
+// ── PRI-416: Type Single-Ownership Guards ──────────────────────────────────────
+//
+// These guards ensure that critical types/functions are defined exactly once
+// within principles-core/src/. This prevents the "duplicate type definition"
+// debt that led to PRI-413/PRI-415 (e.g., HybridLedgerStore in both
+// principle-tree-ledger.ts and types.ts).
+describe('PRI-416: type single-ownership guards', () => {
+    let fs; // eslint-disable-line @typescript-eslint/consistent-type-imports
+    let pathModule; // eslint-disable-line @typescript-eslint/consistent-type-imports
+    let coreSrcDir;
+    beforeAll(async () => {
+        fs = await import('fs');
+        pathModule = await import('path');
+        coreSrcDir = pathModule.resolve(__dirname, '..', '..');
+    });
+    function findDefinitions(pattern) {
+        const hits = [];
+        function scan(dir) {
+            for (const entry of fs.readdirSync(dir)) {
+                const full = pathModule.join(dir, entry);
+                const stat = fs.statSync(full);
+                if (stat.isDirectory()) {
+                    if (entry === 'node_modules' || entry === '__tests__')
+                        continue;
+                    scan(full);
+                }
+                else if (entry.endsWith('.ts') && !entry.endsWith('.test.ts') && !entry.endsWith('.d.ts')) {
+                    const content = fs.readFileSync(full, 'utf-8');
+                    if (pattern.test(content)) {
+                        hits.push(full.replace(coreSrcDir + pathModule.sep, '').replace(coreSrcDir + '/', '').replace(/\\/g, '/'));
+                    }
+                }
+            }
+        }
+        scan(coreSrcDir);
+        return hits;
+    }
+    it('InjectablePrinciple is defined exactly once in core/src/', () => {
+        const hits = findDefinitions(/export\s+interface\s+InjectablePrinciple\s*\{/);
+        expect(hits).toEqual(['prompt-builder/principle-selection.ts']);
+    });
+    it('HybridLedgerStore is defined exactly once in core/src/', () => {
+        const hits = findDefinitions(/export\s+interface\s+HybridLedgerStore\s*\{/);
+        expect(hits).toEqual(['principle-tree-ledger.ts']);
+    });
+    it('atomicWriteFileSync is defined exactly once in core/src/', () => {
+        const hits = findDefinitions(/export\s+function\s+atomicWriteFileSync\s*\(/);
+        expect(hits).toEqual(['io.ts']);
+    });
+});
+// ── PRI-416: Barrel Cap Guards ────────────────────────────────────────────────
+//
+// The barrel export file (index.ts) must stay lean to avoid bloat.
+// After PRI-415 cleanup, it has ~263 total lines and ~40 export lines.
+// Set upper limits to prevent future regression.
+describe('PRI-416: barrel cap guards', () => {
+    const BARREL_MAX_TOTAL_LINES = 300;
+    const BARREL_MAX_EXPORT_LINES = 50;
+    it('index.ts total lines <= ' + BARREL_MAX_TOTAL_LINES, async () => {
+        const fsMod = await import('fs'); // eslint-disable-line @typescript-eslint/consistent-type-imports
+        const pathMod = await import('path'); // eslint-disable-line @typescript-eslint/consistent-type-imports
+        const barrelPath = pathMod.resolve(__dirname, '..', '..', 'index.ts');
+        const content = fsMod.readFileSync(barrelPath, 'utf-8');
+        const lineCount = content.split('\n').length;
+        expect(lineCount).toBeLessThanOrEqual(BARREL_MAX_TOTAL_LINES);
+    });
+    it('index.ts export lines <= ' + BARREL_MAX_EXPORT_LINES, async () => {
+        const fsMod = await import('fs'); // eslint-disable-line @typescript-eslint/consistent-type-imports
+        const pathMod = await import('path'); // eslint-disable-line @typescript-eslint/consistent-type-imports
+        const barrelPath = pathMod.resolve(__dirname, '..', '..', 'index.ts');
+        const content = fsMod.readFileSync(barrelPath, 'utf-8');
+        const exportLines = content.split('\n').filter((l) => /^\s*export\s/.test(l));
+        expect(exportLines.length).toBeLessThanOrEqual(BARREL_MAX_EXPORT_LINES);
+    });
+});
 //# sourceMappingURL=architecture-regression.test.js.map