create-principles-disciple 1.79.0 → 1.81.0

package/pd-cli/dist/services/pd-config-loader.js

@@ -0,0 +1,156 @@
+/**
+ * PD Config Loader — PRI-305
+ *
+ * I/O boundary: reads `.pd/config.yaml`, validates via core, computes effective config.
+ * This replaces the old `feature-flag-loader.ts` and `workflows.yaml` reading
+ * for CLI production paths.
+ *
+ * ADR-0016: PD owns exactly one user config file.
+ * - Missing config → defaults with nextAction
+ * - Malformed config → fail loud with errors and nextAction
+ * - No secrets in output
+ */
+import * as fs from 'fs';
+import * as path from 'path';
+import yaml from 'js-yaml';
+import { validatePdConfig, computeEffectivePdConfig, computeFeatureFlagsFromConfig, redactPdConfig, } from '@principles/core/runtime-v2';
+// ── Constants ────────────────────────────────────────────────────────────────
+export const PD_CONFIG_DIR = '.pd';
+export const PD_CONFIG_FILENAME = 'config.yaml';
+// ── Config Path ──────────────────────────────────────────────────────────────
+export function getPdConfigPath(workspaceDir) {
+    return path.join(workspaceDir, PD_CONFIG_DIR, PD_CONFIG_FILENAME);
+}
+// ── Legacy File Detection ────────────────────────────────────────────────────
+function detectLegacyFiles(workspaceDir) {
+    const detected = [];
+    const legacyPaths = [
+        path.join(workspaceDir, PD_CONFIG_DIR, 'feature-flags.yaml'),
+        path.join(workspaceDir, '.state', 'workflows.yaml'),
+    ];
+    for (const p of legacyPaths) {
+        if (fs.existsSync(p)) {
+            detected.push(p);
+        }
+    }
+    return detected;
+}
+// ── Load PD Config ───────────────────────────────────────────────────────────
+/**
+ * Load and validate `.pd/config.yaml` from the workspace.
+ *
+ * - Missing file → returns defaults with source='defaults'
+ * - Malformed file → returns error result with defaults fallback
+ * - Valid file → returns effective config with source='user_config'
+ *
+ * Never throws on malformed input. Always provides a usable fallback.
+ */
+export function loadPdConfig(workspaceDir) {
+    const configPath = getPdConfigPath(workspaceDir);
+    const legacyFilesDetected = detectLegacyFiles(workspaceDir);
+    // 1) Config file missing → use defaults
+    if (!fs.existsSync(configPath)) {
+        const effective = computeEffectivePdConfig(null);
+        return {
+            ok: true,
+            effective,
+            source: 'defaults',
+            configPath,
+            warnings: [
+                ...effective.warnings,
+                ...(legacyFilesDetected.length > 0
+                    ? [`Legacy config files detected (${legacyFilesDetected.length}): ${legacyFilesDetected.join(', ')}. PD now uses .pd/config.yaml.`]
+                    : []),
+            ],
+            legacyFilesDetected,
+        };
+    }
+    // 2) Read the file
+    let raw;
+    try {
+        raw = fs.readFileSync(configPath, 'utf8');
+    }
+    catch (err) {
+        const message = err instanceof Error ? err.message : String(err);
+        const effective = computeEffectivePdConfig(null);
+        return {
+            ok: false,
+            source: 'malformed',
+            configPath,
+            errors: [{ path: '', reason: `Failed to read .pd/config.yaml: ${message}`, nextAction: 'Check file permissions for .pd/config.yaml' }],
+            warnings: [],
+            defaults: effective,
+            legacyFilesDetected,
+        };
+    }
+    // 3) Parse YAML — treat as unknown (ERR-001)
+    let parsed;
+    try {
+        parsed = yaml.load(raw, { schema: yaml.JSON_SCHEMA });
+    }
+    catch (err) {
+        const message = err instanceof Error ? err.message : String(err);
+        const effective = computeEffectivePdConfig(null);
+        return {
+            ok: false,
+            source: 'malformed',
+            configPath,
+            errors: [{ path: '', reason: `YAML parse error in .pd/config.yaml: ${message}`, nextAction: 'Fix YAML syntax in .pd/config.yaml' }],
+            warnings: [],
+            defaults: effective,
+            legacyFilesDetected,
+        };
+    }
+    // 4) Validate via core (ERR-001, ERR-005: no `as` bypasses)
+    const validationResult = validatePdConfig(parsed);
+    if (!validationResult.ok) {
+        const effective = computeEffectivePdConfig(null);
+        return {
+            ok: false,
+            source: 'malformed',
+            configPath,
+            errors: validationResult.errors.map(e => ({
+                path: e.path,
+                reason: e.reason,
+                nextAction: e.nextAction,
+            })),
+            warnings: [],
+            defaults: effective,
+            legacyFilesDetected,
+        };
+    }
+    // 5) Compute effective config
+    const effective = computeEffectivePdConfig(validationResult.value);
+    return {
+        ok: true,
+        effective,
+        source: 'user_config',
+        configPath,
+        warnings: [
+            ...effective.warnings,
+            ...(legacyFilesDetected.length > 0
+                ? [`Legacy config files detected (${legacyFilesDetected.length}): ${legacyFilesDetected.join(', ')}. PD now uses .pd/config.yaml.`]
+                : []),
+        ],
+        legacyFilesDetected,
+    };
+}
+// ── Feature Flags from Config ────────────────────────────────────────────────
+/**
+ * Compute feature flags from the loaded PD config.
+ * Works with both ok and error results (uses defaults for errors).
+ */
+export function computeFlagsFromLoadResult(result) {
+    const effective = result.ok ? result.effective : result.defaults;
+    return computeFeatureFlagsFromConfig(effective);
+}
+// ── Redacted Summary from Config ─────────────────────────────────────────────
+/**
+ * Produce a redacted summary of the PD config for CLI/Console display.
+ * Never includes token/API key values or raw provider objects.
+ */
+export function redactLoadResult(result) {
+    const effective = result.ok ? result.effective : result.defaults;
+    return redactPdConfig(effective);
+}
+//# sourceMappingURL=pd-config-loader.js.map

package/pd-cli/dist/services/pd-config-loader.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"pd-config-loader.js","sourceRoot":"","sources":["../../src/services/pd-config-loader.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;;GAWG;AAEH,OAAO,KAAK,EAAE,MAAM,IAAI,CAAC;AACzB,OAAO,KAAK,IAAI,MAAM,MAAM,CAAC;AAC7B,OAAO,IAAI,MAAM,SAAS,CAAC;AAC3B,OAAO,EACL,gBAAgB,EAChB,wBAAwB,EACxB,6BAA6B,EAC7B,cAAc,GACf,MAAM,6BAA6B,CAAC;AAQrC,gFAAgF;AAEhF,MAAM,CAAC,MAAM,aAAa,GAAG,KAAK,CAAC;AACnC,MAAM,CAAC,MAAM,kBAAkB,GAAG,aAAa,CAAC;AA+BhD,gFAAgF;AAEhF,MAAM,UAAU,eAAe,CAAC,YAAoB;IAClD,OAAO,IAAI,CAAC,IAAI,CAAC,YAAY,EAAE,aAAa,EAAE,kBAAkB,CAAC,CAAC;AACpE,CAAC;AAED,gFAAgF;AAEhF,SAAS,iBAAiB,CAAC,YAAoB;IAC7C,MAAM,QAAQ,GAAa,EAAE,CAAC;IAC9B,MAAM,WAAW,GAAG;QAClB,IAAI,CAAC,IAAI,CAAC,YAAY,EAAE,aAAa,EAAE,oBAAoB,CAAC;QAC5D,IAAI,CAAC,IAAI,CAAC,YAAY,EAAE,QAAQ,EAAE,gBAAgB,CAAC;KACpD,CAAC;IACF,KAAK,MAAM,CAAC,IAAI,WAAW,EAAE,CAAC;QAC5B,IAAI,EAAE,CAAC,UAAU,CAAC,CAAC,CAAC,EAAE,CAAC;YACrB,QAAQ,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC;QACnB,CAAC;IACH,CAAC;IACD,OAAO,QAAQ,CAAC;AAClB,CAAC;AAED,gFAAgF;AAEhF;;;;;;;;GAQG;AACH,MAAM,UAAU,YAAY,CAAC,YAAoB;IAC/C,MAAM,UAAU,GAAG,eAAe,CAAC,YAAY,CAAC,CAAC;IACjD,MAAM,mBAAmB,GAAG,iBAAiB,CAAC,YAAY,CAAC,CAAC;IAE5D,wCAAwC;IACxC,IAAI,CAAC,EAAE,CAAC,UAAU,CAAC,UAAU,CAAC,EAAE,CAAC;QAC/B,MAAM,SAAS,GAAG,wBAAwB,CAAC,IAAI,CAAC,CAAC;QACjD,OAAO;YACL,EAAE,EAAE,IAAI;YACR,SAAS;YACT,MAAM,EAAE,UAAU;YAClB,UAAU;YACV,QAAQ,EAAE;gBACR,GAAG,SAAS,CAAC,QAAQ;gBACrB,GAAG,CAAC,mBAAmB,CAAC,MAAM,GAAG,CAAC;oBAChC,CAAC,CAAC,CAAC,iCAAiC,mBAAmB,CAAC,MAAM,MAAM,mBAAmB,CAAC,IAAI,CAAC,IAAI,CAAC,gCAAgC,CAAC;oBACnI,CAAC,CAAC,EAAE,CAAC;aACR;YACD,mBAAmB;SACpB,CAAC;IACJ,CAAC;IAED,mBAAmB;IACnB,IAAI,GAAW,CAAC;IAChB,IAAI,CAAC;QACH,GAAG,GAAG,EAAE,CAAC,YAAY,CAAC,UAAU,EAAE,MAAM,CAAC,CAAC;IAC5C,CAAC;IAAC,OAAO,GAAG,EAAE,CAAC;QACb,MAAM,OAAO,GAAG,GAAG,YAAY,KAAK,CAAC,CAAC,CAAC,GAAG,CAAC,OAAO,CAAC,CAAC,CAAC,MAAM,CAAC,GAAG,CAAC,CAAC;QACjE,MAAM,SAAS,GAAG,wBAAwB,CAAC,IAAI,CAAC,CAAC;QACjD,OAAO;YACL,EAAE,EAAE,KAAK;YACT,MAAM,EAAE,WAAW;YACnB,UAAU;YACV,MAAM,EAAE,CAAC,EAAE,IAAI,EAAE,EAAE,EAAE,MAAM,EAAE,mCAAmC,OAAO,EAAE,EAAE,UAAU,EAAE,4CAA4C,EAAE,CAAC;YACtI,QAAQ,EAAE,EAAE;YACZ,QAAQ,EAAE,SAAS;YACnB,mBAAmB;SACpB,CAAC;IACJ,CAAC;IAED,6CAA6C;IAC7C,IAAI,MAAe,CAAC;IACpB,IAAI,CAAC;QACH,MAAM,GAAG,IAAI,CAAC,IAAI,CAAC,GAAG,EAAE,EAAE,MAAM,EAAE,IAAI,CAAC,WAAW,EAAE,CAAC,CAAC;IACxD,CAAC;IAAC,OAAO,GAAG,EAAE,CAAC;QACb,MAAM,OAAO,GAAG,GAAG,YAAY,KAAK,CAAC,CAAC,CAAC,GAAG,CAAC,OAAO,CAAC,CAAC,CAAC,MAAM,CAAC,GAAG,CAAC,CAAC;QACjE,MAAM,SAAS,GAAG,wBAAwB,CAAC,IAAI,CAAC,CAAC;QACjD,OAAO;YACL,EAAE,EAAE,KAAK;YACT,MAAM,EAAE,WAAW;YACnB,UAAU;YACV,MAAM,EAAE,CAAC,EAAE,IAAI,EAAE,EAAE,EAAE,MAAM,EAAE,wCAAwC,OAAO,EAAE,EAAE,UAAU,EAAE,oCAAoC,EAAE,CAAC;YACnI,QAAQ,EAAE,EAAE;YACZ,QAAQ,EAAE,SAAS;YACnB,mBAAmB;SACpB,CAAC;IACJ,CAAC;IAED,4DAA4D;IAC5D,MAAM,gBAAgB,GAA6B,gBAAgB,CAAC,MAAM,CAAC,CAAC;IAE5E,IAAI,CAAC,gBAAgB,CAAC,EAAE,EAAE,CAAC;QACzB,MAAM,SAAS,GAAG,wBAAwB,CAAC,IAAI,CAAC,CAAC;QACjD,OAAO;YACL,EAAE,EAAE,KAAK;YACT,MAAM,EAAE,WAAW;YACnB,UAAU;YACV,MAAM,EAAE,gBAAgB,CAAC,MAAM,CAAC,GAAG,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC;gBACxC,IAAI,EAAE,CAAC,CAAC,IAAI;gBACZ,MAAM,EAAE,CAAC,CAAC,MAAM;gBAChB,UAAU,EAAE,CAAC,CAAC,UAAU;aACzB,CAAC,CAAC;YACH,QAAQ,EAAE,EAAE;YACZ,QAAQ,EAAE,SAAS;YACnB,mBAAmB;SACpB,CAAC;IACJ,CAAC;IAED,8BAA8B;IAC9B,MAAM,SAAS,GAAG,wBAAwB,CAAC,gBAAgB,CAAC,KAAK,CAAC,CAAC;IAEnE,OAAO;QACL,EAAE,EAAE,IAAI;QACR,SAAS;QACT,MAAM,EAAE,aAAa;QACrB,UAAU;QACV,QAAQ,EAAE;YACR,GAAG,SAAS,CAAC,QAAQ;YACrB,GAAG,CAAC,mBAAmB,CAAC,MAAM,GAAG,CAAC;gBAChC,CAAC,CAAC,CAAC,iCAAiC,mBAAmB,CAAC,MAAM,MAAM,mBAAmB,CAAC,IAAI,CAAC,IAAI,CAAC,gCAAgC,CAAC;gBACnI,CAAC,CAAC,EAAE,CAAC;SACR;QACD,mBAAmB;KACpB,CAAC;AACJ,CAAC;AAED,gFAAgF;AAEhF;;;GAGG;AACH,MAAM,UAAU,0BAA0B,CAAC,MAA0B;IACnE,MAAM,SAAS,GAAG,MAAM,CAAC,EAAE,CAAC,CAAC,CAAC,MAAM,CAAC,SAAS,CAAC,CAAC,CAAC,MAAM,CAAC,QAAQ,CAAC;IACjE,OAAO,6BAA6B,CAAC,SAAS,CAAC,CAAC;AAClD,CAAC;AAED,gFAAgF;AAEhF;;;GAGG;AACH,MAAM,UAAU,gBAAgB,CAAC,MAA0B;IACzD,MAAM,SAAS,GAAG,MAAM,CAAC,EAAE,CAAC,CAAC,CAAC,MAAM,CAAC,SAAS,CAAC,CAAC,CAAC,MAAM,CAAC,QAAQ,CAAC;IACjE,OAAO,cAAc,CAAC,SAAS,CAAC,CAAC;AACnC,CAAC"}

package/pd-cli/package.json

@@ -15,9 +15,11 @@
   "dependencies": {
     "@principles/core": "file:../core",
     "commander": "^12.0.0",
-    "js-yaml": "^4.1.1"
+    "js-yaml": "^4.1.1",
+    "better-sqlite3": "^12.9.0"
   },
   "devDependencies": {
+    "@types/better-sqlite3": "^7.6.13",
     "@types/js-yaml": "^4.0.9",
     "@types/node": "^25.6.2",
     "typescript": "^6.0.3",

package/plugin/dist/core/event-log.d.ts

@@ -43,6 +43,16 @@ export declare class EventLog {
     recordRuleHostAutoCorrectProposed(data: RuleHostAutoCorrectProposedEventData): void;
     recordRuleHostAutoCorrectApplied(data: RuleHostAutoCorrectAppliedEventData): void;
     recordRuntimeV2ActivationsInjected(data: RuntimeV2PromptActivationsInjectedEventData): void;
+    /**
+     * Redact telemetry-sensitive string values in event data before persistence.
+     * Applies redactTelemetryString to known high-risk fields (filePath, command,
+     * reason, args, new_string, old_string, text, paramsSummary values) and to all
+     * string values in tool_call/rulehost_* data as a safety net.
+     *
+     * ERR-002: never throws; returns data unchanged on error.
+     * ERR-045/046: covers composite command strings, Authorization headers, env vars.
+     */
+    private redactEventData;
     private record;
     private formatDate;
     private loadStats;

package/plugin/dist/core/event-log.js

@@ -2,6 +2,7 @@ import * as fs from 'fs';
 import * as path from 'path';
 import { createEmptyDailyStats } from '../types/event-types.js';
 import { atomicWriteFileSync } from '../utils/io.js';
+import { redactTelemetryString } from '@principles/core/runtime-v2';
 const EVENT_LOG_RETENTION_DAYS = 7;
 export class EventLog {
     logsDir;
@@ -142,16 +143,99 @@ export class EventLog {
     recordRuntimeV2ActivationsInjected(data) {
         this.record('runtime_v2_prompt_activations_injected', 'injected', data.sessionId, data);
     }
+    /**
+     * Redact telemetry-sensitive string values in event data before persistence.
+     * Applies redactTelemetryString to known high-risk fields (filePath, command,
+     * reason, args, new_string, old_string, text, paramsSummary values) and to all
+     * string values in tool_call/rulehost_* data as a safety net.
+     *
+     * ERR-002: never throws; returns data unchanged on error.
+     * ERR-045/046: covers composite command strings, Authorization headers, env vars.
+     */
+    redactEventData(type, data) {
+        try {
+            // Known high-risk event types — telemetry that carries tool commands / paths
+            const telemetryTypes = new Set([
+                'tool_call',
+                'rulehost_evaluated',
+                'rulehost_blocked',
+                'rulehost_requireApproval',
+                'rulehost_auto_correct_proposed',
+                'rulehost_auto_correct_applied',
+                'rule_enforced',
+                'hook_execution',
+                'gate_block',
+                'gate_bypass',
+            ]);
+            if (!telemetryTypes.has(type))
+                return data;
+            const redacted = {};
+            for (const [key, value] of Object.entries(data)) {
+                if (typeof value === 'string') {
+                    redacted[key] = redactTelemetryString(value);
+                }
+                else if (Array.isArray(value)) {
+                    // Recurse into arrays (e.g. correctedFields with original/applied)
+                    redacted[key] = value.map((item) => {
+                        if (typeof item === 'string') {
+                            return redactTelemetryString(item);
+                        }
+                        if (typeof item === 'object' && item !== null) {
+                            const nested = {};
+                            for (const [nk, nv] of Object.entries(item)) {
+                                nested[nk] = typeof nv === 'string' ? redactTelemetryString(nv) : nv;
+                            }
+                            return nested;
+                        }
+                        return item;
+                    });
+                }
+                else if (typeof value === 'object' && value !== null) {
+                    // Recurse one level for nested objects (e.g. paramsSummary)
+                    const nested = {};
+                    for (const [nk, nv] of Object.entries(value)) {
+                        if (typeof nv === 'string') {
+                            nested[nk] = redactTelemetryString(nv);
+                        }
+                        else {
+                            nested[nk] = nv;
+                        }
+                    }
+                    redacted[key] = nested;
+                }
+                else {
+                    redacted[key] = value;
+                }
+            }
+            return redacted;
+        }
+        catch (e) {
+            // ERR-002: fail safe — never write raw payload on redaction failure.
+            // Return a masked payload with context so downstream knows what happened.
+            const errStr = e instanceof Error ? e.message.slice(0, 200) : String(e).slice(0, 200);
+            const masked = {
+                redactionFailure: true,
+                redactionStatus: 'failed',
+                'redaction.status': 'failed',
+                redactionReason: errStr || 'unknown error',
+                redactionDataDropped: true,
+                originalType: type,
+                originalSessionId: data.sessionId ?? null,
+            };
+            return masked;
+        }
+    }
     record(type, category, sessionId, data) {
         const now = new Date();
         const date = this.formatDate(now);
+        const redactedData = this.redactEventData(type, data);
         const entry = {
             ts: now.toISOString(),
             date,
             type,
             category,
             sessionId,
-            data: data,
+            data: redactedData,
         };
         this.eventBuffer.push(entry);
         this.updateStats(entry);

package/plugin/dist/core/pd-config-loader.d.ts

@@ -0,0 +1,96 @@
+/**
+ * PD Config Loader (Plugin I/O boundary) — PRI-307
+ *
+ * Reads `.pd/config.yaml`, validates via core, computes effective config.
+ * Replaces the old `.pd/feature-flags.yaml` and `.state/workflows.yaml` reading
+ * for plugin production paths.
+ *
+ * ADR-0016: PD owns exactly one user config file.
+ * - Missing config → defaults with nextAction
+ * - Malformed config → fail loud with errors and nextAction
+ * - No secrets in output
+ * - Observer disabled → no start / no noisy log cycling
+ * - Observer enabled + missing setup → structured needs_setup + nextAction
+ */
+import type { EffectivePdConfig } from '@principles/core/runtime-v2';
+export declare const PD_CONFIG_DIR = ".pd";
+export declare const PD_CONFIG_FILENAME = "config.yaml";
+export type ObserverReadiness = 'disabled' | 'needs_setup' | 'ready' | 'not_ready' | 'config_malformed';
+export interface ObserverConfigResult {
+    /** Whether the observer feature is enabled in config */
+    enabled: boolean;
+    /** Observer readiness state */
+    readiness: ObserverReadiness;
+    /** Config source: 'defaults' | 'user_config' | 'malformed' */
+    source: string;
+    /** Reason for current state */
+    reason: string;
+    /** What the user should do next */
+    nextAction: string;
+    /** The runtime profile ID for this observer, if configured */
+    runtimeProfileId: string | null;
+    /** The runtime profile type, if configured */
+    runtimeProfileType: string | null;
+    /** The apiKeyEnv for the runtime profile, if applicable */
+    apiKeyEnv: string | null;
+    /** Whether the apiKeyEnv is present in process.env */
+    apiKeyPresent: boolean;
+    /** Provider name from runtime profile */
+    provider: string | null;
+    /** Model name from runtime profile */
+    model: string | null;
+    /** Timeout from runtime profile */
+    timeoutMs: number | null;
+    /** Base URL from runtime profile */
+    baseUrl: string | null;
+    /** Config validation errors (only present when readiness=config_malformed) */
+    configErrors?: Array<{
+        path: string;
+        reason: string;
+        nextAction: string;
+    }>;
+}
+export interface PluginConfigLoadResult {
+    ok: boolean;
+    effective: EffectivePdConfig;
+    source: 'defaults' | 'user_config' | 'malformed';
+    configPath: string;
+    warnings: string[];
+    errors: Array<{
+        path: string;
+        reason: string;
+        nextAction: string;
+    }>;
+}
+export declare function getPdConfigPath(workspaceDir: string): string;
+/**
+ * Load and validate `.pd/config.yaml` from the workspace.
+ * Never throws on malformed input. Always provides a usable fallback.
+ */
+export declare function loadPdConfigForPlugin(workspaceDir: string): PluginConfigLoadResult;
+/**
+ * Get a single feature flag's enabled state from .pd/config.yaml.
+ * Replaces the old `loadFeatureFlagFromWorkspace` which read .pd/feature-flags.yaml.
+ */
+export declare function loadFeatureFlagFromConfig(workspaceDir: string, flagId: string, logger?: {
+    warn?: (msg: string) => void;
+    info?: (msg: string) => void;
+}): {
+    enabled: boolean;
+    source: string;
+};
+/**
+ * Resolve observer configuration from .pd/config.yaml.
+ *
+ * Returns structured state:
+ * - config_malformed: config file is invalid — no guessing, fail loud
+ * - disabled: observer feature flag is off OR agent.enabled=false → no start, no noisy logs
+ * - needs_setup: observer enabled but runtime profile missing, API key not set, or unsupported profile type
+ * - ready: observer enabled and fully configured (pi-ai with key present)
+ * - not_ready: observer enabled, API key present, but runtime availability unknown
+ */
+export declare function resolveObserverConfig(workspaceDir: string, observerFlagId: string, observerAgentName: string, _logger?: {
+    warn?: (msg: string) => void;
+    info?: (msg: string) => void;
+    debug?: (msg: string) => void;
+}): ObserverConfigResult;