create-principles-disciple 1.126.1 → 1.127.0

package/console/dist/server/config/pd-config-store.d.ts

@@ -43,6 +43,12 @@ export interface AgentBindingUpdateResultOk {
     agent: InternalAgentName;
     runtimeProfile: string;
     enabled: boolean;
+    /**
+     * PRI-638 (reviewer P1): set when the write retired a conflicting legacy
+     * `diagnostician_split_pipeline=false` override so the canonical toggle is
+     * authoritative after reload.
+     */
+    warning?: string;
 }
 export interface AgentBindingUpdateResultErr {
     ok: false;

package/console/dist/server/config/pd-config-store.js

@@ -298,19 +298,30 @@ export function updateAgentBinding(workspaceDir, agentName, payload) {
     else {
         rawConfig = {};
     }
+    // PRI-638 (reviewer P1 #2): rebuild only what the Owner explicitly changed.
+    // Untouched agents keep their RAW binding from the config file verbatim.
+    // Defaults / inheritance resolution / compatibility transforms (e.g. the
+    // legacy split=false shim folding effective diagnostician to false) belong
+    // to the resolver — materializing them back into config would turn the
+    // documented read-time cutover into an implicit persistent migration.
+    const rawInternalAgents = isRecord(rawConfig.internalAgents) ? rawConfig.internalAgents : {};
+    const rawAgents = isRecord(rawInternalAgents.agents) ? rawInternalAgents.agents : {};
     // Update only the agent binding section
     const agentsMap = {};
     for (const name of INTERNAL_AGENT_NAMES) {
-        const existing = effective.config.internalAgents.agents[name];
         if (name === agentName) {
             agentsMap[name] = { enabled, runtimeProfile };
+            continue;
         }
-        else if (existing) {
+        const rawEntry = rawAgents[name];
+        if (isRecord(rawEntry) && typeof rawEntry.enabled === 'boolean') {
             agentsMap[name] = {
-                enabled: existing.enabled,
-                ...(existing.runtimeProfile ? { runtimeProfile: existing.runtimeProfile } : {}),
+                enabled: rawEntry.enabled,
+                ...(typeof rawEntry.runtimeProfile === 'string' ? { runtimeProfile: rawEntry.runtimeProfile } : {}),
             };
         }
+        // Agent absent from raw config → keep it absent (defaults belong to the
+        // resolver, never snapshot into config).
     }
     // Merge: start from raw config, overlay known sections, update internalAgents.agents.
     // PRI-637: preserve the file's own `features:` section instead of re-writing
@@ -328,6 +339,22 @@ export function updateAgentBinding(workspaceDir, agentName, payload) {
         },
         ui: { ...effective.config.ui },
     };
+    // PRI-638 (reviewer P1 #1): an explicit Owner write to the canonical
+    // Diagnostician binding supersedes the legacy compatibility override. While
+    // `diagnostician_split_pipeline=false` remains in the raw features section,
+    // the read-time shim folds the effective binding back to disabled — a
+    // Console ON toggle would otherwise return success while a reload silently
+    // disables the agent again. Retire the conflicting legacy override in the
+    // SAME atomic write; no new authority, DB or migration subsystem is added.
+    let retiredLegacySplit = false;
+    if (agentName === 'diagnostician') {
+        const features = isRecord(updatedConfig.features) ? updatedConfig.features : {};
+        const legacySplit = isRecord(features) ? features.diagnostician_split_pipeline : undefined;
+        if (isRecord(legacySplit) && legacySplit.enabled === false) {
+            delete features.diagnostician_split_pipeline;
+            retiredLegacySplit = true;
+        }
+    }
     // 7. Validate the updated config before writing
     const validation = validatePdConfig(updatedConfig);
     if (!validation.ok) {
@@ -345,6 +372,12 @@ export function updateAgentBinding(workspaceDir, agentName, payload) {
         agent: agentName,
         runtimeProfile,
         enabled,
+        ...(retiredLegacySplit
+            ? {
+                warning: 'Retired the conflicting legacy diagnostician_split_pipeline=false override so the canonical ' +
+                    'Diagnostician toggle is authoritative after reload.',
+            }
+            : {}),
     };
 }
 export function updateDefaultRuntime(workspaceDir, payload) {

package/console/dist/server/routes/config.js

@@ -141,6 +141,7 @@ export async function handleConfigRoute(req, res, ctx) {
             agent: result.agent,
             runtimeProfile: result.runtimeProfile,
             enabled: result.enabled,
+            ...(result.warning !== undefined ? { warning: result.warning } : {}),
         });
         return;
     }

package/console/dist/ui/utils/agent-metadata.js

@@ -81,13 +81,17 @@ export const AGENT_METADATA = {
         techDetailZh: {
             '输入': '`DiagnosticianContextPayload`（pain 信号上下文）',
             '输出': '`DiagnosticianOutputV1` · rootCause / violatedPrinciples / recommendations[] / confidence',
-            '编排': '由 `PainSignalBridge` 触发；`diagnostician_split_pipeline` flag 控制单体 vs 3 段拆分',
+            // PRI-638: the split flag no longer selects an implementation nor
+            // disables anything — the capability switch is the agent binding here.
+            '编排': '由 `PainSignalBridge` 触发；开关 = 本页面的代理启用开关（`internalAgents.agents.diagnostician.enabled`）',
             '阶段': '`diag_rootcause` → `diag_distiller` → `diag_router`',
         },
         techDetailEn: {
             'Input': '`DiagnosticianContextPayload` (pain signal context)',
             'Output': '`DiagnosticianOutputV1` · rootCause / violatedPrinciples / recommendations[] / confidence',
-            'Orchestration': 'Triggered by `PainSignalBridge`; `diagnostician_split_pipeline` flag controls monolithic vs 3-stage split',
+            // PRI-638: the split flag no longer selects an implementation nor
+            // disables anything — the capability switch is the agent binding here.
+            'Orchestration': 'Triggered by `PainSignalBridge`; switch = this agent\'s enable toggle (`internalAgents.agents.diagnostician.enabled`)',
             'Stages': '`diag_rootcause` → `diag_distiller` → `diag_router`',
         },
         isCore: true,