create-principles-disciple 1.105.0 → 1.106.0

package/console/dist/server/routes/update.js

@@ -128,6 +128,85 @@ function copyFileTo(src, dest) {
         fs.mkdirSync(dir, { recursive: true });
     fs.copyFileSync(src, dest);
 }
+// --- Plugin skill-language preservation (PR #1332 companion) -----------------
+// OpenClaw publishes plugin skills by directory name (first declaration
+// wins, same-name roots only warn — no locale mechanism), so a manifest must
+// declare exactly ONE language root. The shipped manifest declares zh
+// (product default); installs made with --lang en have their installed
+// manifest rewritten to the en root by the installer. Updates ship a fresh
+// zh-default manifest and would silently revert that choice — so capture the
+// installed language BEFORE any mutation and re-apply it after the new
+// manifest lands. Mirrors create-principles-disciple/src/skill-language.ts
+// (keep the two transforms in sync).
+const SKILL_LANGUAGE_ROOTS = {
+    zh: 'templates/langs/zh/skills',
+    en: 'templates/langs/en/skills',
+};
+function isLanguageSkillRoot(entry) {
+    if (typeof entry !== 'string')
+        return false;
+    const normalized = entry.replaceAll('\\', '/');
+    return normalized === SKILL_LANGUAGE_ROOTS.zh || normalized === SKILL_LANGUAGE_ROOTS.en;
+}
+function detectInstalledSkillLanguage(extDir) {
+    try {
+        const manifestPath = path.join(extDir, 'openclaw.plugin.json');
+        if (!fs.existsSync(manifestPath))
+            return 'zh';
+        const raw = JSON.parse(fs.readFileSync(manifestPath, 'utf-8'));
+        if (!isRecord(raw) || !Array.isArray(raw.skills))
+            return 'zh';
+        const languages = new Set();
+        for (const entry of raw.skills) {
+            if (typeof entry !== 'string')
+                continue;
+            const normalized = entry.replaceAll('\\', '/');
+            if (normalized === SKILL_LANGUAGE_ROOTS.zh)
+                languages.add('zh');
+            else if (normalized === SKILL_LANGUAGE_ROOTS.en)
+                languages.add('en');
+        }
+        // Exactly one language root → that is the user's selection. Zero or both
+        // (pre-ERR-097 legacy install) → product default.
+        if (languages.size !== 1)
+            return 'zh';
+        for (const language of languages)
+            return language;
+        return 'zh';
+    }
+    catch {
+        return 'zh';
+    }
+}
+function reapplySkillLanguage(extDir, language) {
+    try {
+        const manifestPath = path.join(extDir, 'openclaw.plugin.json');
+        if (!fs.existsSync(manifestPath))
+            return;
+        // Defense in depth: only rewrite when the selected language's templates
+        // actually exist — otherwise the host would warn "plugin skill path not
+        // found" and publish nothing.
+        if (!fs.existsSync(path.join(extDir, SKILL_LANGUAGE_ROOTS[language]))) {
+            console.error(`[pd-console:update] skill language "${language}" templates missing — keeping shipped manifest skills`);
+            return;
+        }
+        const raw = JSON.parse(fs.readFileSync(manifestPath, 'utf-8'));
+        if (!isRecord(raw) || !Array.isArray(raw.skills))
+            return;
+        const skills = raw.skills;
+        const kept = skills.filter((entry) => typeof entry === 'string' && !isLanguageSkillRoot(entry));
+        const next = [...kept, SKILL_LANGUAGE_ROOTS[language]];
+        const unchanged = next.length === skills.length && next.every((entry, i) => entry === skills[i]);
+        if (unchanged)
+            return;
+        raw.skills = next;
+        fs.writeFileSync(manifestPath, JSON.stringify(raw, null, 2) + '\n', 'utf-8');
+    }
+    catch (error) {
+        // rc-9: degrade observably, never fail the whole update over skill language.
+        console.error(`[pd-console:update] failed to re-apply skill language "${language}": ${error instanceof Error ? error.message : String(error)}`);
+    }
+}
 function getAllFilesLocal(dir, skipDirs) {
     const skip = skipDirs ?? new Set();
     const result = [];
@@ -293,6 +372,9 @@ async function doApplyUpdate(options, workspaceDir) {
     try {
         // 0. Save current version BEFORE any changes
         const fromVersion = readCurrentVersion(targetDir) ?? 'unknown';
+        // Capture the installed skill language before the tarball's manifest
+        // overwrites it (PR #1332 companion — see reapplySkillLanguage).
+        const skillLanguage = detectInstalledSkillLanguage(targetDir);
         // 1. Fetch latest package info (with timeout + retry)
         const response = await fetchWithRetry(NPM_REGISTRY_LATEST, 'Registry check');
         const rawData = await response.json();
@@ -355,6 +437,9 @@ async function doApplyUpdate(options, workspaceDir) {
             copyFileTo(path.join(tempDir, file), path.join(targetDir, file));
             updatedFiles.push(file);
         }
+        // 4b. The incoming manifest declares the product-default skill language
+        // (zh); restore the language this install was materialized with.
+        reapplySkillLanguage(targetDir, skillLanguage);
         // Fix 3: deletions intentionally skipped — see comment above.
         // 5. Update package.json version
         const pkgPath = path.join(targetDir, 'package.json');
@@ -487,6 +572,9 @@ async function doInlineFullUpdate(workspaceDir) {
     }
     // Capture version before changes
     const fromVersion = readCurrentVersion(extDir) ?? 'unknown';
+    // Capture the installed skill language before the tarball's manifest
+    // overwrites it (PR #1332 companion — see reapplySkillLanguage).
+    const skillLanguage = detectInstalledSkillLanguage(extDir);
     let tempDir;
     try {
         // 2. Fetch installer package info from npm
@@ -527,6 +615,9 @@ async function doInlineFullUpdate(workspaceDir) {
         const pluginSrc = path.join(tempDir, 'plugin');
         if (fs.existsSync(pluginSrc)) {
             copyDirRecursive(pluginSrc, extDir, SKIP_DIRS);
+            // The incoming manifest declares the product-default skill language
+            // (zh); restore the language this install was materialized with.
+            reapplySkillLanguage(extDir, skillLanguage);
         }
         //    b. console/ → extDir/console/ (overwrite dist/ files; do NOT rmSync —
         //       console/node_modules/ may contain locked native modules like

package/console/dist/web/assets/app.css

@@ -2234,6 +2234,9 @@
     -moz-user-select: none;
          user-select: none;
   }
+  .\[pd-console\:update\] {
+    pd-console: update;
+  }
   @media (hover: hover) {
     .group-hover\:opacity-100:is(:where(.group):hover *) {
       opacity: 100%;

package/core/dist/runtime-v2/__tests__/architecture-regression.test.js

@@ -328,6 +328,12 @@ const KNOWN_PLUGIN_CORE_FILES = new Set([
     // I/O shell: reads .pd/config.yaml, constructs PiAiRuntimeAdapter, writes trajectory.
     // Pure detection logic lives in @principles/core/runtime-v2/signal-collector/.
     'signal-collector-host.ts',
+    // PRI-530: Plugin I/O boundary — sync readonly state.db reads resolving principle
+    // receipt attribution (title fallback chain / approval date / source summary).
+    'principle-receipt-metadata.ts',
+    // PRI-531: Plugin I/O boundary — durable receipt ledger writes (state.db
+    // principle_applications inserts + 90-day retention sweep).
+    'principle-application-ledger.ts',
     'pain-lifecycle.ts',
     'session-tracker.ts',
     // PRI-459: now a thin re-export adapter over @principles/core/principle-tree-ledger.
@@ -429,7 +435,10 @@ describe('PRI-212 plugin core anti-growth guard', () => {
         // collection I/O host (correction + empathy upstream merge). Reads
         // .pd/config.yaml, constructs PiAiRuntimeAdapter, writes trajectory. Pure
         // detection logic lives in @principles/core/runtime-v2/signal-collector/.
-        expect(KNOWN_PLUGIN_CORE_FILES.size).toBe(94);
+        // PRI-530: Added principle-receipt-metadata.ts (94 → 95) — plugin I/O boundary
+        // for principle receipt attribution reads (readonly state.db joins).
+        // PRI-531: Added principle-application-ledger.ts (95 → 96) — receipt ledger writer.
+        expect(KNOWN_PLUGIN_CORE_FILES.size).toBe(96);
     });
 });
 const REQUIRED_TEST_FILES = [