create-principles-disciple 1.102.0 → 1.103.0

package/plugin/dist/core/rule-host.js

@@ -161,7 +161,7 @@ export class RuleHost {
         try {
             const { loaded, skipped } = this._loadFromActivationsTable(this.workspaceDir, supportsContextV2);
             if (loaded.length === 0) {
-                this._emitEmptyLoadWarn('armed but empty — 0 active code_tool_hook activations loaded (RuleHost will not block or require approval)', 'If this is unexpected, run `pd runtime activation list --channel code_tool_hook` to inspect activations, or `pd runtime activation promote` to enable a live rule');
+                this._emitEmptyLoadWarn('armed but empty — 0 active code_tool_hook activations loaded (RuleHost will not block or require approval)', 'If this is unexpected, run `pd activation list --channel code_tool_hook` to inspect activations, or `pd activation promote --activation-id <id> --confirm` to enable a live rule');
             }
             return { loaded, skipped };
         }
@@ -258,7 +258,13 @@ export class RuleHost {
                 }
             }
             // Emit structured unhealthy evidence for duplicate groups; collect valid (non-duplicate) rows.
+            // PRI-497: duplicate activations are ALSO pushed to the `skipped` array
+            // so callers (gate.ts, CLI, Console) can observe them via
+            // skippedActivations — not just via rulehost_unhealthy event log.
+            // Both paths are populated (rc-9-no-silent-fallback): event log for
+            // telemetry, skipped array for structured caller-facing observability.
             const validRows = [];
+            const skipped = [];
             for (const [targetRef, group] of rowsByTargetRef) {
                 if (group.length > 1) {
                     const activationIds = [];
@@ -280,6 +286,14 @@ export class RuleHost {
                         const artifactId = typeof r['artifact_id'] === 'string' ? r['artifact_id'] : '';
                         if (activationId && artifactId) {
                             this._recordUnhealthy(activationId, artifactId, targetRef, `duplicate active activation for target_ref ${targetRef}`, 'Deactivate all but one activation for this target_ref');
+                            // PRI-497: also surface in skippedActivations for caller observability
+                            skipped.push({
+                                activationId,
+                                ruleId: targetRef,
+                                mode: 'live',
+                                reason: 'duplicate_active_activation',
+                                nextAction: 'Deactivate all but one activation for this target_ref',
+                            });
                         }
                     }
                 }
@@ -290,7 +304,6 @@ export class RuleHost {
                 }
             }
             const loaded = [];
-            const skipped = [];
             for (const r of validRows) {
                 const activationId = typeof r['activation_id'] === 'string' ? r['activation_id'] : '';
                 const artifactId = typeof r['artifact_id'] === 'string' ? r['artifact_id'] : '';

package/plugin/dist/hooks/gate.js

@@ -80,7 +80,7 @@ export function handleBeforeToolCall(event, ctx) {
         };
         const report = typeof ruleHost.evaluateDetailed === 'function'
             ? ruleHost.evaluateDetailed(hostInput)
-            : { liveDecision: ruleHost.evaluate(hostInput), shadowDecisions: [] };
+            : { liveDecision: ruleHost.evaluate(hostInput), shadowDecisions: [], skippedActivations: [] };
         const hostResult = report.liveDecision;
         for (const shadowDecision of report.shadowDecisions) {
             try {

package/plugin/dist/service/evolution-dedup.d.ts

@@ -4,7 +4,7 @@
  * Dedup logic for preventing duplicate pain tasks and redundant reflections.
  * Extracted from evolution-worker.ts.
  */
-import type { EvolutionQueueItem } from './evolution-queue-migration.js';
+import type { EvolutionQueueItem } from '../core/evolution-types.js';
 /**
  * Dedup window for pain queue tasks (30 minutes).
  */

package/plugin/dist/service/evolution-worker.d.ts

@@ -1,6 +1,5 @@
 import type { OpenClawPluginServiceContext, OpenClawPluginApi, PluginLogger } from '../openclaw-sdk.js';
 import { WorkspaceContext } from '../core/workspace-context.js';
-import type { TaskKind, TaskPriority } from '../core/trajectory-types.js';
 export type { TaskKind, TaskPriority } from '../core/trajectory-types.js';
 export { loadEvolutionQueue, saveEvolutionQueue, withQueueLock, acquireQueueLock, requireQueueLock } from './queue-io.js';
 export { EVOLUTION_QUEUE_LOCK_SUFFIX, LOCK_MAX_RETRIES, LOCK_RETRY_DELAY_MS, LOCK_STALE_MS } from './queue-io.js';
@@ -24,37 +23,14 @@ export type { WatchdogResult };
  * Pain diagnosis is Runtime v2 only: after_tool_call / pd pain record ->
  * PainSignalBridge -> SplitDiagnosticianRunner. EvolutionWorker does not read
  * .pain_flag or process pain_diagnosis queue items.
+ *
+ * Types (QueueStatus / TaskResolution / EvolutionQueueItem) are re-exported
+ * from queue-migration.ts, which sources them from evolution-types.ts
+ * (canonical single source of truth).
  */
-/** @deprecated Use PDTaskStatus from '@principles/core/runtime-v2'. M2 migration will replace this. */
-export type QueueStatus = 'pending' | 'in_progress' | 'completed' | 'failed' | 'canceled';
-export type TaskResolution = 'marker_detected' | 'auto_completed_timeout' | 'failed_max_retries' | 'runtime_unavailable' | 'canceled' | 'late_marker_principle_created' | 'late_marker_no_principle' | 'stub_fallback' | 'skipped_thin_violation' | 'noise_classified' | 'retired';
-export interface EvolutionQueueItem {
-    id: string;
-    taskKind: TaskKind;
-    priority: TaskPriority;
-    source: string;
-    traceId?: string;
-    task?: string;
-    score: number;
-    reason: string;
-    timestamp: string;
-    enqueued_at?: string;
-    started_at?: string;
-    completed_at?: string;
-    assigned_session_key?: string;
-    trigger_text_preview?: string;
-    status: QueueStatus;
-    resolution?: TaskResolution;
-    session_id?: string;
-    agent_id?: string;
-    retryCount: number;
-    maxRetries: number;
-    lastError?: string;
-    resultRef?: string;
-    painEventId?: number;
-}
-import { migrateToV2, isLegacyQueueItem, migrateQueueToV2, LegacyEvolutionQueueItem, DEFAULT_TASK_KIND, DEFAULT_PRIORITY, DEFAULT_MAX_RETRIES, type RawQueueItem } from './queue-migration.js';
-export { migrateToV2, isLegacyQueueItem, migrateQueueToV2, LegacyEvolutionQueueItem, DEFAULT_TASK_KIND, DEFAULT_PRIORITY, DEFAULT_MAX_RETRIES };
+export type { QueueStatus, TaskResolution, EvolutionQueueItem } from './queue-migration.js';
+import { migrateToV2, isLegacyQueueItem, migrateQueueToV2, LegacyEvolutionQueueItem, DEFAULT_TASK_KIND, DEFAULT_PRIORITY, DEFAULT_MAX_RETRIES, validateQueueItem, VALID_TASK_KINDS, isValidQueueItem, type RawQueueItem, type EvolutionQueueItem } from './queue-migration.js';
+export { migrateToV2, isLegacyQueueItem, migrateQueueToV2, LegacyEvolutionQueueItem, DEFAULT_TASK_KIND, DEFAULT_PRIORITY, DEFAULT_MAX_RETRIES, validateQueueItem, VALID_TASK_KINDS, isValidQueueItem };
 export type { RawQueueItem };
 export declare function extractEvolutionTaskId(task: string): string | null;
 export declare function purgeStaleFailedTasks(queue: EvolutionQueueItem[], logger: PluginLogger): {

package/plugin/dist/service/evolution-worker.js

@@ -11,7 +11,7 @@ import { atomicWriteFileSync } from '../utils/io.js';
 // Re-export queue I/O (extracted to queue-io.ts)
 export { loadEvolutionQueue, saveEvolutionQueue, withQueueLock, acquireQueueLock, requireQueueLock } from './queue-io.js';
 export { EVOLUTION_QUEUE_LOCK_SUFFIX, LOCK_MAX_RETRIES, LOCK_RETRY_DELAY_MS, LOCK_STALE_MS } from './queue-io.js';
-import { saveEvolutionQueue, requireQueueLock } from './queue-io.js';
+import { saveEvolutionQueue, requireQueueLock, loadEvolutionQueue } from './queue-io.js';
 import { WorkflowStore } from './subagent-workflow/workflow-store.js';
 import { PrincipleCompiler } from '../core/principle-compiler/index.js';
 import { loadLedger, updatePrinciple } from '../core/principle-tree-ledger.js';
@@ -58,8 +58,8 @@ import { runWorkflowWatchdog } from './workflow-watchdog.js';
 export { runWorkflowWatchdog };
 let timeoutId = null;
 // ── Queue Migration (extracted to queue-migration.ts) ────────────────────────
-import { migrateToV2, isLegacyQueueItem, migrateQueueToV2, DEFAULT_TASK_KIND, DEFAULT_PRIORITY, DEFAULT_MAX_RETRIES } from './queue-migration.js';
-export { migrateToV2, isLegacyQueueItem, migrateQueueToV2, DEFAULT_TASK_KIND, DEFAULT_PRIORITY, DEFAULT_MAX_RETRIES };
+import { migrateToV2, isLegacyQueueItem, migrateQueueToV2, DEFAULT_TASK_KIND, DEFAULT_PRIORITY, DEFAULT_MAX_RETRIES, validateQueueItem, VALID_TASK_KINDS, isValidQueueItem } from './queue-migration.js';
+export { migrateToV2, isLegacyQueueItem, migrateQueueToV2, DEFAULT_TASK_KIND, DEFAULT_PRIORITY, DEFAULT_MAX_RETRIES, validateQueueItem, VALID_TASK_KINDS, isValidQueueItem };
 // Queue lock constants and requireQueueLock are imported from queue-io.ts
 export function extractEvolutionTaskId(task) {
     if (!task)
@@ -302,30 +302,12 @@ async function processEvolutionQueue(wctx, logger, _eventLog, _api) {
             logger?.info?.(`[PD:EvolutionWorker] Dropped ${beforeLegacyPainDrop - queue.length} legacy pain_diagnosis queue item(s); use PainSignalBridge/pd pain record`);
         }
         // Validate queue items — filter out malformed entries before processing.
-        // Malformed items are logged + skipped; they never crash the evolution cycle.
+        // rc-1/rc-4 (ERR-007): consolidated in validateQueueItem (queue-migration.ts)
+        // so every load path applies the same filter. Malformed items are logged +
+        // skipped; they never crash the evolution cycle.
         const beforeValidation = queue.length;
         queue = queue.filter((item) => {
-            const errors = [];
-            if (!item.id || typeof item.id !== 'string')
-                errors.push('missing/invalid id');
-            if (!item.source || typeof item.source !== 'string')
-                errors.push('missing/invalid source');
-            if (typeof item.score !== 'number')
-                errors.push('missing/invalid score');
-            if (!item.status || typeof item.status !== 'string')
-                errors.push('missing/invalid status');
-            if (!item.taskKind || typeof item.taskKind !== 'string')
-                errors.push('missing/invalid taskKind');
-            else {
-                const validTaskKinds = ['model_eval'];
-                if (!validTaskKinds.includes(item.taskKind)) {
-                    errors.push(`invalid taskKind value '${item.taskKind}' (expected one of: ${validTaskKinds.join(', ')})`);
-                }
-            }
-            if (typeof item.retryCount !== 'number')
-                errors.push('missing/invalid retryCount');
-            if (typeof item.maxRetries !== 'number')
-                errors.push('missing/invalid maxRetries');
+            const errors = validateQueueItem(item);
             if (errors.length > 0) {
                 logger?.warn?.(`[PD:EvolutionWorker] Skipping malformed queue item: ${errors.join(', ')} | ${JSON.stringify(item).slice(0, 200)}`);
                 SystemLogger.log(wctx.workspaceDir, 'QUEUE_ITEM_MALFORMED', `Skipped: ${errors.join(', ')} | id=${item.id || 'N/A'}`);
@@ -361,16 +343,11 @@ export async function registerEvolutionTaskSession(workspaceResolve, taskId, ses
         return false;
     const releaseLock = await requireQueueLock(queuePath, logger, 'registerEvolutionTaskSession');
     try {
-        let rawQueue;
-        try {
-            rawQueue = JSON.parse(fs.readFileSync(queuePath, 'utf8'));
-        }
-        catch (parseErr) {
-            logger?.warn?.(`[PD:EvolutionWorker] Failed to parse EVOLUTION_QUEUE for session registration: ${queuePath} - ${parseErr instanceof Error ? parseErr.message : String(parseErr)}`);
-            return false;
-        }
-        // V2: Migrate queue to current schema
-        const queue = migrateQueueToV2(rawQueue);
+        // loadEvolutionQueue handles JSON parse + migrate + validate (rc-1/rc-4).
+        // Previously this inlined JSON.parse + migrate cast without validating,
+        // so malformed queue items could reach the find() below. Reusing the
+        // shared loader keeps a single chokepoint for queue validation.
+        const queue = loadEvolutionQueue(queuePath);
         const task = queue.find((item) => item.id === taskId && item.status === 'in_progress');
         if (!task) {
             logger?.warn?.(`[PD:EvolutionWorker] Could not find in-progress evolution task ${taskId} for session assignment`);
@@ -406,7 +383,11 @@ async function processEvolutionQueueWithResult(wctx, logger, eventLog, api) {
         if (!fs.existsSync(queuePath)) {
             return { queue: queueResult, errors };
         }
-        const queue = JSON.parse(fs.readFileSync(queuePath, 'utf8'));
+        // rc-1/rc-2/rc-4 (ERR-001/ERR-005/ERR-007): use the canonical loader
+        // instead of raw JSON.parse + cast. loadEvolutionQueue handles parse,
+        // migrate, and element-wise validation; malformed items are dropped
+        // with a console.warn (rc-9: no silent fallback).
+        const queue = loadEvolutionQueue(queuePath);
         // Purge stale failed tasks before processing (keeps queue lean)
         const purgeResult = purgeStaleFailedTasks(queue, logger);
         if (purgeResult.purged > 0) {

package/plugin/dist/service/queue-io.js

@@ -11,7 +11,7 @@ import { createHash } from 'crypto';
 import { acquireLockAsync, releaseLock as releaseImportedLock } from '../utils/file-lock.js';
 import { atomicWriteFileSync } from '../utils/io.js';
 import { LockUnavailableError } from '../config/errors.js';
-import { migrateQueueToV2 } from './queue-migration.js';
+import { migrateQueueToV2, validateQueueItem } from './queue-migration.js';
 export const EVOLUTION_QUEUE_LOCK_SUFFIX = '.lock';
 export const LOCK_MAX_RETRIES = 50;
 export const LOCK_RETRY_DELAY_MS = 50;
@@ -72,7 +72,19 @@ export function loadEvolutionQueue(queuePath) {
             rawQueue = [];
         }
     }
-    return migrateQueueToV2(rawQueue);
+    // rc-1/rc-4 (ERR-007): every element of the parsed array is untrusted disk
+    // JSON — validate before returning. Malformed items are filtered out and
+    // reported via console.warn (rc-9: no silent drop). This is the single
+    // chokepoint that loadEvolutionQueue callers inherit.
+    const migrated = migrateQueueToV2(rawQueue);
+    return migrated.filter((item) => {
+        const errors = validateQueueItem(item);
+        if (errors.length > 0) {
+            console.warn(`[queue-io] Dropping malformed queue item: ${errors.join(', ')} | id=${item?.id ?? 'N/A'}`);
+            return false;
+        }
+        return true;
+    });
 }
 export function saveEvolutionQueue(queuePath, queue) {
     atomicWriteFileSync(queuePath, JSON.stringify(queue, null, 2));

package/plugin/dist/service/queue-migration.d.ts

@@ -5,32 +5,8 @@
  * to the V2 schema. Zero I/O, zero imports from evolution-worker.ts.
  */
 import type { TaskKind, TaskPriority } from '../core/trajectory-types.js';
-export type QueueStatus = 'pending' | 'in_progress' | 'completed' | 'failed';
-export type TaskResolution = 'success' | 'failure' | 'skipped';
-export interface EvolutionQueueItem {
-    id: string;
-    taskKind: TaskKind;
-    priority: TaskPriority;
-    source: string;
-    traceId?: string;
-    task?: string;
-    score: number;
-    reason: string;
-    timestamp: string;
-    enqueued_at?: string;
-    started_at?: string;
-    completed_at?: string;
-    assigned_session_key?: string;
-    trigger_text_preview?: string;
-    status: QueueStatus;
-    resolution?: TaskResolution;
-    session_id?: string;
-    agent_id?: string;
-    retryCount: number;
-    maxRetries: number;
-    lastError?: string;
-    resultRef?: string;
-}
+import type { EvolutionQueueItem } from '../core/evolution-types.js';
+export type { QueueStatus, TaskResolution, EvolutionQueueItem } from '../core/evolution-types.js';
 /**
  * Legacy queue item shape (pre-V2) for migration compatibility.
  * These items lack taskKind, priority, retryCount, maxRetries, lastError fields.
@@ -81,3 +57,28 @@ export declare function isLegacyQueueItem(item: RawQueueItem): boolean;
  * Returns a new array with all items migrated to V2 format.
  */
 export declare function migrateQueueToV2(queue: RawQueueItem[]): EvolutionQueueItem[];
+/**
+ * Canonical set of valid taskKind values. Single source of truth — mirrors
+ * TaskKind in trajectory-types.ts. Previously the inline validator in
+ * evolution-worker.ts hard-coded `['model_eval']`, which silently rejected
+ * three legitimate taskKind values (pain_diagnosis / sleep_reflection /
+ * keyword_optimization). Keep this in sync with TaskKind.
+ */
+export declare const VALID_TASK_KINDS: readonly TaskKind[];
+/**
+ * Validate a single queue item loaded from untrusted disk JSON.
+ *
+ * Returns an array of human-readable error reasons; an empty array means the
+ * item is valid. Use {@link isValidQueueItem} for a type-guard form.
+ *
+ * This consolidates the inline validation that lived in processEvolutionQueue
+ * (evolution-worker.ts) so every queue load path (loadEvolutionQueue,
+ * registerEvolutionTaskSession) applies the same filter. rc-4 (ERR-007):
+ * array elements from parsed JSON must be element-wise validated.
+ */
+export declare function validateQueueItem(item: unknown): string[];
+/**
+ * Type-guard convenience over {@link validateQueueItem}.
+ * Drops the reason strings (callers that need them should call validateQueueItem).
+ */
+export declare function isValidQueueItem(item: unknown): item is EvolutionQueueItem;

package/plugin/dist/service/queue-migration.js

@@ -54,3 +54,60 @@ export function isLegacyQueueItem(item) {
 export function migrateQueueToV2(queue) {
     return queue.map(item => isLegacyQueueItem(item) ? migrateToV2(item) : item);
 }
+// ── Validation (rc-1/rc-2, rc-4: validate array elements from untrusted JSON) ─
+/**
+ * Canonical set of valid taskKind values. Single source of truth — mirrors
+ * TaskKind in trajectory-types.ts. Previously the inline validator in
+ * evolution-worker.ts hard-coded `['model_eval']`, which silently rejected
+ * three legitimate taskKind values (pain_diagnosis / sleep_reflection /
+ * keyword_optimization). Keep this in sync with TaskKind.
+ */
+export const VALID_TASK_KINDS = [
+    'pain_diagnosis',
+    'sleep_reflection',
+    'model_eval',
+    'keyword_optimization',
+];
+/**
+ * Validate a single queue item loaded from untrusted disk JSON.
+ *
+ * Returns an array of human-readable error reasons; an empty array means the
+ * item is valid. Use {@link isValidQueueItem} for a type-guard form.
+ *
+ * This consolidates the inline validation that lived in processEvolutionQueue
+ * (evolution-worker.ts) so every queue load path (loadEvolutionQueue,
+ * registerEvolutionTaskSession) applies the same filter. rc-4 (ERR-007):
+ * array elements from parsed JSON must be element-wise validated.
+ */
+export function validateQueueItem(item) {
+    const errors = [];
+    if (item === null || typeof item !== 'object' || Array.isArray(item)) {
+        return ['item is not an object'];
+    }
+    const it = item;
+    if (!it.id || typeof it.id !== 'string')
+        errors.push('missing/invalid id');
+    if (!it.source || typeof it.source !== 'string')
+        errors.push('missing/invalid source');
+    if (typeof it.score !== 'number')
+        errors.push('missing/invalid score');
+    if (!it.status || typeof it.status !== 'string')
+        errors.push('missing/invalid status');
+    if (!it.taskKind || typeof it.taskKind !== 'string')
+        errors.push('missing/invalid taskKind');
+    else if (!VALID_TASK_KINDS.includes(it.taskKind)) {
+        errors.push(`invalid taskKind value '${it.taskKind}' (expected one of: ${VALID_TASK_KINDS.join(', ')})`);
+    }
+    if (typeof it.retryCount !== 'number')
+        errors.push('missing/invalid retryCount');
+    if (typeof it.maxRetries !== 'number')
+        errors.push('missing/invalid maxRetries');
+    return errors;
+}
+/**
+ * Type-guard convenience over {@link validateQueueItem}.
+ * Drops the reason strings (callers that need them should call validateQueueItem).
+ */
+export function isValidQueueItem(item) {
+    return validateQueueItem(item).length === 0;
+}

package/plugin/templates/langs/en/core/AGENTS.md

@@ -200,6 +200,6 @@ When completing any coding task (via AI coding assistant or direct):
 Use this to avoid confusing peer agents with Principles internal workers:
 
 - **Peer agents / peer sessions**: `agents_list`, `sessions_list`, `sessions_send`, `sessions_spawn`
-- **Internal workers** (for example `diagnostician`, `explorer`): use `sessions_spawn with pd-diagnostician/pd-explorer skills`
+- **Internal workers** (for example `explorer`): use `sessions_spawn with pd-explorer skill`
 - **Inspect internal workers**: use `subagents`
-- **Do not** treat `diagnostician` or `explorer` as peer session targets
+- **Do not** treat `explorer` as a peer session target

package/plugin/templates/langs/en/core/TOOLS.md

@@ -10,6 +10,6 @@
 ## 4. Agent Routing Clarification
 
 - `agents_list`, `sessions_list`, `sessions_send`, and `sessions_spawn` are for peer agents and peer sessions
-- Use `sessions_spawn` with `pd-diagnostician` or `pd-explorer` skills to start Principles internal workers
+- Use `sessions_spawn` with `pd-explorer` skill to start Principles internal workers (e.g., explorer)
 - `subagents` inspects already-started internal workers and their outputs
 - Do not use peer-session tools to pretend an internal worker is a peer agent

package/plugin/templates/langs/zh/core/AGENTS.md

@@ -192,6 +192,6 @@ _This folder is home. Treat it that way._
 用下面这几条避免把同级代理和 Principles 内部 worker 混淆：
 
 - **同级代理 / 同级会话**：`agents_list`、`sessions_list`、`sessions_send`、`sessions_spawn`
-- **内部 worker**（例如 `diagnostician`、`explorer`）：使用 `sessions_spawn` 配合 `pd-diagnostician/pd-explorer` skill 启动
+- **内部 worker**（例如 `explorer`）：使用 `sessions_spawn` 配合 `pd-explorer` skill 启动
 - **查询内部 worker**：使用 `subagents`
-- **不要**把 `diagnostician` 或 `explorer` 当成同级 peer session 目标
+- **不要**把 `explorer` 当成同级 peer session 目标

package/plugin/templates/langs/zh/core/TOOLS.md

@@ -10,6 +10,6 @@
 ## 4. 智能体路由澄清
 
 - `agents_list`、`sessions_list`、`sessions_send`、`sessions_spawn` 用于同级代理和同级会话
-- 使用 `sessions_spawn` 配合 `pd-diagnostician/pd-explorer` skill 启动 Principles 内部 worker，例如 `diagnostician`、`explorer`
+- 使用 `sessions_spawn` 配合 `pd-explorer` skill 启动 Principles 内部 worker，例如 `explorer`
 - `subagents` 用于查看已启动内部 worker 的状态和输出
 - 不要用同级会话工具把内部 worker 伪装成同级代理

package/templates/langs/en/core/AGENTS.md

@@ -200,6 +200,6 @@ When completing any coding task (via AI coding assistant or direct):
 Use this to avoid confusing peer agents with Principles internal workers:
 
 - **Peer agents / peer sessions**: `agents_list`, `sessions_list`, `sessions_send`, `sessions_spawn`
-- **Internal workers** (for example `diagnostician`, `explorer`): use `sessions_spawn with pd-diagnostician/pd-explorer skills`
+- **Internal workers** (for example `explorer`): use `sessions_spawn with pd-explorer skill`
 - **Inspect internal workers**: use `subagents`
-- **Do not** treat `diagnostician` or `explorer` as peer session targets
+- **Do not** treat `explorer` as a peer session target

package/templates/langs/en/core/TOOLS.md

@@ -53,6 +53,6 @@ Tool returns: Blind Spots → Risk Warnings → Alternative Approaches → Recom
 ## 4. Agent Routing Clarification
 
 - `agents_list`, `sessions_list`, `sessions_send`, and `sessions_spawn` are for peer agents and peer sessions
-- Use `sessions_spawn` with `pd-diagnostician` or `pd-explorer` skills to start Principles internal workers
+- Use `sessions_spawn` with `pd-explorer` skill to start Principles internal workers (e.g., explorer)
 - `subagents` inspects already-started internal workers and their outputs
 - Do not use peer-session tools to pretend an internal worker is a peer agent

package/templates/langs/zh/core/AGENTS.md

@@ -192,6 +192,6 @@ _This folder is home. Treat it that way._
 用下面这几条避免把同级代理和 Principles 内部 worker 混淆：
 
 - **同级代理 / 同级会话**：`agents_list`、`sessions_list`、`sessions_send`、`sessions_spawn`
-- **内部 worker**（例如 `diagnostician`、`explorer`）：使用 `sessions_spawn` 配合 `pd-diagnostician/pd-explorer` skill 启动
+- **内部 worker**（例如 `explorer`）：使用 `sessions_spawn` 配合 `pd-explorer` skill 启动
 - **查询内部 worker**：使用 `subagents`
-- **不要**把 `diagnostician` 或 `explorer` 当成同级 peer session 目标
+- **不要**把 `explorer` 当成同级 peer session 目标

package/templates/langs/zh/core/TOOLS.md

@@ -53,6 +53,6 @@ deep_reflect(
 ## 4. 智能体路由澄清
 
 - `agents_list`、`sessions_list`、`sessions_send`、`sessions_spawn` 用于同级代理和同级会话
-- 使用 `sessions_spawn` 配合 `pd-diagnostician/pd-explorer` skill 启动 Principles 内部 worker，例如 `diagnostician`、`explorer`
+- 使用 `sessions_spawn` 配合 `pd-explorer` skill 启动 Principles 内部 worker，例如 `explorer`
 - `subagents` 用于查看已启动内部 worker 的状态和输出
 - 不要用同级会话工具把内部 worker 伪装成同级代理

package/plugin/dist/constants/diagnostician.d.ts

@@ -1,12 +0,0 @@
-/**
- * Diagnostician 协议常量
- *
- * 用于 Runtime V2 diagnostician prompt
- * 与 templates/langs/zh/skills/pd-diagnostician/SKILL.md 保持一致
- */
-/**
- * 诊断协议摘要（用于 HEARTBEAT.md 注入）
- *
- * 完整版见: templates/langs/zh/skills/pd-diagnostician/SKILL.md
- */
-export declare const DIAGNOSTICIAN_PROTOCOL_SUMMARY = "## Diagnostic Protocol (5 Whys)\n\n**Phase 1 - Evidence Gathering**:\n- Use the task input/context provided by Runtime V2 for pain context\n- Read .state/logs/events.jsonl recent entries\n- Search codebase for error patterns from Reason field\n- Record all evidence sources (file:line)\n\n**Phase 2 - Causal Chain (5 Whys)**:\n- Why 1: Surface symptom (what you can see)\n- Why 2: Direct cause (what triggered it)\n- Why 3: Process gap (what should have caught it)\n- Why 4: Design flaw (why the gap exists)\n- Why 5: Root cause (systemic issue to fix)\n- Each Why MUST have evidence. Stop at actionable root cause.\n\n**Phase 3 - Root Cause Classification**:\nClassify into one of:\n- **People**: Human error, missing knowledge, communication gap\n- **Design**: Architecture flaw, missing validation, poor abstraction\n- **Assumption**: Invalid assumption, outdated context, edge case\n- **Tooling**: Tool limitation, environment issue, dependency problem\n- For Design: analyze why existing hooks/rules didn't catch this\n\n**Phase 4 - Principle Extraction**:\nExtract a HIGHLY ABSTRACTED principle (not an operational rule):\n- **trigger_pattern**: regex/keywords for when this occurs\n- **action**: what to do differently\n- **abstracted_principle**: ONE sentence, max 40 chars, cross-scenario applicable\n  - \u274C Bad: \"\u5199\u5165\u524D\u68C0\u67E5\u76EE\u5F55\u662F\u5426\u5B58\u5728\" (too specific)\n  - \u2705 Good: \"\u4EFB\u4F55\u5199\u5165\u64CD\u4F5C\u5FC5\u987B\u786E\u4FDD\u76EE\u6807\u73AF\u5883\u7684\u5B8C\u6574\u6027\" (abstract, reusable)\n\n**Output Format** (single JSON object):\n```json\n{\n  \"diagnosis_report\": {\n    \"task_id\": \"pain-xxx\",\n    \"summary\": \"One-line root cause\",\n    \"causal_chain\": [\n      { \"why\": 1, \"answer\": \"...\", \"evidence\": \"file:line\" }\n    ],\n    \"root_cause\": {\n      \"category\": \"Design|People|Assumption|Tooling\",\n      \"description\": \"...\"\n    },\n    \"principle\": {\n      \"trigger_pattern\": \"...\",\n      \"action\": \"...\",\n      \"abstracted_principle\": \"\u9AD8\u5EA6\u62BD\u8C61\u7684\u4E00\u53E5\u8BDD\u539F\u5219\"\n    }\n  }\n}\n```\n";

package/plugin/dist/constants/diagnostician.js

@@ -1,65 +0,0 @@
-/**
- * Diagnostician 协议常量
- *
- * 用于 Runtime V2 diagnostician prompt
- * 与 templates/langs/zh/skills/pd-diagnostician/SKILL.md 保持一致
- */
-/**
- * 诊断协议摘要（用于 HEARTBEAT.md 注入）
- *
- * 完整版见: templates/langs/zh/skills/pd-diagnostician/SKILL.md
- */
-export const DIAGNOSTICIAN_PROTOCOL_SUMMARY = `## Diagnostic Protocol (5 Whys)
-
-**Phase 1 - Evidence Gathering**:
-- Use the task input/context provided by Runtime V2 for pain context
-- Read .state/logs/events.jsonl recent entries
-- Search codebase for error patterns from Reason field
-- Record all evidence sources (file:line)
-
-**Phase 2 - Causal Chain (5 Whys)**:
-- Why 1: Surface symptom (what you can see)
-- Why 2: Direct cause (what triggered it)
-- Why 3: Process gap (what should have caught it)
-- Why 4: Design flaw (why the gap exists)
-- Why 5: Root cause (systemic issue to fix)
-- Each Why MUST have evidence. Stop at actionable root cause.
-
-**Phase 3 - Root Cause Classification**:
-Classify into one of:
-- **People**: Human error, missing knowledge, communication gap
-- **Design**: Architecture flaw, missing validation, poor abstraction
-- **Assumption**: Invalid assumption, outdated context, edge case
-- **Tooling**: Tool limitation, environment issue, dependency problem
-- For Design: analyze why existing hooks/rules didn't catch this
-
-**Phase 4 - Principle Extraction**:
-Extract a HIGHLY ABSTRACTED principle (not an operational rule):
-- **trigger_pattern**: regex/keywords for when this occurs
-- **action**: what to do differently
-- **abstracted_principle**: ONE sentence, max 40 chars, cross-scenario applicable
-  - ❌ Bad: "写入前检查目录是否存在" (too specific)
-  - ✅ Good: "任何写入操作必须确保目标环境的完整性" (abstract, reusable)
-
-**Output Format** (single JSON object):
-\`\`\`json
-{
-  "diagnosis_report": {
-    "task_id": "pain-xxx",
-    "summary": "One-line root cause",
-    "causal_chain": [
-      { "why": 1, "answer": "...", "evidence": "file:line" }
-    ],
-    "root_cause": {
-      "category": "Design|People|Assumption|Tooling",
-      "description": "..."
-    },
-    "principle": {
-      "trigger_pattern": "...",
-      "action": "...",
-      "abstracted_principle": "高度抽象的一句话原则"
-    }
-  }
-}
-\`\`\`
-`;