create-powerapps-project 0.16.2 → 0.16.3

package/CHANGELOG.json

@@ -2,7 +2,22 @@
   "name": "create-powerapps-project",
   "entries": [
     {
-      "date": "Tue, 08 Feb 2022 18:47:00 GMT",
+      "date": "Wed, 09 Feb 2022 16:18:47 GMT",
+      "tag": "create-powerapps-project_v0.16.3",
+      "version": "0.16.3",
+      "comments": {
+        "patch": [
+          {
+            "author": "derek.finlinson@journeyteam.com",
+            "package": "create-powerapps-project",
+            "commit": "cdab4698564ece9f40c5a45327a38270a6d1c16d",
+            "comment": "Catch errors on commands"
+          }
+        ]
+      }
+    },
+    {
+      "date": "Tue, 08 Feb 2022 18:47:13 GMT",
       "tag": "create-powerapps-project_v0.16.2",
       "version": "0.16.2",
       "comments": {

package/CHANGELOG.md

@@ -1,17 +1,25 @@
 # Change Log - create-powerapps-project
 
-This log was last generated on Tue, 08 Feb 2022 18:47:00 GMT and should not be manually modified.
+This log was last generated on Wed, 09 Feb 2022 16:18:47 GMT and should not be manually modified.
 
 <!-- Start content -->
 
-## 0.16.2
+## 0.16.3
 
-Tue, 08 Feb 2022 18:47:00 GMT
+Wed, 09 Feb 2022 16:18:47 GMT
 
 ### Patches
 
-- Update symbols (derek.finlinson@journeyteam.com)
+- Catch errors on commands (derek.finlinson@journeyteam.com)
 
+## 0.16.2
+
+Tue, 08 Feb 2022 18:47:13 GMT
+
+### Patches
+
+- Update symbols (derek.finlinson@journeyteam.com)
+
 ## 0.16.1
 
 Tue, 08 Feb 2022 18:13:53 GMT

package/lib/createDataverseProject.js

@@ -54,10 +54,18 @@ exports.default = async (type) => {
         const xrmVersions = await (0, nuget_1.getNugetPackageVersions)('JourneyTeam.Xrm');
         config.xrmVersion = xrmVersions.shift();
     }
-    logger_1.logger.info('get plop generator');
+    else if (type === 'webresource') {
+        config.name = name;
+    }
     const generator = await (0, plop_1.getGenerator)(type, name);
     logger_1.logger.info(`run powerapps-project-${type} code generator`);
-    await (0, plop_1.runGenerator)(generator, config);
+    try {
+        await (0, plop_1.runGenerator)(generator, config);
+    }
+    catch (ex) {
+        logger_1.logger.error(ex.message);
+        return;
+    }
     logger_1.logger.info('initialize project');
     if (type !== 'pcf' || config.react) {
         pkg.install(process.cwd(), type);

package/lib/logger.js

@@ -30,7 +30,7 @@ exports.logger = {
     },
     done(...args) {
         if (!isTest) {
-            console.info(exports.icons.info, ...args);
+            console.info(exports.icons.done, ...args);
         }
     },
 };

package/lib/plop.js

@@ -21,11 +21,11 @@ exports.getGenerator = getGenerator;
 const runGenerator = async (generator, args) => {
     const results = await generator.runActions(args, {
         onComment: (comment) => {
-            logger_1.logger.done(comment);
+            logger_1.logger.info(comment);
         }
     });
     if (results.failures && results.failures.length > 0) {
-        throw new Error('Error: ' + results.failures[0].error);
+        throw new Error(results.failures[0].error);
     }
     // do something after the actions have run
     for (const change of results.changes) {

package/lib/plopfile.js

@@ -6,13 +6,26 @@ Object.defineProperty(exports, "__esModule", { value: true });
 const path_1 = __importDefault(require("path"));
 const child_process_1 = require("child_process");
 const fs_1 = __importDefault(require("fs"));
+const didSucceed = (code) => `${code}` === '0';
 /* eslint-disable @typescript-eslint/no-explicit-any */
 // eslint-disable-next-line @typescript-eslint/explicit-module-boundary-types
 exports.default = (plop) => {
     plop.setActionType('signAssembly', (answers) => {
         const keyPath = path_1.default.resolve(process.cwd(), `${answers.name}.snk`);
-        (0, child_process_1.spawnSync)(path_1.default.resolve(__dirname, '../', 'bin', 'sn.exe'), ['-q', '-k', keyPath], { stdio: 'inherit' });
-        return 'signed assembly';
+        return new Promise((resolve, reject) => {
+            if (process.env.JEST_WORKER_ID !== undefined) {
+                resolve('Testing so no need to sign');
+            }
+            const sign = (0, child_process_1.spawn)(path_1.default.resolve(__dirname, '../', 'bin', 'sn.exe'), ['-q', '-k', keyPath], { stdio: 'inherit' });
+            sign.on('close', (code) => {
+                if (didSucceed(code)) {
+                    resolve('signed assembly');
+                }
+                else {
+                    reject('Failed to sign assembly');
+                }
+            });
+        });
     });
     plop.setActionType('runPcf', (answers) => {
         const args = ['pcf', 'init', '-ns', answers.namespace, '-n', answers.name, '-t', answers.template];
@@ -23,15 +36,24 @@ exports.default = (plop) => {
         if (process.env.JEST_WORKER_ID !== undefined) {
             args.push('-npm', 'false');
         }
-        (0, child_process_1.spawnSync)('pac', args, { stdio: 'inherit' });
-        return 'pcf project created';
+        return new Promise((resolve, reject) => {
+            const pac = (0, child_process_1.spawn)('pac', args, { stdio: 'inherit' });
+            pac.on('close', (code) => {
+                if (didSucceed(code)) {
+                    resolve('pcf project created');
+                }
+                else {
+                    reject('Ensure the Power Platform CLI is installed. Command must be run from within VS Code if using the Power Platform Extension');
+                }
+            });
+        });
     });
-    plop.setActionType('addGenScript', () => {
+    plop.setActionType('addGenScript', async () => {
         const packagePath = path_1.default.resolve(process.cwd(), 'package.json');
         // eslint-disable-next-line @typescript-eslint/no-var-requires
         const packageJson = require(packagePath);
         packageJson.scripts.gen = 'plop';
-        fs_1.default.writeFileSync(packagePath, JSON.stringify(packageJson, null, 4), 'utf8');
+        await fs_1.default.promises.writeFile(packagePath, JSON.stringify(packageJson, null, 4), 'utf8');
         return 'added plop script to package.json';
     });
     plop.setGenerator('webresource', {

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "create-powerapps-project",
   "description": "💧 plop generator for Dataverse development",
-  "version": "0.16.2",
+  "version": "0.16.3",
   "license": "MIT",
   "main": "lib/index.js",
   "bin": {