create-pmos 0.8.0 → 0.9.0

package/workspace/lib/transcript-read.js

@@ -168,7 +168,7 @@ function prettyTool(name) {
  */
 function readHarness(file, clean = (x) => x) {
   const out = { model: null, effort: null, turns: 0, tokens: null, tools: null, skills: null,
-    title: null, openCall: null, missing: {} };
+    title: null, openCall: null, turn: null, missing: {} };
   let raw;
   try {
     const st = fs.statSync(file);
@@ -199,6 +199,11 @@ function readHarness(file, clean = (x) => x) {
   // report the raw fact {verb, sinceTs}; we never claim it is live.
   const openUse = new Map();       // tool_use_id → { verb, ts }  (insertion order = chronological)
   const resolved = new Set();      // tool_use_ids that got a tool_result
+  // WHOSE TURN IS IT (workspace-waiting-on-you R1). The last TURN-TAKING record's role — nothing
+  // more. `ai-title` and `attachment` records are CLI bookkeeping and are deliberately not
+  // turn-taking, and neither is a SYNTHETIC assistant record: counting one as "the assistant
+  // finished speaking" is exactly how a false `needs you` would be manufactured.
+  let lastRole = null;             // 'assistant' | 'user' | null
 
   for (const line of raw.split('\n')) {
     if (!line) continue;
@@ -217,6 +222,7 @@ function readHarness(file, clean = (x) => x) {
       for (const c of (Array.isArray(um.content) ? um.content : [])) {
         if (c && c.type === 'tool_result' && c.tool_use_id) resolved.add(c.tool_use_id);
       }
+      lastRole = 'user';           // a prompt was submitted, or a tool result landed
       continue;
     }
     if (r.type === 'attachment') {
@@ -234,6 +240,7 @@ function readHarness(file, clean = (x) => x) {
     if (m.model && m.model !== SYNTHETIC) {
       out.model = clean(m.model);
       out.turns++;                                  // only real model turns count
+      lastRole = 'assistant';                       // ...and only a real turn takes the turn
       if (r.effort) out.effort = clean(String(r.effort));
     }
     const u = m.usage || {};
@@ -260,6 +267,19 @@ function readHarness(file, clean = (x) => x) {
     if (!resolved.has(id)) out.openCall = { verb: info.verb, sinceTs: info.ts };
   }
 
+  // ── Whose turn (R1). Derived here, from what the pass already collected — no second walk. ──
+  // The ORDER of these three branches is the honesty property the whole feature rests on (R4).
+  // `tool` is tested FIRST, so any unresolved call claims the turn. A crashed session's dangling
+  // tool_use is a PERMANENT phantom (2/25 real transcripts), and a phantom is by definition an
+  // unresolved call — so a phantom always lands on `tool`, and `user` (the only turn from which
+  // the strong `needs you` claim can be built) is UNREACHABLE for it. Not a guard that rejects
+  // the phantom: a value it cannot construct. Reordering these branches silently converts a
+  // corpse into "waiting on you", which is the one lie this surface must not tell.
+  if (out.openCall) out.turn = 'tool';              // awaiting a tool — OR the PM's approval of one
+  else if (lastRole === 'assistant') out.turn = 'user';   // the model stopped; the human is up
+  else if (lastRole === 'user') out.turn = 'agent';       // a prompt/result landed; the model is up
+  // else: null — nothing turn-taking was parseable, so no claim is made.
+
   if (!out.model) out.missing.model = 'the transcript names no model yet';
   if (!out.effort) out.missing.effort = 'the transcript records no effort level';
   if (toolTotal) out.tools = { counts: toolCounts, total: toolTotal };
@@ -271,11 +291,13 @@ function readHarness(file, clean = (x) => x) {
   else out.missing.tokens = 'the transcript records no token usage yet';
   if (!out.skills) out.missing.skills = 'the CLI listed no skills for this session';
   if (!out.turns) out.missing.turns = 'no model turns in the transcript yet';
-  // NOTE: `title` and `openCall` deliberately get NO `missing` entry. This map carries reasons the
-  // UI RENDERS in place of a value; both of these instead fall back to a real shipped rendering
-  // (agent · cwd for an untitled session; the plain `working`/`quiet` word when no call is open).
-  // Putting them here would break the map's contract — "empty missing == everything was readable" —
-  // and put a reason on screen where a perfectly good value already goes.
+  // NOTE: `title`, `openCall` and `turn` deliberately get NO `missing` entry. This map carries
+  // reasons the UI RENDERS in place of a value; all three instead fall back to a real shipped
+  // rendering (agent · cwd for an untitled session; the plain `working`/`quiet` word when no call
+  // is open and when the turn is unknown). Putting them here would break the map's contract —
+  // "empty missing == everything was readable" — and put a reason on screen where a perfectly good
+  // value already goes. For `turn` that fallback IS the feature's refusal rule (R5): no second
+  // source, no claim, and the row reads exactly as it did before this existed.
 
   return out;
 }