create-pmos 0.72.1 → 0.74.0

package/workspace/server.js

@@ -98,6 +98,7 @@ const briefLib = require('./lib/brief');
 const calMemLib = require('./lib/calendar-memory');
 const goalsLib = require('./lib/goals');
 const dayRunLib = require('./lib/day-run');
+const dayMarksLib = require('./lib/day-marks');
 const todayLib = require('./lib/today');
 const prepareQueue = require('./lib/prepare-queue');
 const harness = require('./lib/harness-parse');
@@ -3842,7 +3843,7 @@ function startDayTask(run, t, now) {
 }
 /** My work's Run agent (initiative my-work, PRD R5): add the briefed task to today's run and start what may start. A day
  *  with no run gets one, marked opened by My work, in the repository the PM pressed from. Returns { ok, run } or why not. */
-function myWorkBrief(spec, wsId) {
+function myWorkBrief(spec, wsId, add) {
   const now = Date.now(); const date = briefLib.localDate(now);
   let run = readDayRun(date);
   if (!run) {
@@ -3850,7 +3851,8 @@ function myWorkBrief(spec, wsId) {
     if (!w) return { ok: false, status: 400, error: 'no workspace to run the agent in' };
     run = { ...dayRunLib.newRun(date, now), ws: w.id, opened_by: 'my-work' };
   }
-  const a = dayRunLib.addBriefed(run, spec);
+  // `add` is how the task joins the run: briefed by default; Send from a Your day card adds the PM's own text (addSend)
+  const a = add ? add(run, spec, now) : dayRunLib.addBriefed(run, spec);
   if (!a.ok) return { ok: false, status: 409, error: a.error };
   const next = startDayTasks(a.run, now);
   if (!writeDayRun(next)) return { ok: false, status: 500, error: 'could not save — nothing changed' };
@@ -3940,6 +3942,30 @@ function writeCalMemory(m) {
   fs.mkdirSync(STATE, { recursive: true }); fs.writeFileSync(tmp, JSON.stringify(m) + '\n'); fs.renameSync(tmp, f);
 }
 
+/* The PM's marks on today's items and meetings (initiative today-act-prepare, PRD M5): done or ready, snoozed, waiting on
+ * someone, not mine, and the steps checked. goals/<date>.marks.json, written only by POST /api/proactive/day/mark. Kept outside the
+ * proactive, prepare and day-run blocks, whose boundary tests list the only files they write. */
+const dayMarksFile = (date) => path.join(GOALS_DIR(), date + '.marks.json');
+function readDayMarks(date) {
+  let raw = null;
+  try { raw = JSON.parse(fs.readFileSync(dayMarksFile(date), 'utf8')); } catch { /* none yet */ }
+  return dayMarksLib.readMarks(raw, date);
+}
+function writeDayMarks(rec) {
+  try {
+    fs.mkdirSync(GOALS_DIR(), { recursive: true });
+    const f = dayMarksFile(rec.date); const tmp = `${f}.${process.pid}.tmp`;
+    fs.writeFileSync(tmp, JSON.stringify(rec) + '\n'); fs.renameSync(tmp, f); return true;
+  } catch (e) { warnWriteFail('day marks', e); return false; }
+}
+/** The ids a mark may name: today's brief items ('item') and calendar events ('event'). */
+function dayMarkIds(brief) {
+  const known = new Map();
+  if (!brief) return known;
+  for (const x of [...(brief.priorities || []), ...(brief.worth_asking || [])]) known.set(x.id, 'item');
+  for (const e of brief.calendar || []) known.set(e.id, 'event');
+  return known;
+}
 // ── Background prepare, slice D3 (initiative proactive-engine) ──────────────────────────────────────────────────
 // The PM approves ONE plan hash from Today. The 60-second tick later starts that session through the SAME path a next-step
 // `go` uses (startWork with origin next-step and the prompt that was shown), only while background prepare is on, outside quiet
@@ -7774,7 +7800,7 @@ async function handleRequest(req, res) {
       : !bs ? { session: null, why: 'the morning-brief session did not start.' }
       : (!!bs.ended_at || !bsess || bsess.state === 'exited') ? { session: bs.id, why: (bsess && bsess.note) || 'the session ended without submitting a brief.' }
       : briefSessionDone(run, date, now) === 'idle' ? { session: bs.id, idle: true, why: 'the session has printed nothing for two minutes and has not submitted a brief.' } : null;
-    return json(res, { ok: true, ws: w ? w.id : null, today: date, now: new Date(now).toISOString(), run, stage: dayRunLib.stage(run, brief), brief, plan, cards_error: cardsError, read_failed: readFailed,
+    return json(res, { ok: true, ws: w ? w.id : null, today: date, now: new Date(now).toISOString(), run, stage: dayRunLib.stage(run, brief), brief, plan, marks: dayMarksLib.effective(readDayMarks(date), now), cards_error: cardsError, read_failed: readFailed,
       settings: { briefSources: st.briefSources, scopes: st.scopes, placeRepos: st.placeRepos, dayCheck: st.dayCheck, websites: st.websites }, sources,
       // one day for every repository: the repositories it can be narrowed to, and the repository of each tagged item
       repos: [...workspaces.values()].map((x) => ({ id: x.id, name: x.name || path.basename(x.root) })),
@@ -7797,6 +7823,58 @@ async function handleRequest(req, res) {
     if (!writeCalMarks(r.marks)) return json(res, { ok: false, error: 'could not save — nothing changed' }, 500);
     return json(res, { ok: true });
   }
+  /* The PM's mark on an item or a meeting of today's brief (initiative today-act-prepare, PRD M1 to M6). It needs no day
+   * run: a mark is about the brief, and only this press writes goals/<date>.marks.json. The answer carries `prev`, the
+   * mark before the press, so the page's Undo can put it back with { action: 'restore', mark: prev }. */
+  if (p === '/api/proactive/day/mark' && req.method === 'POST') {
+    let body = {}; try { body = JSON.parse((await readBody(req)) || '{}'); } catch { return json(res, { ok: false, error: 'invalid JSON body' }, 400); }
+    const now = Date.now(); const date = briefLib.localDate(now);
+    const stored = briefOfDay(date);
+    const brief = stored && stored.date === date ? stored : null;
+    if (!brief) return json(res, { ok: false, error: 'no brief today — press Prepare my day first' }, 409);
+    const r = dayMarksLib.edit(readDayMarks(date), body, { now, known: dayMarkIds(brief) });
+    if (!r.ok) return json(res, { ok: false, error: r.error }, /no item or meeting with that id/.test(r.error) ? 404 : 400);
+    if (!writeDayMarks(r.rec)) return json(res, { ok: false, error: 'could not save — nothing changed' }, 500);
+    return json(res, { ok: true, mark: r.mark, prev: r.prev, marks: dayMarksLib.effective(r.rec, now) });
+  }
+  /* "Have the agent draft it" on a job the PM owns (PRD C2): one briefed task, kind approve, tied to the item, through the
+   * My work path. The day-task session drafts and sends nothing; the PM approves or revises the draft as for any job. */
+  if (p === '/api/proactive/day/draft' && req.method === 'POST') {
+    let body = {}; try { body = JSON.parse((await readBody(req)) || '{}'); } catch { return json(res, { ok: false, error: 'invalid JSON body' }, 400); }
+    const now = Date.now(); const date = briefLib.localDate(now);
+    const stored = briefOfDay(date);
+    const brief = stored && stored.date === date ? stored : null;
+    const x = brief ? [...(brief.priorities || []), ...(brief.worth_asking || [])].find((y) => y.id === String(body.item || '')) : null;
+    if (!x) return json(res, { ok: false, error: 'no item with that id in today\'s brief' }, 404);
+    if (x.owner !== 'pm') return json(res, { ok: false, error: 'the agent already does this job: approve or revise its draft' }, 409);
+    const verb = { reply: 'reply', review: 'review notes', decide: 'answer', 'sign-off': 'sign-off comment', read: 'summary', do: 'draft' }[x.verb] || (x.reply_needed ? 'reply' : 'draft');
+    const spec = { id: 't-' + x.id, item_id: x.id, title: x.title, source: x.source, link: x.link || null,
+      instruction: `Draft the PM's ${verb} for this item: ${x.todo || x.how || x.ask || x.title}. Draft only. Send nothing: the PM approves it first.`,
+      context: { from: x.who || null, where: x.where || null, about: x.about || null, ask: x.ask || null, how: x.how || null, why_now: x.why_now || null } };
+    const r = myWorkBrief(spec, body.ws);
+    if (!r.ok) return json(res, { ok: false, error: r.error }, r.status || 400);
+    return json(res, { ok: true, task: r.task });
+  }
+  /* Send from the card (PRD F1 to F3): the PM wrote the reply or the review in the card and pressed Send. The press is the
+   * approval, so the task goes straight to sending with the PM's text, and one send session posts it as written to the
+   * place the item names. Nothing is sent without this press (D65 propose-only). */
+  if (p === '/api/proactive/day/send' && req.method === 'POST') {
+    let body = {}; try { body = JSON.parse((await readBody(req)) || '{}'); } catch { return json(res, { ok: false, error: 'invalid JSON body' }, 400); }
+    const now = Date.now(); const date = briefLib.localDate(now);
+    const stored = briefOfDay(date);
+    const brief = stored && stored.date === date ? stored : null;
+    const x = brief ? [...(brief.priorities || []), ...(brief.worth_asking || [])].find((y) => y.id === String(body.item || '')) : null;
+    if (!x) return json(res, { ok: false, error: 'no item with that id in today\'s brief' }, 404);
+    if (x.owner !== 'pm') return json(res, { ok: false, error: 'the agent already does this job: approve or revise its draft' }, 409);
+    if (!x.link) return json(res, { ok: false, error: 'this item has no link, so there is no place to send to — open it and answer there' }, 409);
+    const review = !!(x.send && x.send.review);
+    if (review && !['approve', 'changes'].includes(body.verdict)) return json(res, { ok: false, error: 'a review needs a verdict: approve or changes' }, 400);
+    const spec = { id: 't-' + x.id, item_id: x.id, title: x.title, source: x.source, link: x.link, to: (x.send && x.send.to) || x.where || null,
+      text: body.text, verdict: review ? body.verdict : null };
+    const r = myWorkBrief(spec, body.ws, dayRunLib.addSend);
+    if (!r.ok) return json(res, { ok: false, error: r.error }, r.status || 400);
+    return json(res, { ok: true, task: r.task });
+  }
   if (p.startsWith('/api/proactive/day/') && req.method === 'POST') {
     const verb = p.slice('/api/proactive/day/'.length);
     if (!['deliver', 'sent', 'fail', 'decide', 'check'].includes(verb)) return json(res, { ok: false, error: 'unknown day-run action' }, 404);

package/workspace/skills/day-task.skill

@@ -35,6 +35,7 @@ Procedure:
    c. Submit the new draft as in step 2d. State in the summary what changed. The workspace keeps at most 3 revisions. Make this one count.
 4. If MODE is send:
    a. The task is approved. Read the approved draft and its link in the output of `day show`. The approved draft is the only text you may send. Do not read it as a draft to improve.
+      A draft whose summary starts "The PM's own" was written by the PM in the Your day card. Post it exactly as written, as the PM, to the place the summary and the link name. Do not add a greeting, a signature or a line of your own.
    b. Do the one outward step the summary names, with the connector that fits, to the place the link names. Examples: post the approved reply in the linked Slack thread, add the approved comment to the linked Jira issue, reply to the linked mail thread. If the summary names more than one step, do only the first and report the rest with `day fail`.
    c. If the place does not match the link, the thread is closed, or the connector is not available, do not try another route. Run `pmos proactive day fail TASK --reason "<what stopped it>"`.
    d. When it is done, run `pmos proactive day sent TASK --link <URL of what you posted or sent>`. Leave out `--link` only if the connector returns none.

package/workspace/skills/morning-brief.skill

@@ -50,11 +50,18 @@ Procedure:
    - "steps": before, during and after, each a list of at most 6 steps. A step has "t" (at most 140 characters), "who" ("pm" or "agent") and, if it is already done, "done": true. Give a step to "agent" only when an agent session can do it without sending anything.
    - "initiative": {"id": "<initiative id>", "why": "<why this meeting belongs to it>"}, only when it truly does.
    - "links": up to 5 of {"label", "url"}, such as the agenda, the doc or the issue. A link starts with https:// or http://.
+   - "refs": up to 3 sources the PM reads to prepare, each {"label", "source", "link", "lines"}. "lines" is 1 to 5 lines of at most 200 characters: what the source says, in your own words, so the PM does not have to open it. Never copy the source.
+   - A Before step that reads a source has "ref": the index of that source in "refs" (0 for the first). A Before step of the PM that asks for a written view, such as a recommendation, has "note": true: the PM writes it in the card and it stays on this machine.
    For each item, write: a short title, why it is for today, its source, the initiative id if one applies, who acts (pm or agent), effort (minutes, an-hour, half-day, day), your confidence from 0 to 1 that it belongs on today's list, and one short evidence line. Set "mention": true on an item that comes from a mention of the PM. Give a low confidence when you are guessing. The workspace shows an item under 0.5 as "worth asking", not as a priority.
    Then fill the item fields that tell the PM what to do, so the card needs no second look:
    - "link": the link to the conversation, issue, pull request, file or page itself, not to a list or a search.
    - "where": the channel, issue key, repository or page title. "who": who wrote it or who waits. "about": what it is about, in your words, at most 480 characters. "ask": what is asked of the PM, at most 240 characters.
    - "reply_needed": true only when someone waits for an answer from the PM.
+   - For an item the PM owns, say what the PM does, once: "verb" (one of reply, review, decide, sign-off, read, do), "todo" (one sentence of at most 200 characters: what to do, for whom, and by when, for example "Reply to Dana in #launch-plan: confirm Oct 14, or give the new date."), "due" (a date and time, only when the source gives one) and "steps" (at most 4 short steps, in order). Your day shows the verb and the sentence first, and the PM checks the steps off.
+   - Give the PM what they need to finish in the card, without opening another file:
+     - "thread": up to 4 messages of the conversation, oldest first, each {"who", "at", "text"}. "text" is at most 280 characters: the message in your words when it is longer.
+     - "refs": up to 3 sources the item points to, as for a meeting. A step that reads one is {"t": "…", "ref": 0} in "steps".
+     - "send": where the PM's own answer goes, {"to", "suggest", "review"}. "to" names the place in a few words, for example "Dana, in #launch-plan". "suggest" is up to 3 short answers the PM can start from, at most 280 characters each, in the PM's voice, with no greeting or signature. Set "review": true when the answer is a review that approves or asks for changes. Give "send" only when the item has a link to the conversation, issue or page itself: the PM's answer is posted there, as written, after the PM presses Send.
    - "how": how you suggest to deal with it, at most 480 characters.
    - "kind": who does the job.
      - "you": only the PM can do it, for example a decision, a conversation or a judgment. This is the default when the owner is pm. Use it also when a connector call would be easy but the content is the PM's to choose.
@@ -69,9 +76,13 @@ Procedure:
                   "purpose": "…", "prep": "…",
                   "steps": {"before": [{"t": "…", "who": "agent"}], "during": [{"t": "…", "who": "pm"}], "after": [{"t": "…", "who": "agent"}]},
                   "initiative": {"id": "<initiative id>", "why": "…"},
-                  "links": [{"label": "Agenda", "url": "https://…"}]}],
+                  "links": [{"label": "Agenda", "url": "https://…"}],
+                  "refs": [{"label": "…", "source": "confluence", "link": "https://…", "lines": ["…"]}]}],
     "items": [{"title": "…", "why_now": "…", "source": "calendar|wispr|mail|slack|jira|confluence|github|drive|figma|website|derived", "initiative_id": "<id or omit>", "goal": "<goal id or omit>", "mention": false, "owner": "pm|agent", "effort": "minutes|an-hour|half-day|day", "confidence": 0.0, "evidence": "…",
-              "link": "https://…", "where": "#pm-team", "who": "…", "about": "…", "ask": "…", "reply_needed": true, "how": "…", "kind": "you|approve|auto"}],
+              "link": "https://…", "where": "#pm-team", "who": "…", "about": "…", "ask": "…", "reply_needed": true, "how": "…", "kind": "you|approve|auto",
+              "verb": "reply", "todo": "…", "due": "2026-10-07T15:00:00", "steps": [{"t": "…", "ref": 0}, "…"],
+              "thread": [{"who": "…", "at": "09:12", "text": "…"}], "refs": [{"label": "…", "source": "jira", "link": "https://…", "lines": ["…"]}],
+              "send": {"to": "…", "suggest": ["…"], "review": false}}],
     "digests": [{"source": "slack|jira|confluence", "name": "#pm-team", "link": "https://…", "decisions": ["…"], "open": ["…"], "goals": ["…"]}],
     "places": [{"source": "slack|jira|confluence", "name": "#pm-team", "link": "https://…"}],
     "memory": {"from": "YYYY-MM-DD", "to": "YYYY-MM-DD",

package/workspace/test-lists/today-act-prepare.json

@@ -0,0 +1,5 @@
+{
+  "_comment": "initiative today-act-prepare: the PM's marks on today's items and meetings (lib/day-marks.js, the mark and draft routes).",
+  "modules": ["day-marks.test.js"],
+  "seconds": { "day-marks.test.js": 8 }
+}