create-pmos 0.53.0 → 0.53.1

package/workspace/server.js

@@ -94,6 +94,8 @@ const judgmentLib = require('./lib/judgment');
 const proactiveLib = require('./lib/proactive');
 const learnLib = require('./lib/learn');
 const briefLib = require('./lib/brief');
+const goalsLib = require('./lib/goals');
+const todayLib = require('./lib/today');
 const prepareQueue = require('./lib/prepare-queue');
 const harness = require('./lib/harness-parse');
 const transcript = require('./lib/transcript-read');
@@ -3621,6 +3623,21 @@ function prepareTick({ manual = false } = {}) {
 const PRO_SIGNALS = () => path.join(STATE, 'signals.jsonl');
 const PRO_FEEDBACK = () => path.join(STATE, 'proactive-feedback.jsonl');
 const PRO_SETTINGS = () => path.join(STATE, 'proactive-settings.json');
+// today-goals: one goals file per local day, and the newest stored brief (the same read GET /api/proactive/brief makes).
+const GOALS_DIR = () => path.join(STATE, 'goals');
+const goalsCardsMemo = new Map();   // ws -> { at, cards, error }: GET /api/proactive/goals reads Today's cards at most every 30 s
+function readGoalsDay(date) {
+  let raw = null;
+  try { raw = JSON.parse(fs.readFileSync(path.join(GOALS_DIR(), date + '.json'), 'utf8')); } catch { /* none yet */ }
+  return goalsLib.readDay(raw, date);
+}
+function latestBrief() {
+  try {
+    const dir = path.join(STATE, 'briefs');
+    const f = fs.readdirSync(dir).filter((n) => /^\d{4}-\d{2}-\d{2}\.json$/.test(n)).sort().pop();
+    return f ? JSON.parse(fs.readFileSync(path.join(dir, f), 'utf8')) : null;
+  } catch { return null; }
+}
 let proLastScan = 0;
 const PRO_SCAN_EVERY_MS = 10 * 60 * 1000;
 function proSettings() {
@@ -4977,6 +4994,29 @@ async function handleRequest(req, res) {
     res.writeHead(200, { 'Content-Type': 'image/svg+xml', 'Cache-Control': 'max-age=86400' });
     return res.end(svg);
   }
+  // workspace-phone-app: what Add to Home Screen reads, so the phone opens the workspace full screen
+  // with its own icon. The manifest is built here rather than shipped as a file because its colours
+  // are the dark theme's tokens and its start_url must be the bare page: never a ?token= URL, which
+  // would store the secret in the phone's home-screen entry. No service worker, on purpose: this is
+  // live state, and an offline cache would show a stale board as if it were current.
+  if (p === '/manifest.webmanifest') {
+    res.writeHead(200, { 'Content-Type': 'application/manifest+json', 'Cache-Control': 'no-cache' });
+    return res.end(JSON.stringify({
+      name: 'PMOS workspace', short_name: 'PMOS', id: '/', start_url: '/', scope: '/',
+      display: 'standalone', orientation: 'any', background_color: '#090b0c', theme_color: '#090b0c',
+      icons: [
+        { src: '/icons/icon-192.png', sizes: '192x192', type: 'image/png', purpose: 'any' },
+        { src: '/icons/icon-512.png', sizes: '512x512', type: 'image/png', purpose: 'any' },
+        // The mark sits inside the central 62%, so the same image survives an Android maskable crop.
+        { src: '/icons/icon-512.png', sizes: '512x512', type: 'image/png', purpose: 'maskable' },
+      ],
+    }));
+  }
+  // The three icons, by name (an allowlist, like /lib/ above). iOS also asks for /apple-touch-icon.png
+  // at the root unprompted, so that path answers too.
+  if (p === '/icons/icon-192.png' || p === '/icons/icon-512.png' || p === '/icons/apple-touch-icon.png' || p === '/apple-touch-icon.png') {
+    return serveFile(res, path.join(PUB, 'icons', path.basename(p)), 'image/png');
+  }
   // xterm assets straight from node_modules (offline; no CDN)
   if (p === '/vendor/xterm.js') return serveFile(res, path.join(XROOT, 'xterm', 'lib', 'xterm.js'));
   if (p === '/vendor/xterm.css') return serveFile(res, path.join(XROOT, 'xterm', 'css', 'xterm.css'));
@@ -6911,6 +6951,66 @@ async function handleRequest(req, res) {
     if (!w) return json(res, { ok: false, error: 'no workspace' }, 400);
     return json(res, { ok: true, ws: w.id, name: w.name, ...validateLib.readFindings(validationFindingsFile(w)) });
   }
+  /* ── today-goals (G1, G4, G5): the PM's goals for the day, the plan that joins them to the brief and Today, and "plan my
+   *    day". The goals routes write only goals/<date>.json in the state folder. "Plan my day" seeds the morning-brief
+   *    schedule when the repository has none and runs it through fireSchedule, the run-now path. Nothing else starts. ── */
+  if (p === '/api/proactive/goals' && req.method === 'GET') {
+    const now = Date.now();
+    const date = briefLib.localDate(now);
+    const w = getWs(url.searchParams.get('ws'));
+    const day = readGoalsDay(date);
+    const brief = latestBrief();
+    let cards = []; let cardsError = null;
+    // Today's cards are read only when an open goal can take them, and at most once per 30 seconds per repository: the
+    // read is synchronous and heavy on a large repository, and the Today feed itself must not wait behind it.
+    if (w && day.goals.some((x) => x.status === 'open')) {
+      const memo = goalsCardsMemo.get(w.id);
+      if (memo && now - memo.at < 30000) ({ cards, error: cardsError } = memo);
+      else {
+        let sess = []; try { sess = sessionList(); } catch { /* no session cards */ }
+        const t = todayLib.todayFor(w, { stateDir: stateDirFor(w), sessions: sess, registered: (root) => { const x = workspaces.get(wsId(root)); return !!x && path.resolve(x.root) === path.resolve(root); } });
+        if (t.ok) cards = t.cards; else cardsError = t.error;
+        goalsCardsMemo.set(w.id, { at: now, cards, error: cardsError });
+      }
+    }
+    const plan = goalsLib.planDay({ day, brief, cards, now });
+    const sched = readSchedules().find((x) => x.skill === 'morning-brief' && (!w || x.ws === w.id)) || null;
+    return json(res, { ok: true, ws: w ? w.id : null, today: date, plan, cards_error: cardsError, max_goals: goalsLib.MAX_GOALS,
+      schedule: sched ? { id: sched.id, time: sched.time, lastRun: sched.lastRun, lastStatus: sched.lastStatus } : null,
+      note: 'Goals are kept in the workspace state folder on this computer. The plan joins them to the morning brief and Today by goal id or initiative, never by guessing.' });
+  }
+  if (p === '/api/proactive/goals' && req.method === 'POST') {
+    let body = {}; try { body = JSON.parse((await readBody(req)) || '{}'); } catch { return json(res, { ok: false, error: 'invalid JSON body' }, 400); }
+    const now = Date.now();
+    const date = briefLib.localDate(now);
+    const r = goalsLib.edit(readGoalsDay(date), body, { now });
+    if (!r.ok) return json(res, { ok: false, error: r.error }, /no goal with that id/.test(r.error) ? 404 : 400);
+    try { fs.mkdirSync(GOALS_DIR(), { recursive: true }); fs.writeFileSync(path.join(GOALS_DIR(), date + '.json'), JSON.stringify(r.day) + '\n'); }
+    catch (e) { warnWriteFail('goals', e); return json(res, { ok: false, error: 'could not save — nothing changed' }, 500); }
+    return json(res, { ok: true, day: r.day, goal: r.goal });
+  }
+  if (p === '/api/proactive/goals/plan' && req.method === 'POST') {
+    // A PM press: make sure the morning brief is scheduled for this repository, then run it now. The session reads the
+    // goals with `pmos proactive goals` and submits a brief whose items name them.
+    let body = {}; try { body = JSON.parse((await readBody(req)) || '{}'); } catch { return json(res, { ok: false, error: 'invalid JSON body' }, 400); }
+    const w = getWs(body.ws);
+    if (!w) return json(res, { ok: false, error: 'no workspace' }, 400);
+    const open = readGoalsDay(briefLib.localDate(Date.now())).goals.filter((g) => g.status === 'open');
+    if (!open.length) return json(res, { ok: false, error: 'add a goal for today first: the plan is made for your goals' }, 409);
+    let sched = readSchedules().find((x) => x.ws === w.id && x.skill === 'morning-brief');
+    let seeded = false;
+    if (!sched) {
+      if (!taskById('morning-brief', w.root)) return json(res, { ok: false, error: 'the morning-brief skill is not installed for this repository' }, 409);
+      const norm = scheduleLogic.normalizeSchedule({ ...SEED_SETS.brief[0], task: 'morning-brief' });
+      if (!norm.ok) return json(res, { ok: false, error: norm.error }, 500);
+      sched = { id: 'sc-' + Date.now().toString(36) + 'g', ws: w.id, ...norm.schedule, profile: null, lastRun: null, lastStatus: null };
+      sched.nextRun = scheduleLogic.nextRun(sched);
+      const list = readSchedules(); list.unshift(sched); writeSchedules(list); seeded = true;
+    }
+    const result = fireSchedule(sched);
+    return json(res, { ok: !!result.ok, seeded, schedule: { id: sched.id, time: sched.time }, result, goals: open.length,
+      ...(result.ok ? {} : { error: result.reason || 'the morning-brief session did not start' }) }, result.ok ? 200 : 500);
+  }
   /* ── background prepare (D3): plan is read-only; queue records an approval; the runner starts it later ── */
   if (p === '/api/proactive/prepare/plan' && req.method === 'POST') {
     let body = {}; try { body = JSON.parse((await readBody(req)) || '{}'); } catch { return json(res, { ok: false, error: 'invalid JSON body' }, 400); }
@@ -6984,7 +7084,8 @@ async function handleRequest(req, res) {
     const dir = path.join(STATE, 'briefs');
     if (req.method === 'POST') {
       let body = {}; try { body = JSON.parse((await readBody(req)) || '{}'); } catch { return json(res, { ok: false, error: 'invalid JSON body' }, 400); }
-      const v = briefLib.validateBrief(body, { now: Date.now(), settings: proSettings() });
+      const bday = body && typeof body.date === 'string' && /^\d{4}-\d{2}-\d{2}$/.test(body.date) ? body.date : briefLib.localDate(Date.now());
+      const v = briefLib.validateBrief(body, { now: Date.now(), settings: proSettings(), goalIds: readGoalsDay(bday).goals.map((g) => g.id) });
       if (!v.ok) return json(res, { ok: false, error: v.error }, 400);
       try { fs.mkdirSync(dir, { recursive: true }); fs.writeFileSync(path.join(dir, v.brief.date + '.json'), JSON.stringify(v.brief) + '\n'); }
       catch (e) { warnWriteFail('briefs', e); return json(res, { ok: false, error: 'could not save — nothing changed' }, 500); }
@@ -7460,8 +7561,31 @@ function httpGuard(req, res) {
   // sub-resource loads (CSS/JS) or the WS upgrade — so the documented "open http://…/?token=<t>"
   // phone flow (REMOTE.md + startup banner) must reach THIS page-load guard, and every later request
   // rides the cookie we seed just below. presentedToken() resolves all channels. (local hotfix)
+  // workspace-phone-app: the sign-in form posts here. It is the one route an unauthorized peer may
+  // reach, and all it can do is compare a token (constant-time) and, on a match, seed the same
+  // cookie a valid ?token= navigation seeds. The body is capped; nothing about it is logged (D08).
+  const navigation = remoteAccess.isPageNavigation({ method: req.method, accept: req.headers.accept });
+  if (req.method === 'POST' && (req.url || '').split('?')[0] === remoteAccess.AUTH_PATH) {
+    let body = '';
+    req.on('data', (c) => { body += c; if (body.length > 4096) req.destroy(); });
+    req.on('end', () => {
+      if (remoteAccess.tokenMatches(remoteAccess.parseAuthForm(body), TOKEN)) {
+        res.writeHead(303, { Location: '/', 'Set-Cookie': remoteAccess.sessionCookie(TOKEN), 'Cache-Control': 'no-store' });
+        return res.end();
+      }
+      res.writeHead(401, { 'Content-Type': 'text/html; charset=utf-8', 'Cache-Control': 'no-store' });
+      res.end(remoteAccess.signInPage({ failed: true }));
+    });
+    return;
+  }
   if (!remoteAccess.authorize({ remoteAddress: req.socket.remoteAddress,
       presentedToken: remoteAccess.presentedToken(req), expectedToken: TOKEN })) {
+    // A phone's browser gets a page it can act on, not JSON. API calls, scripts and anything else
+    // that is not a page load keep the JSON 401 they had.
+    if (navigation) {
+      res.writeHead(401, { 'Content-Type': 'text/html; charset=utf-8', 'WWW-Authenticate': 'Bearer', 'Cache-Control': 'no-store' });
+      return res.end(req.method === 'HEAD' ? undefined : remoteAccess.signInPage());
+    }
     res.writeHead(401, { 'Content-Type': 'application/json', 'WWW-Authenticate': 'Bearer' });
     res.end(JSON.stringify({ ok: false, error: 'unauthorized' }));
     return;
@@ -7474,8 +7598,14 @@ function httpGuard(req, res) {
     let qTok = null;
     try { qTok = new URL(req.url || '', 'http://localhost').searchParams.get('token'); } catch { /* ignore */ }
     if (qTok && remoteAccess.tokenMatches(qTok.trim(), TOKEN)) {
-      res.setHeader('Set-Cookie',
-        `${remoteAccess.COOKIE_NAME}=${encodeURIComponent(TOKEN)}; HttpOnly; SameSite=Strict; Path=/; Max-Age=604800`);
+      res.setHeader('Set-Cookie', remoteAccess.sessionCookie(TOKEN));
+      // workspace-phone-app: on a page load, redirect to the same URL without the token, so it does
+      // not stay in the address bar, the history, or the start_url of a home-screen install.
+      const clean = navigation ? remoteAccess.stripTokenParam(req.url) : null;
+      if (clean) {
+        res.writeHead(303, { Location: clean, 'Cache-Control': 'no-store' });
+        return res.end();
+      }
     }
   }
   return handleRequest(req, res);
@@ -7667,7 +7797,7 @@ if (require.main === module) {
       // old EADDRINUSE advice told the PM to do, on another port) has to leave the same trace as
       // one started by `pmos` — otherwise the next `pmos` cannot see it and starts a second server.
       try { fs.mkdirSync(STATE, { recursive: true }); fs.writeFileSync(PID_FILE, String(process.pid)); } catch {}
-      for (const line of remoteAccess.startupLines(BIND, PORT)) console.log(line);
+      for (const line of remoteAccess.startupLines(BIND, PORT, { ansi: !!process.stdout.isTTY && !process.env.NO_COLOR })) console.log(line);
     });
   });
 }

package/workspace/skills/morning-brief.skill

@@ -1,20 +1,21 @@
 ---
 name: morning-brief
 label: "Morning brief"
-description: "Prepare today's brief: the calendar, the priorities and what is worth asking. Read-only on every source; it submits the brief to the workspace and sends nothing."
+description: "Prepare today's brief and plan the PM's goals for the day: the calendar, Slack, Jira and Confluence mentions, the priorities and what is worth asking. Read-only on every source; it submits the brief to the workspace and sends nothing."
 run: agent
 agent: claude
 output:
+  - Goals
   - Calendar
   - Priorities
   - Worth asking
   - Sources reached and not reached
 ---
 
-/morning-brief — prepare today's brief for the PM.
+/morning-brief — prepare today's brief for the PM, and plan the goals they set for today.
 
 Rules that always hold:
-1. READ-ONLY on every source. Never send, reply, forward, post, comment, create, edit, accept, decline, transition, label, archive or delete anything in mail, chat, Jira, Confluence, calendar, Wispr Flow or any other source.
+1. READ-ONLY on every source. Never send, reply, forward, post, react, comment, create, edit, accept, decline, transition, label, archive, mark read or delete anything in mail, Slack, Jira, Confluence, calendar, Wispr Flow or any other source.
 2. SETTINGS DECIDE THE SOURCES. Run `pmos proactive settings`. Read a source only if its line under "brief sources" says on. A source that is off is reported as "off". Mail is off unless the PM turned it on.
 3. LIGHT ON CONTENT. Titles, times, names and ids only. Never copy a message body, an attachment, a token or a credential. Skip anything marked private, personal, confidential or HR. At most one short evidence line per item.
 4. NOTHING INVENTED. A source you cannot reach in this session is reported as "not-reached". If nothing is waiting, submit a brief with no items. An honest short brief is correct.
@@ -23,21 +24,26 @@ Rules that always hold:
 
 Procedure:
 1. Run `pmos proactive settings` and `pmos proactive today`. The second lists what the workspace derived from the ledgers. Each of its items may become a priority with source "derived".
+   Then run `pmos proactive goals`. It lists the PM's goals for today, each with its id (g-xxxxxxxx), its status and, if set, an initiative. The goals are what the PM wants done today: plan for them first.
    Then run `pmos proactive learn lessons`. Each line is a preference the PM approved, written from their own feedback. Use it only to decide how confident to be and where an item goes. A lesson never asks you to read another source, to switch a setting on, or to write anything.
 2. Read today's events from the calendar and today's and tomorrow's meeting notes from Wispr Flow, if those sources are on and reachable. Read Jira issues assigned to the PM or due soon, and Confluence pages changed since yesterday, if on and reachable. Read mail only if on: subjects and senders of threads waiting on the PM, no bodies.
-3. For each thing the PM should act on today, write one item: a short title, why it is for today, its source, the initiative id if one applies, who acts (pm or agent), effort (minutes, an-hour, half-day, day), your confidence from 0 to 1 that it belongs on today's list, and one short evidence line. Give a low confidence when you are guessing. The workspace shows an item under 0.5 as "worth asking", not as a priority.
+   Read MENTIONS of the PM since yesterday morning, if the source is on and reachable: Slack messages that @-mention the PM or are direct messages to them; Jira issues and comments that mention the PM; Confluence pages and comments that mention the PM. For each, keep only where it is (channel, issue key, page title), who wrote it, and a one-line paraphrase of what is asked. Never copy the message itself.
+3. PLAN EACH OPEN GOAL. For each open goal, find what moves it today in what you read and in `pmos proactive today`: a meeting where it is decided, a mention that blocks it, an issue or page it needs, a step an agent can prepare. Write each as an item with "goal": "<the goal id>". An agent step names the initiative it advances, so the PM can prepare it from Today. A calendar event that belongs to a goal also gets "goal". If you find nothing for a goal, write nothing for it: the workspace shows that goal as needing a plan. Never invent a step.
+   Then ANTICIPATE: for each other thing the PM should act on today (a mention waiting on them, a meeting to prepare for, an issue due), write one item with no goal.
+   For each item, write: a short title, why it is for today, its source, the initiative id if one applies, who acts (pm or agent), effort (minutes, an-hour, half-day, day), your confidence from 0 to 1 that it belongs on today's list, and one short evidence line. Set "mention": true on an item that comes from a mention of the PM. Give a low confidence when you are guessing. The workspace shows an item under 0.5 as "worth asking", not as a priority.
 4. Write the brief as a JSON file in the scratch folder of this session, in this shape, and nothing else:
    ```
-   {"date": "YYYY-MM-DD", "sources": {"calendar": "read", "wispr": "not-reached", "mail": "off", "jira": "read", "confluence": "read"},
-    "calendar": [{"start": "<ISO date and time>", "end": "<ISO>", "title": "…", "with": "…"}],
-    "items": [{"title": "…", "why_now": "…", "source": "calendar|wispr|mail|jira|confluence|derived", "initiative_id": "<id or omit>", "owner": "pm|agent", "effort": "minutes|an-hour|half-day|day", "confidence": 0.0, "evidence": "…"}],
+   {"date": "YYYY-MM-DD", "sources": {"calendar": "read", "wispr": "not-reached", "mail": "off", "slack": "read", "jira": "read", "confluence": "read"},
+    "calendar": [{"start": "<ISO date and time>", "end": "<ISO>", "title": "…", "with": "…", "goal": "<goal id or omit>"}],
+    "items": [{"title": "…", "why_now": "…", "source": "calendar|wispr|mail|slack|jira|confluence|derived", "initiative_id": "<id or omit>", "goal": "<goal id or omit>", "mention": false, "owner": "pm|agent", "effort": "minutes|an-hour|half-day|day", "confidence": 0.0, "evidence": "…"}],
     "judgment": {"used": false}}
    ```
-   Only report calendar events if calendar is "read". Only give an item a source that is "read" (or "derived").
+   Only report calendar events if calendar is "read". Only give an item a source that is "read" (or "derived"). Only use a goal id that `pmos proactive goals` listed today: the workspace refuses any other.
 5. Run `pmos proactive brief submit --file <that file>`. If it is refused, read the reason, fix the file and submit once more. Do not work around a refusal.
-6. Finish by saying in two lines how many priorities and worth-asking items you submitted and which sources were not reached.
+6. Finish by saying in three lines how many goals have a step and which have none, how many priorities and worth-asking items you submitted, and which sources were not reached.
 
 Output contract — produce EXACTLY these sections in your final message:
+- Goals
 - Calendar
 - Priorities
 - Worth asking

package/workspace/test-files.json

@@ -9,6 +9,7 @@
   ],
   "modules": [
     "proactive.test.js",
+    "goals.test.js",
     "focus.test.js",
     "handoff.test.js",
     "repo-scan.test.js",
@@ -104,6 +105,7 @@
   "seconds": {
     "test.js": 48,
     "proactive.test.js": 4,
+    "goals.test.js": 6,
     "focus.test.js": 1,
     "handoff.test.js": 1,
     "repo-scan.test.js": 1,

package/workspace/test-lists/workspace-launcher.json

@@ -0,0 +1,5 @@
+{
+  "_comment": "workspace-launcher: `pmos launcher on|off|status` (lib/launcher-cli.js).",
+  "modules": ["launcher.test.js"],
+  "seconds": { "launcher.test.js": 2 }
+}

package/workspace/test-lists/workspace-phone-app.json

@@ -0,0 +1,5 @@
+{
+  "_comment": "workspace-phone-app: the tailnet branches of the access guard (sign-in page, /auth, the token-stripping redirect), driven through httpGuard as a library because test.js runs loopback-only.",
+  "modules": ["phone-access.test.js"],
+  "seconds": { "phone-access.test.js": 3 }
+}