create-pmos 0.30.1 → 0.31.1

package/workspace/public/pm/tab-doc.js

@@ -316,6 +316,7 @@ function diffBody(tab, raw, text, dirty) {
 /* ── per-tab state that is DOM, not data ───────────────────────────────────────────────────── */
 
 const boxes = new Map();      // tab id -> the persistent textarea for that tab
+const normNote = new Map();   // tab id -> what the last `normalize` click did, in words
 
 function editBox(tab) {
   let ta = boxes.get(tab.id);
@@ -336,6 +337,7 @@ function editBox(tab) {
 /** Release what a closed doc tab held. Called by panel-tabs.js when the tab goes away. */
 export function disposeDoc(id) {
   boxes.delete(id);
+  normNote.delete(id);
   frames.delete(id);
   scrollers.delete(id);
 }
@@ -373,15 +375,44 @@ export function mountDoc(host, tab) {
     hover: 'border-color:var(--ring)',
   }, 'revert') : null;
 
+  /* ── normalize ────────────────────────────────────────────────────────────────────────────────
+   * The one-click half of markdown-newlines. It writes the normalized text into the BUFFER, never
+   * to disk: the pane goes dirty, `diff` shows exactly which lines were joined, and `save` is the
+   * existing write path with its existing refusal on a changed base. So a repair the PM did not
+   * want is one `revert` away, and no new way to write a file was added to get it.
+   *
+   * A document that is already normalized reports that and leaves the buffer alone — marking a
+   * clean file dirty for nothing is how a tool teaches you to ignore its dirty flag. */
+  const norm = typeof window !== 'undefined' ? window.MdNormalize : null;
+  const canNormalize = !!(norm && typeof norm.normalize === 'function')
+    && !isHtmlDoc(tab.path) && !isReference(tab.path) && !unread.has(tab.path);
+  const normBtn = canNormalize ? el('button', {
+    onClick: () => {
+      const r = norm.normalize(text);
+      normNote.set(tab.id, r.changed
+        ? r.joins + ' line(s) joined' + (r.blanks ? ', ' + r.blanks + ' blank inserted' : '')
+        : 'already normalized — every paragraph is one line');
+      if (!r.changed) { setState({}); return; }
+      setState((s) => ({ docEdits: { ...s.docEdits, [tab.path]: r.text } }));
+    },
+    style: 'margin-left:8px;font-family:var(--mono);font-size:10.5px;padding:4px 10px;min-height:26px;background:var(--secondary);border:1px solid var(--border);color:var(--muted-foreground)',
+    hover: 'border-color:var(--ring)',
+    title: 'Join hard-wrapped paragraphs into one line each — what a Jira issue, a Google Doc or any'
+      + ' plain-text destination needs. Writes the buffer, not the file: read it in diff, then save.',
+  }, 'normalize') : null;
+
   // The one place a real-mode refusal is reported: the same line that carries the dirty flag, so
-  // a save that did not happen cannot read as one that did.
-  const dirtyLabel = err ? 'not saved — ' + err : (dirty ? '● modified — unsaved' : 'saved on disk');
+  // a save that did not happen cannot read as one that did. The normalize note shares the line for
+  // the same reason — a repair that changed nothing must say so where the PM is already looking.
+  const note = normNote.get(tab.id);
+  const dirtyLabel = err ? 'not saved — ' + err
+    : (dirty ? '● modified — unsaved' : (note || 'saved on disk'));
   const dirtyColor = err ? 'var(--destructive)' : (dirty ? 'var(--warning)' : 'var(--muted-foreground)');
 
   const modeBar = el('div', {
     style: 'flex:none;display:flex;gap:2px;align-items:center;padding:6px 10px;border-bottom:1px solid var(--border);background:var(--background)',
   },
-    modeBtns, saveBtn, revertBtn,
+    modeBtns, normBtn, saveBtn, revertBtn,
     el('span', { style: 'margin-left:auto;font-family:var(--mono);font-size:10px;color:' + dirtyColor }, iv(dirtyLabel)),
   );
 

package/workspace/server.js

@@ -3760,6 +3760,10 @@ async function handleRequest(req, res) {
   // /pm/ module graph below, and one front end is the point. A stray <script src="/app.js"> now
   // 404s loudly rather than silently resurrecting a second, diverging surface.
   if (p === '/lib/preview-kind.js') return serveFile(res, path.join(__dirname, 'lib', 'preview-kind.js'));
+  // The newline normalizer the doc tab's `normalize` action runs, and the same file
+  // scripts/md-newlines.js requires — one implementation, so the button and the gate can never
+  // disagree about what a normalized document is (markdown-newlines).
+  if (p === '/lib/md-normalize.js') return serveFile(res, path.join(__dirname, 'lib', 'md-normalize.js'));
   if (p === '/lib/layout.js') return serveFile(res, path.join(__dirname, 'lib', 'layout.js'));
   if (p === '/lib/mobile-nav.js') return serveFile(res, path.join(__dirname, 'lib', 'mobile-nav.js'));
   if (p === '/lib/session-state.js') return serveFile(res, path.join(__dirname, 'lib', 'session-state.js'));
@@ -4644,10 +4648,23 @@ async function handleRequest(req, res) {
       action: body.action, run_id: body.run_id, initiative_id: body.initiative_id,
       // `accepted` is the kit's field (D54) — what metrics.py counts for the north star and
       // throughput. Only the explicit Acceptance action sets it; `approve` is a Review-gate
-      // disposition and leaves it unset. `pm_label` is deliberately NOT derived here: κ labels
-      // are the PM's own word (D40 — never manufacture calibration data from a UI click).
+      // disposition and leaves it unset. `pm_label` is still never DERIVED here: κ labels are the
+      // PM's own word (D40 — never manufacture calibration data from a UI click).
+      //
+      // But refusing to derive it is not the same as refusing to CARRY it, and the two were
+      // conflated. This endpoint is the PM's real click path under D62/D64, so every acceptance it
+      // wrote was unlabeled — 38 of 42 distinct runs in the live ledger — and κ stayed degenerate
+      // because tn and fp had nowhere to come from. `record-acceptance.js` requires the label and
+      // nothing routes the PM to it. So the label is accepted from the client when the PM states
+      // it, validated against the same closed set, and simply absent when they do not.
       accepted: body.action === 'accept' ? true : body.action === 'return' ? false : undefined,
+      ...(body.pm_label === 'pass' || body.pm_label === 'fail' ? { pm_label: body.pm_label } : {}),
       note: body.note || '', workspace: w ? w.name : null, root: w ? w.root : null, pm: true };
+    // A malformed label is refused rather than dropped. Silently discarding it would put the row in
+    // the unlabeled pile while the PM believed they had labelled it — the same shape as inferring.
+    if (body.pm_label !== undefined && body.pm_label !== 'pass' && body.pm_label !== 'fail') {
+      return json(res, { ok: false, error: "pm_label must be 'pass' or 'fail' — it answers whether the EVALUATOR was right (D40), separately from whether the work goes in (D12)" }, 400);
+    }
     // Record into the workspace's OWN state, creating the kit layout for a PMOS-shaped repo.
     // If it can't be resolved, still record — but in the server's state/, and say so in the
     // response so the client can be honest about where the decision landed.
@@ -4677,7 +4694,14 @@ async function handleRequest(req, res) {
         fs.writeFileSync(nf, JSON.stringify(needs.filter((n) => n.run_id !== body.run_id)));
       }
     } catch (e) { warnWriteFail('needs.json (clearing the accepted need)', e); }
-    return json(res, { ok: true, recorded: rec, sink, fallback });
+    /* `pm_label_recorded` is reported so the surface can show the gap rather than the PM having to
+     * know it exists. An acceptance with no label is legal and always will be — the PM's attention
+     * is the scarce thing — but it is the reason κ is degenerate, and a gap nobody is shown is a gap
+     * nobody closes. Reported, never enforced. */
+    return json(res, {
+      ok: true, recorded: rec, sink, fallback,
+      pm_label_recorded: rec.pm_label === 'pass' || rec.pm_label === 'fail',
+    });
   }
   if (p === '/api/doc/save' && req.method === 'POST') {
     // The editor's save (workspace-doc-editor R3/R4). The ONLY write path on this surface, and it is