create-pmos 0.214.0 → 0.215.0

package/workspace/public/pm/pm-work-view.js

@@ -33,7 +33,7 @@ import { renderCase } from './c3-case.js';
 import { makeXp, attachExpand } from './c3-expand.js';
 import { attachSwipe } from './c3-swipe.js';
 import { toast } from './c3-toast.js';
-import { openSheet } from './c3-sheet.js';
+import { openSheet, closeSheet } from './c3-sheet.js';
 import { c3btn } from './page-agent.js';
 import { onBriefing, loadBriefing } from './shell-ticker.js';
 import { reviewSection } from './c3-brief.js';
@@ -724,7 +724,9 @@ const AG = {
   openSession: 'Open the session',
   willDo: 'What the agent will do: ', change: 'Change what the agent does', askLabel: 'What the agent will do',
   draftIt: 'Let the agent draft this', tryAgain: 'Try again', post: (k) => 'Post it to ' + k, back: 'Send it back with a note', keepDraft: 'Keep it as a draft',
-  noteLabel: 'Tell the agent what to change', openDraft: 'Open the draft', draftSheet: (k) => 'Draft for ' + k, stop: 'stop',
+  noteLabel: 'Tell the agent what to change', openDraft: 'Open the draft', editDraft: 'Edit the draft', edited: 'Edited by you. Post sends your text.',
+  saveDraft: 'Save the draft', cancel: 'Cancel', savedDraft: (w) => `Saved. Post sends your text to ${w}.`, savedMine: 'Saved. The draft stays here.', bodyLabel: 'The draft',
+  doneIt: 'Mark it done', doneFx: 'Closes the item. Nothing is posted', doneToast: 'Done. Nothing was posted.', draftSheet: (k) => 'Draft for ' + k, stop: 'stop',
   handed: (w) => `Handed to the agent. Nothing goes to ${w} until you post it.`, stopped: 'Stopped. Nothing was kept.', kept: 'Kept as a draft. Post it when you are ready.',
   posting: 'Approved. A session posts exactly this text.', sentBack: 'Sent back with your note. The agent drafts it again.', retried: 'The agent tries again.',
   needNote: 'Say what to change first: type a note, then send it back.', link: 'Open what was posted',
@@ -785,6 +787,7 @@ function agentCase(inst, item, L) {
     const d = a.draft || {};
     quote = d.body || ''; sit = AG.sitReady('', w);
     if (d.summary) chg.push(['doc', d.summary, 'draft']);
+    if (d.edited_at) chg.push(['edit', AG.edited, '']);
     if (a.revisions) chg.push(['reply', 'Redrafted after your note' + (a.revisions > 1 ? 's (' + a.revisions + ')' : ''), '']);
     outbox = true; cta = 'Hold to post';
     const note = el('input', { type: 'text', placeholder: AG.noteLabel, 'aria-label': AG.noteLabel, 'data-pm-agent-note-in': item.id, autocomplete: 'off' });
@@ -794,16 +797,18 @@ function agentCase(inst, item, L) {
       isMine(item) ? null : o('post', AG.post(k), [fx('lock', 'Outward: exactly this text', 'warn'), fx('out', 'Goes to ' + w + ' as you', 'warn')], () => agentPress(inst, '/api/my-work/decide', { item: item.id, action: 'approve' }, AG.posting), { outward: true }),
       o('back', AG.back, [fx('reply', 'The agent drafts it again', 'ok')], back),
       o('keep', AG.keepDraft, [fx('check', 'Nothing leaves PMOS', 'ok')], () => say({ text: isMine(item) ? AG.keptMine : AG.kept, timeout: 3000 })),
+      o('done', AG.doneIt, [fx('check', AG.doneFx, 'ok')], (r) => doneAct(inst, item, r, AG.doneToast)),
     ].filter(Boolean);
     const noteBox = el('div', { class: 'form wk-agent-ask', 'data-pm-agent-note': item.id }, note); noteBox.hidden = inst.picks.get(item.id) !== 'back';
-    extras.push(el('div', { class: 'chips2' }, c3btn('chip2 lk', { 'data-pm-agent-draft': item.id }, [c3ic('eye', 'sm'), AG.openDraft], () => openDraft(item))));
+    extras.push(el('div', { class: 'chips2' }, c3btn('chip2 lk', { 'data-pm-agent-draft': item.id }, [c3ic('eye', 'sm'), AG.openDraft], () => openDraft(item, inst)),
+      c3btn('chip2 lk', { 'data-pm-agent-edit': item.id }, [c3ic('edit', 'sm'), AG.editDraft], () => openDraft(item, inst, true))));
     after = noteBox;
   } else if (a.state === 'sending') {
     sit = AG.sitSending(k);
   } else if (a.state === 'sent') {
     sit = AG.sitSent(a.sent && a.sent.at ? hhmm(a.sent.at) : '', w);
     opts = L.opts.map((x) => ({ ...x }));
-    if (a.draft && a.draft.body) extras.push(el('div', { class: 'chips2' }, c3btn('chip2 lk', { 'data-pm-agent-draft': item.id }, [c3ic('eye', 'sm'), AG.openDraft], () => openDraft(item)),
+    if (a.draft && a.draft.body) extras.push(el('div', { class: 'chips2' }, c3btn('chip2 lk', { 'data-pm-agent-draft': item.id }, [c3ic('eye', 'sm'), AG.openDraft], () => openDraft(item, inst)),
       a.sent && a.sent.link ? el('a', { class: 'chip2 lk', href: a.sent.link, target: '_blank', rel: 'noopener noreferrer' }, c3ic('out', 'sm'), AG.link) : null));
   }
   if (opts.length) opts[0].rec = 1;
@@ -817,14 +822,35 @@ function openAgentSession(id, item) {
   try { window.dispatchEvent(new CustomEvent('pmos:open-session', { detail: { id, name: 'Job · ' + (item.key || item.title || '') } })); } catch { /* no event */ }
 }
 
-function openDraft(item) {
+/* The agent's draft in a sheet. A draft that waits for the PM can be edited there (amendment 13): Save keeps the PM's text
+ * as the draft, so Post sends exactly that text. */
+function openDraft(item, inst, editing) {
   const a = item.agent || {}; const d = a.draft || {};
+  const canEdit = !!inst && a.state === 'ready';
+  const area = el('textarea', { class: 'wk-agent-edit', rows: '18', 'aria-label': AG.bodyLabel, 'data-pm-agent-edit-in': item.id });
+  area.value = d.body || '';
+  const save = async () => {
+    const v = area.value.trim();
+    if (!v) { say({ text: 'The draft cannot be empty. Send it back with a note instead.', timeout: 3500 }); area.focus(); return; }
+    const r = await pmPost('/api/my-work/decide', { item: item.id, action: 'edit', body: v });
+    if (!r || !r.ok) { say({ text: (r && r.error) || COPY.saveError, tone: 'error' }); return; }
+    closeSheet();
+    say({ text: isMine(item) ? AG.savedMine : AG.savedDraft(whereOf(item)), timeout: 4000 });
+    await load(inst);
+  };
+  const text = editing && canEdit
+    ? el('div', { class: 'wk-agent-editbox' }, area, el('div', { class: 'chips2' },
+      button({ label: AG.saveDraft, variant: 'primary', size: 'sm', onClick: save, attrs: { 'data-pm-agent-save': item.id } }),
+      button({ label: AG.cancel, variant: 'outline', size: 'sm', onClick: () => openDraft(item, inst, false) })))
+    : el('div', { class: 'case wk-agent-body' }, el('p', { class: 'sit' }, d.body || ''));
   const body = el('div', { class: 'wk-agent-sheet' },
-    el('div', { class: 'chips' }, el('span', { class: 'tag' }, a.state === 'sent' ? 'posted' : 'draft'), item.key ? el('span', { class: 'chip2' }, c3ic('org', 'sm'), (item.origin === 'jira' ? 'Jira ' : '') + item.key) : null),
+    el('div', { class: 'chips' }, el('span', { class: 'tag' }, a.state === 'sent' ? 'posted' : d.edited_at ? 'draft · edited by you' : 'draft'), item.key ? el('span', { class: 'chip2' }, c3ic('org', 'sm'), (item.origin === 'jira' ? 'Jira ' : '') + item.key) : null),
     d.summary ? el('p', { class: 'dim wk-agent-sum' }, d.summary) : null,
-    el('div', { class: 'case wk-agent-body' }, el('p', { class: 'sit' }, d.body || '')),
+    text,
     el('div', { class: 'fold' }, c3ic('info', 'sm'), ' ' + (a.state === 'sent' ? 'This is the text that was posted.' : 'Nothing is in ' + whereOf(item) + ' yet. Post it from the item, after you read it.')));
-  openSheet({ title: AG.draftSheet(item.key || item.title), icon: 'doc', body });
+  const actions = canEdit && !editing ? [c3btn('chip2 lk', { 'data-pm-agent-edit-sheet': item.id }, [c3ic('edit', 'sm'), AG.editDraft], () => openDraft(item, inst, true))] : null;
+  openSheet({ title: AG.draftSheet(item.key || item.title), icon: 'doc', body, actions });
+  if (editing && canEdit) { try { area.focus(); } catch { /* not focusable yet */ } }
 }
 
 /** The case file element of an item: c3-case.js plus what is Work's own (offline work, the shared actions, the steps, the agent tray, the edit fields). */
@@ -840,7 +866,7 @@ function caseFile(inst, item, lens) {
   });
   root.setAttribute('data-pm-case', item.id);
   if (!item.mock_row) {   // real items carry no confidence figure: never show a made-up percentage
-    root.querySelectorAll('.opt .rk').forEach((n) => { n.replaceChildren(c3ic('spark', 'sm'), 'Suggested'); n.removeAttribute('title'); });
+    root.querySelectorAll('.opt .rk').forEach((n) => { if (n.childNodes.length) n.replaceChildren(c3ic('spark', 'sm'), 'Suggested'); else n.remove(); n.removeAttribute('title'); });
     root.querySelectorAll('.opt .conf').forEach((n) => n.remove());
   }
   const extras = [];
@@ -863,7 +889,7 @@ function caseFile(inst, item, lens) {
       c3ib('Speak is off on this line: nothing on this page records. Type the reply here.', 'mic', { 'data-off': '', onclick: () => say({ text: 'The microphone needs the app. Nothing was recorded: type the reply here.', timeout: 4200 }) }, 'sm'),
       c3ib('Close the reply', 'x', { onClick: () => { inst.trays.delete(item.id); draw(inst); } }, 'sm')));
   }
-  const showSteps = !(rs && rs.phase) && item.kind !== 'offline' && !(item.agent && !item.mock_row && item.agent.state !== 'sent' && !isMine(item)) && (inst.planning.has(item.id) || (item.steps || []).length || (!agent && (!item.mock_row || item.src === 'You')));
+  const showSteps = !(rs && rs.phase) && item.kind !== 'offline' && !(item.agent && !item.mock_row && item.agent.state !== 'sent' && !isMine(item) && !(item.steps || []).length) && (inst.planning.has(item.id) || (item.steps || []).length || (!agent && (!item.mock_row || item.src === 'You')));
   if (showSteps) extras.push(stepsBlock(inst, item));
   const anchor = root.querySelector('.c3ag') || root.querySelector('.sit');
   if (anchor) anchor.after(...extras); else root.prepend(...extras);
@@ -1227,7 +1253,7 @@ function jobNewCase(inst, st, close) {
     if (r) { say({ text: 'Job created. Add work to it by saying which job it serves.', timeout: 3000 }); close(); await load(inst); }
   } });
   if (!demo) {
-    root.querySelectorAll('.opt .rk').forEach((n) => { n.replaceChildren(c3ic('spark', 'sm'), 'Suggested'); n.removeAttribute('title'); });
+    root.querySelectorAll('.opt .rk').forEach((n) => { if (n.childNodes.length) n.replaceChildren(c3ic('spark', 'sm'), 'Suggested'); else n.remove(); n.removeAttribute('title'); });
     root.querySelectorAll('.opt .conf').forEach((n) => n.remove());
   }
   root.querySelector('.sit').after(el('div', { class: 'c3jf' }, nameIn ? field('Job', nameIn) : null, ...['when', 'want', 'so'].map((k, i) => field(k === 'when' ? 'When' : k === 'want' ? 'I want' : 'So', inputs[i]))));

package/workspace/public/pm/tab-term.js

@@ -1098,6 +1098,15 @@ export async function typeIntoSession(id, text) {
   return send({ t: 'input', id, data: '\r' });
 }
 
+/** Keys typed into a session as they are, with no Enter after them: a menu choice ('1') or Esc ('\x1b') for a running agent.
+ * The same frame and socket as typeIntoSession. Returns false when nothing was sent. */
+export async function pressKeys(id, data) {
+  if (FIXTURE || !id || !data) return false;
+  connect();
+  for (let i = 0; i < 50 && !socketOpen(); i++) await new Promise((r) => setTimeout(r, 100));
+  return send({ t: 'input', id, data });
+}
+
 /**
  * End a running session, by id — the `＋ session` chooser's one destructive action.
  *

package/workspace/server.js

@@ -2939,22 +2939,41 @@ function txFound(s, now = Date.now()) {
 }
 // console3's session conversation: the PM's prompts and the agent's words from the transcript (transcript-read.readConversation).
 // Re-parsed only when the file moves; `stamp` lets the page skip a redraw when nothing changed. Read-only and local.
+// `state` says what the page can show: 'conv' (a conversation), 'shell' (a shell with no agent in it yet), 'unlinked' (an agent
+// whose record cannot be found or read), 'other' (an agent that keeps no Claude transcript). `ask` is Claude Code's permission
+// prompt while it is on the pane's screen (permissionAsk).
 function sessionConversation(s) {
-  if (s.agent !== 'claude' && s.agent !== 'shell') return { messages: [], missing: 'Only Claude sessions show a conversation here.' };
+  if (s.agent !== 'claude' && s.agent !== 'shell') return { messages: [], state: 'other', missing: 'Only Claude sessions show a conversation here.' };
   const found = txFound(s);
   if (found.missing) {
-    if (s.agent === 'shell' && /wrote no session record/.test(found.missing)) return { messages: [], missing: 'No agent is running in this shell yet.' };
-    return { messages: [], missing: found.missing };
+    if (s.agent === 'shell' && /wrote no session record/.test(found.missing)) return { messages: [], state: 'shell', missing: 'No agent is running in this shell yet.' };
+    return { messages: [], state: 'unlinked', missing: found.missing };
   }
   let stamp = null;
   try { const st = fs.statSync(found.file); stamp = `${st.size}:${st.mtimeMs}`; } catch {}
-  if (s.conv && s.convStamp === stamp) return s.conv;
-  const c = transcript.readConversation(found.file, scrub);
-  const h = transcriptHarness(s);
-  c.turn = h && h.turn ? h.turn : null;
-  c.stamp = stamp;
-  s.conv = c; s.convStamp = stamp;
-  return c;
+  let c = s.conv;
+  if (!(c && s.convStamp === stamp)) {
+    c = transcript.readConversation(found.file, scrub, transcript.CONV_LIMIT, s.root);
+    c.state = 'conv';
+    c.stamp = stamp;
+    s.conv = c; s.convStamp = stamp;
+  }
+  // whose turn comes from the harness read, which has its own re-read floor: taken on every call, so a turn that the floor
+  // held back shows on the next poll even when the file has not moved since
+  const h = transcriptHarness(s) || {};
+  const out = { ...c, turn: h.turn || null, openCall: h.openCall ? h.openCall.verb : null, model: h.model || null };
+  // the prompt is on the screen, not in the transcript: read it only while a tool call is open
+  const ask = out.turn === 'tool' ? paneAsk(s) : null;
+  return ask ? { ...out, ask } : out;
+}
+// The pane's visible screen, plain text, read at most once every 1.5s per session (a tmux capture is a blocking spawn).
+function paneAsk(s, now = Date.now()) {
+  if (!s.tmux || !TMUX) return null;
+  if (s.askAt && now - s.askAt < 1500) return s.ask || null;
+  s.askAt = now;
+  const r = tmuxCtl(['capture-pane', '-p', '-t', s.tmux]);
+  s.ask = r.status === 0 && r.stdout ? transcript.permissionAsk(r.stdout, scrub) : null;
+  return s.ask;
 }
 function transcriptHarness(s) {
   if (s.state === 'exited') return { missing: { all: 'the session has exited' } };
@@ -6682,9 +6701,10 @@ async function handleRequest(req, res) {
   if (p === '/api/sessions/conversation' && req.method === 'GET') {
     const sess = sessions.get(String(url.searchParams.get('id') || ''));
     if (!sess) return json(res, { ok: false, error: 'no such session' }, 404);
-    if (sess.state === 'exited') return json(res, { ok: true, id: sess.id, messages: [], missing: 'The session has ended.', turn: null, stamp: null });
+    if (sess.state === 'exited') return json(res, { ok: true, id: sess.id, agent: sess.agent, messages: [], state: 'ended', missing: 'The session has ended.', turn: null, stamp: null });
     const c = sessionConversation(sess);
-    return json(res, { ok: true, id: sess.id, messages: c.messages, missing: c.missing || null, turn: c.turn || null, stamp: c.stamp || null });
+    return json(res, { ok: true, id: sess.id, agent: sess.agent, messages: c.messages, state: c.state || null, missing: c.missing || null, turn: c.turn || null,
+      openCall: c.openCall || null, model: c.model || null, ask: c.ask || null, stamp: c.stamp || null });
   }
   if (p === '/api/sessions/transcript' && req.method === 'GET') {
     const sess = sessions.get(String(url.searchParams.get('id') || ''));

package/workspace/skills/day-task.skill

@@ -36,6 +36,7 @@ Procedure:
 4. If MODE is send:
    a. The task is approved. Read the approved draft and its link in the output of `day show`. The approved draft is the only text you may send. Do not read it as a draft to improve.
       A draft whose summary starts "The PM's own" was written by the PM in the Your day card. Post it exactly as written, as the PM, to the place the summary and the link name. Do not add a greeting, a signature or a line of your own.
+      If `day show` prints "edited by the PM", the PM changed the draft in Work. The body is the PM's text. Post it exactly as written, the same way.
    b. Do the one outward step the summary names, with the connector that fits, to the place the link names. Examples: post the approved reply in the linked Slack thread, add the approved comment to the linked Jira issue, reply to the linked mail thread. If the summary names more than one step, do only the first and report the rest with `day fail`.
    c. If the place does not match the link, the thread is closed, or the connector is not available, do not try another route. Run `pmos proactive day fail TASK --reason "<what stopped it>"`.
    d. When it is done, run `pmos proactive day sent TASK --link <URL of what you posted or sent>`. Leave out `--link` only if the connector returns none.

package/workspace/test-files.json

@@ -299,7 +299,7 @@
     "pm-portfolio-inline-test.js": 15,
     "settings-store.test.js": 1,
     "c3-settings-test.js": 25,
-    "c3-sessions-panel-test.js": 20,
+    "c3-sessions-panel-test.js": 70,
     "c3-updates-test.js": 20,
     "c3-quiet-test.js": 30,
     "c3-phone-model.test.js": 1,