create-pmos 0.10.1 → 0.11.1

package/workspace/lib/layout.js

@@ -31,15 +31,17 @@
 
   const SIDE_MIN = 160, SIDE_MAX = 520;
   const READ_MIN = 280, READ_MAX = 1000;
+  const LIB_MIN = 15, LIB_MAX = 80;                       // the library/document divider, percent
   const BOTTOM_H = 300;                                   // the reader's height when docked bottom
+  const LIB_DEFAULT = 46;
 
   // `review` is byte-for-byte the arrangement that shipped before this feature (R2): a PM who
   // never opens the layout control must see no change at all.
   const STOCK = [
-    { id: 'focus',   name: 'focus',   key: 1, side: 'off',  reader: 'off',    split: 'off', sideW: 262, readW: 400 },
-    { id: 'read',    name: 'read',    key: 2, side: 'left', reader: 'left',   split: 'off', sideW: 214, readW: 760 },
-    { id: 'compare', name: 'compare', key: 3, side: 'left', reader: 'off',    split: 'on',  sideW: 214, readW: 400 },
-    { id: 'review',  name: 'review',  key: 4, side: 'left', reader: 'right',  split: 'off', sideW: 262, readW: 400 },
+    { id: 'focus',   name: 'focus',   key: 1, side: 'off',  reader: 'off',    split: 'off', sideW: 262, readW: 400, libSplit: LIB_DEFAULT },
+    { id: 'read',    name: 'read',    key: 2, side: 'left', reader: 'left',   split: 'off', sideW: 214, readW: 760, libSplit: LIB_DEFAULT },
+    { id: 'compare', name: 'compare', key: 3, side: 'left', reader: 'off',    split: 'on',  sideW: 214, readW: 400, libSplit: LIB_DEFAULT },
+    { id: 'review',  name: 'review',  key: 4, side: 'left', reader: 'right',  split: 'off', sideW: 262, readW: 400, libSplit: LIB_DEFAULT },
   ];
   const DEFAULT_ID = 'review';
   const STOCK_IDS = STOCK.map((l) => l.id);
@@ -86,6 +88,11 @@
       split: oneOf(r.split, SPLIT, base ? base.split : 'off'),
       sideW: Math.round(clamp(num(r.sideW, base ? base.sideW : 262), SIDE_MIN, SIDE_MAX)),
       readW: Math.round(clamp(num(r.readW, base ? base.readW : 400), READ_MIN, READ_MAX)),
+      // the library/document divider. It lives IN the tuple rather than in localStorage because R8
+      // promises to carry it across the upgrade and dimension 1 counts it as "nothing lost" — a
+      // global client key can satisfy neither: it is not per-workspace, and it goes on being read
+      // from the pre-feature store on every boot, which R8 explicitly forbids.
+      libSplit: Math.round(clamp(num(r.libSplit, base ? base.libSplit : LIB_DEFAULT), LIB_MIN, LIB_MAX) * 10) / 10,
       folds: folds(r.folds),
       lastUsedAt: Math.max(0, Math.round(num(r.lastUsedAt, 0))),
     };
@@ -140,16 +147,26 @@
   }
 
   /* A layout that hides every pane is legal (`focus` is exactly that) — but a layout the PM
-     cannot get OUT of is not. The header control is always rendered, so the only real dead end
-     would be a template with no terminal track; assert it here so a future edit cannot introduce
-     one silently (rubric dimension 1, checklist item 4). */
+     cannot get OUT of is not.
+
+     HONEST SCOPE, and read this before trusting it: every branch of gridFor() unconditionally
+     emits a `term` cell, so this can only fail if someone edits gridFor. It is a change-detector
+     for that one function — NOT evidence for rubric dimension 1's checklist item 4. A Review-Gate
+     evaluator fuzzed 38,416 layouts through it for zero failures and correctly called it vacuous.
+     The property item 4 actually names — the control that un-hides a pane is itself always
+     reachable — is a fact about the DOM (the chip lives in `.bar`, a grid sibling of `#bodyGrid`,
+     and the position controls in `.lay-pos` can always restore a pane), and it is asserted where
+     it can genuinely fail: ui-test.js walks all twelve side × reader states in a real engine. */
   function hasEscape(l) {
     return gridFor(l).areas.indexOf('term') !== -1;
   }
 
   /* R8 — carry the pre-feature client keys into this workspace's `review` so nobody's tuning is
      lost on upgrade. Reads the five localStorage values the shipped app wrote:
-     rail(on|off) railw(<n>px) libsplit(<n>%) fold-lib(on|off) fold-doc(on|off). */
+     rail(on|off) railw(<n>px) libsplit(<n>%) fold-lib(on|off) fold-doc(on|off).
+     It formerly said "five" and read four — `libsplit` was collected by the caller and dropped
+     here, so R8's promise was false for it and the pre-feature key went on being read at every
+     boot. Review-Gate finding: the comment was the spec, and the code disagreed with it. */
   function migrateLegacy(legacy) {
     const g = (k) => (legacy && typeof legacy === 'object' ? legacy[k] : null);
     const review = stockLayout(DEFAULT_ID);
@@ -157,6 +174,8 @@
     if (railOff) review.reader = 'off';
     const w = num(String(g('railw') || '').replace('px', ''), null);
     if (w !== null) review.readW = Math.round(clamp(w, READ_MIN, READ_MAX));
+    const ls = num(String(g('libsplit') || '').replace('%', ''), null);
+    if (ls !== null) review.libSplit = Math.round(clamp(ls, LIB_MIN, LIB_MAX) * 10) / 10;
     if (g('fold-lib') === 'off') review.folds.lib = false;
     if (g('fold-doc') === 'off') review.folds.doc = false;
     const layouts = stockLayouts().map((l) => (l.id === DEFAULT_ID ? review : l));
@@ -180,7 +199,7 @@
 
   return {
     SIDE, READER, SPLIT, FOLD_KEYS, STOCK_IDS, DEFAULT_ID,
-    SIDE_MIN, SIDE_MAX, READ_MIN, READ_MAX, BOTTOM_H,
+    SIDE_MIN, SIDE_MAX, READ_MIN, READ_MAX, LIB_MIN, LIB_MAX, LIB_DEFAULT, BOTTOM_H,
     isStock, stockLayout, stockLayouts, layout, sanitize, gridFor, hasEscape, migrateLegacy,
     loadAction,
   };

package/workspace/package-lock.json

@@ -1,12 +1,12 @@
 {
   "name": "pmos-workspace",
-  "version": "0.1.0",
+  "version": "0.11.1",
   "lockfileVersion": 3,
   "requires": true,
   "packages": {
     "": {
       "name": "pmos-workspace",
-      "version": "0.1.0",
+      "version": "0.11.1",
       "license": "MIT",
       "dependencies": {
         "@xterm/addon-fit": "^0.11.0",

package/workspace/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pmos-workspace",
-  "version": "0.10.1",
+  "version": "0.11.1",
   "private": true,
   "description": "PMOS Terminal Workspace — local companion hosting real PTYs beside the library and gates (D62)",
   "license": "MIT",