create-platformatic 0.23.1 → 0.24.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "create-platformatic",
-  "version": "0.23.1",
+  "version": "0.24.0",
   "description": "Create platformatic-db interactive tool",
   "repository": {
     "type": "git",
@@ -32,22 +32,23 @@
     "pupa": "^3.1.0",
     "semver": "^7.5.0",
     "undici": "^5.22.0",
-    "@platformatic/config": "0.23.1"
+    "@platformatic/config": "0.24.0"
   },
   "devDependencies": {
     "ajv": "^8.12.0",
     "c8": "^7.13.0",
+    "cross-env": "^7.0.3",
     "dotenv": "^16.0.3",
     "esmock": "^2.2.1",
     "snazzy": "^9.0.0",
     "standard": "^17.0.0",
     "tap": "^16.3.4",
     "yaml": "^2.2.2",
-    "@platformatic/db": "0.23.1",
-    "@platformatic/service": "0.23.1"
+    "@platformatic/db": "0.24.0",
+    "@platformatic/service": "0.24.0"
   },
   "scripts": {
-    "test": "standard | snazzy && NODE_OPTIONS=--loader=esmock c8 --100 tap --no-coverage test/*test.mjs test/*/*test.mjs",
+    "test": "standard | snazzy && cross-env NODE_OPTIONS=\"--loader=esmock --no-warnings\" c8 --100 tap --no-coverage test/*test.mjs test/*/*test.mjs",
     "lint": "standard | snazzy"
   }
 }

package/src/db/create-db.mjs

@@ -144,6 +144,7 @@ async function createDB ({ hostname, database = 'sqlite', port, migrations = 'mi
     const envFileExists = await isFileAccessible('.env', currentDir)
     await appendFile(join(currentDir, '.env'), env)
     await writeFile(join(currentDir, '.env.sample'), env)
+    /* c8 ignore next 5 */
     if (envFileExists) {
       logger.info('Environment file .env found, appending new environment variables to existing .env file.')
     } else {

package/src/service/create-service.mjs

@@ -145,6 +145,7 @@ async function createService ({ hostname, port, typescript = false }, logger, cu
     const envFileExists = await isFileAccessible('.env', currentDir)
     await appendFile(join(currentDir, '.env'), env)
     await writeFile(join(currentDir, '.env.sample'), env)
+    /* c8 ignore next 5 */
     if (envFileExists) {
       logger.info('Environment file .env found, appending new environment variables to existing .env file.')
     } else {

package/test/create-gitignore.test.mjs

@@ -22,7 +22,7 @@ afterEach(() => {
 
 test('creates gitignore file', async ({ end, equal }) => {
   await createGitignore(fakeLogger, tmpDir)
-  equal(log, `Gitignore file ${tmpDir}/.gitignore successfully created.`)
+  equal(log, `Gitignore file ${join(tmpDir, '.gitignore')} successfully created.`)
   const accessible = await isFileAccessible(join(tmpDir, '.gitignore'))
   equal(accessible, true)
 })
@@ -31,5 +31,5 @@ test('do not create gitignore file because already present', async ({ end, equal
   const gitignore = join(tmpDir, '.gitignore')
   writeFileSync(gitignore, 'TEST')
   await createGitignore(fakeLogger, tmpDir)
-  equal(log, `Gitignore file ${tmpDir}/.gitignore found, skipping creation of gitignore file.`)
+  equal(log, `Gitignore file ${join(tmpDir, '.gitignore')} found, skipping creation of gitignore file.`)
 })

package/test/create-package-json.test.mjs

@@ -24,7 +24,7 @@ test('creates package.json file for db project', async ({ equal }) => {
   const version = '1.2.3'
   const fastifyVersion = '4.5.6'
   await createPackageJson('db', version, fastifyVersion, fakeLogger, tmpDir, false)
-  equal(log, `${tmpDir}/package.json successfully created.`)
+  equal(log, `${join(tmpDir, 'package.json')} successfully created.`)
   const accessible = await isFileAccessible(join(tmpDir, 'package.json'))
   equal(accessible, true)
   const packageJson = JSON.parse(readFileSync(join(tmpDir, 'package.json')))
@@ -38,7 +38,7 @@ test('creates package.json file for service project', async ({ equal }) => {
   const version = '1.2.3'
   const fastifyVersion = '4.5.6'
   await createPackageJson('service', version, fastifyVersion, fakeLogger, tmpDir, false)
-  equal(log, `${tmpDir}/package.json successfully created.`)
+  equal(log, `${join(tmpDir, 'package.json')} successfully created.`)
   const accessible = await isFileAccessible(join(tmpDir, 'package.json'))
   equal(accessible, true)
   const packageJson = JSON.parse(readFileSync(join(tmpDir, 'package.json')))
@@ -53,14 +53,14 @@ test('do not create package.json file because already present', async ({ equal }
   const packagejson = join(tmpDir, 'package.json')
   writeFileSync(packagejson, 'TEST')
   await createPackageJson('db', version, fastifyVersion, fakeLogger, tmpDir, false)
-  equal(log, `${tmpDir}/package.json found, skipping creation of package.json file.`)
+  equal(log, `${join(tmpDir, 'package.json')} found, skipping creation of package.json file.`)
 })
 
 test('creates package.json file with TS build', async ({ equal }) => {
   const version = '1.2.3'
   const fastifyVersion = '4.5.6'
   await createPackageJson('db', version, fastifyVersion, fakeLogger, tmpDir, true)
-  equal(log, `${tmpDir}/package.json successfully created.`)
+  equal(log, `${join(tmpDir, 'package.json')} successfully created.`)
   const accessible = await isFileAccessible(join(tmpDir, 'package.json'))
   equal(accessible, true)
   const packageJson = JSON.parse(readFileSync(join(tmpDir, 'package.json')))

package/test/db/create-db.test.mjs

@@ -21,10 +21,11 @@ const moviesMigrationUndo = `
 DROP TABLE movies;
 `
 
+const base = tmpdir()
 let tmpDir
 let log = []
 beforeEach(() => {
-  tmpDir = mkdtempSync(join(tmpdir(), 'test-create-platformatic-'))
+  tmpDir = mkdtempSync(join(base, 'test-create-platformatic-'))
 })
 
 afterEach(() => {

package/test/ghaction-dynamic.test.mjs

@@ -77,7 +77,7 @@ test('do not create gitignore file because already present', async ({ end, equal
   await writeFile(ghaction, 'TEST')
   const workspaceId = '29aa2d07-e1c5-440f-bf3a-cd654d91f7ed'
   await createDynamicWorkspaceGHAction(fakeLogger, workspaceId, env, 'db', tmpDir)
-  equal(log[0], `Github action file ${tmpDir}/.github/workflows/platformatic-dynamic-workspace-deploy.yml found, skipping creation of github action file.`)
+  equal(log[0], `Github action file ${join(tmpDir, '.github', 'workflows', 'platformatic-dynamic-workspace-deploy.yml')} found, skipping creation of github action file.`)
 })
 
 test('creates gh action with a warn if a .git folder is not present', async ({ end, equal }) => {

package/test/ghaction-static.test.mjs

@@ -75,7 +75,7 @@ test('do not create gitignore file because already present', async ({ end, equal
   await writeFile(ghaction, 'TEST')
   const workspaceId = '29aa2d07-e1c5-440f-bf3a-cd654d91f7ed'
   await createStaticWorkspaceGHAction(fakeLogger, workspaceId, env, 'db', tmpDir)
-  equal(log[0], `Github action file ${tmpDir}/.github/workflows/platformatic-static-workspace-deploy.yml found, skipping creation of github action file.`)
+  equal(log[0], `Github action file ${join(tmpDir, '.github', 'workflows', 'platformatic-static-workspace-deploy.yml')} found, skipping creation of github action file.`)
 })
 
 test('creates gh action with a warn if a .git folder is not present', async ({ end, equal }) => {

package/test/service/create-service.test.mjs

@@ -8,10 +8,11 @@ import dotenv from 'dotenv'
 import Ajv from 'ajv'
 import { schema } from '@platformatic/service'
 
+const base = tmpdir()
 let tmpDir
 let log = []
 beforeEach(() => {
-  tmpDir = mkdtempSync(join(tmpdir(), 'test-create-platformatic-'))
+  tmpDir = mkdtempSync(join(base, 'test-create-platformatic-'))
 })
 
 afterEach(() => {

package/test/utils.test.mjs

@@ -1,7 +1,7 @@
 import { test } from 'tap'
 import { randomBetween, sleep, validatePath, getDependencyVersion, findDBConfigFile, findServiceConfigFile, isFileAccessible, isCurrentVersionSupported, minimumSupportedNodeVersions } from '../src/utils.mjs'
 import { mkdtempSync, rmSync, writeFileSync } from 'fs'
-import { tmpdir } from 'os'
+import { tmpdir, platform } from 'os'
 import { join } from 'path'
 import esmock from 'esmock'
 import semver from 'semver'
@@ -122,7 +122,7 @@ test('validatePath', async ({ end, equal, rejects, ok }) => {
     ok(valid)
   }
 
-  {
+  if (platform().indexOf('win') < 0) {
     // not writeable folder
     const valid = await validatePath('/')
     ok(!valid)
@@ -176,19 +176,13 @@ test('minimumSupportedNodeVersions', async ({ equal, not }) => {
 test('isCurrentVersionSupported', async ({ equal }) => {
   const { major, minor, patch } = semver.minVersion(minimumSupportedNodeVersions[0])
   {
-    // v15 major not supported
+    // major - 1 not supported
     const nodeVersion = `${major - 1}.${minor}.${patch}`
     const supported = isCurrentVersionSupported(nodeVersion)
     equal(supported, false)
   }
   {
-    // v17 major not supported
-    const nodeVersion = `${major + 1}.${minor}.${patch}`
-    const supported = isCurrentVersionSupported(nodeVersion)
-    equal(supported, false)
-  }
-  {
-    // v16 minor not supported
+    // minor - 1 not supported
     const nodeVersion = `${major}.${minor - 1}.${patch}`
     const supported = isCurrentVersionSupported(nodeVersion)
     equal(supported, false)
@@ -198,29 +192,24 @@ test('isCurrentVersionSupported', async ({ equal }) => {
     const supported = isCurrentVersionSupported(`${major}.${minor + 2}.${patch}`)
     equal(supported, true)
   }
-  // node version 18 test, to check greater and lesser major version
-  const { major: major18, minor: minor18, patch: patch18 } = semver.minVersion(minimumSupportedNodeVersions[1])
+
+  // node version 19 test, to check greater and lesser major version
+  const { major: major19, minor: minor19, patch: patch19 } = semver.minVersion(minimumSupportedNodeVersions[1])
   {
-    // v17 major not supported
-    const nodeVersion = `${major18 - 1}.${minor18}.${patch18}`
+    // v18.0.0 is not supported
+    const nodeVersion = `${major19 - 1}.${minor19}.${patch19}`
     const supported = isCurrentVersionSupported(nodeVersion)
     equal(supported, false)
   }
   {
-    // v19 is supported
-    const nodeVersion = `${major18 + 1}.${minor18}.${patch18}`
-    const supported = isCurrentVersionSupported(nodeVersion)
-    equal(supported, true)
-  }
-  {
-    // v18 minor not supported
-    const nodeVersion = `${major18}.${minor18 - 2}.${patch18}`
+    // v20 is not supported
+    const nodeVersion = `${major19 + 1}.${minor19}.${patch19}`
     const supported = isCurrentVersionSupported(nodeVersion)
     equal(supported, false)
   }
   {
-    // v18 supported
-    const supported = isCurrentVersionSupported(`${major18}.${minor18 + 1}.${patch18}`)
+    // v19 supported
+    const supported = isCurrentVersionSupported(`${major19}.${minor19 + 1}.${patch19}`)
     equal(supported, true)
   }
   for (const version of minimumSupportedNodeVersions) {