create-plasmic-app 0.0.46 → 0.0.47

package/dist/lib.js

@@ -102,6 +102,7 @@ function create(args) {
         const installResult = yield cpaStrategy.installDeps({
             scheme,
             projectPath: resolvedProjectPath,
+            useTypescript,
         });
         if (!installResult) {
             throw new Error("Failed to install the Plasmic dependency");

package/dist/strategies/gatsby.js

@@ -61,15 +61,26 @@ const gatsbyStrategy = {
         const createCommand = `npx -p create-gatsby create-gatsby ${useTypescript ? "-ts" : ""} -y ${dir}`;
         yield cmd_utils_1.spawnOrFail(`${createCommand}`, parent);
     }),
-    installDeps: ({ projectPath, scheme }) => __awaiter(void 0, void 0, void 0, function* () {
+    installDeps: ({ projectPath, scheme, useTypescript }) => __awaiter(void 0, void 0, void 0, function* () {
         if (scheme === "loader") {
-            return ((yield npm_utils_1.installUpgrade("@plasmicapp/loader-gatsby", {
+            const installedLoader = yield npm_utils_1.installUpgrade("@plasmicapp/loader-gatsby", {
                 workingDir: projectPath,
-            })) &&
-                (yield npm_utils_1.installUpgrade("react-helmet", { workingDir: projectPath })) &&
-                (yield npm_utils_1.installUpgrade("gatsby-plugin-react-helmet", {
+            });
+            const installedHelmet = yield npm_utils_1.installUpgrade("react-helmet", {
+                workingDir: projectPath,
+            });
+            const installedHelmetTypes = !useTypescript ||
+                (yield npm_utils_1.installUpgrade("@types/react-helmet", {
                     workingDir: projectPath,
-                })));
+                    dev: true,
+                }));
+            const installedHelmetPlugin = yield npm_utils_1.installUpgrade("gatsby-plugin-react-helmet", {
+                workingDir: projectPath,
+            });
+            return (installedLoader &&
+                installedHelmet &&
+                installedHelmetPlugin &&
+                installedHelmetTypes);
         }
         else {
             return yield common_1.installCodegenDeps({ projectPath });
@@ -86,7 +97,9 @@ const gatsbyStrategy = {
                 input: fs_1.createReadStream(gatsbyConfigFile),
                 crlfDelay: Infinity,
             });
-            let result = "";
+            // Typescript doesn't accept require.resolve
+            // https://www.gatsbyjs.com/docs/how-to/custom-configuration/typescript/#requireresolve
+            let result = useTypescript ? `import path from "path";\n` : "";
             const pluginConfig = gatsby_1.GATSBY_PLUGIN_CONFIG(projectId, lang_utils_1.ensure(projectApiToken), useTypescript);
             try {
                 for (var rl_1 = __asyncValues(rl), rl_1_1; rl_1_1 = yield rl_1.next(), !rl_1_1.done;) {

package/dist/strategies/types.d.ts

@@ -25,6 +25,7 @@ interface BuildArgs {
 interface InstallArgs {
     scheme: CodeScheme;
     projectPath: string;
+    useTypescript: boolean;
 }
 export interface CPAStrategy {
     create: (args: CreateArgs) => Promise<void>;

package/dist/templates/gatsby.js

@@ -43,10 +43,10 @@ const PlasmicGatsbyPage = ({ data }${file_utils_1.ifTs(ts, ": PlasmicGatsbyPageP
       prefetchedData={plasmicComponents}
     >
       <Helmet>
-        {pageMetadata.title && <title>{pageMetadata.title}</title>}
-        {pageMetadata.title && <meta property="og:title" content={pageMetadata.title} /> }
-        {pageMetadata.description && <meta property="og:description" content={pageMetadata.description} />}
-        {pageMetadata.openGraphImageUrl && <meta property="og:image" content={pageMetadata.openGraphImageUrl} />}
+        {pageMetadata?.title && <title>{pageMetadata.title}</title>}
+        {pageMetadata?.title && <meta property="og:title" content={pageMetadata.title} /> }
+        {pageMetadata?.description && <meta property="og:description" content={pageMetadata.description} />}
+        {pageMetadata?.openGraphImageUrl && <meta property="og:image" content={pageMetadata.openGraphImageUrl} />}
       </Helmet>
       <PlasmicComponent component={pageMeta.displayName} />
     </PlasmicRootProvider>
@@ -74,7 +74,7 @@ const GATSBY_PLUGIN_CONFIG = (projectId, projectApiToken, useTypescript) => `
       },
     ], // An array of project ids.
     preview: false,
-    defaultPlasmicPage: require.resolve("./src/templates/defaultPlasmicPage.${useTypescript ? "tsx" : "jsx"}"),
+    defaultPlasmicPage: ${useTypescript ? "path" : "require"}.resolve("./src/templates/defaultPlasmicPage.${useTypescript ? "tsx" : "jsx"}"),
   },
 },
 {

package/dist/templates/nextjs.js

@@ -61,7 +61,7 @@ export default function PlasmicLoaderPage(props${file_utils_1.ifTs(ts, `: {
       prefetchedData={plasmicData}
       prefetchedQueryData={queryCache}
       pageParams={pageMeta.params}
-      pageQuery={router.query${file_utils_1.ifTs(ts, " as Record<string, string>")}}
+      pageQuery={router.query}
     >
       <PlasmicComponent component={pageMeta.displayName} />
     </PlasmicRootProvider>

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "create-plasmic-app",
-  "version": "0.0.46",
+  "version": "0.0.47",
   "description": "Create Plasmic-powered React apps",
   "main": "./dist/lib.js",
   "types": "./dist/lib.d.ts",

package/src/lib.ts

@@ -97,6 +97,7 @@ export async function create(args: CreatePlasmicAppArgs): Promise<void> {
   const installResult = await cpaStrategy.installDeps({
     scheme,
     projectPath: resolvedProjectPath,
+    useTypescript,
   });
 
   if (!installResult) {

package/src/strategies/gatsby.ts

@@ -36,16 +36,34 @@ const gatsbyStrategy: CPAStrategy = {
     } -y ${dir}`;
     await spawnOrFail(`${createCommand}`, parent);
   },
-  installDeps: async ({ projectPath, scheme }) => {
+  installDeps: async ({ projectPath, scheme, useTypescript }) => {
     if (scheme === "loader") {
-      return (
-        (await installUpgrade("@plasmicapp/loader-gatsby", {
+      const installedLoader = await installUpgrade(
+        "@plasmicapp/loader-gatsby",
+        {
+          workingDir: projectPath,
+        }
+      );
+      const installedHelmet = await installUpgrade("react-helmet", {
+        workingDir: projectPath,
+      });
+      const installedHelmetTypes =
+        !useTypescript ||
+        (await installUpgrade("@types/react-helmet", {
           workingDir: projectPath,
-        })) &&
-        (await installUpgrade("react-helmet", { workingDir: projectPath })) &&
-        (await installUpgrade("gatsby-plugin-react-helmet", {
+          dev: true,
+        }));
+      const installedHelmetPlugin = await installUpgrade(
+        "gatsby-plugin-react-helmet",
+        {
           workingDir: projectPath,
-        }))
+        }
+      );
+      return (
+        installedLoader &&
+        installedHelmet &&
+        installedHelmetPlugin &&
+        installedHelmetTypes
       );
     } else {
       return await installCodegenDeps({ projectPath });
@@ -71,7 +89,9 @@ const gatsbyStrategy: CPAStrategy = {
         input: createReadStream(gatsbyConfigFile),
         crlfDelay: Infinity,
       });
-      let result = "";
+      // Typescript doesn't accept require.resolve
+      // https://www.gatsbyjs.com/docs/how-to/custom-configuration/typescript/#requireresolve
+      let result = useTypescript ? `import path from "path";\n` : "";
       const pluginConfig = GATSBY_PLUGIN_CONFIG(
         projectId,
         ensure(projectApiToken),

package/src/strategies/types.ts

@@ -30,6 +30,7 @@ interface BuildArgs {
 interface InstallArgs {
   scheme: CodeScheme;
   projectPath: string;
+  useTypescript: boolean;
 }
 
 export interface CPAStrategy {

package/src/templates/gatsby.ts

@@ -48,10 +48,10 @@ const PlasmicGatsbyPage = ({ data }${ifTs(ts, ": PlasmicGatsbyPageProps")}) => {
       prefetchedData={plasmicComponents}
     >
       <Helmet>
-        {pageMetadata.title && <title>{pageMetadata.title}</title>}
-        {pageMetadata.title && <meta property="og:title" content={pageMetadata.title} /> }
-        {pageMetadata.description && <meta property="og:description" content={pageMetadata.description} />}
-        {pageMetadata.openGraphImageUrl && <meta property="og:image" content={pageMetadata.openGraphImageUrl} />}
+        {pageMetadata?.title && <title>{pageMetadata.title}</title>}
+        {pageMetadata?.title && <meta property="og:title" content={pageMetadata.title} /> }
+        {pageMetadata?.description && <meta property="og:description" content={pageMetadata.description} />}
+        {pageMetadata?.openGraphImageUrl && <meta property="og:image" content={pageMetadata.openGraphImageUrl} />}
       </Helmet>
       <PlasmicComponent component={pageMeta.displayName} />
     </PlasmicRootProvider>
@@ -84,9 +84,11 @@ export const GATSBY_PLUGIN_CONFIG = (
       },
     ], // An array of project ids.
     preview: false,
-    defaultPlasmicPage: require.resolve("./src/templates/defaultPlasmicPage.${
-      useTypescript ? "tsx" : "jsx"
-    }"),
+    defaultPlasmicPage: ${
+      useTypescript ? "path" : "require"
+    }.resolve("./src/templates/defaultPlasmicPage.${
+  useTypescript ? "tsx" : "jsx"
+}"),
   },
 },
 {

package/src/templates/nextjs.ts

@@ -67,7 +67,7 @@ export default function PlasmicLoaderPage(props${ifTs(
       prefetchedData={plasmicData}
       prefetchedQueryData={queryCache}
       pageParams={pageMeta.params}
-      pageQuery={router.query${ifTs(ts, " as Record<string, string>")}}
+      pageQuery={router.query}
     >
       <PlasmicComponent component={pageMeta.displayName} />
     </PlasmicRootProvider>