create-nx-workspace 23.2.0-beta.3 → 23.2.0-beta.5

package/dist/bin/create-nx-workspace.d.ts

@@ -65,6 +65,10 @@ interface UnknownStackArguments extends BaseArguments {
 }
 type Arguments = NoneArguments | ReactArguments | AngularArguments | VueArguments | NodeArguments | UnknownStackArguments;
 export declare const commandsObject: yargs.Argv<Arguments>;
+export declare function applyEmptyPresetAlias(argv: {
+    preset?: Preset | 'empty';
+    template?: string;
+}): void;
 /** Workspace names must start with a letter. */
 export declare function isValidWorkspaceName(name: string): boolean;
 export declare function validateWorkspaceName(name: string): void;

package/dist/bin/create-nx-workspace.js

@@ -1,6 +1,7 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.commandsObject = void 0;
+exports.applyEmptyPresetAlias = applyEmptyPresetAlias;
 exports.isValidWorkspaceName = isValidWorkspaceName;
 exports.validateWorkspaceName = validateWorkspaceName;
 exports.resolveSpecialFolderName = resolveSpecialFolderName;
@@ -344,30 +345,15 @@ async function handleError(error) {
 async function normalizeArgsMiddleware(argv) {
     try {
         rawArgs = { ...argv };
-        // Map invalid/legacy presets to templates for all users
-        // These presets don't exist as npm packages and would fail if not mapped
-        const invalidPresetToTemplateMap = {
-            empty: 'nrwl/empty-template',
-        };
-        if (rawArgs.preset && !rawArgs.template) {
-            const mappedTemplate = invalidPresetToTemplateMap[rawArgs.preset];
-            if (mappedTemplate) {
-                output_1.output.log({
-                    title: `Mapping preset '${rawArgs.preset}' to template '${mappedTemplate}'`,
-                });
-                argv.template = mappedTemplate;
-                rawArgs.template = mappedTemplate;
-                delete argv.preset;
-                delete rawArgs.preset;
-            }
-        }
         // AI Agent Detection: When an AI agent is detected, switch to AI-optimized mode
         const aiMode = (0, ai_output_1.isAiAgent)();
         if (aiMode) {
             // Force non-interactive mode for AI agents
             argv.interactive = false;
             // Map legacy presets to templates for AI agents
-            // Many AI models were trained on old preset syntax, so we convert them
+            // Many AI models were trained on old preset syntax, so we convert them.
+            // Never add `empty` here - it must stay npm-only as the escape hatch
+            // when github.com is unreachable (see applyEmptyPresetAlias).
             const legacyPresetToTemplateMap = {
                 ts: 'nrwl/empty-template',
                 apps: 'nrwl/empty-template',
@@ -426,6 +412,7 @@ async function normalizeArgsMiddleware(argv) {
                 title: "Let's create a new workspace [https://nx.dev/getting-started/intro]",
             });
         }
+        applyEmptyPresetAlias(argv);
         argv.workspaces ??= true;
         argv.useProjectJson ??= !argv.workspaces;
         useCloud = argv.nxCloud !== 'skip' && argv.nxCloud !== 'never';
@@ -616,6 +603,15 @@ async function normalizeArgsMiddleware(argv) {
         handleError(error);
     }
 }
+// Map `empty` to the `ts` preset, not the template - sandboxed agents often
+// cannot reach github.com. Wins over --template so appending --preset=empty
+// to a failed command escapes the download.
+function applyEmptyPresetAlias(argv) {
+    if (argv.preset === 'empty') {
+        argv.preset = preset_1.Preset.TS;
+        delete argv.template;
+    }
+}
 function invariant(predicate, errorCode, message) {
     if (!predicate) {
         throw new error_utils_1.CnwError(errorCode, message);

package/dist/src/create-workspace.js

@@ -38,7 +38,9 @@ async function createWorkspace(preset, options, rawArgs) {
     if (options.template) {
         // Resolve shorthand template names to full GitHub org/repo format
         options.template = resolveTemplateShorthand(options.template);
-        if (!options.template.startsWith('nrwl/'))
+        // Strict slug match - a bare startsWith('nrwl/') check lets path
+        // traversal (`nrwl/../evil`) resolve to another org's repo.
+        if (!/^nrwl\/[\w.-]+$/.test(options.template))
             throw new Error(`Invalid template. Only templates from the 'nrwl' GitHub org are supported.`);
         const workingDir = (options.workingDir ?? process.cwd()).replace(/\\/g, '/');
         directory = (0, path_1.join)(workingDir, name);

package/dist/src/utils/ai/ai-output.js

@@ -113,7 +113,7 @@ function buildTemplateRequiredResult(workspaceName) {
         stage: 'needs_input',
         success: false,
         title: 'Template Selection Required',
-        message: 'Ask the user which workspace type they want, then run again with --template. If the directory exists, append a number (e.g., my-nx-repo-2).',
+        message: 'Ask the user which workspace type they want, then run again with --template. If the directory exists, append a number (e.g., my-nx-repo-2). If this environment cannot reach github.com, run with --preset=empty instead of --template to create a minimal workspace without downloading a template.',
         suggestedName: name,
         templates: [
             {
@@ -227,9 +227,14 @@ function getErrorHints(errorCode) {
             ];
         case 'NETWORK_ERROR':
             return [
-                'Check your internet connection',
-                'Try again in a few moments',
-                'Check if npm/yarn registry is accessible',
+                'Templates download from github.com, which may be blocked or unreachable in this environment',
+                'Check your network and sandbox configuration (allow https://github.com) and try again',
+                'Or re-run with --preset=empty (instead of --template) to create a minimal workspace without downloading a template, then build on top of it',
+            ];
+        case 'TEMPLATE_CLONE_FAILED':
+            return [
+                'Check the template name (e.g. nrwl/empty-template)',
+                'If github.com is restricted in this environment, re-run with --preset=empty',
             ];
         case 'PACKAGE_INSTALL_ERROR':
             return [

package/dist/src/utils/template/download-template.js

@@ -25,8 +25,9 @@ const DEFAULT_BRANCHES = ['main', 'master'];
 async function downloadTemplate(template, directory) {
     let body;
     const attempts = [];
-    // A thrown fetch is a connectivity problem; a non-ok response is a missing
-    // branch/repo. Distinguish them so the error code (and its hints) are right.
+    // 404 means the repo/branch does not exist; any other failure (thrown fetch,
+    // 403 from a sandbox proxy, 407/429/5xx) means blocked or failed egress.
+    // The distinction picks the error code and its hints.
     let networkError = false;
     for (const branch of DEFAULT_BRANCHES) {
         const url = `https://github.com/${template}/archive/refs/heads/${branch}.tar.gz`;
@@ -36,6 +37,8 @@ async function downloadTemplate(template, directory) {
                 body = res.body;
                 break;
             }
+            if (res.status !== 404)
+                networkError = true;
             attempts.push(`${branch}: HTTP ${res.status}`);
         }
         catch (e) {
@@ -44,7 +47,11 @@ async function downloadTemplate(template, directory) {
         }
     }
     if (!body) {
-        throw new error_utils_1.CnwError(networkError ? 'NETWORK_ERROR' : 'TEMPLATE_CLONE_FAILED', `Failed to download template '${template}' (${attempts.join('; ')})`);
+        if (networkError) {
+            throw new error_utils_1.CnwError('NETWORK_ERROR', `Failed to download template '${template}' (${attempts.join('; ')}).\n` +
+                `github.com may be blocked or unreachable in this environment. Check your network and sandbox configuration and try again, or run with --preset=empty (instead of --template) to create a minimal workspace without downloading a template.`);
+        }
+        throw new error_utils_1.CnwError('TEMPLATE_CLONE_FAILED', `Failed to download template '${template}' (${attempts.join('; ')}). Check that the template name is correct.`);
     }
     // Only remove the directory on failure if we created it - never delete a
     // pre-existing dir (e.g. the user's current directory).

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "create-nx-workspace",
-  "version": "23.2.0-beta.3",
+  "version": "23.2.0-beta.5",
   "private": false,
   "description": "Smart Monorepos · Fast Builds",
   "repository": {
@@ -37,7 +37,7 @@
   },
   "homepage": "https://nx.dev",
   "dependencies": {
-    "axios": "1.16.1",
+    "axios": "1.18.1",
     "chalk": "^4.1.0",
     "enquirer": "~2.3.6",
     "flat": "^5.0.2",