create-nextblock 0.16.1 → 0.16.2

package/templates/nextblock-template/app/actions/contactSellerActions.ts

@@ -1,222 +1,222 @@
-'use server';
-
-import { headers } from 'next/headers';
-import { after } from 'next/server';
-import { getServiceRoleSupabaseClient } from '@nextblock-cms/db/server';
-
-import { resolveSellerContactEmail } from '../../lib/commerce/seller-contact';
-import { createThread, notifyAdminOfMessage } from '../../lib/messages/threads';
-import { verifyBotProtection } from '../../lib/botProtection/verify';
-
-/**
- * Public "contact the seller" enquiry, shown in place of Add-to-Cart when the store
- * cannot take payment for a product.
- *
- * Two rules shape this module:
- *
- * 1. The recipient is resolved ENTIRELY server-side. The existing form-block action
- *    takes its recipient from a bound argument, which means the address travels in the
- *    client payload; doing that here would publish the shop owner's inbox on every
- *    product page and turn the store's SMTP credentials into an open relay.
- *
- * 2. The database row is the deliverable, not the email. A store with no payment keys
- *    very often has no SMTP either, so the enquiry is persisted FIRST and the
- *    notification attempted afterwards. A failed send downgrades to `email_delivered:
- *    false` — the visitor is still told their message got through, because it did.
- */
-
-const MAX_NAME_LENGTH = 120;
-const MAX_EMAIL_LENGTH = 254;
-const MAX_MESSAGE_LENGTH = 2000;
-const MAX_USER_AGENT_LENGTH = 500;
-
-/** Per-IP submission cap. Deliberately generous — this is anti-flood, not anti-user. */
-const THROTTLE_WINDOW_MINUTES = 10;
-const THROTTLE_MAX_SUBMISSIONS = 5;
-
-/**
- * Throttle bucket for a request whose origin cannot be determined. Deliberately a single
- * shared key: unattributable requests are throttled TOGETHER rather than exempted.
- *
- * This is the difference between this helper and the visually similar one in
- * app/actions/consent.ts. There, a null mask just means one audit row is less precise.
- * Here the value is load-bearing for a rate limit, so "I could not parse that" must
- * never be allowed to mean "no limit applies".
- */
-const UNKNOWN_IP_BUCKET = 'unknown';
-
-/**
- * Best available client address, preferring headers the platform sets over ones the
- * client can write.
- *
- * `x-forwarded-for` is a list the client can prepend to: on an appending proxy (nginx's
- * proxy_add_x_forwarded_for, the shape this repo's Dockerfile deploys) its LEFTMOST
- * entry is attacker-controlled, so keying a throttle on it lets one caller mint a fresh
- * bucket per request. `x-vercel-forwarded-for` and `x-real-ip` are overwritten by the
- * proxy on every request, so they are checked first.
- */
-function firstHop(headerValue: string | null): string | null {
-  const [first] = (headerValue ?? '').split(',');
-  const trimmed = first?.trim() ?? '';
-  return trimmed || null;
-}
-
-function resolveClientIp(requestHeaders: Headers): string | null {
-  return (
-    firstHop(requestHeaders.get('x-vercel-forwarded-for')) ??
-    firstHop(requestHeaders.get('x-real-ip')) ??
-    firstHop(requestHeaders.get('x-forwarded-for'))
-  );
-}
-
-/** Reduce an address to a non-identifying prefix — never store a full IP. */
-function maskIp(ip: string | null): string {
-  if (!ip) return UNKNOWN_IP_BUCKET;
-  if (ip.includes(':')) {
-    const hextets = ip.split(':').filter(Boolean);
-    return `${hextets.slice(0, 3).join(':')}::x`;
-  }
-  const octets = ip.split('.');
-  if (octets.length === 4) {
-    octets[3] = 'x';
-    return octets.join('.');
-  }
-  return UNKNOWN_IP_BUCKET;
-}
-
-function readField(formData: FormData, name: string, maxLength: number): string {
-  const raw = formData.get(name);
-  return typeof raw === 'string' ? raw.trim().slice(0, maxLength) : '';
-}
-
-function isPlausibleEmail(value: string): boolean {
-  return /^[^\s@]+@[^\s@]+\.[^\s@]+$/.test(value);
-}
-
-export interface ContactSellerState {
-  success: boolean;
-  /** Translation key the client renders, with its own English fallback. */
-  messageKey:
-    | 'ecommerce.contact_seller_sent'
-    | 'ecommerce.contact_seller_error'
-    | 'ecommerce.contact_seller_throttled'
-    | 'ecommerce.contact_seller_invalid'
-    | '';
-  /** Set only for captcha failures, which carry their own provider-specific text. */
-  message?: string;
-}
-
-export async function submitProductInquiry(
-  _prevState: unknown,
-  formData: FormData
-): Promise<ContactSellerState> {
-  const verification = await verifyBotProtection(formData);
-  if (!verification.ok) {
-    // Fake a success for the honeypot so the bot learns nothing about the check.
-    if (verification.reason === 'honeypot') {
-      return { success: true, messageKey: 'ecommerce.contact_seller_sent' };
-    }
-    return { success: false, messageKey: '', message: verification.message };
-  }
-
-  const productId = readField(formData, 'product_id', 64);
-  const senderName = readField(formData, 'name', MAX_NAME_LENGTH);
-  const senderEmail = readField(formData, 'email', MAX_EMAIL_LENGTH);
-  const message = readField(formData, 'message', MAX_MESSAGE_LENGTH);
-  const locale = readField(formData, 'locale', 12) || null;
-
-  if (!productId || !senderName || !senderEmail || !message || !isPlausibleEmail(senderEmail)) {
-    return { success: false, messageKey: 'ecommerce.contact_seller_invalid' };
-  }
-
-  try {
-    const supabase = getServiceRoleSupabaseClient();
-
-    const requestHeaders = await headers();
-    // Always a string, so the throttle below always runs. See UNKNOWN_IP_BUCKET.
-    const ipMasked = maskIp(resolveClientIp(requestHeaders));
-    const userAgent = requestHeaders.get('user-agent');
-
-    const since = new Date(Date.now() - THROTTLE_WINDOW_MINUTES * 60_000).toISOString();
-    const { count } = await supabase
-      .from('product_inquiries')
-      .select('id', { count: 'exact', head: true })
-      .eq('ip_masked', ipMasked)
-      .gte('created_at', since);
-
-    if ((count ?? 0) >= THROTTLE_MAX_SUBMISSIONS) {
-      return { success: false, messageKey: 'ecommerce.contact_seller_throttled' };
-    }
-
-    // Look the product up server-side: a client-supplied title would let anyone send
-    // arbitrary text through the owner's own SMTP identity.
-    const { data: product } = await supabase
-      .from('products')
-      .select('id, title, slug')
-      .eq('id', productId)
-      .maybeSingle();
-
-    if (!product) {
-      return { success: false, messageKey: 'ecommerce.contact_seller_invalid' };
-    }
-
-    const { data: inserted, error: insertError } = await supabase
-      .from('product_inquiries')
-      .insert({
-        product_id: product.id,
-        product_slug: product.slug,
-        product_title: product.title,
-        sender_name: senderName,
-        sender_email: senderEmail,
-        message,
-        locale,
-        ip_masked: ipMasked,
-        user_agent: userAgent ? userAgent.slice(0, MAX_USER_AGENT_LENGTH) : null,
-      })
-      .select('id')
-      .single();
-
-    if (insertError) {
-      console.error('Failed to record product inquiry:', insertError.message);
-      return { success: false, messageKey: 'ecommerce.contact_seller_error' };
-    }
-
-    // Open the conversation this enquiry belongs to. The enquiry row above stays as
-    // the enquiry's own record (and owns the ip_masked the throttle counts); the thread
-    // is what the owner actually replies in.
-    const thread = await createThread({
-      source: 'product_inquiry',
-      subjectId: inserted.id,
-      subjectLabel: product.title,
-      senderName,
-      senderEmail,
-      message,
-      locale,
-      ipMasked,
-      userAgent: userAgent ? userAgent.slice(0, MAX_USER_AGENT_LENGTH) : null,
-    });
-
-    // Notification is best-effort and runs after the response. A bare floating promise
-    // would risk the serverless instance being frozen before the SMTP round trip ends.
-    if (thread) {
-      after(async () => {
-        const { email: recipient } = await resolveSellerContactEmail();
-        await notifyAdminOfMessage({
-          threadId: thread.threadId,
-          source: 'product_inquiry',
-          messageId: thread.messageId,
-          subjectLabel: product.title,
-          senderName,
-          senderEmail,
-          message,
-          recipient,
-        });
-      });
-    }
-
-    return { success: true, messageKey: 'ecommerce.contact_seller_sent' };
-  } catch (error) {
-    console.error('Product inquiry submission failed:', error);
-    return { success: false, messageKey: 'ecommerce.contact_seller_error' };
-  }
-}
+'use server';
+
+import { headers } from 'next/headers';
+import { after } from 'next/server';
+import { getServiceRoleSupabaseClient } from '@nextblock-cms/db/server';
+
+import { resolveSellerContactEmail } from '../../lib/commerce/seller-contact';
+import { createThread, notifyAdminOfMessage } from '../../lib/messages/threads';
+import { verifyBotProtection } from '../../lib/botProtection/verify';
+
+/**
+ * Public "contact the seller" enquiry, shown in place of Add-to-Cart when the store
+ * cannot take payment for a product.
+ *
+ * Two rules shape this module:
+ *
+ * 1. The recipient is resolved ENTIRELY server-side. The existing form-block action
+ *    takes its recipient from a bound argument, which means the address travels in the
+ *    client payload; doing that here would publish the shop owner's inbox on every
+ *    product page and turn the store's SMTP credentials into an open relay.
+ *
+ * 2. The database row is the deliverable, not the email. A store with no payment keys
+ *    very often has no SMTP either, so the enquiry is persisted FIRST and the
+ *    notification attempted afterwards. A failed send downgrades to `email_delivered:
+ *    false` — the visitor is still told their message got through, because it did.
+ */
+
+const MAX_NAME_LENGTH = 120;
+const MAX_EMAIL_LENGTH = 254;
+const MAX_MESSAGE_LENGTH = 2000;
+const MAX_USER_AGENT_LENGTH = 500;
+
+/** Per-IP submission cap. Deliberately generous — this is anti-flood, not anti-user. */
+const THROTTLE_WINDOW_MINUTES = 10;
+const THROTTLE_MAX_SUBMISSIONS = 5;
+
+/**
+ * Throttle bucket for a request whose origin cannot be determined. Deliberately a single
+ * shared key: unattributable requests are throttled TOGETHER rather than exempted.
+ *
+ * This is the difference between this helper and the visually similar one in
+ * app/actions/consent.ts. There, a null mask just means one audit row is less precise.
+ * Here the value is load-bearing for a rate limit, so "I could not parse that" must
+ * never be allowed to mean "no limit applies".
+ */
+const UNKNOWN_IP_BUCKET = 'unknown';
+
+/**
+ * Best available client address, preferring headers the platform sets over ones the
+ * client can write.
+ *
+ * `x-forwarded-for` is a list the client can prepend to: on an appending proxy (nginx's
+ * proxy_add_x_forwarded_for, the shape this repo's Dockerfile deploys) its LEFTMOST
+ * entry is attacker-controlled, so keying a throttle on it lets one caller mint a fresh
+ * bucket per request. `x-vercel-forwarded-for` and `x-real-ip` are overwritten by the
+ * proxy on every request, so they are checked first.
+ */
+function firstHop(headerValue: string | null): string | null {
+  const [first] = (headerValue ?? '').split(',');
+  const trimmed = first?.trim() ?? '';
+  return trimmed || null;
+}
+
+function resolveClientIp(requestHeaders: Headers): string | null {
+  return (
+    firstHop(requestHeaders.get('x-vercel-forwarded-for')) ??
+    firstHop(requestHeaders.get('x-real-ip')) ??
+    firstHop(requestHeaders.get('x-forwarded-for'))
+  );
+}
+
+/** Reduce an address to a non-identifying prefix — never store a full IP. */
+function maskIp(ip: string | null): string {
+  if (!ip) return UNKNOWN_IP_BUCKET;
+  if (ip.includes(':')) {
+    const hextets = ip.split(':').filter(Boolean);
+    return `${hextets.slice(0, 3).join(':')}::x`;
+  }
+  const octets = ip.split('.');
+  if (octets.length === 4) {
+    octets[3] = 'x';
+    return octets.join('.');
+  }
+  return UNKNOWN_IP_BUCKET;
+}
+
+function readField(formData: FormData, name: string, maxLength: number): string {
+  const raw = formData.get(name);
+  return typeof raw === 'string' ? raw.trim().slice(0, maxLength) : '';
+}
+
+function isPlausibleEmail(value: string): boolean {
+  return /^[^\s@]+@[^\s@]+\.[^\s@]+$/.test(value);
+}
+
+export interface ContactSellerState {
+  success: boolean;
+  /** Translation key the client renders, with its own English fallback. */
+  messageKey:
+    | 'ecommerce.contact_seller_sent'
+    | 'ecommerce.contact_seller_error'
+    | 'ecommerce.contact_seller_throttled'
+    | 'ecommerce.contact_seller_invalid'
+    | '';
+  /** Set only for captcha failures, which carry their own provider-specific text. */
+  message?: string;
+}
+
+export async function submitProductInquiry(
+  _prevState: unknown,
+  formData: FormData
+): Promise<ContactSellerState> {
+  const verification = await verifyBotProtection(formData);
+  if (!verification.ok) {
+    // Fake a success for the honeypot so the bot learns nothing about the check.
+    if (verification.reason === 'honeypot') {
+      return { success: true, messageKey: 'ecommerce.contact_seller_sent' };
+    }
+    return { success: false, messageKey: '', message: verification.message };
+  }
+
+  const productId = readField(formData, 'product_id', 64);
+  const senderName = readField(formData, 'name', MAX_NAME_LENGTH);
+  const senderEmail = readField(formData, 'email', MAX_EMAIL_LENGTH);
+  const message = readField(formData, 'message', MAX_MESSAGE_LENGTH);
+  const locale = readField(formData, 'locale', 12) || null;
+
+  if (!productId || !senderName || !senderEmail || !message || !isPlausibleEmail(senderEmail)) {
+    return { success: false, messageKey: 'ecommerce.contact_seller_invalid' };
+  }
+
+  try {
+    const supabase = getServiceRoleSupabaseClient();
+
+    const requestHeaders = await headers();
+    // Always a string, so the throttle below always runs. See UNKNOWN_IP_BUCKET.
+    const ipMasked = maskIp(resolveClientIp(requestHeaders));
+    const userAgent = requestHeaders.get('user-agent');
+
+    const since = new Date(Date.now() - THROTTLE_WINDOW_MINUTES * 60_000).toISOString();
+    const { count } = await supabase
+      .from('product_inquiries')
+      .select('id', { count: 'exact', head: true })
+      .eq('ip_masked', ipMasked)
+      .gte('created_at', since);
+
+    if ((count ?? 0) >= THROTTLE_MAX_SUBMISSIONS) {
+      return { success: false, messageKey: 'ecommerce.contact_seller_throttled' };
+    }
+
+    // Look the product up server-side: a client-supplied title would let anyone send
+    // arbitrary text through the owner's own SMTP identity.
+    const { data: product } = await supabase
+      .from('products')
+      .select('id, title, slug')
+      .eq('id', productId)
+      .maybeSingle();
+
+    if (!product) {
+      return { success: false, messageKey: 'ecommerce.contact_seller_invalid' };
+    }
+
+    const { data: inserted, error: insertError } = await supabase
+      .from('product_inquiries')
+      .insert({
+        product_id: product.id,
+        product_slug: product.slug,
+        product_title: product.title,
+        sender_name: senderName,
+        sender_email: senderEmail,
+        message,
+        locale,
+        ip_masked: ipMasked,
+        user_agent: userAgent ? userAgent.slice(0, MAX_USER_AGENT_LENGTH) : null,
+      })
+      .select('id')
+      .single();
+
+    if (insertError) {
+      console.error('Failed to record product inquiry:', insertError.message);
+      return { success: false, messageKey: 'ecommerce.contact_seller_error' };
+    }
+
+    // Open the conversation this enquiry belongs to. The enquiry row above stays as
+    // the enquiry's own record (and owns the ip_masked the throttle counts); the thread
+    // is what the owner actually replies in.
+    const thread = await createThread({
+      source: 'product_inquiry',
+      subjectId: inserted.id,
+      subjectLabel: product.title,
+      senderName,
+      senderEmail,
+      message,
+      locale,
+      ipMasked,
+      userAgent: userAgent ? userAgent.slice(0, MAX_USER_AGENT_LENGTH) : null,
+    });
+
+    // Notification is best-effort and runs after the response. A bare floating promise
+    // would risk the serverless instance being frozen before the SMTP round trip ends.
+    if (thread) {
+      after(async () => {
+        const { email: recipient } = await resolveSellerContactEmail();
+        await notifyAdminOfMessage({
+          threadId: thread.threadId,
+          source: 'product_inquiry',
+          messageId: thread.messageId,
+          subjectLabel: product.title,
+          senderName,
+          senderEmail,
+          message,
+          recipient,
+        });
+      });
+    }
+
+    return { success: true, messageKey: 'ecommerce.contact_seller_sent' };
+  } catch (error) {
+    console.error('Product inquiry submission failed:', error);
+    return { success: false, messageKey: 'ecommerce.contact_seller_error' };
+  }
+}

package/templates/nextblock-template/app/actions/email-retry.test.ts

@@ -1,62 +1,62 @@
-import { describe, expect, it } from 'vitest';
-
-import { describeSmtpError } from './email';
-
-/**
- * A reply failed with "The mail server did not respond in time" on an install whose
- * transport verifies in about a second and whose identical send succeeds moments later.
- * That signature — everything healthy, one send hangs — is a pooled connection the relay
- * reaped while it sat idle: nodemailer still believes it is open, so the send blocks
- * until the socket timeout.
- *
- * sendEmail now drops the pool and retries once on a fresh connection for that class of
- * fault only. These cover the classification, which is what decides retry vs report.
- */
-
-describe('describeSmtpError', () => {
-  it('explains the TLS/port mismatch that produced an unreadable OpenSSL error', () => {
-    const message = describeSmtpError(
-      new Error('B4730000:error:0A00010B:SSL routines:ssl3_get_record:wrong version number:ssl3_record.c:355:')
-    );
-    expect(message).toContain('2525');
-    expect(message).toContain('465');
-    expect(message).not.toContain('ssl3_get_record');
-  });
-
-  it('names credentials as the cause of an auth rejection', () => {
-    const error = Object.assign(new Error('Invalid login: 535 authentication failed'), {
-      code: 'EAUTH',
-    });
-    expect(describeSmtpError(error)).toMatch(/username or password/i);
-  });
-
-  it('distinguishes a timeout from an unreachable host', () => {
-    const timeout = Object.assign(new Error('Connection timeout'), { code: 'ETIMEDOUT' });
-    expect(describeSmtpError(timeout)).toMatch(/did not respond in time/i);
-
-    const dns = Object.assign(new Error('getaddrinfo ENOTFOUND smtp.example.com'), {
-      code: 'ENOTFOUND',
-    });
-    expect(describeSmtpError(dns)).toMatch(/hostname could not be resolved/i);
-
-    const refused = Object.assign(new Error('connect ECONNREFUSED'), { code: 'ECONNREFUSED' });
-    expect(describeSmtpError(refused)).toMatch(/refused the connection/i);
-  });
-
-  it('tells an unconfigured install what to do rather than echoing the throw', () => {
-    expect(describeSmtpError(new Error('Email server is not configured.'))).toMatch(
-      /CMS Settings/i
-    );
-  });
-
-  it('passes an unrecognised failure through rather than inventing an explanation', () => {
-    expect(describeSmtpError(new Error('552 5.3.4 Message too big'))).toBe(
-      '552 5.3.4 Message too big'
-    );
-  });
-
-  it('handles a non-Error throw without crashing', () => {
-    expect(describeSmtpError('something odd')).toBe('something odd');
-    expect(describeSmtpError(null)).toBe('null');
-  });
-});
+import { describe, expect, it } from 'vitest';
+
+import { describeSmtpError } from './email';
+
+/**
+ * A reply failed with "The mail server did not respond in time" on an install whose
+ * transport verifies in about a second and whose identical send succeeds moments later.
+ * That signature — everything healthy, one send hangs — is a pooled connection the relay
+ * reaped while it sat idle: nodemailer still believes it is open, so the send blocks
+ * until the socket timeout.
+ *
+ * sendEmail now drops the pool and retries once on a fresh connection for that class of
+ * fault only. These cover the classification, which is what decides retry vs report.
+ */
+
+describe('describeSmtpError', () => {
+  it('explains the TLS/port mismatch that produced an unreadable OpenSSL error', () => {
+    const message = describeSmtpError(
+      new Error('B4730000:error:0A00010B:SSL routines:ssl3_get_record:wrong version number:ssl3_record.c:355:')
+    );
+    expect(message).toContain('2525');
+    expect(message).toContain('465');
+    expect(message).not.toContain('ssl3_get_record');
+  });
+
+  it('names credentials as the cause of an auth rejection', () => {
+    const error = Object.assign(new Error('Invalid login: 535 authentication failed'), {
+      code: 'EAUTH',
+    });
+    expect(describeSmtpError(error)).toMatch(/username or password/i);
+  });
+
+  it('distinguishes a timeout from an unreachable host', () => {
+    const timeout = Object.assign(new Error('Connection timeout'), { code: 'ETIMEDOUT' });
+    expect(describeSmtpError(timeout)).toMatch(/did not respond in time/i);
+
+    const dns = Object.assign(new Error('getaddrinfo ENOTFOUND smtp.example.com'), {
+      code: 'ENOTFOUND',
+    });
+    expect(describeSmtpError(dns)).toMatch(/hostname could not be resolved/i);
+
+    const refused = Object.assign(new Error('connect ECONNREFUSED'), { code: 'ECONNREFUSED' });
+    expect(describeSmtpError(refused)).toMatch(/refused the connection/i);
+  });
+
+  it('tells an unconfigured install what to do rather than echoing the throw', () => {
+    expect(describeSmtpError(new Error('Email server is not configured.'))).toMatch(
+      /CMS Settings/i
+    );
+  });
+
+  it('passes an unrecognised failure through rather than inventing an explanation', () => {
+    expect(describeSmtpError(new Error('552 5.3.4 Message too big'))).toBe(
+      '552 5.3.4 Message too big'
+    );
+  });
+
+  it('handles a non-Error throw without crashing', () => {
+    expect(describeSmtpError('something odd')).toBe('something odd');
+    expect(describeSmtpError(null)).toBe('null');
+  });
+});