create-merlin-brain 3.5.1 → 3.5.2

package/bin/install.cjs

@@ -980,32 +980,28 @@ async function install() {
       hooks: [{ type: 'command', command: 'bash ~/.claude/hooks/subagent-context.sh' }]
     });
 
-    // --- Prompt-based hooks (LLM evaluates .md content) ---
-    // On update, old prompt hooks have stale content. Remove all Merlin prompt hooks
-    // first (identified by containing 'merlin' or 'Merlin' in their prompt text),
-    // then re-add fresh ones. This prevents duplicate hooks across version upgrades.
-    const removeMerlinPromptHooks = (hookArray) => {
+    // --- Prompt-based hooks cleanup & registration ---
+    // Remove ALL prompt-type hooks from Merlin (identified by type: 'prompt').
+    // This prevents duplicates across version upgrades and removes broken hooks.
+    const removeAllPromptHooks = (hookArray) => {
       return hookArray.filter(entry => {
         if (!entry.hooks || !Array.isArray(entry.hooks)) return true;
-        // Remove entry if ALL its hooks are Merlin prompt hooks
-        const allMerlinPrompts = entry.hooks.every(h => {
-          if (h.type !== 'prompt') return false;
-          const prompt = (h.prompt || '').toLowerCase();
-          return prompt.includes('merlin') || prompt.includes('sights');
-        });
-        return !allMerlinPrompts;
+        // Remove entry if ALL its hooks are prompt-type (Merlin is the only
+        // source of prompt hooks in settings.local.json)
+        const allPrompts = entry.hooks.every(h => h.type === 'prompt');
+        return !allPrompts;
       });
     };
 
-    settings.hooks.SessionStart = removeMerlinPromptHooks(settings.hooks.SessionStart);
-    settings.hooks.PreToolUse = removeMerlinPromptHooks(settings.hooks.PreToolUse);
-    settings.hooks.Stop = removeMerlinPromptHooks(settings.hooks.Stop);
+    settings.hooks.SessionStart = removeAllPromptHooks(settings.hooks.SessionStart);
+    settings.hooks.PreToolUse = removeAllPromptHooks(settings.hooks.PreToolUse);
+    settings.hooks.Stop = removeAllPromptHooks(settings.hooks.Stop);
     settings.hooks.Notification = settings.hooks.Notification || [];
-    settings.hooks.Notification = removeMerlinPromptHooks(settings.hooks.Notification);
+    settings.hooks.Notification = removeAllPromptHooks(settings.hooks.Notification);
     settings.hooks.TaskCompleted = settings.hooks.TaskCompleted || [];
-    settings.hooks.TaskCompleted = removeMerlinPromptHooks(settings.hooks.TaskCompleted);
+    settings.hooks.TaskCompleted = removeAllPromptHooks(settings.hooks.TaskCompleted);
 
-    // Now add fresh prompt/command hooks in new format
+    // Now add fresh hooks in new format
     // NOTE: SessionStart does NOT support prompt hooks (only command hooks).
     // The Merlin boot sequence is handled via CLAUDE.md instructions instead.
     // We use a command hook to inject additionalContext at session start.
@@ -1013,11 +1009,11 @@ async function install() {
       hooks: [{ type: 'command', command: 'bash ~/.claude/hooks/session-start-context.sh' }]
     });
 
-    // Prompt-based PreToolUse hook: evaluate Sights check before edits
-    settings.hooks.PreToolUse.push({
-      matcher: 'Edit|Write',
-      hooks: [{ type: 'prompt', prompt: fs.readFileSync(path.join(HOOKS_DIR, 'pre-edit-sights-enforce.md'), 'utf8') }]
-    });
+    // NOTE: The PreToolUse prompt hook has been REMOVED. It caused an infinite
+    // rejection loop because the evaluator model cannot see conversation history
+    // to verify whether merlin_get_context was called. The command-type hook
+    // (pre-edit-sights-check.sh) handles advisory logging instead.
+    // Sights enforcement is done via CLAUDE.md instructions, not hook blocking.
 
     // Prompt-based Stop hook: evaluate whether stopping is appropriate
     settings.hooks.Stop.push({

package/files/hooks/pre-edit-sights-enforce.md

@@ -1,12 +1 @@
-You are evaluating whether a file edit should proceed. Context: $ARGUMENTS
-
-Check: Has the assistant recently called merlin_get_context, merlin_find_files, or merlin_search for this file's area in the current conversation? Look at recent tool calls in the transcript.
-
-Rules:
-- If Sights was consulted recently (within the last few messages) for this area: allow the edit
-- If this is a minor/trivial edit (formatting, typo fix, small change): allow the edit
-- If this is a significant edit and Sights was NOT consulted: suggest checking first
-
-Respond with ONLY valid JSON, no other text:
-- Allow the edit: {"ok": true}
-- Suggest Sights check first: {"ok": false, "reason": "Call merlin_get_context before editing this file to check for existing patterns and conventions"}
+Always allow this edit. Respond with ONLY: {"ok": true}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "create-merlin-brain",
-  "version": "3.5.1",
+  "version": "3.5.2",
   "description": "Merlin - The Ultimate AI Brain for Claude Code. One install: workflows, agents, loop, and Sights MCP server.",
   "type": "module",
   "main": "./dist/server/index.js",