create-manifest 1.3.1 → 1.3.2

package/dist/commands/index.js

@@ -1,6 +1,6 @@
 import { Args, Command, Flags } from '@oclif/core';
 import axios from 'axios';
-import { exec as execCp } from 'node:child_process';
+import { exec as execCp, spawn } from 'node:child_process';
 import * as fs from 'node:fs';
 import * as crypto from 'node:crypto';
 import * as path from 'node:path';
@@ -18,6 +18,42 @@ import { input } from '@inquirer/prompts';
 import { slugify } from '../utils/helpers.js';
 import chalk from 'chalk';
 const exec = promisify(execCp);
+/**
+ * Execute a command in a specific directory with cross-platform support
+ * @param command - The command to execute
+ * @param cwd - The working directory
+ * @returns Promise with stdout and stderr
+ */
+async function execInDirectory(command, cwd) {
+    return exec(command, { cwd });
+}
+/**
+ * Spawn a command in a specific directory that runs in the background
+ * @param command - The command to execute
+ * @param args - The command arguments
+ * @param cwd - The working directory
+ * @returns ChildProcess
+ */
+function spawnInDirectory(command, args, cwd) {
+    const isWindows = process.platform === 'win32';
+    if (isWindows) {
+        // On Windows, use shell to resolve npm command
+        return spawn(command, args, {
+            cwd,
+            stdio: 'pipe',
+            detached: false,
+            shell: true
+        });
+    }
+    else {
+        // On Unix systems, spawn directly
+        return spawn(command, args, {
+            cwd,
+            stdio: 'pipe',
+            detached: false
+        });
+    }
+}
 export default class CreateManifest extends Command {
     static description = 'Create a new Manifest project with the default files and folders.';
     static args = {
@@ -298,7 +334,7 @@ export default class CreateManifest extends Command {
         spinner.start('Installing dependencies...');
         // Install deps.
         try {
-            await exec(`cd ${projectName} && npm install --silent`);
+            await execInDirectory(`npm install --silent`, projectName);
         }
         catch (error) {
             spinner.fail(`Execution error: ${error}`);
@@ -322,19 +358,30 @@ export default class CreateManifest extends Command {
         fs.writeFileSync(envFilePath, envContent);
         spinner.succeed();
         spinner.start('Building the database...');
-        let serveTask = null;
+        let serverProcess = null;
         try {
-            // We run the manifest script to build the database.
-            serveTask = exec(`cd ${projectName} && npm run start`);
+            // We run the manifest script to build the database in the background
+            serverProcess = spawnInDirectory('npm', ['run', 'start'], projectName);
+            // Wait for the server to be ready
             await this.waitForServerToBeReady();
             spinner.succeed();
         }
         catch (error) {
             spinner.fail(`Execution error: ${error}`);
+            // If server failed to start, try to kill it
+            if (serverProcess && serverProcess.pid) {
+                try {
+                    await this.silentKill(serverProcess.pid);
+                }
+                catch {
+                    // Ignore errors when killing the process
+                }
+            }
+            throw error;
         }
         spinner.start('Seeding initial data...');
         try {
-            await exec(`cd ${projectName} && npm run seed`);
+            await execInDirectory(`npm run seed`, projectName);
         }
         catch (error) {
             spinner.fail(`Execution error: ${error}`);
@@ -348,7 +395,15 @@ export default class CreateManifest extends Command {
         console.log(chalk.bold(`  cd ${projectName}`));
         console.log(chalk.bold('  npm run start'));
         console.log();
-        await this.silentKill(serveTask?.child?.pid || 0);
+        // Kill the background server process if it exists
+        if (serverProcess && serverProcess.pid) {
+            try {
+                await this.silentKill(serverProcess.pid);
+            }
+            catch {
+                // Ignore errors when killing the process
+            }
+        }
         process.exit();
     }
     /**
@@ -358,10 +413,16 @@ export default class CreateManifest extends Command {
      *
      **/
     async isServerReady() {
-        return axios
-            .get('http://localhost:1111/api/health')
-            .then(() => true)
-            .catch(() => false);
+        try {
+            const response = await axios.get('http://localhost:1111/api/health', {
+                timeout: 5000 // 5 second timeout
+            });
+            return response.status === 200;
+        }
+        catch {
+            // Server is not ready yet
+            return false;
+        }
     }
     /**
      * Wait for the server to be ready.
@@ -371,12 +432,18 @@ export default class CreateManifest extends Command {
      **/
     async waitForServerToBeReady() {
         let serverReady = false;
-        while (!serverReady) {
+        let attempts = 0;
+        const maxAttempts = 30; // 30 seconds timeout
+        while (!serverReady && attempts < maxAttempts) {
             serverReady = await this.isServerReady();
             if (!serverReady) {
+                attempts++;
                 await new Promise((resolve) => setTimeout(resolve, 1000)); // Wait 1s before retrying
             }
         }
+        if (!serverReady) {
+            throw new Error('Server failed to start within 30 seconds');
+        }
     }
     /**
      * Transform a JSON with comments to a JSON without comments.

package/oclif.manifest.json

@@ -43,5 +43,5 @@
       "enableJsonFlag": false
     }
   },
-  "version": "1.3.1"
+  "version": "1.3.2"
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "create-manifest",
-  "version": "1.3.1",
+  "version": "1.3.2",
   "author": "Manifest",
   "description": "Create a new Manifest backend",
   "homepage": "https://manifest.build",