create-kumiko-app 0.4.149 → 0.4.150

package/feature-manifest.json

@@ -493,7 +493,10 @@
           "encrypted": false,
           "computed": false,
           "options": null,
-          "bounds": null,
+          "bounds": {
+            "min": 1,
+            "max": 500
+          },
           "pattern": null,
           "writeRoles": [
             "TenantAdmin",
@@ -515,7 +518,9 @@
           "computed": false,
           "options": null,
           "bounds": null,
-          "pattern": null,
+          "pattern": {
+            "regex": "^[a-z]{3}(\\+[a-z]{3})*$"
+          },
           "writeRoles": [
             "TenantAdmin",
             "SystemAdmin"

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "create-kumiko-app",
-  "version": "0.4.149",
+  "version": "0.4.150",
   "description": "`bun create kumiko-app <name>` — scaffold a new Kumiko app with an interactive feature picker.",
   "license": "BUSL-1.1",
   "author": "Marc Frost <marc@cosmicdriftgamestudio.com>",
@@ -30,9 +30,9 @@
     "vendor:manifest": "bun run scripts/vendor-manifest.ts"
   },
   "dependencies": {
-    "@cosmicdrift/kumiko-dev-server": "0.165.0",
-    "@cosmicdrift/kumiko-framework": "0.165.0",
-    "@cosmicdrift/kumiko-server-runtime": "0.165.0",
+    "@cosmicdrift/kumiko-dev-server": "1.0.0",
+    "@cosmicdrift/kumiko-framework": "1.0.0",
+    "@cosmicdrift/kumiko-server-runtime": "1.0.0",
     "@inquirer/core": "^10.0.0",
     "@inquirer/prompts": "^7.4.0"
   },

package/src/__tests__/cli.test.ts

@@ -30,7 +30,10 @@ describe("create-kumiko-app CLI", () => {
     expect(code).toBe(0);
     // Onboarding regression gate: the scaffold step is the first thing a new
     // user waits on. Generous ceiling so slow CI runners pass — what we catch
-    // is an order-of-magnitude blowup, not seconds.
+    // is an order-of-magnitude blowup, not seconds. Needs an explicit test
+    // timeout above the 30s ceiling: bun's default (5s) would fail a slow-
+    // but-fine CI run on its own timeout before this assertion ever gets to
+    // fire, making the "ceiling" the opposite of what the comment claims.
     expect(scaffoldMs, `scaffold took ${Math.round(scaffoldMs)}ms (ceiling 30s)`).toBeLessThan(
       30_000,
     );
@@ -67,7 +70,7 @@ describe("create-kumiko-app CLI", () => {
 
     // Setup-impact preview lands before the scaffold actually runs.
     expect(out).toMatch(/→ Scaffolding \d+ features? into \.\/demo-app\//);
-  });
+  }, 35_000);
 
   test("--print-manifest emits JSON, no name needed", async () => {
     const code = await runCreate({

package/src/__tests__/feature-constructors.test.ts

@@ -0,0 +1,48 @@
+// Guards against #1425/1: callExpression (rendered into generated
+// run-config.ts) and callArgs (used at runtime by instantiateScaffoldFeatures)
+// encode the same call twice by hand. If someone edits one without the
+// other, the boot test validates a different feature config than what
+// actually gets scaffolded. This derives the expected callExpression from
+// exportName + callArgs for every entry and diffs it against the literal.
+
+import { describe, expect, test } from "bun:test";
+import { FEATURE_CONSTRUCTORS } from "../feature-constructors";
+
+function expectedCallExpression(
+  exportName: string,
+  callArgs: readonly unknown[] | undefined,
+): string {
+  if (callArgs === undefined) {
+    // Ambiguous by callArgs alone: could be a zero-arg factory (`fn()`) or a
+    // bare object export (`fn`). Disambiguate the same way the runtime does
+    // (scaffold-app.ts's instantiateScaffoldFeatures): trust the "()" the
+    // literal itself carries, then only check the exportName prefix matches.
+    return exportName;
+  }
+  const args = callArgs.map((a) => JSON.stringify(a)).join(", ");
+  return `${exportName}(${args})`;
+}
+
+describe("FEATURE_CONSTRUCTORS callExpression/callArgs consistency", () => {
+  for (const [name, entry] of Object.entries(FEATURE_CONSTRUCTORS)) {
+    test(`${name}: callExpression matches exportName + callArgs`, () => {
+      if (entry.callArgs !== undefined) {
+        // callExpression is hand-formatted TS source (`{ scopes: {} }`), not
+        // JSON (`{"scopes":{}}`) — compare with whitespace stripped so both
+        // are checked against the same underlying arg values.
+        const normalize = (s: string) => s.replace(/[\s"]+/g, "");
+        expect(normalize(entry.callExpression)).toBe(
+          normalize(expectedCallExpression(entry.exportName, entry.callArgs)),
+        );
+        return;
+      }
+      // No callArgs: either `exportName()` (zero-arg factory) or bare
+      // `exportName` (object export) — both are legal, but the export name
+      // itself must be the prefix either way.
+      expect(
+        entry.callExpression === entry.exportName ||
+          entry.callExpression === `${entry.exportName}()`,
+      ).toBe(true);
+    });
+  }
+});