create-kumiko-app 0.4.128 → 0.4.130

package/feature-manifest.json

@@ -2240,12 +2240,13 @@
     },
     {
       "name": "user-profile",
-      "description": "Self-service account page building blocks: a `change-email` write handler (re-auth via current password, uniqueness check, resets emailVerified and expects the app to trigger the verification flow) plus the ProfileScreen web component that composes change-password (auth-email-password), change-email and account deletion (user-data-rights request/cancel with grace period) into one screen. Apps register the screen as `type: \"custom\"` with `__component: \"UserProfileScreen\"`. Requires `user`, `auth-email-password`, and `user-data-rights`.",
+      "description": "Self-service account page building blocks: a `change-email` write handler (re-auth via current password, uniqueness check, resets emailVerified and expects the app to trigger the verification flow) plus the ProfileScreen web component that composes change-password (auth-email-password), change-email and account deletion (user-data-rights request/cancel with grace period) into one screen. Apps register the screen as `type: \"custom\"` with `__component: \"UserProfileScreen\"`. Requires `user`, `auth-email-password`, `user-data-rights`, and `user-data-rights-defaults` (so the GDPR boot-validator finds export/delete hooks for `user`'s PII fields once user-data-rights is mounted).",
       "toggleableDefault": null,
       "requires": [
         "user",
         "auth-email-password",
-        "user-data-rights"
+        "user-data-rights",
+        "user-data-rights-defaults"
       ],
       "optionalRequires": [],
       "configReads": [],

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "create-kumiko-app",
-  "version": "0.4.128",
+  "version": "0.4.130",
   "description": "`bun create kumiko-app <name>` — scaffold a new Kumiko app with an interactive feature picker.",
   "license": "BUSL-1.1",
   "author": "Marc Frost <marc@cosmicdriftgamestudio.com>",
@@ -30,8 +30,9 @@
     "vendor:manifest": "bun run scripts/vendor-manifest.ts"
   },
   "dependencies": {
-    "@cosmicdrift/kumiko-dev-server": "0.156.0",
-    "@cosmicdrift/kumiko-framework": "0.156.0",
+    "@cosmicdrift/kumiko-dev-server": "0.156.2",
+    "@cosmicdrift/kumiko-framework": "0.156.2",
+    "@cosmicdrift/kumiko-server-runtime": "0.156.2",
     "@inquirer/core": "^10.0.0",
     "@inquirer/prompts": "^7.4.0"
   },

package/src/__tests__/cli.test.ts

@@ -44,6 +44,11 @@ describe("create-kumiko-app CLI", () => {
     expect(cfg).toContain("createDeliveryFeature");
     // mail-transport-smtp is opt-in (not recommended, no transitive require) — should NOT auto-mount.
     expect(cfg).not.toContain("mailTransportSmtpFeature");
+    // issue-1174: user-profile (recommended) requires user-data-rights
+    // transitively, which trips the GDPR boot-validator unless
+    // user-data-rights-defaults (the PII export/delete hooks for `user`)
+    // is auto-included too.
+    expect(cfg).toContain("createUserDataRightsDefaultsFeature");
 
     // UX-polish: Next-steps points at `bun dev` (the primary dev path since
     // PR #583 introduced bin/dev.ts), not the CI-only `bun run boot` smoke.

package/src/__tests__/yes-scaffold-boot.test.ts

@@ -0,0 +1,60 @@
+// issue-1174: `bun create kumiko-app <name> --yes` resolves the recommended
+// feature set through the manifest's `requires` graph (dep-resolver.ts), not
+// through hand-written app composition. That graph can pull in a feature
+// (here: user-data-rights, transitively via user-profile) whose boot-time
+// obligations (an EXT_USER_DATA hook per PII entity) no OTHER auto-included
+// feature satisfies — cli.test.ts's file-existence checks can't catch that,
+// only actually booting the resolved set through validateBoot can.
+
+import { describe, expect, test } from "bun:test";
+import {
+  createRegistry,
+  type FeatureDefinition,
+  validateBoot as validateBootRaw,
+} from "@cosmicdrift/kumiko-framework/engine";
+import { withBootValidatorFixture } from "@cosmicdrift/kumiko-framework/testing";
+import { composeFeatures } from "@cosmicdrift/kumiko-server-runtime/compose-features";
+import { resolveDeps } from "../dep-resolver";
+import { FEATURE_CONSTRUCTORS } from "../feature-constructors";
+import { loadManifest } from "../manifest";
+import { buildChoices } from "../picker";
+
+function validateBoot(features: readonly FeatureDefinition[]): void {
+  validateBootRaw(withBootValidatorFixture(features));
+}
+
+async function instantiateResolved(names: readonly string[]): Promise<FeatureDefinition[]> {
+  const instances: FeatureDefinition[] = [];
+  for (const name of names) {
+    const entry = FEATURE_CONSTRUCTORS[name];
+    if (!entry) continue; // mirrors index.ts:47-49 — auto-mounted core deps have no entry
+    const mod = (await import(entry.importPath)) as Record<string, unknown>;
+    const exp = mod[entry.exportName];
+    instances.push(
+      entry.callExpression.endsWith("()")
+        ? (exp as () => FeatureDefinition)()
+        : (exp as FeatureDefinition),
+    );
+  }
+  return instances;
+}
+
+describe("--yes resolved set boots (issue-1174 regression)", () => {
+  const manifest = loadManifest();
+  const recommended = buildChoices(manifest)
+    .filter((c) => c.recommended)
+    .map((c) => c.name);
+  const resolved = resolveDeps(recommended, manifest);
+
+  test("resolves user-data-rights-defaults alongside the transitively-pulled user-data-rights", () => {
+    expect(resolved.featureNames).toContain("user-data-rights");
+    expect(resolved.featureNames).toContain("user-data-rights-defaults");
+  });
+
+  test("the resolved --yes feature set boots without the GDPR PII-hook-coverage error", async () => {
+    const instances = await instantiateResolved(resolved.featureNames);
+    const composed = composeFeatures(instances, { includeBundled: true });
+    expect(() => validateBoot(composed)).not.toThrow();
+    expect(() => createRegistry(composed)).not.toThrow();
+  });
+});

package/src/feature-constructors.ts

@@ -177,6 +177,12 @@ export const FEATURE_CONSTRUCTORS: Readonly<Record<string, ScaffoldFeatureEntry>
     exportName: "createUserDataRightsFeature",
     callExpression: "createUserDataRightsFeature()",
   },
+  "user-data-rights-defaults": {
+    name: "user-data-rights-defaults",
+    importPath: "@cosmicdrift/kumiko-bundled-features/user-data-rights-defaults",
+    exportName: "createUserDataRightsDefaultsFeature",
+    callExpression: "createUserDataRightsDefaultsFeature()",
+  },
 
   // --- Operations ---
   "feature-toggles": {