create-ecdh 4.0.4 → 4.0.5

package/.github/FUNDING.yml

@@ -0,0 +1,12 @@
+# These are supported funding model platforms
+
+github: [ljharb]
+patreon: # Replace with a single Patreon username
+open_collective: # Replace with a single Open Collective username
+ko_fi: # Replace with a single Ko-fi username
+tidelift: npm/createECDH
+community_bridge: # Replace with a single Community Bridge project-name e.g., cloud-foundry
+liberapay: # Replace with a single Liberapay username
+issuehunt: # Replace with a single IssueHunt username
+otechie: # Replace with a single Otechie username
+custom: # Replace with a single custom sponsorship URL

package/CHANGELOG.md

@@ -0,0 +1,136 @@
+# Changelog
+
+All notable changes to this project will be documented in this file.
+
+The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
+and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
+
+## [v4.0.5](https://github.com/browserify/createECDH/compare/v4.0.4...v4.0.5) - 2026-11-13
+
+### Commits
+
+- [eslint] remove autofixable overrides [`0d88756`](https://github.com/browserify/createECDH/commit/0d88756535ce694d513cf9f4586a66194c48db2e)
+- [meta] modernize the package [`25eea4b`](https://github.com/browserify/createECDH/commit/25eea4bc4aec9a77e1d0e3c8da4ff06e31b614f5)
+- [eslint] remove remaining overrides [`f733f24`](https://github.com/browserify/createECDH/commit/f733f2491f804ff4faa759c65cbfb75aa028466d)
+- [Fix] `computeSecret`, `setPublicKey`: reject public keys that are invalid for the curve [`1cfaf33`](https://github.com/browserify/createECDH/commit/1cfaf332773237e5fea4b51a2ad3efab4c22bec1)
+- [meta] switch to eslint [`cdd622f`](https://github.com/browserify/createECDH/commit/cdd622f17b1a5948eb823352515444fa46367009)
+- [Fix] use the JS implementation when native `setPrivateKey` does not compute the public key [`13fadb6`](https://github.com/browserify/createECDH/commit/13fadb63b6be0e72fa1917b0396fdc9f28858684)
+- [Deps] update `bn.js`, `elliptic` [`3adc987`](https://github.com/browserify/createECDH/commit/3adc987435d3849600267cd108bdaa83e1e52ab4)
+- [Robustness] cache `Array.isArray` at module level [`4b33188`](https://github.com/browserify/createECDH/commit/4b33188665910b01c9e8472853bf8e4787204bf4)
+- [meta] add missing auto-changelog settings [`bc21216`](https://github.com/browserify/createECDH/commit/bc212162ed25c069c9586f7a537afd60fde1f0fd)
+
+## [v4.0.4](https://github.com/browserify/createECDH/compare/v4.0.3...v4.0.4) - 2020-08-04
+
+### Merged
+
+- Update elliptic version [`#16`](https://github.com/browserify/createECDH/pull/16)
+
+### Fixed
+
+- Update elliptic version (#16) [`#14`](https://github.com/crypto-browserify/createECDH/issues/14)
+
+## [v4.0.3](https://github.com/browserify/createECDH/compare/v4.0.2...v4.0.3) - 2018-05-07
+
+### Commits
+
+- move standard to dev deps [`5b6ad7a`](https://github.com/browserify/createECDH/commit/5b6ad7a3697706b8c008135e4087c0e1a82f9efa)
+
+## [v4.0.2](https://github.com/browserify/createECDH/compare/v4.0.1...v4.0.2) - 2018-05-07
+
+### Merged
+
+- Private key import [`#8`](https://github.com/browserify/createECDH/pull/8)
+
+## [v4.0.1](https://github.com/browserify/createECDH/compare/v4.0.0...v4.0.1) - 2018-04-11
+
+### Merged
+
+- add license [`#10`](https://github.com/browserify/createECDH/pull/10)
+
+## [v4.0.0](https://github.com/browserify/createECDH/compare/v3.0.0...v4.0.0) - 2015-10-29
+
+### Merged
+
+- update bn and elliptic [`#7`](https://github.com/browserify/createECDH/pull/7)
+
+## [v3.0.0](https://github.com/browserify/createECDH/compare/v2.0.2...v3.0.0) - 2015-10-26
+
+### Merged
+
+- upgrade bn.js and elliptic, add 2 curves [`#6`](https://github.com/browserify/createECDH/pull/6)
+
+### Commits
+
+- upgrade bn.js and eleptic, add 2 curves [`84f7984`](https://github.com/browserify/createECDH/commit/84f798475470600dfbb2259ff03d702ccd91018d)
+
+## [v2.0.2](https://github.com/browserify/createECDH/compare/v2.0.1...v2.0.2) - 2015-10-05
+
+### Merged
+
+- add browser field [`#5`](https://github.com/browserify/createECDH/pull/5)
+
+## [v2.0.1](https://github.com/browserify/createECDH/compare/v2.0.0...v2.0.1) - 2015-05-21
+
+### Merged
+
+- update deps [`#4`](https://github.com/browserify/createECDH/pull/4)
+
+### Commits
+
+- adds npmignore [`3cbf265`](https://github.com/browserify/createECDH/commit/3cbf265600d93aef242c56e72c68ac812c844b92)
+
+## [v2.0.0](https://github.com/browserify/createECDH/compare/v1.0.3...v2.0.0) - 2015-02-12
+
+### Merged
+
+- modularize, expand documentation, expand curve list [`#3`](https://github.com/browserify/createECDH/pull/3)
+
+### Commits
+
+- ecdh [`649d8ee`](https://github.com/browserify/createECDH/commit/649d8ee793c080c97f0dc9908075da51e5e66fd2)
+- add prime generation [`feb843b`](https://github.com/browserify/createECDH/commit/feb843bb68872e2b2387839c10d0ecfa66476662)
+- modularize [`96e6a1e`](https://github.com/browserify/createECDH/commit/96e6a1e18595b512ba600dd409640333d6fe30b5)
+- gen primes [`32b0cd0`](https://github.com/browserify/createECDH/commit/32b0cd0b6c3bb8a52161a4776970d2950ac36008)
+- clean up prime generation [`721d40b`](https://github.com/browserify/createECDH/commit/721d40b6418dfce6e356af62f297a1cced5679a7)
+- rm fast primes [`08779de`](https://github.com/browserify/createECDH/commit/08779de3f58bf83ef7b135b867a503154cf9c472)
+- add factory, return this on set functions [`9aa1df2`](https://github.com/browserify/createECDH/commit/9aa1df299026ea6c40a6dbd254f9d80b7cc075a3)
+- generate primes [`f1d7cc3`](https://github.com/browserify/createECDH/commit/f1d7cc3257525be9e1a34338271dc4de27a0196d)
+- update .travis.yml [`5576ed5`](https://github.com/browserify/createECDH/commit/5576ed5b70f622f6a70884ab963334d46e5a8afb)
+- update eliptic [`6b3fbd0`](https://github.com/browserify/createECDH/commit/6b3fbd00c9930e23921b276acedcb1788d1d03d2)
+- Update bn.js [`08a105a`](https://github.com/browserify/createECDH/commit/08a105a882f6db84abd81e9f9109146d20fe8562)
+- Update bn.js [`fb6a7d9`](https://github.com/browserify/createECDH/commit/fb6a7d960c5c45469fa6abd3e67a7b1d9a976ddf)
+- name [`99208c8`](https://github.com/browserify/createECDH/commit/99208c8728a9e671cc46d4afe97c7a3b71974f3d)
+- travis [`810fac1`](https://github.com/browserify/createECDH/commit/810fac1b8ff14ace34ddd88c49b09bed1a45e25b)
+- touch travis [`9039dea`](https://github.com/browserify/createECDH/commit/9039deaf14d2a1903aee048338cdf7fe5bb2e556)
+- rm console log [`c40a075`](https://github.com/browserify/createECDH/commit/c40a075e7bf3b16e5eb6024eb472f3106b0f0f26)
+
+## [v1.0.3](https://github.com/browserify/createECDH/compare/v1.0.2...v1.0.3) - 2014-11-04
+
+### Commits
+
+- Revert "bench" [`54dc2a2`](https://github.com/browserify/createECDH/commit/54dc2a28b5ff73a61c261b721b0665a349b2c67d)
+- bench [`3a4f943`](https://github.com/browserify/createECDH/commit/3a4f943ef0070a8146c0aa8b75e20747acc24040)
+- finish up [`de5c813`](https://github.com/browserify/createECDH/commit/de5c8132359dbf07182576e2dcdc771ae412e41f)
+
+## [v1.0.2](https://github.com/browserify/createECDH/compare/v1.0.1...v1.0.2) - 2014-11-02
+
+## v1.0.1 - 2015-01-03
+
+### Commits
+
+- ecdh [`649d8ee`](https://github.com/browserify/createECDH/commit/649d8ee793c080c97f0dc9908075da51e5e66fd2)
+- first [`923fdc5`](https://github.com/browserify/createECDH/commit/923fdc540603443b7da981094c8906f722ce1ef8)
+- add prime generation [`feb843b`](https://github.com/browserify/createECDH/commit/feb843bb68872e2b2387839c10d0ecfa66476662)
+- gen primes [`32b0cd0`](https://github.com/browserify/createECDH/commit/32b0cd0b6c3bb8a52161a4776970d2950ac36008)
+- works [`a4ec953`](https://github.com/browserify/createECDH/commit/a4ec953802fdc5944a0318331bfadea364942cde)
+- clean up prime generation [`721d40b`](https://github.com/browserify/createECDH/commit/721d40b6418dfce6e356af62f297a1cced5679a7)
+- Revert "bench" [`54dc2a2`](https://github.com/browserify/createECDH/commit/54dc2a28b5ff73a61c261b721b0665a349b2c67d)
+- bench [`3a4f943`](https://github.com/browserify/createECDH/commit/3a4f943ef0070a8146c0aa8b75e20747acc24040)
+- rm fast primes [`08779de`](https://github.com/browserify/createECDH/commit/08779de3f58bf83ef7b135b867a503154cf9c472)
+- finish up [`de5c813`](https://github.com/browserify/createECDH/commit/de5c8132359dbf07182576e2dcdc771ae412e41f)
+- deps [`911fcfb`](https://github.com/browserify/createECDH/commit/911fcfb2ffb579f2668a5e5dbd927bbaa36660fe)
+- generate primes [`f1d7cc3`](https://github.com/browserify/createECDH/commit/f1d7cc3257525be9e1a34338271dc4de27a0196d)
+- Update bn.js [`fb6a7d9`](https://github.com/browserify/createECDH/commit/fb6a7d960c5c45469fa6abd3e67a7b1d9a976ddf)
+- name [`99208c8`](https://github.com/browserify/createECDH/commit/99208c8728a9e671cc46d4afe97c7a3b71974f3d)
+- travis [`810fac1`](https://github.com/browserify/createECDH/commit/810fac1b8ff14ace34ddd88c49b09bed1a45e25b)
+- rm console log [`c40a075`](https://github.com/browserify/createECDH/commit/c40a075e7bf3b16e5eb6024eb472f3106b0f0f26)

package/browser.js

@@ -1,124 +1,129 @@
-var elliptic = require('elliptic')
-var BN = require('bn.js')
+'use strict';
 
-module.exports = function createECDH (curve) {
-  return new ECDH(curve)
-}
+var elliptic = require('elliptic');
+var BN = require('bn.js');
+
+var isArray = Array.isArray;
 
 var aliases = {
-  secp256k1: {
-    name: 'secp256k1',
-    byteLength: 32
-  },
-  secp224r1: {
-    name: 'p224',
-    byteLength: 28
-  },
-  prime256v1: {
-    name: 'p256',
-    byteLength: 32
-  },
-  prime192v1: {
-    name: 'p192',
-    byteLength: 24
-  },
-  ed25519: {
-    name: 'ed25519',
-    byteLength: 32
-  },
-  secp384r1: {
-    name: 'p384',
-    byteLength: 48
-  },
-  secp521r1: {
-    name: 'p521',
-    byteLength: 66
-  }
+	ed25519: {
+		byteLength: 32,
+		name: 'ed25519'
+	},
+	prime192v1: {
+		byteLength: 24,
+		name: 'p192'
+	},
+	prime256v1: {
+		byteLength: 32,
+		name: 'p256'
+	},
+	secp224r1: {
+		byteLength: 28,
+		name: 'p224'
+	},
+	secp256k1: {
+		byteLength: 32,
+		name: 'secp256k1'
+	},
+	secp384r1: {
+		byteLength: 48,
+		name: 'p384'
+	},
+	secp521r1: {
+		byteLength: 66,
+		name: 'p521'
+	}
+};
+
+aliases.p224 = aliases.secp224r1;
+aliases.secp256r1 = aliases.prime256v1;
+aliases.p256 = aliases.prime256v1;
+aliases.secp192r1 = aliases.prime192v1;
+aliases.p192 = aliases.prime192v1;
+aliases.p384 = aliases.secp384r1;
+aliases.p521 = aliases.secp521r1;
+
+function formatReturnValue(bn, enc, len) {
+	var arr = isArray(bn) ? bn : bn.toArray();
+	var buf = new Buffer(arr);
+	if (len && buf.length < len) {
+		var zeros = new Buffer(len - buf.length);
+		zeros.fill(0);
+		buf = Buffer.concat([zeros, buf]);
+	}
+	if (!enc) {
+		return buf;
+	}
+	return buf.toString(enc);
+
 }
 
-aliases.p224 = aliases.secp224r1
-aliases.p256 = aliases.secp256r1 = aliases.prime256v1
-aliases.p192 = aliases.secp192r1 = aliases.prime192v1
-aliases.p384 = aliases.secp384r1
-aliases.p521 = aliases.secp521r1
-
-function ECDH (curve) {
-  this.curveType = aliases[curve]
-  if (!this.curveType) {
-    this.curveType = {
-      name: curve
-    }
-  }
-  this.curve = new elliptic.ec(this.curveType.name) // eslint-disable-line new-cap
-  this.keys = void 0
+function ECDH(curve) {
+	this.curveType = aliases[curve];
+	if (!this.curveType) {
+		this.curveType = {
+			name: curve
+		};
+	}
+	this.curve = new elliptic.ec(this.curveType.name); // eslint-disable-line new-cap
+	this.keys = void 0;
 }
 
 ECDH.prototype.generateKeys = function (enc, format) {
-  this.keys = this.curve.genKeyPair()
-  return this.getPublicKey(enc, format)
+	this.keys = this.curve.genKeyPair();
+	return this.getPublicKey(enc, format);
+};
+
+function validPublicKey(curve, pubBuf) {
+	var key = curve.keyFromPublic(pubBuf);
+	// rejects the point at infinity, points not on the curve, and points outside the prime-order subgroup
+	var pub = key.getPublic();
+	// elliptic's Montgomery ladder wrongly reports n * (x = 0) as infinity, so that low-order point passes `validate`
+	if (!key.validate().result || (curve.curve.type === 'mont' && pub.getX().isZero())) {
+		throw new Error('Public key is not valid for specified curve');
+	}
+	return pub;
 }
 
 ECDH.prototype.computeSecret = function (other, inenc, enc) {
-  inenc = inenc || 'utf8'
-  if (!Buffer.isBuffer(other)) {
-    other = new Buffer(other, inenc)
-  }
-  var otherPub = this.curve.keyFromPublic(other).getPublic()
-  var out = otherPub.mul(this.keys.getPrivate()).getX()
-  return formatReturnValue(out, enc, this.curveType.byteLength)
-}
+	var otherBuf = Buffer.isBuffer(other) ? other : new Buffer(other, inenc || 'utf8');
+	var otherPub = validPublicKey(this.curve, otherBuf);
+	var out = this.keys.derive(otherPub);
+	return formatReturnValue(out, enc, this.curveType.byteLength);
+};
 
 ECDH.prototype.getPublicKey = function (enc, format) {
-  var key = this.keys.getPublic(format === 'compressed', true)
-  if (format === 'hybrid') {
-    if (key[key.length - 1] % 2) {
-      key[0] = 7
-    } else {
-      key[0] = 6
-    }
-  }
-  return formatReturnValue(key, enc)
-}
+	var key = this.keys.getPublic(format === 'compressed', true);
+	if (format === 'hybrid') {
+		if (key[key.length - 1] % 2) {
+			key[0] = 7;
+		} else {
+			key[0] = 6;
+		}
+	}
+	return formatReturnValue(key, enc);
+};
 
 ECDH.prototype.getPrivateKey = function (enc) {
-  return formatReturnValue(this.keys.getPrivate(), enc)
-}
+	return formatReturnValue(this.keys.getPrivate(), enc);
+};
 
 ECDH.prototype.setPublicKey = function (pub, enc) {
-  enc = enc || 'utf8'
-  if (!Buffer.isBuffer(pub)) {
-    pub = new Buffer(pub, enc)
-  }
-  this.keys._importPublic(pub)
-  return this
-}
+	var pubBuf = Buffer.isBuffer(pub) ? pub : new Buffer(pub, enc || 'utf8');
+	this.keys.pub = validPublicKey(this.curve, pubBuf);
+	return this;
+};
 
 ECDH.prototype.setPrivateKey = function (priv, enc) {
-  enc = enc || 'utf8'
-  if (!Buffer.isBuffer(priv)) {
-    priv = new Buffer(priv, enc)
-  }
-
-  var _priv = new BN(priv)
-  _priv = _priv.toString(16)
-  this.keys = this.curve.genKeyPair()
-  this.keys._importPrivate(_priv)
-  return this
-}
+	var privBuf = Buffer.isBuffer(priv) ? priv : new Buffer(priv, enc || 'utf8');
 
-function formatReturnValue (bn, enc, len) {
-  if (!Array.isArray(bn)) {
-    bn = bn.toArray()
-  }
-  var buf = new Buffer(bn)
-  if (len && buf.length < len) {
-    var zeros = new Buffer(len - buf.length)
-    zeros.fill(0)
-    buf = Buffer.concat([zeros, buf])
-  }
-  if (!enc) {
-    return buf
-  } else {
-    return buf.toString(enc)
-  }
-}
+	var privHex = new BN(privBuf).toString(16);
+	this.keys = this.curve.genKeyPair();
+	this.keys._importPrivate(privHex);
+	return this;
+};
+
+module.exports = function createECDH(curve) {
+	return new ECDH(curve);
+};

package/index.js

@@ -1,3 +1,23 @@
-var createECDH = require('crypto').createECDH
+'use strict';
 
-module.exports = createECDH || require('./browser')
+var createECDH = require('crypto').createECDH;
+
+// secp256k1 generator point, ie, the public key for a private key of 1
+var G = '0479be667ef9dcbbac55a06295ce870b07029bfcdb2dce28d959f2815b16f81798483ada7726a3c4655da4fbfc0e1108a8fd17b448a68554199c47d08ffb10d4b8';
+
+// node < 5 does not compute the public key in `setPrivateKey`
+function nativeIsCorrect() {
+	if (!createECDH) {
+		return false;
+	}
+	try {
+		var ecdh = createECDH('secp256k1');
+		ecdh.setPrivateKey('01', 'hex');
+		return ecdh.getPublicKey('hex') === G;
+	} catch (e) {
+		return false;
+	}
+}
+
+/* istanbul ignore next */
+module.exports = nativeIsCorrect() ? createECDH : require('./browser');

package/package.json

@@ -1,16 +1,28 @@
 {
   "name": "create-ecdh",
-  "version": "4.0.4",
+  "version": "4.0.5",
   "description": "createECDH but browserifiable",
   "main": "index.js",
   "browser": "browser.js",
   "scripts": {
-    "test": "standard && node test.js | tspec"
+    "prepack": "npmignore --auto --commentLines=autogenerated",
+    "prepublishOnly": "safe-publish-latest",
+    "prepublish": "not-in-publish || npm run prepublishOnly",
+    "lint": "eslint .",
+    "pretest": "npm run lint",
+    "tests-only": "nyc tape 'test/**/*'",
+    "test": "npm run tests-only",
+    "posttest": "npx npm@\">= 10.2\" audit --production",
+    "version": "auto-changelog && git add CHANGELOG.md",
+    "postversion": "auto-changelog && git add CHANGELOG.md && git commit --no-edit --amend && git tag -f \"v$(node -e \"console.log(require('./package.json').version)\")\""
   },
   "repository": {
     "type": "git",
     "url": "https://github.com/crypto-browserify/createECDH.git"
   },
+  "funding": {
+    "url": "https://github.com/sponsors/ljharb"
+  },
   "keywords": [
     "diffie",
     "hellman",
@@ -24,12 +36,36 @@
   },
   "homepage": "https://github.com/crypto-browserify/createECDH",
   "dependencies": {
-    "bn.js": "^4.1.0",
-    "elliptic": "^6.5.3"
+    "bn.js": "^4.12.5",
+    "elliptic": "^6.6.1"
   },
   "devDependencies": {
-    "tap-spec": "^1.0.1",
-    "tape": "^3.0.1",
-    "standard": "^5.4.1"
+    "@ljharb/eslint-config": "^22.2.5",
+    "auto-changelog": "^2.7.0",
+    "eslint": "^10.14.0",
+    "in-publish": "^2.0.1",
+    "jiti": "^0.0.0",
+    "npmignore": "^0.3.6",
+    "nyc": "^10.3.2",
+    "safe-publish-latest": "^2.0.0",
+    "tape": "^5.10.3"
+  },
+  "engines": {
+    "node": ">= 0.4"
+  },
+  "publishConfig": {
+    "ignore": [
+      ".github/workflows",
+      "eslint.config.mjs",
+      "test"
+    ]
+  },
+  "auto-changelog": {
+    "output": "CHANGELOG.md",
+    "template": "keepachangelog",
+    "unreleased": false,
+    "commitLimit": false,
+    "backfillLimit": false,
+    "hideCredit": true
   }
 }

package/.travis.yml

@@ -1,7 +0,0 @@
-language: node_js
-sudo: false
-node_js:
-  - 6
-  - 8
-  - 9
-  - 10