create-dig-app 0.1.1 → 0.2.3

package/lib/nft-metadata.js

@@ -57,6 +57,9 @@ function attrValue(v) {
  * Normalize a list of `{trait_type,value}` (accepting `traitType` too) into the canonical attribute
  * array: trimmed string `trait_type` + stringified `value`, dropping any entry with an empty
  * trait_type. Order is preserved (CHIP-0007 does not sort attributes).
+ *
+ * This is for NFT-**item** attributes only. Collection-level attributes use `type`, not
+ * `trait_type` — see {@link normalizeCollectionAttributes} (#189).
  * @param {Array<{trait_type?:string,traitType?:string,value:unknown}>} attrs
  * @returns {Array<{trait_type:string,value:string}>}
  */
@@ -66,6 +69,31 @@ function normalizeAttributes(attrs) {
     .filter((a) => a.trait_type !== "");
 }
 
+/**
+ * Normalize a list of **collection-level** attributes (icon/banner/website/twitter/etc) into the
+ * canonical shape: trimmed string `type` + stringified `value`, dropping any entry with an empty
+ * `type`. Order is preserved.
+ *
+ * Per CHIP-0007, a collection's attributes use the field `type` — DISTINCT from an NFT item's
+ * `trait_type` ({@link normalizeAttributes}). Issue #189 (the emit-side twin of digstore's #187 and
+ * chip35_dl_coin's own fix): this repo's generator was reusing the item shape for collection
+ * attributes too, emitting non-conformant `trait_type` for the collection block. This function
+ * always WRITES `type`; it still ACCEPTS the legacy `trait_type`/`traitType` spellings on input
+ * (back-compat with already-authored `collection.json` files and the wasm boundary's alias), so
+ * existing scaffolded projects keep working unchanged while newly generated metadata becomes
+ * CHIP-0007-conformant.
+ * @param {Array<{type?:string,trait_type?:string,traitType?:string,value:unknown}>} attrs
+ * @returns {Array<{type:string,value:string}>}
+ */
+function normalizeCollectionAttributes(attrs) {
+  return (attrs ?? [])
+    .map((a) => ({
+      type: String(a?.type ?? a?.trait_type ?? a?.traitType ?? "").trim(),
+      value: attrValue(a?.value),
+    }))
+    .filter((a) => a.type !== "");
+}
+
 /**
  * Build a canonical CHIP-0007 metadata object from loose inputs. The returned object's keys are in
  * the pinned field order and omit empty/false/None fields, so {@link canonicalJson} of it is
@@ -76,7 +104,8 @@ function normalizeAttributes(attrs) {
  * @param {string} [input.description]         Optional; omitted when empty/undefined.
  * @param {boolean} [input.sensitive_content]  Omitted when falsey.
  * @param {{id:string,name:string,attributes?:Array}} [input.collection]  Collection ref; its
- *   `attributes` are omitted when empty.
+ *   `attributes` (CHIP-0007 `type`/`value` pairs — NOT `trait_type`, see #189) are omitted when
+ *   empty.
  * @param {Array<{trait_type?:string,traitType?:string,value:unknown}>} [input.attributes] Per-item traits.
  * @param {number} [input.series_number]       1-based position; omitted when undefined.
  * @param {number} [input.series_total]        Series size; omitted when undefined.
@@ -94,7 +123,7 @@ export function buildChip0007Metadata(input) {
   if (input?.collection) {
     const c = input.collection;
     const ref = { id: String(c.id ?? ""), name: String(c.name ?? "") };
-    const cattrs = normalizeAttributes(c.attributes);
+    const cattrs = normalizeCollectionAttributes(c.attributes);
     if (cattrs.length > 0) ref.attributes = cattrs;
     md.collection = ref;
   }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "create-dig-app",
-  "version": "0.1.1",
+  "version": "0.2.3",
   "description": "Scaffold a wallet-wired, deployable DIG Network app — free, no mint. The JS front door for building dapps, frontends, and NFT collections on Chia.",
   "license": "MIT",
   "author": "DIG Network",
@@ -41,8 +41,8 @@
     "node": ">=18"
   },
   "scripts": {
-    "test": "node --test test/",
-    "coverage": "c8 node --test test/",
+    "test": "node --test",
+    "coverage": "c8 node --test",
     "start": "node bin/create-dig-app.js"
   },
   "devDependencies": {

package/templates/nft-collection/collection.json

@@ -9,6 +9,6 @@
   "icon": "assets/icon.svg",
   "banner": "assets/banner.svg",
   "attributes": [
-    { "trait_type": "Website", "value": "https://example.on.dig.net" }
+    { "type": "Website", "value": "https://example.on.dig.net" }
   ]
 }

package/templates/nft-collection/scripts/dig-nft.mjs

@@ -56,6 +56,18 @@ function normalizeAttributes(attrs) {
     .filter((a) => a.trait_type !== "");
 }
 
+// Collection-level attributes use CHIP-0007's `type` field, NOT the item shape's `trait_type`
+// (#189 — the emit-side twin of digstore's #187 / chip35_dl_coin's own fix). Still accepts the
+// legacy `trait_type`/`traitType` spellings on input so an existing collection.json keeps working.
+function normalizeCollectionAttributes(attrs) {
+  return (attrs ?? [])
+    .map((a) => ({
+      type: String(a?.type ?? a?.trait_type ?? a?.traitType ?? "").trim(),
+      value: attrValue(a?.value),
+    }))
+    .filter((a) => a.type !== "");
+}
+
 function buildChip0007Metadata(input) {
   const md = { format: CHIP0007_FORMAT, name: String(input?.name ?? "") };
   const description = input?.description;
@@ -64,7 +76,7 @@ function buildChip0007Metadata(input) {
   if (input?.collection) {
     const c = input.collection;
     const ref = { id: String(c.id ?? ""), name: String(c.name ?? "") };
-    const cattrs = normalizeAttributes(c.attributes);
+    const cattrs = normalizeCollectionAttributes(c.attributes);
     if (cattrs.length > 0) ref.attributes = cattrs;
     md.collection = ref;
   }