create-cmp-cli 0.17.0 → 0.17.1

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "create-cmp-cli",
-  "version": "0.17.0",
+  "version": "0.17.1",
   "description": "Create production mobile apps (Android + iOS, one Kotlin codebase) with AI — the delivery harness for Compose Multiplatform, the current generation of cross-platform (Google-backed KMP, iOS stable since May 2025). A deterministic, non-interactive generator that scaffolds a green-building app in minutes, then holds AI-driven changes to a machine-enforced verify lane with a committed evidence receipt. Every app carries a device-free UI preview loop (real screens rendered headlessly on save; changed-screen attribution and compile-error surfacing for coding agents, a live gallery for humans) plus agent-first docs (CLAUDE.md + AGENTS.md). Installs the `create-cmp` command.",
   "type": "module",
   "bin": {

package/src/commands/doctor.mjs

@@ -7,11 +7,13 @@
 //                     [--target-dir <dir>] [--fix]
 //
 // --fix applies only SAFE heals (write local.properties from ANDROID_HOME, add
-// ksp.useKSP2=true); everything else prints the exact manual step.
+// ksp.useKSP2=true, wire the walk into .claude/settings.json); everything else
+// prints the exact manual step.
 
 import fs from "node:fs";
 import os from "node:os";
 import path from "node:path";
+import { fileURLToPath } from "node:url";
 
 import { flagBool } from "../lib/args.mjs";
 import { colors, ok } from "../lib/log.mjs";
@@ -71,6 +73,65 @@ function freeDiskBytes() {
   }
 }
 
+/** This engine checkout root — the template it ships is the wiring of record. */
+const ENGINE_ROOT = path.join(path.dirname(fileURLToPath(import.meta.url)), "..", "..");
+
+/**
+ * The walk wiring the CURRENT engine template declares: the statusLine object
+ * and the UserPromptSubmit hook groups that invoke qa/walk-status.mjs. Read from
+ * template/.claude/settings.json rather than duplicated here, so the heal cannot
+ * drift from what a fresh scaffold gets.
+ * @returns {{statusLine: object|null, promptSubmit: Array|null}}
+ */
+export function templateWalkWiring() {
+  const raw = readIfExists(path.join(ENGINE_ROOT, "template", ".claude", "settings.json"));
+  if (raw === null) return { statusLine: null, promptSubmit: null };
+  try {
+    const t = JSON.parse(raw);
+    const statusLine = invokesWalk(t.statusLine) ? t.statusLine : null;
+    const groups = (t.hooks?.UserPromptSubmit ?? []).filter((g) =>
+      (g?.hooks ?? []).some(invokesWalk)
+    );
+    return { statusLine, promptSubmit: groups.length > 0 ? groups : null };
+  } catch {
+    return { statusLine: null, promptSubmit: null };
+  }
+}
+
+/** Does this settings entry ({type, command}) actually run the walk? */
+function invokesWalk(entry) {
+  return String(entry?.command ?? "").includes("walk-status.mjs");
+}
+
+/**
+ * Is the walk installed, and does .claude/settings.json invoke it? The machinery
+ * and the wiring live in separately-owned files (lane vs app config), so they can
+ * and do come apart — see the walk-wiring finding in project-doctor.mjs.
+ */
+export function gatherWalkInputs(projectDir) {
+  const scriptPresent = fs.existsSync(path.join(projectDir, "qa", "walk-status.mjs"));
+  if (!scriptPresent) return null; // not a walk-carrying lane — nothing to say
+  const raw = readIfExists(path.join(projectDir, ".claude", "settings.json"));
+  if (raw === null) {
+    return { scriptPresent, settingsPresent: false, statusLine: false, promptHook: false };
+  }
+  let settings;
+  try {
+    settings = JSON.parse(raw);
+  } catch {
+    // Unparseable settings invoke nothing, which is exactly what we report.
+    return { scriptPresent, settingsPresent: true, statusLine: false, promptHook: false };
+  }
+  return {
+    scriptPresent,
+    settingsPresent: true,
+    statusLine: invokesWalk(settings.statusLine),
+    promptHook: (settings.hooks?.UserPromptSubmit ?? []).some((g) =>
+      (g?.hooks ?? []).some(invokesWalk)
+    ),
+  };
+}
+
 /** Gather filesystem/env inputs for the pure diagnosis. */
 export function gatherProjectInputs(projectDir) {
   const toml = readIfExists(path.join(projectDir, "gradle", "libs.versions.toml"));
@@ -112,6 +173,7 @@ export function gatherProjectInputs(projectDir) {
     freeDiskBytes: freeDiskBytes(),
     inspectorHits,
     inspectorCatalog,
+    walk: gatherWalkInputs(projectDir),
   };
 }
 
@@ -146,7 +208,7 @@ function scanInspectorSources(projectDir) {
 }
 
 /** Apply the SAFE auto-heals for --fix. Returns ids of findings it fixed. */
-function applySafeFixes(projectDir, findings, inputs) {
+export function applySafeFixes(projectDir, findings, inputs) {
   const fixed = [];
   for (const f of findings) {
     if (!f.fix || !f.fix.auto || f.level === "ok") continue;
@@ -164,6 +226,43 @@ function applySafeFixes(projectDir, findings, inputs) {
       }
     }
 
+    if (f.id === "walk-wiring") {
+      const { statusLine, promptSubmit } = templateWalkWiring();
+      const target = path.join(projectDir, ".claude", "settings.json");
+      const raw = readIfExists(target);
+      let settings = {};
+      if (raw !== null) {
+        try {
+          settings = JSON.parse(raw);
+        } catch {
+          // Never overwrite settings we could not read — that is the app's file.
+          continue;
+        }
+      }
+      let changed = false;
+      if (statusLine && !invokesWalk(settings.statusLine)) {
+        // Only claim an unclaimed slot: an app that set its OWN status line keeps it.
+        if (!settings.statusLine) {
+          settings.statusLine = statusLine;
+          changed = true;
+        }
+      }
+      if (promptSubmit) {
+        settings.hooks = settings.hooks ?? {};
+        const existing = settings.hooks.UserPromptSubmit ?? [];
+        if (!existing.some((g) => (g?.hooks ?? []).some(invokesWalk))) {
+          settings.hooks.UserPromptSubmit = [...existing, ...promptSubmit];
+          changed = true;
+        }
+      }
+      if (changed) {
+        fs.mkdirSync(path.dirname(target), { recursive: true });
+        fs.writeFileSync(target, `${JSON.stringify(settings, null, 2)}\n`);
+        ok("--fix: wired the walk into .claude/settings.json (statusLine + UserPromptSubmit)");
+        fixed.push(f.id);
+      }
+    }
+
     if (f.id === "ksp2-flag") {
       const target = path.join(projectDir, "gradle.properties");
       const existing = inputs.gradleProperties ?? "";

package/src/lib/hooks.mjs

@@ -42,7 +42,10 @@ export function isEnforcementEvent(event) {
   return ENFORCEMENT_EVENTS.has(event);
 }
 
-/** Does this hook's command presuppose the verify lane (`qa/`)? */
+/**
+ * Does this entry's command presuppose the verify lane (`qa/`)? Takes anything
+ * settings.json can hold a command in — a hook, or the top-level `statusLine`.
+ */
 export function referencesLane(hook) {
   return String(hook?.command ?? "").includes("qa/");
 }
@@ -118,12 +121,20 @@ export function sessionStartCommand(context) {
 
 /**
  * The minimal-mode hook set, DERIVED from the full one rather than kept as a
- * second file to hold in sync (light is a filter, not a fork). Three edits:
+ * second file to hold in sync (light is a filter, not a fork). Four edits:
  *
  *   (a) enforcement goes — the Stop hook is Act 3;
  *   (b) lane-advisory goes — a nudge naming qa/ presupposes the lane;
  *   (c) SessionStart says what is true HERE — `sessionContext` describes what
- *       this scaffold carries and the one command that adds the rest.
+ *       this scaffold carries and the one command that adds the rest;
+ *   (d) a lane-referencing `statusLine` goes. It is not a hook, so the
+ *       classifier above never saw it, and the first cut of the walk shipped a
+ *       minimal scaffold a status line reading `qa/walk-status.mjs` — a file
+ *       minimal deletes. The command is guarded (`test -f … || true`) so it
+ *       printed nothing rather than erroring, which is exactly what made it
+ *       survive review: dead config that fails silently. The lane-reference
+ *       rule is the same one that drops lane-advisory hooks; it just has to be
+ *       applied to every surface that carries a command, not only to `hooks`.
  *
  * @param {object} settings parsed .claude/settings.json content
  * @param {object} opts
@@ -131,7 +142,9 @@ export function sessionStartCommand(context) {
  */
 export function minimalHookSettings(settings, { sessionContext }) {
   const out = filterHooks(settings, (event, hook) => classifyHook(event, hook) !== "advisory");
-  if (!out || typeof out.hooks !== "object" || out.hooks === null) return out;
+  if (!out || typeof out !== "object") return out;
+  if (referencesLane(out.statusLine)) delete out.statusLine;
+  if (typeof out.hooks !== "object" || out.hooks === null) return out;
   for (const group of out.hooks.SessionStart ?? []) {
     if (!Array.isArray(group?.hooks)) continue;
     for (const hook of group.hooks) hook.command = sessionStartCommand(sessionContext);

package/src/lib/project-doctor.mjs

@@ -36,6 +36,10 @@ export const DISK_WARN_BYTES = 3 * GIB;
  * @param {string[]|null} [input.inspectorHits] relative (posix) paths of Kotlin sources that
  *        reference the live-inspector endpoint (`/inspect/` or `InspectorHttpServer`);
  *        null = scan skipped (no composeApp sources), [] = project has no inspector code.
+ * @param {{scriptPresent:boolean, settingsPresent:boolean, statusLine:boolean,
+ *          promptHook:boolean}|null} [input.walk] the walk's wiring: is
+ *        qa/walk-status.mjs installed, and does .claude/settings.json actually
+ *        INVOKE it (statusLine + UserPromptSubmit)? null = skip the check.
  * @param {{catalog:string, theme:string}|null} [input.inspectorCatalog] the stamped
  *        InspectorCatalog.kt content + concatenated theme sources (Tokens.kt/Theme.kt) for
  *        the declared-token drift tripwire; null = skip.
@@ -55,6 +59,7 @@ export function diagnoseProject(input) {
     freeDiskBytes,
     inspectorHits = null,
     inspectorCatalog = null,
+    walk = null,
   } = input;
 
   // --- version catalog ------------------------------------------------------
@@ -313,6 +318,49 @@ export function diagnoseProject(input) {
     }
   }
 
+  // --- the walk: installed but unwired ----------------------------------------
+  // qa/walk-status.mjs is inert on its own. What renders it is .claude/settings.json:
+  // a statusLine (the ambient "where are we") and a UserPromptSubmit hook (the
+  // per-turn position injected into the agent). Both are APP-OWNED config, so an app
+  // that hand-edited settings.json can take the machinery on upgrade and lose the
+  // wiring — and the failure mode is silence, which is precisely the problem the walk
+  // exists to fix. Nothing else in the system can notice, so doctor does.
+  if (walk !== null && walk.scriptPresent) {
+    const missing = [
+      !walk.statusLine ? "no statusLine" : null,
+      !walk.promptHook ? "no UserPromptSubmit hook" : null,
+    ].filter(Boolean);
+    if (missing.length === 0) {
+      findings.push({
+        id: "walk-wiring",
+        level: "ok",
+        title: "The walk is wired",
+        detail:
+          "qa/walk-status.mjs is installed and .claude/settings.json invokes it from both the " +
+          "status line and UserPromptSubmit.",
+      });
+    } else {
+      findings.push({
+        id: "walk-wiring",
+        level: "warn",
+        title: "The walk is installed but not wired up",
+        detail:
+          "qa/walk-status.mjs is present, but " +
+          (walk.settingsPresent
+            ? `.claude/settings.json does not invoke it (${missing.join(", ")}).`
+            : "there is no .claude/settings.json to invoke it from.") +
+          " Nothing will show which stage a feature is at, or tell the agent where it is — " +
+          "the walk runs nowhere. Running node qa/walk-status.mjs by hand still works.",
+        fix: {
+          auto: true,
+          description:
+            "Add the statusLine and UserPromptSubmit entries to .claude/settings.json " +
+            "(copied from the engine template; existing hooks are left untouched).",
+        },
+      });
+    }
+  }
+
   return findings;
 }