create-byan-agent 2.9.8 → 2.9.9

package/CHANGELOG.md

@@ -7,6 +7,17 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ---
 
+## [2.9.9] - 2026-04-21
+
+### Fixed - MCP copy filter broke on global npm install (root cause of 2.9.6 bug)
+
+- **`copyMcpServer` filter now resolves paths relative to the template src** — the previous filter `(s) => !s.includes('node_modules')` inspected the absolute path, so when BYAN was installed globally (e.g. `/usr/local/lib/node_modules/create-byan-agent/...`), every template file looked like it lived under `node_modules` and was silently skipped. The empty `_byan/mcp/byan-mcp-server/` dossier observed on 2.9.6/2.9.7/2.9.8 had this cause — the post-copy assertion added in 2.9.7 only surfaced the symptom.
+- **`makeNodeModulesFilter(srcRoot)` extracted and exported** — used by `copyMcpServer`; splits the relative path on path separators and skips any component named `node_modules`.
+- **Regression test** added that builds a filter rooted at `/usr/local/lib/node_modules/create-byan-agent/.../byan-mcp-server` and confirms `server.js` passes while a nested `node_modules/` subdir is rejected.
+- **Observed on**: `sudo npm install -g create-byan-agent@2.9.8` → `npx create-byan-agent` → `MCP server copy produced no server.js`.
+
+---
+
 ## [2.9.8] - 2026-04-21
 
 ### Fixed - `update-byan-agent` CLI broken on fresh npm install

package/install/lib/claude-native-setup.js

@@ -50,14 +50,22 @@ async function copyClaudeSettings(projectRoot) {
   return { copied: true };
 }
 
+function makeNodeModulesFilter(srcRoot) {
+  // Checks the path RELATIVE to srcRoot: a global install path like
+  // /usr/local/lib/node_modules/create-byan-agent/... would otherwise make
+  // every file look like it lives under node_modules and get skipped.
+  return (s) => {
+    const rel = path.relative(srcRoot, s);
+    return !rel.split(path.sep).includes('node_modules');
+  };
+}
+
 async function copyMcpServer(projectRoot) {
   const src = path.join(TEMPLATE_ROOT, '_byan', 'mcp', 'byan-mcp-server');
   const dst = path.join(projectRoot, '_byan', 'mcp', 'byan-mcp-server');
   if (!(await fs.pathExists(src))) return { copied: false };
   await fs.ensureDir(dst);
-  await fs.copy(src, dst, { overwrite: true, filter: (s) => !s.includes('node_modules') });
-  // Post-copy sanity check: server.js must exist, otherwise the MCP client will
-  // fail on next Claude Code launch with "Cannot find module" (seen on 2.9.6).
+  await fs.copy(src, dst, { overwrite: true, filter: makeNodeModulesFilter(src) });
   const serverFile = path.join(dst, 'server.js');
   if (!(await fs.pathExists(serverFile))) {
     throw new Error(
@@ -179,6 +187,7 @@ module.exports = {
   copyClaudeSkills,
   copyClaudeSettings,
   copyMcpServer,
+  makeNodeModulesFilter,
   generateMcpConfig,
   installMcpDependencies,
   setupClaudeNative,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "create-byan-agent",
-  "version": "2.9.8",
+  "version": "2.9.9",
   "description": "BYAN v2.8 - Intelligent AI agent creator with ELO trust system + scientific fact-check + Hermes universal dispatcher + native Claude Code integration (hooks, skills, MCP server). Multi-platform (Copilot CLI, Claude Code, Codex). Merise Agile + TDD + 64 Mantras. ~54% LLM cost savings.",
   "main": "src/index.js",
   "bin": {