create-byan-agent 2.4.0 → 2.4.2

package/CHANGELOG.md

@@ -7,6 +7,33 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ---
 
+## [2.4.2] - 2026-02-11
+
+### 🐛 Fixed - Claude Phase 2 System Prompt Separation
+
+**Problem:** On Windows 11, Claude Code Phase 2 chat responded with generic "How can I help you today?" instead of acting as Yanstaller persona.
+
+**Root Cause:** `claude -p "entire_blob"` treats the argument as a user query, not system instructions. The entire system context (Hermes docs, agent catalog, conversation history, instructions) was passed as `-p` argument. Claude ignored it and responded with its default greeting.
+
+**Fix:** Split system prompt from user message using proper Claude Code CLI flags:
+- System context → `--append-system-prompt-file` (temp file, auto-cleaned)
+- User message → `-p` (just the actual user query)
+
+```javascript
+// Before (broken): everything as -p argument
+runCliCommand('claude', ['-p', fullPrompt], projectRoot);
+
+// After (fixed): proper separation
+runCliCommand('claude', [
+  '-p', message,                          // user query only
+  '--append-system-prompt-file', tmpFile   // system context in file
+], projectRoot);
+```
+
+**Impact:** Claude Code Phase 2 now correctly receives Yanstaller persona, Hermes knowledge, and conversation history as system instructions while treating user input as the actual query.
+
+---
+
 ## [2.4.0] - 2026-02-11
 
 ### ✨ Added - Claude Code Native Agent Integration

package/install/bin/create-byan-agent-v2.js

@@ -498,7 +498,7 @@ async function install() {
             '-s'
           ], spawnOpts);
         } else if (detectedPlatforms.codex) {
-          res = spawnSync('codex', ['exec'], { ...spawnOpts, input: promptContent });
+          res = spawnSync('codex', ['exec', promptContent], spawnOpts);
         } else if (detectedPlatforms.claude) {
           res = spawnSync('claude', ['-p', promptContent], spawnOpts);
         }
@@ -684,52 +684,102 @@ async function install() {
       }
     }
     
-    // NEW: Verify authentication for selected platform
+    // Verify authentication for selected platform
     if (selectedPlatform && installMode === 'custom') {
       console.log('');
       console.log(chalk.gray('🔐 Vérification de l\'authentification...'));
       
-      try {
-        let checkCmd;
-        let loginCmd;
-        
-        if (selectedPlatform === 'copilot') {
-          checkCmd = 'copilot --version';
-          loginCmd = 'gh auth login';
-        } else if (selectedPlatform === 'codex') {
-          checkCmd = 'codex --version';
-          loginCmd = 'codex login';
-        } else if (selectedPlatform === 'claude') {
-          checkCmd = 'claude --version';
-          loginCmd = 'claude login';
-        }
-        
-        const result = execSync(checkCmd, { encoding: 'utf8', timeout: 5000, stdio: 'pipe' });
-        console.log(chalk.green(`✓ ${selectedPlatform} disponible`));
-      } catch (error) {
-        console.log('');
-        console.log(chalk.yellow(`⚠️  ${selectedPlatform} n'est pas authentifié ou non disponible`));
-        console.log(chalk.gray(`   Pour vous connecter, exécutez: ${chalk.cyan(loginCmd)}`));
-        if (selectedPlatform === 'claude') {
-          console.log(chalk.gray(`   Alternative: ${chalk.cyan('export ANTHROPIC_API_KEY=sk-ant-...')}`));
-          console.log(chalk.gray(`   Ou dans Claude Code: ${chalk.cyan('/login')}`));
-        }
-        console.log('');
-        
-        const { continueAnyway } = await inquirer.prompt([{
-          type: 'confirm',
-          name: 'continueAnyway',
-          message: 'Continuer avec configuration AUTO (sans conversation)?',
-          default: true
-        }]);
-        
-        if (!continueAnyway) {
-          console.log(chalk.red('Installation annulée. Connectez-vous d\'abord à votre plateforme IA.'));
-          process.exit(1);
+      let isAuthenticated = false;
+      
+      while (!isAuthenticated) {
+        try {
+          let authCheckCmd, authCheckArgs, loginInstructions;
+          const isWindows = process.platform === 'win32';
+          const spawnOpts = { encoding: 'utf8', timeout: 15000, stdio: 'pipe' };
+          if (isWindows) spawnOpts.shell = true;
+          
+          if (selectedPlatform === 'copilot') {
+            // gh auth status returns non-zero if not logged in
+            authCheckCmd = 'gh';
+            authCheckArgs = ['auth', 'status'];
+            loginInstructions = [
+              `${chalk.cyan('gh auth login')}`
+            ];
+          } else if (selectedPlatform === 'codex') {
+            // codex --version as basic check (no auth status command available)
+            authCheckCmd = 'codex';
+            authCheckArgs = ['--version'];
+            loginInstructions = [
+              `${chalk.cyan('codex login')}`
+            ];
+          } else if (selectedPlatform === 'claude') {
+            // claude --version checks install; auth errors surface during -p calls
+            // Use 'claude -p "test" --max-turns 1' for real auth check
+            authCheckCmd = 'claude';
+            authCheckArgs = ['-p', 'reply OK', '--max-turns', '1'];
+            loginInstructions = [
+              `${chalk.cyan('claude login')}`,
+              `${chalk.gray('ou:')} ${chalk.cyan('export ANTHROPIC_API_KEY=sk-ant-...')}`,
+              `${chalk.gray('ou dans Claude Code:')} ${chalk.cyan('/login')}`
+            ];
+          }
+          
+          const res = spawnSync(authCheckCmd, authCheckArgs, spawnOpts);
+          
+          if (res.error) throw res.error;
+          if (res.status !== 0) {
+            const stderr = (res.stderr || '').toString().trim();
+            throw new Error(stderr || `${selectedPlatform} returned exit code ${res.status}`);
+          }
+          
+          isAuthenticated = true;
+          console.log(chalk.green(`✓ ${selectedPlatform} authentifié et disponible`));
+          
+        } catch (error) {
+          console.log('');
+          console.log(chalk.yellow(`⚠️  ${selectedPlatform} n'est pas authentifié ou non disponible`));
+          console.log(chalk.gray(`   Erreur: ${(error.message || '').substring(0, 120)}`));
+          console.log('');
+          console.log(chalk.bold('   Pour vous connecter:'));
+          
+          let loginInstructions;
+          if (selectedPlatform === 'copilot') {
+            loginInstructions = [`${chalk.cyan('gh auth login')}`];
+          } else if (selectedPlatform === 'codex') {
+            loginInstructions = [`${chalk.cyan('codex login')}`];
+          } else if (selectedPlatform === 'claude') {
+            loginInstructions = [
+              `${chalk.cyan('claude login')}`,
+              `${chalk.gray('ou:')} ${chalk.cyan('export ANTHROPIC_API_KEY=sk-ant-...')}`,
+              `${chalk.gray('ou dans Claude Code:')} ${chalk.cyan('/login')}`
+            ];
+          }
+          loginInstructions.forEach((inst, i) => console.log(`   ${i + 1}. ${inst}`));
+          console.log('');
+          
+          const { authAction } = await inquirer.prompt([{
+            type: 'list',
+            name: 'authAction',
+            message: 'Que souhaitez-vous faire?',
+            choices: [
+              { name: '🔄 Réessayer (après connexion dans un autre terminal)', value: 'retry' },
+              { name: '⚡ Continuer en mode AUTO (sans conversation IA)', value: 'auto' },
+              { name: '❌ Annuler l\'installation', value: 'cancel' }
+            ]
+          }]);
+          
+          if (authAction === 'retry') {
+            console.log(chalk.gray('\n🔐 Nouvelle vérification...'));
+            continue;
+          } else if (authAction === 'auto') {
+            installMode = 'auto';
+            selectedPlatform = null;
+            isAuthenticated = true; // exit loop
+          } else {
+            console.log(chalk.red('Installation annulée. Connectez-vous d\'abord à votre plateforme IA.'));
+            process.exit(1);
+          }
         }
-        
-        installMode = 'auto';
-        selectedPlatform = null;
       }
     }
     

package/install/lib/phase2-chat.js

@@ -7,6 +7,7 @@
 
 const { spawnSync } = require('child_process');
 const path = require('path');
+const os = require('os');
 const fs = require('fs-extra');
 const inquirer = require('inquirer');
 const chalk = require('chalk');
@@ -32,6 +33,13 @@ function runCliCommand(cmd, args, cwd, stdinInput) {
   
   const res = spawnSync(cmd, args, opts);
   if (res.error) throw res.error;
+  
+  // Check for non-zero exit code with stderr
+  if (res.status !== 0 && res.stderr) {
+    const stderr = res.stderr.toString().trim();
+    if (stderr) throw new Error(stderr);
+  }
+  
   return (res.stdout || '').toString();
 }
 
@@ -185,9 +193,22 @@ Continue la conversation pour comprendre le projet et personnaliser les agents.`
     if (selectedPlatform === 'copilot') {
       result = runCliCommand('copilot', ['-p', fullPrompt, '-s'], projectRoot);
     } else if (selectedPlatform === 'codex') {
-      result = runCliCommand('codex', ['exec'], projectRoot, fullPrompt);
+      // Codex takes prompt as argument to exec command
+      result = runCliCommand('codex', ['exec', fullPrompt], projectRoot);
     } else if (selectedPlatform === 'claude') {
-      result = runCliCommand('claude', ['-p', fullPrompt], projectRoot);
+      // Claude: separate system prompt from user query
+      // -p treats arg as user query; system context goes via --append-system-prompt-file
+      const claudeSystemCtx = `${systemContext}\n\n## Historique de conversation:\n${conversationHistory}\n\n## Instructions:\nRéponds de manière concise et naturelle. Si l'utilisateur dit "finaliser", génère le JSON de configuration.\nContinue la conversation pour comprendre le projet et personnaliser les agents.`;
+      const tmpFile = path.join(os.tmpdir(), `byan-claude-ctx-${Date.now()}.txt`);
+      fs.writeFileSync(tmpFile, claudeSystemCtx, 'utf8');
+      try {
+        result = runCliCommand('claude', [
+          '-p', message,
+          '--append-system-prompt-file', tmpFile
+        ], projectRoot);
+      } finally {
+        try { fs.unlinkSync(tmpFile); } catch(e) {}
+      }
     } else {
       throw new Error(`Platform not supported: ${selectedPlatform}`);
     }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "create-byan-agent",
-  "version": "2.4.0",
+  "version": "2.4.2",
   "description": "BYAN v2.3.2 - Intelligent AI agent ecosystem with Hermes universal dispatcher + Multi-platform support (Copilot CLI, Claude, Codex) + Automatic LLM cost optimization (87.5% savings) + Node 12+ compatible",
   "main": "src/index.js",
   "bin": {