create-byan-agent 1.2.1 → 1.2.3

package/CHANGELOG.md

@@ -5,6 +5,110 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [1.2.3] - 2026-02-03
+
+### Added
+- **E2E Test Suite** - Automated end-to-end testing before npm publish
+  - Tests complete installation flow (7 steps)
+  - Validates directory structure, agent files, config, platform stubs
+  - Smoke tests for all 8 YANSTALLER modules
+  - Runs automatically via `prepublishOnly` hook
+  - Prevents broken releases (caught 8 bugs before production)
+  - Command: `npm run test:e2e`
+  - Documentation: TEST-E2E-GUIDE.md
+
+### Fixed
+- **CRITICAL BUG #1**: Fixed recommender crash when platforms is undefined
+  - `recommender.recommend()` now properly handles both direct detection object and options wrapper
+  - Added default empty array for platforms parameter in `getRecommendedAgents()`
+  - Added null-check before calling `.some()` on platforms array
+  - Fixed display of detected platforms in CLI (was showing "[object Object]")
+  
+- **CRITICAL BUG #2**: Fixed backup crash on wrong parameter format
+  - Fixed `backuper.backup()` call - now passes bmadPath directly instead of object wrapper
+  
+- **CRITICAL BUG #3**: Fixed installation result property access
+  - Fixed `installResult` property access - uses `agentsInstalled` instead of `installedAgents.length`
+  - Removed references to non-existent properties (`createdDirectories`, `generatedStubs`)
+  - Added error reporting for installation failures
+
+- **CRITICAL BUG #4**: Fixed wizard crash on undefined properties
+  - Added null-checks for `config.agents`, `config.targetPlatforms`, `config.platforms`
+  - Fixed wizard call to pass correct config object with all required properties
+  - Prevents crash when displaying installation summary
+
+- **CRITICAL BUG #5**: Fixed agent templates not found
+  - Limited recommendations to available agents only (byan, rachid, patnote, marc, etc.)
+  - Removed recommendations for non-existent agents (architect, dev, quinn, pm, ux-designer, tech-writer)
+  - Prevents installation failures due to missing template files
+
+- **CRITICAL BUG #6**: Fixed missing fileUtils.readDir function
+  - Added `readDir()` function to file-utils.js
+  - Fixes validator crashes when checking workflow directories
+  - Properly exports readDir in module.exports
+
+- **CRITICAL BUG #7**: Fixed installer config parameter mismatch
+  - Fixed installer.install() call to pass `targetPlatforms` instead of `platforms`
+  - Config file now created correctly during installation
+  - Matches InstallConfig typedef definition
+
+- **BUG #8**: Removed carmack from recommendations
+  - carmack.md template does not exist in templates/_bmad/
+  - Removed from baseAgents to prevent installation failures
+  - Updated E2E test to not expect carmack agent
+
+## [1.2.2] - 2026-02-03
+
+### Added
+- **E2E Test Suite** - Automated end-to-end testing before npm publish
+  - Tests complete installation flow (7 steps)
+  - Validates directory structure, agent files, config, platform stubs
+  - Smoke tests for all 8 YANSTALLER modules
+  - Runs automatically via `prepublishOnly` hook
+  - Prevents broken releases (caught 7 bugs before production)
+  - Command: `npm run test:e2e`
+  - Documentation: TEST-E2E-GUIDE.md
+
+### Fixed
+- **CRITICAL BUG #1**: Fixed recommender crash when platforms is undefined
+  - `recommender.recommend()` now properly handles both direct detection object and options wrapper
+  - Added default empty array for platforms parameter in `getRecommendedAgents()`
+  - Added null-check before calling `.some()` on platforms array
+  - Fixed display of detected platforms in CLI (was showing "[object Object]")
+  
+- **CRITICAL BUG #2**: Fixed backup crash on wrong parameter format
+  - Fixed `backuper.backup()` call - now passes bmadPath directly instead of object wrapper
+  
+- **CRITICAL BUG #3**: Fixed installation result property access
+  - Fixed `installResult` property access - uses `agentsInstalled` instead of `installedAgents.length`
+  - Removed references to non-existent properties (`createdDirectories`, `generatedStubs`)
+  - Added error reporting for installation failures
+
+- **CRITICAL BUG #4**: Fixed wizard crash on undefined properties
+  - Added null-checks for `config.agents`, `config.targetPlatforms`, `config.platforms`
+  - Fixed wizard call to pass correct config object with all required properties
+  - Prevents crash when displaying installation summary
+
+- **CRITICAL BUG #5**: Fixed agent templates not found
+  - Limited recommendations to available agents only (byan, rachid, patnote, carmack, marc, etc.)
+  - Removed recommendations for non-existent agents (architect, dev, quinn, pm, ux-designer, tech-writer)
+  - Prevents installation failures due to missing template files
+
+- **CRITICAL BUG #6**: Fixed missing fileUtils.readDir function
+  - Added `readDir()` function to file-utils.js
+  - Fixes validator crashes when checking workflow directories
+  - Properly exports readDir in module.exports
+
+- **CRITICAL BUG #7**: Fixed installer config parameter mismatch
+  - Fixed installer.install() call to pass `targetPlatforms` instead of `platforms`
+  - Config file now created correctly during installation
+  - Matches InstallConfig typedef definition
+
+- **BUG #8**: Removed carmack from recommendations
+  - carmack.md template does not exist in templates/_bmad/
+  - Removed from baseAgents to prevent installation failures
+  - Updated E2E test to not expect carmack agent
+
 ## [1.2.1] - 2026-02-03
 
 ### Changed

package/README.md

@@ -846,7 +846,7 @@ SOFTWARE.
 
 # 🏗️ YANSTALLER - Intelligent BYAN Installer
 
-[![Version](https://img.shields.io/badge/version-1.2.1-blue.svg)](https://www.npmjs.com/package/create-byan-agent)
+[![Version](https://img.shields.io/badge/version-1.2.3-blue.svg)](https://www.npmjs.com/package/create-byan-agent)
 [![License](https://img.shields.io/badge/license-MIT-green.svg)](LICENSE)
 [![Node](https://img.shields.io/badge/node-%3E%3D18.0.0-brightgreen.svg)](https://nodejs.org)
 [![Tests](https://img.shields.io/badge/tests-168%20passing-success.svg)](#tests)

package/bin/create-byan-agent.js

@@ -14,7 +14,7 @@ const wizard = require('../lib/yanstaller/wizard');
 const backuper = require('../lib/yanstaller/backuper');
 const logger = require('../lib/utils/logger');
 
-const YANSTALLER_VERSION = '1.2.0';
+const YANSTALLER_VERSION = '1.2.3';
 
 // ASCII Art Banner
 const banner = `
@@ -52,7 +52,8 @@ async function main() {
     logger.info(chalk.bold('\n🔍 STEP 1/7: Detection\n'));
     const detection = await detector.detect({ projectRoot });
     
-    logger.info(`✓ Platforms detected: ${chalk.cyan(detection.platforms.join(', ') || 'none')}`);
+    const platformNames = detection.platforms ? detection.platforms.map(p => p.name).join(', ') : 'none';
+    logger.info(`✓ Platforms detected: ${chalk.cyan(platformNames)}`);
     if (detection.projectType) {
       logger.info(`✓ Project type: ${chalk.cyan(detection.projectType)}`);
     }
@@ -79,7 +80,8 @@ async function main() {
     if (answers.createBackup) {
       logger.info(chalk.bold('\n💾 STEP 4/7: Backup\n'));
       try {
-        const backup = await backuper.backup({ projectRoot });
+        const bmadPath = path.join(projectRoot, '_bmad');
+        const backup = await backuper.backup(bmadPath);
         logger.info(`✓ Backup created: ${chalk.cyan(backup.backupPath)}`);
       } catch (error) {
         logger.warn(`⚠ Backup failed (non-critical): ${error.message}`);
@@ -93,15 +95,16 @@ async function main() {
     const installResult = await installer.install({
       projectRoot,
       agents: answers.agents,
-      platforms: answers.targetPlatforms,
+      targetPlatforms: answers.targetPlatforms,
       userName: answers.userName,
       language: answers.language,
       mode: answers.mode
     });
     
-    logger.info(`✓ Installed ${chalk.cyan(installResult.installedAgents.length)} agents`);
-    logger.info(`✓ Created ${chalk.cyan(installResult.createdDirectories)} directories`);
-    logger.info(`✓ Generated ${chalk.cyan(installResult.generatedStubs)} platform stubs`);
+    logger.info(`✓ Installed ${chalk.cyan(installResult.agentsInstalled)} agents`);
+    if (installResult.errors && installResult.errors.length > 0) {
+      logger.warn(`⚠ ${installResult.errors.length} installation errors`);
+    }
     
     // STEP 6: VALIDATE - 10 Automated Checks
     logger.info(chalk.bold('\n✅ STEP 6/7: Validation\n'));
@@ -122,8 +125,10 @@ async function main() {
     // STEP 7: WIZARD - Post-Install Actions
     logger.info(chalk.bold('\n🧙 STEP 7/7: Post-Install Wizard\n'));
     await wizard.show({
-      installedAgents: installResult.installedAgents,
-      platforms: answers.targetPlatforms,
+      agents: answers.agents,
+      targetPlatforms: answers.targetPlatforms,
+      mode: answers.mode,
+      projectRoot,
       userName: answers.userName,
       language: answers.language
     });

package/lib/utils/file-utils.js

@@ -92,6 +92,16 @@ async function writeFile(filePath, content) {
   await fs.writeFile(filePath, content, 'utf8');
 }
 
+/**
+ * Read directory contents
+ * 
+ * @param {string} dirPath - Directory path
+ * @returns {Promise<string[]>} - Array of file/directory names
+ */
+async function readDir(dirPath) {
+  return fs.readdir(dirPath);
+}
+
 module.exports = {
   copy,
   exists,
@@ -100,5 +110,6 @@ module.exports = {
   readJSON,
   writeJSON,
   readFile,
-  writeFile
+  writeFile,
+  readDir
 };

package/lib/yanstaller/recommender.js

@@ -22,11 +22,15 @@ const fileUtils = require('../utils/file-utils');
 /**
  * Analyze project and recommend configuration
  * 
- * @param {import('./detector').DetectionResult} detection - Detection results
+ * @param {Object} options - Options object
+ * @param {string} [options.projectRoot] - Project root path
+ * @param {import('./detector').DetectionResult} options.detection - Detection results
  * @returns {Promise<Recommendation>}
  */
-async function recommend(detection) {
-  const projectRoot = process.cwd();
+async function recommend(options) {
+  // Support both old API (direct detection) and new API (options object)
+  const detection = options.detection || options;
+  const projectRoot = options.projectRoot || process.cwd();
   
   // 1. Analyze project type
   let projectType = 'unknown';
@@ -40,7 +44,8 @@ async function recommend(detection) {
   }
   
   // 2. Recommend agents based on type + platforms
-  const agents = getRecommendedAgents(projectType, detection.platforms);
+  const platforms = detection.platforms || [];
+  const agents = getRecommendedAgents(projectType, platforms);
   
   // 3. Determine mode
   const mode = agents.length > 10 ? 'full' : 'minimal';
@@ -167,22 +172,27 @@ function detectFramework(deps) {
  * Get recommended agents based on project type
  * 
  * @param {string} projectType - Project type
- * @param {Array} platforms - Detected platforms
+ * @param {Array} platforms - Detected platforms (array of platform objects)
  * @returns {string[]} - Agent names
  */
-function getRecommendedAgents(projectType, platforms) {
-  const baseAgents = ['byan', 'rachid', 'patnote', 'carmack'];
+function getRecommendedAgents(projectType, platforms = []) {
+  // Only recommend agents that exist in templates/_bmad/
+  // Available: byan, byan-test, rachid, patnote, marc, agent-builder, module-builder, workflow-builder
+  const availableAgents = ['byan', 'byan-test', 'rachid', 'patnote', 'marc', 'agent-builder', 'module-builder', 'workflow-builder'];
+  
+  const baseAgents = ['byan', 'rachid', 'patnote'];
   
   // Add MARC if Copilot CLI detected
-  if (platforms.some(p => p.name === 'copilot-cli' && p.detected)) {
+  if (platforms && platforms.some(p => p.name === 'copilot-cli' && p.detected)) {
     baseAgents.push('marc');
   }
   
+  // Simple recommendations based on available agents only
   const recommendations = {
-    frontend: [...baseAgents, 'ux-designer', 'dev', 'quinn'],
-    backend: [...baseAgents, 'architect', 'dev', 'quinn'],
-    fullstack: [...baseAgents, 'architect', 'dev', 'ux-designer', 'quinn', 'pm'],
-    library: [...baseAgents, 'dev', 'tech-writer', 'quinn'],
+    frontend: [...baseAgents],
+    backend: [...baseAgents],
+    fullstack: [...baseAgents],
+    library: [...baseAgents],
     unknown: baseAgents
   };
   

package/lib/yanstaller/wizard.js

@@ -25,12 +25,30 @@ async function show(config) {
   logger.info(chalk.gray('═'.repeat(60)));
   logger.info('');
   
-  // Show installation summary
+  // Show installation summary with null-checks
   logger.info(chalk.bold('📊 Installation Summary:'));
-  logger.info(`   • Agents installed: ${chalk.cyan(config.agents.length)}`);
-  logger.info(`   • Platforms: ${chalk.cyan(config.targetPlatforms.join(', '))}`);
-  logger.info(`   • Mode: ${chalk.cyan(config.mode)}`);
-  logger.info(`   • Location: ${chalk.gray(config.projectRoot)}`);
+  
+  if (config && config.agents && Array.isArray(config.agents)) {
+    logger.info(`   • Agents installed: ${chalk.cyan(config.agents.length)}`);
+  } else {
+    logger.info(`   • Agents installed: ${chalk.cyan(0)}`);
+  }
+  
+  if (config && config.targetPlatforms && Array.isArray(config.targetPlatforms)) {
+    logger.info(`   • Platforms: ${chalk.cyan(config.targetPlatforms.join(', '))}`);
+  } else if (config && config.platforms && Array.isArray(config.platforms)) {
+    logger.info(`   • Platforms: ${chalk.cyan(config.platforms.join(', '))}`);
+  } else {
+    logger.info(`   • Platforms: ${chalk.cyan('none')}`);
+  }
+  
+  if (config && config.mode) {
+    logger.info(`   • Mode: ${chalk.cyan(config.mode)}`);
+  }
+  
+  if (config && config.projectRoot) {
+    logger.info(`   • Location: ${chalk.gray(config.projectRoot)}`);
+  }
   logger.info('');
   
   const choices = [

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "create-byan-agent",
-  "version": "1.2.1",
+  "version": "1.2.3",
   "description": "NPX installer for BYAN ecosystem - Agent creators (BYAN, BYAN-Test) with deployment (RACHID), integration (MARC), updates (PATNOTE), and optimization (CARMACK)",
   "bin": {
     "create-byan-agent": "bin/create-byan-agent.js"
@@ -9,7 +9,10 @@
     "start": "node bin/create-byan-agent.js",
     "test": "jest",
     "test:watch": "jest --watch",
-    "test:coverage": "jest --coverage"
+    "test:coverage": "jest --coverage",
+    "test:e2e": "node test-e2e.js",
+    "pretest:e2e": "echo '\n🔍 Running E2E test before publish...\n'",
+    "prepublishOnly": "npm run test:e2e"
   },
   "keywords": [
     "byan",