create-brainerce-store 1.72.0 → 1.74.0

package/templates/nextjs/ui-canvas/product/frequently-bought-together.tsx

@@ -1,168 +1,174 @@
-'use client';
-
-import { useState } from 'react';
-import { CdnImage as Image } from '@/ui/shared/cdn-image';
-import type { Product, ProductRecommendation } from 'brainerce';
-import { formatPrice } from 'brainerce';
-import { useCart, useStoreInfo } from '@/core/providers/store-provider';
-import { useCurrency } from '@/core/lib/use-currency';
-import { useTranslations } from '@/core/lib/translations';
-import { cn } from '@/core/lib/utils';
-
-interface FrequentlyBoughtTogetherProps {
-  items: ProductRecommendation[];
-  currentProduct: Product;
-  className?: string;
-}
-
-function getEffectivePrice(item: { basePrice: string; salePrice?: string | null }): number {
-  const sale = item.salePrice ? parseFloat(item.salePrice) : null;
-  const base = parseFloat(item.basePrice);
-  return sale != null && sale < base ? sale : base;
-}
-
-function ProductThumb({
-  name,
-  imageUrl,
-  price,
-  currency,
-  checked,
-  onToggle,
-  disabled,
-}: {
-  name: string;
-  imageUrl: string | null;
-  price: number;
-  currency: string;
-  checked: boolean;
-  onToggle?: () => void;
-  disabled?: boolean;
-}) {
-  return (
-    <label className="inline-flex items-center gap-2">
-      {onToggle && <input type="checkbox" checked={checked} onChange={onToggle} disabled={disabled} />}
-      {/* `relative` + fixed box are layout-critical for next/image fill */}
-      <span className="relative block h-20 w-20">
-        {imageUrl ? <Image src={imageUrl} alt={name} fill sizes="80px" /> : null}
-      </span>
-      <span>{name}</span>
-      <span>{formatPrice(price, { currency }) as string}</span>
-    </label>
-  );
-}
-
-/**
- * DESIGN ME — "frequently bought together" bundle on the product page:
- * current product + selectable cross-sells + combined total + add-all button;
- * items come from useProductPage().recommendations.crossSells, the feature
- * gate from useStoreInfo().upsell.
- *
- * Building blocks: shadcn/ui primitives in src/components/ui (Button, Card, Badge, Input, Select, Accordion, Dialog, Skeleton, ...) + lucide-react icons are installed and ready to compose with.
- */
-export function FrequentlyBoughtTogether({
-  items,
-  currentProduct,
-  className,
-}: FrequentlyBoughtTogetherProps) {
-  // Hooks must be called unconditionally and in the same order on every
-  // render — keep all of them above any early `return null` branch.
-  const { storeInfo } = useStoreInfo();
-  const { refreshCart } = useCart();
-  const t = useTranslations('productDetail');
-  const currency = useCurrency();
-
-  // Only show up to 3 cross-sells
-  const crossSells = items.slice(0, 3);
-
-  const [selected, setSelected] = useState<Set<string>>(() => new Set(crossSells.map((i) => i.id)));
-  const [adding, setAdding] = useState(false);
-
-  if (!storeInfo?.upsell?.frequentlyBoughtTogetherEnabled) return null;
-  if (crossSells.length === 0) return null;
-
-  const currentPrice = getEffectivePrice(currentProduct);
-  const currentImage = currentProduct.images?.[0];
-  const currentImageUrl = currentImage
-    ? typeof currentImage === 'string'
-      ? currentImage
-      : currentImage.url
-    : null;
-
-  const totalPrice = crossSells
-    .filter((item) => selected.has(item.id))
-    .reduce((sum, item) => sum + getEffectivePrice(item), currentPrice);
-
-  const toggleItem = (id: string) => {
-    setSelected((prev) => {
-      const next = new Set(prev);
-      if (next.has(id)) {
-        next.delete(id);
-      } else {
-        next.add(id);
-      }
-      return next;
-    });
-  };
-
-  async function handleAddAll() {
-    if (adding || selected.size === 0) return;
-    try {
-      setAdding(true);
-      const { getClient } = await import('@/core/lib/brainerce');
-      const client = getClient();
-      const selectedItems = crossSells.filter((item) => selected.has(item.id));
-      for (const item of selectedItems) {
-        await client.smartAddToCart({ productId: item.id, quantity: 1 });
-      }
-      await refreshCart();
-    } catch (err) {
-      console.error('Failed to add items to cart:', err);
-    } finally {
-      setAdding(false);
-    }
-  }
-
-  return (
-    <section className={cn(className)}>
-      <h2>{t('frequentlyBoughtTogether')}</h2>
-
-      <div className="flex flex-wrap items-center gap-3">
-        {/* Current product (always included, no checkbox) */}
-        <ProductThumb
-          name={currentProduct.name}
-          imageUrl={currentImageUrl}
-          price={currentPrice}
-          currency={currency}
-          checked={true}
-          disabled
-        />
-
-        {crossSells.map((item) => {
-          const img = item.images?.[0];
-          const imgUrl = img ? (typeof img === 'string' ? img : img.url) : null;
-          return (
-            <div key={item.id} className="flex items-center gap-3">
-              <span aria-hidden="true">+</span>
-              <ProductThumb
-                name={item.name}
-                imageUrl={imgUrl}
-                price={getEffectivePrice(item)}
-                currency={currency}
-                checked={selected.has(item.id)}
-                onToggle={() => toggleItem(item.id)}
-              />
-            </div>
-          );
-        })}
-      </div>
-
-      {/* Total + Add button */}
-      <div className="flex flex-wrap items-center gap-4">
-        <span>{t('totalPrice', { price: formatPrice(totalPrice, { currency }) as string })}</span>
-        <button type="button" onClick={handleAddAll} disabled={adding || selected.size === 0}>
-          {adding ? t('addingAll') : t('addSelectedToCart')}
-        </button>
-      </div>
-    </section>
-  );
-}
+'use client';
+
+import { useState } from 'react';
+import { CdnImage as Image } from '@/ui/shared/cdn-image';
+import type { Product, ProductRecommendation } from 'brainerce';
+import { formatPrice } from 'brainerce';
+import { useCart, useStoreInfo } from '@/core/providers/store-provider';
+import { useCurrency } from '@/core/lib/use-currency';
+import { useTranslations } from '@/core/lib/translations';
+import { cn } from '@/core/lib/utils';
+
+interface FrequentlyBoughtTogetherProps {
+  items: ProductRecommendation[];
+  currentProduct: Product;
+  className?: string;
+}
+
+// ⛔ STORE CURRENCY THROUGHOUT, deliberately. The cross-sells are
+// `ProductRecommendation`, a trimmed shape with no displayPrice/displayCurrency,
+// so there is nothing to convert them to. Converting only `currentProduct`
+// (which is a full Product and does carry FX fields) would add a euro amount to
+// two dollar amounts and print the result as one total. One currency wins, and
+// it has to be the one the cart actually charges.
+function getEffectivePrice(item: { basePrice: string; salePrice?: string | null }): number {
+  const sale = item.salePrice ? parseFloat(item.salePrice) : null;
+  const base = parseFloat(item.basePrice);
+  return sale != null && sale < base ? sale : base;
+}
+
+function ProductThumb({
+  name,
+  imageUrl,
+  price,
+  currency,
+  checked,
+  onToggle,
+  disabled,
+}: {
+  name: string;
+  imageUrl: string | null;
+  price: number;
+  currency: string;
+  checked: boolean;
+  onToggle?: () => void;
+  disabled?: boolean;
+}) {
+  return (
+    <label className="inline-flex items-center gap-2">
+      {onToggle && <input type="checkbox" checked={checked} onChange={onToggle} disabled={disabled} />}
+      {/* `relative` + fixed box are layout-critical for next/image fill */}
+      <span className="relative block h-20 w-20">
+        {imageUrl ? <Image src={imageUrl} alt={name} fill sizes="80px" /> : null}
+      </span>
+      <span>{name}</span>
+      <span>{formatPrice(price, { currency }) as string}</span>
+    </label>
+  );
+}
+
+/**
+ * DESIGN ME — "frequently bought together" bundle on the product page:
+ * current product + selectable cross-sells + combined total + add-all button;
+ * items come from useProductPage().recommendations.crossSells, the feature
+ * gate from useStoreInfo().upsell.
+ *
+ * Building blocks: shadcn/ui primitives in src/components/ui (Button, Card, Badge, Input, Select, Accordion, Dialog, Skeleton, ...) + lucide-react icons are installed and ready to compose with.
+ */
+export function FrequentlyBoughtTogether({
+  items,
+  currentProduct,
+  className,
+}: FrequentlyBoughtTogetherProps) {
+  // Hooks must be called unconditionally and in the same order on every
+  // render — keep all of them above any early `return null` branch.
+  const { storeInfo } = useStoreInfo();
+  const { refreshCart } = useCart();
+  const t = useTranslations('productDetail');
+  const currency = useCurrency();
+
+  // Only show up to 3 cross-sells
+  const crossSells = items.slice(0, 3);
+
+  const [selected, setSelected] = useState<Set<string>>(() => new Set(crossSells.map((i) => i.id)));
+  const [adding, setAdding] = useState(false);
+
+  if (!storeInfo?.upsell?.frequentlyBoughtTogetherEnabled) return null;
+  if (crossSells.length === 0) return null;
+
+  const currentPrice = getEffectivePrice(currentProduct);
+  const currentImage = currentProduct.images?.[0];
+  const currentImageUrl = currentImage
+    ? typeof currentImage === 'string'
+      ? currentImage
+      : currentImage.url
+    : null;
+
+  const totalPrice = crossSells
+    .filter((item) => selected.has(item.id))
+    .reduce((sum, item) => sum + getEffectivePrice(item), currentPrice);
+
+  const toggleItem = (id: string) => {
+    setSelected((prev) => {
+      const next = new Set(prev);
+      if (next.has(id)) {
+        next.delete(id);
+      } else {
+        next.add(id);
+      }
+      return next;
+    });
+  };
+
+  async function handleAddAll() {
+    if (adding || selected.size === 0) return;
+    try {
+      setAdding(true);
+      const { getClient } = await import('@/core/lib/brainerce');
+      const client = getClient();
+      const selectedItems = crossSells.filter((item) => selected.has(item.id));
+      for (const item of selectedItems) {
+        await client.smartAddToCart({ productId: item.id, quantity: 1 });
+      }
+      await refreshCart();
+    } catch (err) {
+      console.error('Failed to add items to cart:', err);
+    } finally {
+      setAdding(false);
+    }
+  }
+
+  return (
+    <section className={cn(className)}>
+      <h2>{t('frequentlyBoughtTogether')}</h2>
+
+      <div className="flex flex-wrap items-center gap-3">
+        {/* Current product (always included, no checkbox) */}
+        <ProductThumb
+          name={currentProduct.name}
+          imageUrl={currentImageUrl}
+          price={currentPrice}
+          currency={currency}
+          checked={true}
+          disabled
+        />
+
+        {crossSells.map((item) => {
+          const img = item.images?.[0];
+          const imgUrl = img ? (typeof img === 'string' ? img : img.url) : null;
+          return (
+            <div key={item.id} className="flex items-center gap-3">
+              <span aria-hidden="true">+</span>
+              <ProductThumb
+                name={item.name}
+                imageUrl={imgUrl}
+                price={getEffectivePrice(item)}
+                currency={currency}
+                checked={selected.has(item.id)}
+                onToggle={() => toggleItem(item.id)}
+              />
+            </div>
+          );
+        })}
+      </div>
+
+      {/* Total + Add button */}
+      <div className="flex flex-wrap items-center gap-4">
+        <span>{t('totalPrice', { price: formatPrice(totalPrice, { currency }) as string })}</span>
+        <button type="button" onClick={handleAddAll} disabled={adding || selected.size === 0}>
+          {adding ? t('addingAll') : t('addSelectedToCart')}
+        </button>
+      </div>
+    </section>
+  );
+}

package/templates/nextjs/ui-canvas/product/product-card.tsx

@@ -4,7 +4,8 @@ import { useState } from 'react';
 import { Link, useRouter } from '@/core/lib/navigation';
 import { CdnImage as Image } from '@/ui/shared/cdn-image';
 import type { Product } from 'brainerce';
-import { getProductPriceInfo, getVariantPrice, formatPrice } from 'brainerce';
+import { getProductPriceInfo, formatPrice } from 'brainerce';
+import { pickDisplayPrice, pickDisplayPriceRange } from '@/core/lib/display-price';
 import { useTranslations } from '@/core/lib/translations';
 import { PriceDisplay } from '@/ui/product/price-display';
 import { StockBadge } from '@/ui/product/stock-badge';
@@ -19,57 +20,14 @@ interface ProductCardProps {
   className?: string;
 }
 
-/**
- * Pick the price + currency to render for a given product (PRD §23 FX overlay).
- *
- * When the storefront passed `regionId` to `getProducts({ regionId })` AND the
- * region currency differs from the store currency, the backend attaches
- * additive `displayPrice` / `displayCurrency` fields. Otherwise we fall back
- * to the canonical store-currency `basePrice` / `salePrice`. Either way the
- * cart still charges in the store currency — this only affects display.
- */
-function pickDisplayPrice(
-  product: Product,
-  fallbackCurrency: string
-): { price: number | undefined; salePrice: number | null; currency: string } {
-  if (product.displayPrice != null && product.displayCurrency) {
-    const sale = product.displaySalePrice != null ? parseFloat(product.displaySalePrice) : null;
-    return {
-      // `displayPrice` is the base price converted to the region currency —
-      // it goes into the PriceDisplay `price` (base) slot, NOT the sale slot.
-      price: parseFloat(product.displayPrice),
-      salePrice: sale != null && !Number.isNaN(sale) ? sale : null,
-      currency: product.displayCurrency,
-    };
-  }
-  // Same-currency fallback. `getProductPriceInfo.price` is the EFFECTIVE
-  // charged amount (= salePrice when on sale, base otherwise); `originalPrice`
-  // is the base. Map them to PriceDisplay's (price = base, salePrice = sale).
-  const { price: effective, originalPrice, isOnSale } = getProductPriceInfo(product);
-  return {
-    price: originalPrice,
-    salePrice: isOnSale ? effective : null,
-    currency: fallbackCurrency,
-  };
-}
-
 function VariantPriceRange({ product }: { product: Product }) {
-  const currency = useCurrency();
-
-  let min: number;
-  let max: number;
-  if (product.priceMin && product.priceMax) {
-    min = parseFloat(product.priceMin);
-    max = parseFloat(product.priceMax);
-  } else {
-    const variants = product.variants ?? [];
-    if (variants.length === 0) return null;
-    const prices = variants.map((v) => getVariantPrice(v, product.basePrice));
-    min = Math.min(...prices);
-    max = Math.max(...prices);
-  }
-
-  if (isNaN(min) || isNaN(max)) return null;
+  const fallbackCurrency = useCurrency();
+  // ⛔ Region-aware. A range built from priceMin/priceMax alone stays in the
+  // store currency while the single-price card beside it converts, so a
+  // variable product would quote a different currency from its neighbours.
+  const range = pickDisplayPriceRange(product, fallbackCurrency);
+  if (!range) return null;
+  const { min, max, currency } = range;
 
   return (
     <span>

package/templates/nextjs/ui-canvas/product/product-client-section.tsx

@@ -98,6 +98,7 @@ export function ProductClientSection({
     selectedVariant,
     setSelectedVariant,
     priceInfo,
+    displayPrice,
     inventory,
     canPurchase,
     description,
@@ -203,8 +204,9 @@ export function ProductClientSection({
 
           {/* Price */}
           <PriceDisplay
-            price={priceInfo.originalPrice}
-            salePrice={priceInfo.isOnSale ? priceInfo.price : undefined}
+            price={displayPrice.price}
+            salePrice={displayPrice.salePrice ?? undefined}
+            currency={displayPrice.currency}
             size="lg"
           />
 
@@ -212,7 +214,7 @@ export function ProductClientSection({
           {product.isDownloadable ? (
             <p>{t('instantDownload')}</p>
           ) : (
-            <StockBadge inventory={inventory} lowStockThreshold={5} />
+            <StockBadge inventory={inventory} />
           )}
 
           {/* Downloadable files info */}