create-brainerce-store 1.71.0 → 1.73.0

package/templates/nextjs/base/src/app/order-confirmation/page.tsx

@@ -32,10 +32,29 @@ function OrderConfirmationContent() {
       try {
         const client = getClient();
 
-        // Clear cart state after successful payment
-        client.handlePaymentSuccess(checkoutId!);
+        // Clear cart state after successful payment. handlePaymentSuccess is
+        // SYNCHRONOUS: it returns the outcome rather than a promise, so there
+        // is nothing to await. Read the result, then refresh the cart AFTER
+        // it, or the header badge can be repopulated from the pre-clear cart.
+        //
+        //   mode 'full'    - whole cart cleared
+        //   mode 'partial' - only the purchased items were removed (partial
+        //                    checkout); whatever is left is still for sale
+        //   mode 'none'    - nothing to clear. Usually the SDK's idempotency
+        //                    guard: React Strict Mode runs this effect twice
+        //                    in development, and a refresh of this URL hits it
+        //                    too. On a good order this is expected, so it must
+        //                    never become a warning to the shopper.
+        const clearResult = client.handlePaymentSuccess(checkoutId!);
         await refreshCart();
 
+        if (!clearResult.cleared && clearResult.mode !== 'none') {
+          // A clear that neither succeeded nor was skipped leaves purchased
+          // items in the badge. Nothing the shopper can act on, but a silent
+          // gap here looks exactly like a working cart.
+          console.warn('Cart not cleared after payment:', clearResult);
+        }
+
         // For redirect-based payment providers, the customer returns with
         // provider params in the URL — CardCom: lowprofilecode; PayPal:
         // token + PayerID. Send these to the backend for server-side