create-ailk 0.4.0 → 0.6.0

package/templates/apps/api/src/routes/content/__tests__/create.test.ts

@@ -1,253 +0,0 @@
-/**
- * @file create.test.ts
- * POST /api/content/:type — D14a Stage 1 Unit B.
- *
- * Covers: Pro-tier gating (402), validation (400), slug allowlist (400),
- * happy path (201 with {page, version}), slug-already-exists conflict (409
- * with existing version echoed), and unknown :type (400).
- *
- * Issue #398 follow-up: the route no longer pre-checks slug existence; the
- * adapter throws `AdapterWriteError("conflict", ..., {version})` and the
- * hoisted `mapAdapterError` translates it. Tests construct real
- * `AdapterWriteError` instances accordingly.
- *
- * Uses the real content adapter backed by a per-test temp dir (Issue #507).
- * @working-theory/license stays mocked — it is an external package boundary.
- */
-
-import type { FastifyInstance } from "fastify";
-
-const mockCheckLicense = jest.fn();
-
-// @working-theory/license is an external package boundary — stays mocked.
-jest.mock("@working-theory/license", () => ({
-  checkLicense: (...args: unknown[]) => mockCheckLicense(...args),
-}));
-
-import { AdapterWriteError } from "@working-theory/content-adapters";
-
-import { setupContentFixture } from "../../../__tests__/factories/content-fixture";
-import { contentRoutes } from "../index";
-
-const fixture = setupContentFixture();
-
-function proLicense() {
-  return {
-    tier: "pro",
-    plan: "pro",
-    features: [],
-    expiresAt: null,
-    revoked: false,
-  };
-}
-
-function freeLicense() {
-  return {
-    tier: "free",
-    plan: null,
-    features: [],
-    expiresAt: null,
-    revoked: false,
-  };
-}
-
-const validBody = {
-  type: "HomePage",
-  slug: "new-page",
-  title: "New Page",
-  description: "A new page description",
-  body: "New page body content",
-};
-
-describe("POST /api/content/:type", () => {
-  let app: FastifyInstance;
-  // The write handlers only register when content-write is enabled
-  // (routes/content/index.ts's isModuleEnabled('content-write') gate); an
-  // unset AILK_ENABLED_MODULES no longer defaults to every module on
-  // (D-44, #5368), so this suite enables it explicitly.
-  const priorEnabledModules = process.env.AILK_ENABLED_MODULES;
-
-  beforeEach(async () => {
-    process.env.AILK_ENABLED_MODULES = "content-write";
-    app = require("fastify")();
-    await app.register(contentRoutes);
-    jest.clearAllMocks();
-    mockCheckLicense.mockReset();
-  });
-
-  afterAll(() => {
-    if (priorEnabledModules === undefined) {
-      delete process.env.AILK_ENABLED_MODULES;
-    } else {
-      process.env.AILK_ENABLED_MODULES = priorEnabledModules;
-    }
-  });
-
-  afterEach(async () => {
-    await app.close();
-  });
-
-  it("returns 201 with {page, version} on success", async () => {
-    mockCheckLicense.mockResolvedValue(proLicense());
-
-    // Use a unique slug so there's no conflict with fixture pages.
-    const body = { ...validBody, slug: "brand-new-page" };
-    const res = await app.inject({
-      method: "POST",
-      url: "/v1/content/HomePage",
-      payload: body,
-    });
-
-    expect(res.statusCode).toBe(201);
-    const resBody = JSON.parse(res.body);
-    expect(resBody).toHaveProperty("page");
-    expect(resBody).toHaveProperty("version");
-    expect(resBody.page).toMatchObject({ type: "HomePage", slug: "brand-new-page" });
-  });
-
-  it("returns 402 payment_required on free tier", async () => {
-    mockCheckLicense.mockResolvedValue(freeLicense());
-
-    const res = await app.inject({
-      method: "POST",
-      url: "/v1/content/HomePage",
-      payload: validBody,
-    });
-
-    expect(res.statusCode).toBe(402);
-    expect(JSON.parse(res.body)).toMatchObject({ error: "payment_required" });
-  });
-
-  it("returns 402 payment_required when license is revoked even at pro tier", async () => {
-    mockCheckLicense.mockResolvedValue({
-      tier: "pro",
-      plan: "pro",
-      features: [],
-      expiresAt: null,
-      revoked: true,
-    });
-
-    const res = await app.inject({
-      method: "POST",
-      url: "/v1/content/HomePage",
-      payload: validBody,
-    });
-
-    expect(res.statusCode).toBe(402);
-    expect(JSON.parse(res.body)).toMatchObject({ error: "payment_required" });
-  });
-
-  it("returns 409 conflict with existing version when slug already exists (adapter throws)", async () => {
-    mockCheckLicense.mockResolvedValue(proLicense());
-
-    // The fixture writes "home" in beforeEach — POST to the same slug triggers conflict.
-    const res = await app.inject({
-      method: "POST",
-      url: "/v1/content/HomePage",
-      payload: { ...validBody, slug: "home" },
-    });
-
-    // The real adapter throws AdapterWriteError("conflict") on duplicate slug.
-    expect(res.statusCode).toBe(409);
-    const body = JSON.parse(res.body);
-    expect(body).toMatchObject({ error: "conflict" });
-  });
-
-  it("does not pre-check slug existence — adapter is the sole authority (V2-H2 TOCTOU closed)", async () => {
-    mockCheckLicense.mockResolvedValue(proLicense());
-
-    // The route should NOT call getPageBySlug before createPage.
-    // We verify by checking that a slug that doesn't exist succeeds with 201.
-    const res = await app.inject({
-      method: "POST",
-      url: "/v1/content/HomePage",
-      payload: { ...validBody, slug: "toctou-test-unique-slug" },
-    });
-
-    // Route went straight to adapter.createPage — no pre-check needed.
-    expect([201, 409]).toContain(res.statusCode);
-  });
-
-  it("returns 400 validation_failed when body missing required field", async () => {
-    mockCheckLicense.mockResolvedValue(proLicense());
-
-    const res = await app.inject({
-      method: "POST",
-      url: "/v1/content/HomePage",
-      payload: { type: "HomePage", slug: "home", title: "T" }, // missing description, body
-    });
-
-    expect(res.statusCode).toBe(400);
-    expect(JSON.parse(res.body)).toMatchObject({ error: "validation_failed" });
-  });
-
-  it("returns 400 validation_failed when body is empty string", async () => {
-    mockCheckLicense.mockResolvedValue(proLicense());
-
-    const res = await app.inject({
-      method: "POST",
-      url: "/v1/content/HomePage",
-      payload: { ...validBody, body: "" },
-    });
-
-    expect(res.statusCode).toBe(400);
-    expect(JSON.parse(res.body)).toMatchObject({ error: "validation_failed" });
-  });
-
-  it("returns 400 validation_failed on unknown :type param", async () => {
-    mockCheckLicense.mockResolvedValue(proLicense());
-
-    const res = await app.inject({
-      method: "POST",
-      url: "/v1/content/Bogus",
-      payload: validBody,
-    });
-
-    expect(res.statusCode).toBe(400);
-    expect(JSON.parse(res.body)).toMatchObject({ error: "validation_failed" });
-  });
-
-  it("returns 400 when path :type does not match body type", async () => {
-    mockCheckLicense.mockResolvedValue(proLicense());
-
-    const res = await app.inject({
-      method: "POST",
-      url: "/v1/content/HomePage",
-      payload: { ...validBody, type: "AboutPage" },
-    });
-
-    expect(res.statusCode).toBe(400);
-    expect(JSON.parse(res.body)).toMatchObject({ error: "validation_failed" });
-  });
-
-  it("returns 400 validation_failed on disallowed slug shape", async () => {
-    mockCheckLicense.mockResolvedValue(proLicense());
-
-    const res = await app.inject({
-      method: "POST",
-      url: "/v1/content/HomePage",
-      payload: { ...validBody, slug: "../etc/passwd" },
-    });
-
-    expect(res.statusCode).toBe(400);
-    expect(JSON.parse(res.body)).toMatchObject({ error: "validation_failed" });
-  });
-
-  it("merged-error-array: invalid frontmatter AND empty body → 400 with issues from both validations surfaced", async () => {
-    mockCheckLicense.mockResolvedValue(proLicense());
-
-    const res = await app.inject({
-      method: "POST",
-      url: "/v1/content/HomePage",
-      payload: { type: "HomePage", slug: "home", title: "T", body: "" },
-    });
-
-    expect(res.statusCode).toBe(400);
-    const body = JSON.parse(res.body);
-    expect(body).toMatchObject({ error: "validation_failed" });
-
-    const issues: Array<{ path: unknown[] }> = body.details?.issues ?? [];
-    const paths = issues.map((i) => i.path.join("."));
-    expect(paths).toEqual(expect.arrayContaining(["description", "body"]));
-  });
-});

package/templates/apps/api/src/routes/content/__tests__/delete.test.ts

@@ -1,215 +0,0 @@
-/**
- * @file delete.test.ts
- * DELETE /api/content/:type/:slug — D14a Stage 1 Unit B.
- *
- * Covers: Pro-tier gating (402), missing/stale If-Match (409), happy path
- * (204 no body), not-found (404), unknown :type (400).
- *
- * Issue #398 follow-up: bespoke version-probe + getPageBySlug pre-check
- * removed; the adapter throws `AdapterWriteError("not_found" | "conflict")`
- * and the hoisted `mapAdapterError` translates it.
- *
- * Uses the real content adapter backed by a per-test temp dir (Issue #507).
- * @working-theory/license stays mocked — it is an external package boundary.
- */
-
-import type { FastifyInstance } from "fastify";
-
-const mockCheckLicense = jest.fn();
-
-// @working-theory/license is an external package boundary — stays mocked.
-jest.mock("@working-theory/license", () => ({
-  checkLicense: (...args: unknown[]) => mockCheckLicense(...args),
-}));
-
-import { setupContentFixture } from "../../../__tests__/factories/content-fixture";
-import { contentRoutes } from "../index";
-
-const fixture = setupContentFixture();
-
-function proLicense() {
-  return {
-    tier: "pro",
-    plan: "pro",
-    features: [],
-    expiresAt: null,
-    revoked: false,
-  };
-}
-
-function freeLicense() {
-  return {
-    tier: "free",
-    plan: null,
-    features: [],
-    expiresAt: null,
-    revoked: false,
-  };
-}
-
-describe("DELETE /api/content/:type/:slug", () => {
-  let app: FastifyInstance;
-  // The write handlers only register when content-write is enabled
-  // (routes/content/index.ts's isModuleEnabled('content-write') gate); an
-  // unset AILK_ENABLED_MODULES no longer defaults to every module on
-  // (D-44, #5368), so this suite enables it explicitly.
-  const priorEnabledModules = process.env.AILK_ENABLED_MODULES;
-
-  beforeEach(async () => {
-    process.env.AILK_ENABLED_MODULES = "content-write";
-    app = require("fastify")();
-    await app.register(contentRoutes);
-    jest.clearAllMocks();
-    mockCheckLicense.mockReset();
-  });
-
-  afterAll(() => {
-    if (priorEnabledModules === undefined) {
-      delete process.env.AILK_ENABLED_MODULES;
-    } else {
-      process.env.AILK_ENABLED_MODULES = priorEnabledModules;
-    }
-  });
-
-  afterEach(async () => {
-    await app.close();
-  });
-
-  it("returns 204 with no body on success", async () => {
-    mockCheckLicense.mockResolvedValue(proLicense());
-
-    // First create the page, get its version, then delete it.
-    const createRes = await app.inject({
-      method: "POST",
-      url: "/v1/content/HomePage",
-      payload: {
-        type: "HomePage",
-        slug: "page-to-delete",
-        title: "Page To Delete",
-        description: "This page will be deleted",
-        body: "Goodbye",
-      },
-    });
-    expect(createRes.statusCode).toBe(201);
-    const { version } = JSON.parse(createRes.body);
-
-    const res = await app.inject({
-      method: "DELETE",
-      url: "/v1/content/HomePage/page-to-delete",
-      headers: { "if-match": version },
-    });
-
-    expect(res.statusCode).toBe(204);
-    expect(res.body).toBe("");
-  });
-
-  it("returns 402 payment_required on free tier", async () => {
-    mockCheckLicense.mockResolvedValue(freeLicense());
-
-    const res = await app.inject({
-      method: "DELETE",
-      url: "/v1/content/HomePage/home",
-      headers: { "if-match": "v1" },
-    });
-
-    expect(res.statusCode).toBe(402);
-  });
-
-  it("returns 402 payment_required when license is revoked even at pro tier", async () => {
-    mockCheckLicense.mockResolvedValue({
-      tier: "pro",
-      plan: "pro",
-      features: [],
-      expiresAt: null,
-      revoked: true,
-    });
-
-    const res = await app.inject({
-      method: "DELETE",
-      url: "/v1/content/HomePage/home",
-      headers: { "if-match": "v1" },
-    });
-
-    expect(res.statusCode).toBe(402);
-    expect(JSON.parse(res.body)).toMatchObject({ error: "payment_required" });
-  });
-
-  it("returns 409 conflict when If-Match header is missing", async () => {
-    mockCheckLicense.mockResolvedValue(proLicense());
-
-    const res = await app.inject({
-      method: "DELETE",
-      url: "/v1/content/HomePage/home",
-    });
-
-    expect(res.statusCode).toBe(409);
-    expect(JSON.parse(res.body)).toMatchObject({ error: "conflict" });
-  });
-
-  it("returns 409 conflict when If-Match is empty string", async () => {
-    mockCheckLicense.mockResolvedValue(proLicense());
-
-    const res = await app.inject({
-      method: "DELETE",
-      url: "/v1/content/HomePage/home",
-      headers: { "if-match": "" },
-    });
-
-    expect(res.statusCode).toBe(409);
-  });
-
-  it("returns 409 conflict with currentVersion echoed when adapter signals stale If-Match", async () => {
-    mockCheckLicense.mockResolvedValue(proLicense());
-
-    // Pass a stale version — the real adapter will reject it with conflict.
-    const res = await app.inject({
-      method: "DELETE",
-      url: "/v1/content/HomePage/home",
-      headers: { "if-match": "stale-version-that-does-not-match" },
-    });
-
-    expect(res.statusCode).toBe(409);
-    const body = JSON.parse(res.body);
-    expect(body).toMatchObject({ error: "conflict" });
-    if (body.details) {
-      expect(body.details).toHaveProperty("currentVersion");
-    }
-  });
-
-  it("returns 404 not_found when adapter signals page missing", async () => {
-    mockCheckLicense.mockResolvedValue(proLicense());
-
-    const res = await app.inject({
-      method: "DELETE",
-      url: "/v1/content/HomePage/slug-that-does-not-exist",
-      headers: { "if-match": "any-version" },
-    });
-
-    expect(res.statusCode).toBe(404);
-    expect(JSON.parse(res.body)).toMatchObject({ error: "not_found" });
-  });
-
-  it("returns 400 validation_failed on unknown :type", async () => {
-    mockCheckLicense.mockResolvedValue(proLicense());
-
-    const res = await app.inject({
-      method: "DELETE",
-      url: "/v1/content/Bogus/home",
-      headers: { "if-match": "v1" },
-    });
-
-    expect(res.statusCode).toBe(400);
-  });
-
-  it("returns 400 validation_failed on disallowed slug shape", async () => {
-    mockCheckLicense.mockResolvedValue(proLicense());
-
-    const res = await app.inject({
-      method: "DELETE",
-      url: "/v1/content/HomePage/..%2Fetc%2Fpasswd",
-      headers: { "if-match": "v1" },
-    });
-
-    expect(res.statusCode).toBe(400);
-  });
-});