create-ailk 0.24.0 → 0.26.0

package/templates/apps/mcp/__tests__/audit-single-page.test.ts

@@ -1,299 +0,0 @@
-/**
- * Tests for apps/mcp/src/lib/audit-single-page.ts
- *
- * TDD: URL validation cases (security boundary) first, then happy paths.
- *
- * Acceptance criteria verified here:
- * - Rejects URLs not on the AILK installation's own domain (SSRF guard)
- * - Rejects malformed URLs
- * - Rejects when both slug and url are provided
- * - Rejects when neither slug nor url is provided
- * - Accepts slug-only input and builds AuditInput
- * - Accepts same-origin url input and builds AuditInput
- * - Strips query strings + fragments before slug extraction
- * - Cross-domain error message references ailk audit CLI
- * - No fetch() call (structural test)
- */
-
-import { mkdirSync, mkdtempSync, readFileSync, rmSync, writeFileSync } from "node:fs";
-import { tmpdir } from "node:os";
-import { resolve, join } from "node:path";
-
-import {
-  entityMarkup,
-  runAudit,
-  schemaCoverage,
-  type AuditReport,
-} from "@working-theory/aeo";
-
-import { buildSinglePageAuditInput } from "../src/lib/audit-single-page.js";
-
-const REPO_ROOT = resolve(__dirname, "../../..");
-const CONTENT_ROOT = join(REPO_ROOT, "content");
-
-// Set env to a known base URL for tests that exercise same-origin logic.
-const TEST_BASE_URL = "https://example.ailk.test";
-
-function withBaseUrl(
-  url: string,
-  fn: () => Promise<unknown>,
-): Promise<unknown> {
-  const prev = process.env.AILK_BASE_URL;
-  process.env.AILK_BASE_URL = url;
-  return fn().finally(() => {
-    if (prev === undefined) delete process.env.AILK_BASE_URL;
-    else process.env.AILK_BASE_URL = prev;
-  });
-}
-
-// ── URL-validation tests (security boundary — RED first) ──────────────────────
-
-describe("buildSinglePageAuditInput — URL validation (security boundary)", () => {
-  it("rejects a cross-domain URL", async () => {
-    await expect(
-      withBaseUrl(TEST_BASE_URL, () =>
-        buildSinglePageAuditInput(
-          { url: "https://evil.example.com/HomePage/some-page" },
-          CONTENT_ROOT,
-        ),
-      ),
-    ).rejects.toThrow(/out of scope|use `ailk audit`/i);
-  });
-
-  it("cross-domain error message references ailk audit CLI", async () => {
-    const err = await withBaseUrl(TEST_BASE_URL, () =>
-      buildSinglePageAuditInput(
-        { url: "https://evil.example.com/HomePage/some-page" },
-        CONTENT_ROOT,
-      ),
-    ).catch((e: Error) => e);
-    expect(err).toBeInstanceOf(Error);
-    expect((err as Error).message).toMatch(/ailk audit/);
-  });
-
-  it("rejects a URL with user-info (credential-stuffed URL bypass attempt)", async () => {
-    // The bypass form: https://trusted-domain@attacker.com/page
-    // WHATWG URL: userinfo="trusted-domain", hostname="attacker.com"
-    // hostname !== base.hostname → rejected.
-    const bypassUrl = `https://${TEST_BASE_URL.replace("https://", "")}@attacker.com/page`;
-    await expect(
-      withBaseUrl(TEST_BASE_URL, () =>
-        buildSinglePageAuditInput({ url: bypassUrl }, CONTENT_ROOT),
-      ),
-    ).rejects.toThrow(/out of scope|use `ailk audit`/i);
-  });
-
-  it("rejects a malformed URL", async () => {
-    await expect(
-      withBaseUrl(TEST_BASE_URL, () =>
-        buildSinglePageAuditInput({ url: "not-a-url" }, CONTENT_ROOT),
-      ),
-    ).rejects.toThrow();
-  });
-
-  it("rejects input with both slug and url provided", async () => {
-    await expect(
-      withBaseUrl(TEST_BASE_URL, () =>
-        buildSinglePageAuditInput(
-          // eslint-disable-next-line no-restricted-syntax -- #506/#507: pre-existing test-hygiene violation
-          {
-            slug: "home",
-            url: `${TEST_BASE_URL}/HomePage/home`,
-          } as unknown as Parameters<typeof buildSinglePageAuditInput>[0],
-          CONTENT_ROOT,
-        ),
-      ),
-    ).rejects.toThrow(/both|exclusive/i);
-  });
-
-  it("rejects input with neither slug nor url", async () => {
-    await expect(
-      withBaseUrl(TEST_BASE_URL, () =>
-        buildSinglePageAuditInput(
-          // eslint-disable-next-line no-restricted-syntax -- #506/#507: pre-existing test-hygiene violation
-          {} as unknown as Parameters<typeof buildSinglePageAuditInput>[0],
-          CONTENT_ROOT,
-        ),
-      ),
-    ).rejects.toThrow(/slug.*url|url.*slug|required/i);
-  });
-
-  it("accepts same-origin URL with matching hostname", async () => {
-    await expect(
-      withBaseUrl(TEST_BASE_URL, () =>
-        buildSinglePageAuditInput(
-          { url: `${TEST_BASE_URL}/HomePage/home` },
-          CONTENT_ROOT,
-        ),
-      ),
-    ).resolves.toBeDefined();
-  });
-
-  it("strips query string from same-origin URL before slug extraction", async () => {
-    const result = await withBaseUrl(TEST_BASE_URL, () =>
-      buildSinglePageAuditInput(
-        { url: `${TEST_BASE_URL}/HomePage/home?utm_source=test` },
-        CONTENT_ROOT,
-      ),
-    );
-    expect(result).toBeDefined();
-  });
-
-  it("strips fragment from same-origin URL before slug extraction", async () => {
-    const result = await withBaseUrl(TEST_BASE_URL, () =>
-      buildSinglePageAuditInput(
-        { url: `${TEST_BASE_URL}/HomePage/home#section` },
-        CONTENT_ROOT,
-      ),
-    );
-    expect(result).toBeDefined();
-  });
-});
-
-// ── Slug happy-path tests ─────────────────────────────────────────────────────
-
-describe("buildSinglePageAuditInput — slug input", () => {
-  it("returns AuditInput with one page for a known HomePage slug", async () => {
-    const result = await buildSinglePageAuditInput(
-      { slug: "home", type: "HomePage" },
-      CONTENT_ROOT,
-    );
-    expect(result.pages).toHaveLength(1);
-    expect(result.pages[0].slug).toBe("home");
-    expect(result.pages[0].type).toBe("HomePage");
-  });
-
-  it("result has locale, identityMode, registry, jsonLdByPage fields", async () => {
-    const result = await buildSinglePageAuditInput(
-      { slug: "home", type: "HomePage" },
-      CONTENT_ROOT,
-    );
-    expect(typeof result.locale).toBe("string");
-    expect(
-      result.identityMode === "person" ||
-        result.identityMode === "organization",
-    ).toBe(true);
-    expect(Array.isArray(result.registry)).toBe(true);
-    expect(typeof result.jsonLdByPage).toBe("object");
-  });
-
-  it("throws for a slug that does not exist in the content directory", async () => {
-    await expect(
-      buildSinglePageAuditInput(
-        { slug: "does-not-exist-at-all", type: "HomePage" },
-        CONTENT_ROOT,
-      ),
-    ).rejects.toThrow(/not found|does not exist/i);
-  });
-});
-
-// ── URL happy-path tests ──────────────────────────────────────────────────────
-
-describe("buildSinglePageAuditInput — url input (same-origin)", () => {
-  it("returns AuditInput for a same-origin URL pointing at a known page", async () => {
-    const result = (await withBaseUrl(TEST_BASE_URL, () =>
-      buildSinglePageAuditInput(
-        { url: `${TEST_BASE_URL}/HomePage/home` },
-        CONTENT_ROOT,
-      ),
-    )) as Awaited<ReturnType<typeof buildSinglePageAuditInput>>;
-    expect(result.pages).toHaveLength(1);
-    expect(result.pages[0].slug).toBe("home");
-    expect(result.pages[0].type).toBe("HomePage");
-  });
-});
-
-// ── Structural guard ──────────────────────────────────────────────────────────
-
-describe("structural guard — no fetch()", () => {
-  it("apps/mcp/src/lib/audit-single-page.ts does not call fetch()", () => {
-    const src = readFileSync(
-      resolve(__dirname, "../src/lib/audit-single-page.ts"),
-      "utf-8",
-    );
-    // Strip block comments (/** ... */ and /* ... */) and line comments (// ...)
-    // before checking — comments may mention fetch() as a negative assertion.
-    const codeOnly = src
-      .replace(/\/\*[\s\S]*?\*\//g, "")
-      .replace(/\/\/[^\n]*/g, "");
-    expect(codeOnly).not.toMatch(/\bfetch\s*\(/);
-  });
-});
-
-describe("buildSinglePageAuditInput — sitewide identity (#6597 AC-7)", () => {
-  const evidenceOf = (report: AuditReport, id: string) =>
-    report.perRule.find((r) => r.id === id);
-  const auditOf = async (input: { slug: string; type?: "AboutPage" }, root: string) =>
-    runAudit(await buildSinglePageAuditInput(input, root), [schemaCoverage, entityMarkup]);
-
-  it("schema-coverage passes for the monorepo's AboutPage/about", async () => {
-    const report = await auditOf({ slug: "about", type: "AboutPage" }, CONTENT_ROOT);
-    expect(evidenceOf(report, "schema-coverage")?.pass).toBe(true);
-  });
-
-  // The content root's own _site.mdx names the site's identity kind: the monorepo's is
-  // Organization, a person-service scaffold's is Person. Read it, don't hard-code it (#8419).
-  const siteKind = (): "Organization" | "Person" => {
-    const site = readFileSync(join(CONTENT_ROOT, "_site.mdx"), "utf-8");
-    const kind = /^siteIdentity:\s*\n(?:[ \t]+.*\n)*?[ \t]+kind:\s*["']?(\w+)["']?\s*$/m.exec(site)?.[1];
-    if (kind !== "Organization" && kind !== "Person") {
-      throw new Error(`content/_site.mdx siteIdentity.kind is not Organization or Person: ${String(kind)}`);
-    }
-    return kind;
-  };
-
-  it("the content root's home finds the identity its _site.mdx names", async () => {
-    const kind = siteKind();
-    const report = await auditOf({ slug: "home" }, CONTENT_ROOT);
-    expect(evidenceOf(report, "entity-markup")?.evidence).toContain(
-      `Identity (${kind.toLowerCase()}) ✓`,
-    );
-  });
-
-  it("stores the flat node array, the page's own primary first", async () => {
-    const input = await buildSinglePageAuditInput({ slug: "about", type: "AboutPage" }, CONTENT_ROOT);
-    const nodes = input.jsonLdByPage["AboutPage/about"] as Array<Record<string, unknown>>;
-    expect(nodes[0]!["@type"]).toBe("AboutPage");
-    expect(nodes.map((n) => n["@type"])).toEqual(
-      expect.arrayContaining([siteKind(), "WebSite"]),
-    );
-  });
-
-  describe("a Person site", () => {
-    let root: string;
-    beforeAll(() => {
-      root = mkdtempSync(join(tmpdir(), "mcp-6597-"));
-      writeFileSync(
-        join(root, "_site.mdx"),
-        [
-          "---",
-          'version: "1"',
-          "siteName: Ada",
-          "baseUrl: https://example.com",
-          "defaultLocale: en",
-          "siteIdentity:",
-          "  kind: Person",
-          "  name: Ada Lovelace",
-          "  url: https://example.com",
-          "---",
-          "",
-        ].join("\n"),
-      );
-      mkdirSync(join(root, "en", "HomePage"), { recursive: true });
-      writeFileSync(
-        join(root, "en", "HomePage", "home.mdx"),
-        ["---", "type: HomePage", "slug: home", "title: Ada", "description: Ada's site.", "---", ""].join("\n"),
-      );
-    });
-    afterAll(() => {
-      rmSync(root, { recursive: true, force: true });
-    });
-
-    it("derives person mode from the kind: Identity (person) ✓", async () => {
-      const input = await buildSinglePageAuditInput({ slug: "home" }, root);
-      expect(input.identityMode).toBe("person");
-      const report = runAudit(input, [entityMarkup]);
-      expect(evidenceOf(report, "entity-markup")?.evidence).toContain("Identity (person) ✓");
-    });
-  });
-});

package/templates/apps/mcp/__tests__/boot.test.ts

@@ -1,280 +0,0 @@
-/**
- * The shared boot module (#8070 D1, D2): `readStatelessEnv` and
- * `httpTransportConfigFromEnv`, which both entrypoints read the environment
- * through.
- *
- * Acceptance criteria verified here (spec docs/specs/8070-spoke-mcp-vercel-backend-spec.md):
- * - AC-1: MCP_HTTP_STATELESS=true selects the stateless transport — a
- *   session-less tools/list answers 200 and lists list_pages.
- * - AC-2: each entry's default, and the accepted spellings.
- * - AC-3: a bad value throws naming the variable; a blank per-minute rate
- *   falls back to its default rather than disabling the limit.
- *
- * And from spec docs/specs/8071-mcp-write-guard-spec.md:
- * - AC-5: a blank or non-numeric MCP_ABUSE_CREATE_BOOKING_DAILY_CAP /
- *   MCP_ABUSE_SUBMIT_FLOW_STEP_DAILY_CAP yields the default cap through the
- *   env reader both entries share, never an unlimited one.
- *
- * Real sockets on port 0, the pattern of `http-transport.test.ts`.
- */
-
-import type { AddressInfo } from "node:net";
-
-import type { FastifyInstance, FastifyRequest } from "fastify";
-
-import {
-  AbuseGuard,
-  DEFAULT_CREATE_BOOKING_DAILY_CAP,
-  DEFAULT_SUBMIT_FLOW_STEP_DAILY_CAP,
-} from "../src/abuse/index.js";
-import { httpTransportConfigFromEnv, readStatelessEnv } from "../src/boot.js";
-import { buildHttpTransportApp } from "../src/http-transport.js";
-
-const VARS = [
-  "MCP_HTTP_STATELESS",
-  "MCP_HTTP_PORT",
-  "MCP_HTTP_PATH",
-  "MCP_RATE_LIMIT_READ_PER_MIN",
-  "MCP_RATE_LIMIT_WRITE_PER_MIN",
-  "MCP_CORS_WRITE_ALLOWED_ORIGINS",
-  "MCP_ABUSE_CAPTURE_LEAD_DAILY_CAP",
-  "MCP_ABUSE_START_PURCHASE_DAILY_CAP",
-  "MCP_ABUSE_CREATE_BOOKING_DAILY_CAP",
-  "MCP_ABUSE_SUBMIT_FLOW_STEP_DAILY_CAP",
-  "MCP_ABUSE_BLOCKED_USER_AGENTS",
-] as const;
-
-const saved: Partial<Record<(typeof VARS)[number], string | undefined>> = {};
-
-beforeEach(() => {
-  for (const name of VARS) {
-    saved[name] = process.env[name];
-    delete process.env[name];
-  }
-});
-
-afterEach(() => {
-  for (const name of VARS) {
-    const value = saved[name];
-    if (value === undefined) delete process.env[name];
-    else process.env[name] = value;
-  }
-});
-
-/** A stub carrying only the two members the guard reads. */
-function requestFrom(ip: string): FastifyRequest {
-  // @ts-expect-error: a full FastifyRequest cannot be built without a server.
-  return {
-    headers: { "user-agent": "Mozilla/5.0 (compatible; TestAgent/1.0)" },
-    ip,
-  };
-}
-
-const TOOLS_LIST = { jsonrpc: "2.0", id: 1, method: "tools/list", params: {} };
-
-async function listen(app: FastifyInstance): Promise<number> {
-  await app.listen({ host: "127.0.0.1", port: 0 });
-  return (app.server.address() as AddressInfo).port;
-}
-
-async function postToolsList(port: number): Promise<Response> {
-  return fetch(`http://127.0.0.1:${port}/mcp`, {
-    method: "POST",
-    body: JSON.stringify(TOOLS_LIST),
-    headers: {
-      "content-type": "application/json",
-      accept: "application/json, text/event-stream",
-    },
-  });
-}
-
-/** The app the long-running entry builds, from the environment as it stands. */
-async function appFromEnv(defaultStateless: boolean): Promise<FastifyInstance> {
-  const { port: _port, ...config } = httpTransportConfigFromEnv();
-  return buildHttpTransportApp({
-    ...config,
-    stateless: readStatelessEnv(defaultStateless),
-  });
-}
-
-describe("AC-1 — MCP_HTTP_STATELESS=true selects the stateless transport", () => {
-  let app: FastifyInstance | undefined;
-
-  afterEach(async () => {
-    await app?.close();
-    app = undefined;
-  });
-
-  it("answers a tools/list with no Mcp-Session-Id with 200, listing list_pages", async () => {
-    process.env["MCP_HTTP_STATELESS"] = "true";
-    app = await appFromEnv(false);
-    const port = await listen(app);
-
-    const res = await postToolsList(port);
-
-    expect(res.status).toBe(200);
-    const body = (await res.json()) as {
-      result?: { tools?: Array<{ name: string }> };
-    };
-    const names = (body.result?.tools ?? []).map((tool) => tool.name);
-    expect(names).toContain("list_pages");
-  });
-});
-
-describe("AC-2 — each entry's default, and the accepted spellings", () => {
-  let app: FastifyInstance | undefined;
-
-  afterEach(async () => {
-    await app?.close();
-    app = undefined;
-  });
-
-  it("unset, the long-running default is false — and a session-less tools/list is 400 (today's stateful behaviour)", async () => {
-    expect(readStatelessEnv(false)).toBe(false);
-
-    app = await appFromEnv(false);
-    const port = await listen(app);
-
-    const res = await postToolsList(port);
-    expect(res.status).toBe(400);
-  });
-
-  it("unset, the serverless default is true", () => {
-    expect(readStatelessEnv(true)).toBe(true);
-  });
-
-  it("an empty value takes the default", () => {
-    process.env["MCP_HTTP_STATELESS"] = "";
-    expect(readStatelessEnv(true)).toBe(true);
-    expect(readStatelessEnv(false)).toBe(false);
-  });
-
-  it.each(["false", "0", "FALSE"])("%s reads as false", (value) => {
-    process.env["MCP_HTTP_STATELESS"] = value;
-    expect(readStatelessEnv(true)).toBe(false);
-  });
-
-  it.each(["1", "True"])("%s reads as true", (value) => {
-    process.env["MCP_HTTP_STATELESS"] = value;
-    expect(readStatelessEnv(false)).toBe(true);
-  });
-
-  it("surrounding whitespace is trimmed", () => {
-    process.env["MCP_HTTP_STATELESS"] = "  true ";
-    expect(readStatelessEnv(false)).toBe(true);
-  });
-});
-
-describe("AC-3 — a bad value fails the boot; a blank rate does not disable the limit", () => {
-  it("a value outside the four spellings throws an Error naming MCP_HTTP_STATELESS", () => {
-    process.env["MCP_HTTP_STATELESS"] = "yes";
-    expect(() => readStatelessEnv(true)).toThrow(Error);
-    expect(() => readStatelessEnv(true)).toThrow(/MCP_HTTP_STATELESS/);
-  });
-
-  it("MCP_RATE_LIMIT_READ_PER_MIN='' yields the default 60, never NaN", () => {
-    process.env["MCP_RATE_LIMIT_READ_PER_MIN"] = "";
-    expect(httpTransportConfigFromEnv().rateLimits.readPerMin).toBe(60);
-  });
-
-  it("MCP_RATE_LIMIT_WRITE_PER_MIN='' yields the default 10, never NaN", () => {
-    process.env["MCP_RATE_LIMIT_WRITE_PER_MIN"] = "";
-    expect(httpTransportConfigFromEnv().rateLimits.writePerMin).toBe(10);
-  });
-});
-
-describe("httpTransportConfigFromEnv — today's reading of every other variable", () => {
-  it("unset, it returns today's defaults", () => {
-    expect(httpTransportConfigFromEnv()).toEqual({
-      port: 8080,
-      path: "/mcp",
-      rateLimits: { readPerMin: 60, writePerMin: 10 },
-      cors: { writeAllowedOrigins: [] },
-      abuse: {
-        captureLeadDailyCapPerIp: 50,
-        startPurchaseDailyCapPerIp: 20,
-        createBookingDailyCapPerIp: 20,
-        submitFlowStepDailyCapPerIp: 50,
-        blockedUserAgents: "",
-      },
-    });
-  });
-
-  it("set, it reads each variable as src/index.ts did", () => {
-    process.env["MCP_HTTP_PORT"] = "9090";
-    process.env["MCP_HTTP_PATH"] = "/agents";
-    process.env["MCP_RATE_LIMIT_READ_PER_MIN"] = "120";
-    process.env["MCP_RATE_LIMIT_WRITE_PER_MIN"] = "5";
-    process.env["MCP_CORS_WRITE_ALLOWED_ORIGINS"] =
-      "https://a.example, https://b.example";
-    process.env["MCP_ABUSE_CAPTURE_LEAD_DAILY_CAP"] = "3";
-    process.env["MCP_ABUSE_START_PURCHASE_DAILY_CAP"] = "2";
-    process.env["MCP_ABUSE_CREATE_BOOKING_DAILY_CAP"] = "4";
-    process.env["MCP_ABUSE_SUBMIT_FLOW_STEP_DAILY_CAP"] = "5";
-    process.env["MCP_ABUSE_BLOCKED_USER_AGENTS"] = "BadBot";
-
-    expect(httpTransportConfigFromEnv()).toEqual({
-      port: 9090,
-      path: "/agents",
-      rateLimits: { readPerMin: 120, writePerMin: 5 },
-      cors: { writeAllowedOrigins: ["https://a.example", "https://b.example"] },
-      abuse: {
-        captureLeadDailyCapPerIp: 3,
-        startPurchaseDailyCapPerIp: 2,
-        createBookingDailyCapPerIp: 4,
-        submitFlowStepDailyCapPerIp: 5,
-        blockedUserAgents: "BadBot",
-      },
-    });
-  });
-});
-
-// #8071 AC-5, through the wiring both entries use: the env value reaches the
-// AbuseGuard the HTTP transport builds from `config.abuse`
-// (http-transport.ts). A guard built straight from AbuseConfig cannot show
-// this — it defaults an absent cap on its own — so each case also pins the
-// value httpTransportConfigFromEnv() returns.
-describe("#8071 AC-5 — the booking and flow-step caps reach the guard both entries build", () => {
-  const CASES = [
-    {
-      toolName: "create_booking",
-      envVar: "MCP_ABUSE_CREATE_BOOKING_DAILY_CAP",
-      field: "createBookingDailyCapPerIp",
-      defaultCap: DEFAULT_CREATE_BOOKING_DAILY_CAP,
-    },
-    {
-      toolName: "submit_flow_step",
-      envVar: "MCP_ABUSE_SUBMIT_FLOW_STEP_DAILY_CAP",
-      field: "submitFlowStepDailyCapPerIp",
-      defaultCap: DEFAULT_SUBMIT_FLOW_STEP_DAILY_CAP,
-    },
-  ] as const;
-
-  /** Calls `toolName` until refused; returns how many calls were allowed. */
-  function allowedCalls(toolName: string, limit: number): number {
-    const guard = new AbuseGuard(httpTransportConfigFromEnv().abuse);
-    const request = requestFrom("198.51.100.7");
-    let allowed = 0;
-    while (allowed <= limit && guard.validate(toolName, {}, request).allowed) {
-      allowed += 1;
-    }
-    return allowed;
-  }
-
-  describe.each(CASES)("$envVar", ({ toolName, envVar, field, defaultCap }) => {
-    it.each(["", "abc"])(
-      "set to %p yields the default cap, refusing the call at default + 1",
-      (raw) => {
-        process.env[envVar] = raw;
-        expect(httpTransportConfigFromEnv().abuse[field]).toBe(defaultCap);
-        expect(allowedCalls(toolName, defaultCap)).toBe(defaultCap);
-      },
-    );
-
-    it("set to a positive integer, the guard refuses the call past that cap", () => {
-      process.env[envVar] = "3";
-      expect(httpTransportConfigFromEnv().abuse[field]).toBe(3);
-      expect(allowedCalls(toolName, defaultCap)).toBe(3);
-    });
-  });
-});