create-ailk 0.23.0 → 0.25.1

package/templates/apps/api/src/middleware/__tests__/write-budget.test.ts

@@ -1,174 +0,0 @@
-/**
- * @file write-budget.test.ts
- * @description The Stripe connection write budget (#8907 D9, AC-12; contract
- * K10) — `chargeWriteBudget` in middleware/rate-limit.ts.
- *
- * It counts every write against an hourly per-Organization and per-person
- * bucket in its OWN database store — never the process default — so neither
- * `AILK_RATE_LIMIT_STORE=memory` nor the per-minute sweep of the shared maps
- * can reset an hourly bucket (SEC-8907-2). A store that rejects falls back to
- * a module-private count the sweep never touches, capped at `MAX_BUCKETS`.
- */
-import Fastify from "fastify";
-
-import type { RateLimitBucket, RateLimitStore } from "../../lib/rate-limit-store.js";
-
-// eslint-disable-next-line no-restricted-syntax -- lib/prisma.ts wraps the external DB boundary; the budget's store is replaced below, so no client is ever built.
-jest.mock("../../lib/prisma.js", () => ({ prisma: {} }));
-
-const mockCreateDatabaseStore = jest.fn();
-// eslint-disable-next-line no-restricted-syntax -- the database store's constructor is the seam the case under test is about: the budget must build its own database store whatever AILK_RATE_LIMIT_STORE says
-jest.mock("../../lib/rate-limit-store.js", () => ({
-  ...jest.requireActual("../../lib/rate-limit-store.js"),
-  createDatabaseRateLimitStore: (...args: unknown[]) => mockCreateDatabaseStore(...args),
-}));
-
-import {
-  __bucketCount,
-  __resetBuckets,
-  __setWriteBudgetStoreForTests,
-  __writeBudgetFallbackCount,
-  chargeWriteBudget,
-  MAX_BUCKETS,
-  rateLimitMiddleware,
-  STRIPE_CONNECTION_WRITES_PER_ORG_PER_HOUR,
-  STRIPE_CONNECTION_WRITES_PER_USER_PER_HOUR,
-} from "../rate-limit.js";
-
-const HOUR = 60 * 60 * 1000;
-const T0 = 1_800_000_000_000;
-
-/** A `hitKey` that counts per key and window, as the database store's upsert does. */
-function countingStore(): RateLimitStore & { hitKey: jest.Mock; keys: Map<string, RateLimitBucket> } {
-  const keys = new Map<string, RateLimitBucket>();
-  const hitKey = jest.fn(async (key: string, now: number, windowMs: number) => {
-    let bucket = keys.get(key);
-    if (!bucket || now - bucket.windowStartMs >= windowMs) {
-      bucket = { count: 0, windowStartMs: now };
-      keys.set(key, bucket);
-    }
-    bucket.count += 1;
-    return { ...bucket };
-  });
-  return {
-    keys,
-    hitKey,
-    hit: jest.fn(),
-    hasOpenWindow: jest.fn(),
-    sweep: jest.fn(),
-  };
-}
-
-function rejectingStore(): RateLimitStore {
-  return {
-    hitKey: jest.fn().mockRejectedValue(new Error("db down")),
-    hit: jest.fn(),
-    hasOpenWindow: jest.fn(),
-    sweep: jest.fn(),
-  };
-}
-
-const charge = (key: string, now: number, limit = STRIPE_CONNECTION_WRITES_PER_ORG_PER_HOUR) =>
-  chargeWriteBudget({ scope: "stripeconn", charges: [{ key, limit }], windowMs: HOUR, now });
-
-beforeEach(() => {
-  __resetBuckets();
-  mockCreateDatabaseStore.mockReset();
-});
-
-afterAll(() => __setWriteBudgetStoreForTests(undefined));
-
-describe("chargeWriteBudget (#8907 D9)", () => {
-  it("answers ok ten times for one Organization, refuses the eleventh, and opens again an hour later", async () => {
-    __setWriteBudgetStoreForTests(countingStore());
-    for (let i = 0; i < 10; i++) {
-      expect(await charge("org,org_a", T0 + i * 1000)).toEqual({ ok: true });
-    }
-    const refused = await charge("org,org_a", T0 + 10_000);
-    expect(refused.ok).toBe(false);
-    if (refused.ok) throw new Error("expected a refusal");
-    expect(refused.retryAfterSeconds).toBeGreaterThanOrEqual(1);
-    expect(refused.retryAfterSeconds).toBeLessThanOrEqual(3600);
-    expect(await charge("org,org_a", T0 + HOUR)).toEqual({ ok: true });
-  });
-
-  it("counts a person's key independently, at its own limit", async () => {
-    __setWriteBudgetStoreForTests(countingStore());
-    for (let i = 0; i < 11; i++) await charge("org,org_a", T0 + i);
-    for (let i = 0; i < STRIPE_CONNECTION_WRITES_PER_USER_PER_HOUR; i++) {
-      expect(await charge("user,user_a", T0 + i, STRIPE_CONNECTION_WRITES_PER_USER_PER_HOUR)).toEqual({
-        ok: true,
-      });
-    }
-    expect((await charge("user,user_a", T0 + 30, STRIPE_CONNECTION_WRITES_PER_USER_PER_HOUR)).ok).toBe(
-      false,
-    );
-  });
-
-  it("refuses when any charge is over, and counts every charge every time", async () => {
-    const store = countingStore();
-    __setWriteBudgetStoreForTests(store);
-    const both = (now: number) =>
-      chargeWriteBudget({
-        scope: "stripeconn",
-        charges: [
-          { key: "org,org_a", limit: 10 },
-          { key: "user,user_a", limit: 20 },
-        ],
-        windowMs: HOUR,
-        now,
-      });
-    for (let i = 0; i < 10; i++) expect((await both(T0 + i)).ok).toBe(true);
-    expect((await both(T0 + 10)).ok).toBe(false);
-    expect(store.keys.get("writebudget:stripeconn|org,org_a")?.count).toBe(11);
-    expect(store.keys.get("writebudget:stripeconn|user,user_a")?.count).toBe(11);
-  });
-
-  it("is not reset by the middleware's per-minute sweep of its shared maps", async () => {
-    // A rejecting store sends every count to the fallback, the one state a
-    // shared-map sweep could reach if the budget lived there.
-    __setWriteBudgetStoreForTests(rejectingStore());
-    const past = Date.now() - 30 * 60 * 1000;
-    for (let i = 0; i < 10; i++) expect((await charge("org,org_b", past)).ok).toBe(true);
-
-    const app = Fastify();
-    await app.register(rateLimitMiddleware, { windowMs: 60_000, perIpPerMinute: 1_000 });
-    app.get("/ping", async () => ({ ok: true }));
-    await app.ready();
-    // 101 requests reach the interval sweep (`evictStaleBuckets`) at least once.
-    for (let i = 0; i < 101; i++) await app.inject({ method: "GET", url: "/ping" });
-    await app.close();
-
-    expect((await charge("org,org_b", past)).ok).toBe(false);
-  });
-
-  it("falls back to a private count capped at MAX_BUCKETS when the store rejects", async () => {
-    __setWriteBudgetStoreForTests(rejectingStore());
-    for (let i = 0; i < MAX_BUCKETS + 5; i++) await charge(`org,org_${i}`, T0);
-    expect(__writeBudgetFallbackCount()).toBe(MAX_BUCKETS);
-    // The newest entry survived the cap, the oldest did not.
-    for (let i = 0; i < 10; i++) await charge(`org,org_${MAX_BUCKETS + 4}`, T0);
-    expect((await charge(`org,org_${MAX_BUCKETS + 4}`, T0)).ok).toBe(false);
-    expect((await charge("org,org_0", T0)).ok).toBe(true);
-  });
-
-  it("uses its own database store even with AILK_RATE_LIMIT_STORE=memory, and never the shared maps", async () => {
-    const before = { DATABASE_URL: process.env.DATABASE_URL, STORE: process.env.AILK_RATE_LIMIT_STORE };
-    process.env.DATABASE_URL = "postgres://budget.invalid/db";
-    process.env.AILK_RATE_LIMIT_STORE = "memory";
-    try {
-      const store = countingStore();
-      mockCreateDatabaseStore.mockReturnValue(store);
-      __setWriteBudgetStoreForTests(undefined);
-      expect((await charge("org,org_c", T0)).ok).toBe(true);
-      expect(mockCreateDatabaseStore).toHaveBeenCalledTimes(1);
-      expect(store.hitKey).toHaveBeenCalledWith("writebudget:stripeconn|org,org_c", T0, HOUR);
-      expect(__bucketCount()).toBe(0);
-    } finally {
-      process.env.DATABASE_URL = before.DATABASE_URL;
-      process.env.AILK_RATE_LIMIT_STORE = before.STORE;
-      if (before.DATABASE_URL === undefined) delete process.env.DATABASE_URL;
-      if (before.STORE === undefined) delete process.env.AILK_RATE_LIMIT_STORE;
-    }
-  });
-});