create-ailk 0.21.0 → 0.23.0

package/templates/apps/web/app/[locale]/(authed)/account/__tests__/layout.test.tsx

@@ -26,6 +26,11 @@
  *      (#8441): a sub-route of a settings path stays inside the shell.
  *   8. One main landmark (#8441): every settings route and the Inbox, each
  *      rendered through this layout with its real page, draw exactly one.
+ *   9. The agreements interstitial (#8765 D7, AC-2, AC-3, AC-4): the layout
+ *      reads `consent.accountAgreements`; `complete: false` renders the
+ *      interstitial in place of the frame and the page; a read that fails
+ *      (anything but a 2xx or a 404) fails closed to the registry's own
+ *      agreements; an older hub's 404 renders the account as before.
  */
 import { fireEvent, render, screen, waitFor, within } from "@testing-library/react";
 import type { ReactElement, ReactNode } from "react";
@@ -85,9 +90,19 @@ jest.mock("@working-theory/api-client", () => ({
     requestForm: (...args: unknown[]) => mockMemberNotFound(...args),
   },
   hubSignIn: { me: jest.fn() },
+  // #8765 D7 — the interstitial's read; `complete: true` unless a case says otherwise.
+  consent: { accountAgreements: (...args: unknown[]) => mockAccountAgreements(...args) },
   visitorForwardHeaders: () => null,
 }));
 
+const mockAccountAgreements = jest.fn();
+const mockAcceptAction = jest.fn();
+// eslint-disable-next-line no-restricted-syntax -- test-seam mock: the Server Action module is a "use server" boundary; the interstitial only passes it through.
+jest.mock("../agreements-actions", () => ({
+  __esModule: true,
+  acceptAccountAgreementsAction: (...args: unknown[]) => mockAcceptAction(...args),
+}));
+
 const mockSignOut = jest.fn();
 jest.mock("better-auth/react", () => ({
   __esModule: true,
@@ -107,6 +122,8 @@ jest.mock("next/navigation", () => ({
 }));
 
 import { usePhoneTab } from "@working-theory/templates/account";
+import { consentStatementText } from "@working-theory/ui/blocks";
+import { ACCOUNT_TERMS_STATEMENT } from "@working-theory/validation";
 
 import AccountLayout from "../layout";
 import InboxPage from "../page";
@@ -127,6 +144,27 @@ const SESSION = {
   },
 };
 
+/** One `account_terms` entry of `GET /v1/consent/account` (#8765 D5). */
+function agreementsAnswer(entry: { acceptedVersion: number | null; current: boolean }) {
+  return {
+    ok: true,
+    body: {
+      agreements: [
+        {
+          id: "account_terms",
+          statement: ACCOUNT_TERMS_STATEMENT,
+          policyVersion: 2,
+          acceptedVersion: entry.acceptedVersion,
+          acceptedAt: entry.acceptedVersion === null ? null : "2026-09-01T00:00:00.000Z",
+          current: entry.current,
+        },
+      ],
+      complete: entry.current,
+    },
+  };
+}
+const COMPLETE = agreementsAnswer({ acceptedVersion: 2, current: true });
+
 const NO_SUBSCRIPTION = {
   ok: true,
   body: { actionRequired: false, status: null, accessRevokesAt: null, portalAvailable: false },
@@ -169,6 +207,8 @@ beforeEach(() => {
   mockSubscriptionMe.mockReset().mockResolvedValue(NO_SUBSCRIPTION);
   mockMemberNotFound.mockReset().mockResolvedValue({ ok: false, status: 404, body: null });
   mockSignOut.mockReset().mockResolvedValue({ data: {}, error: null });
+  mockAccountAgreements.mockReset().mockResolvedValue(COMPLETE);
+  mockAcceptAction.mockReset();
   mockPush.mockReset();
   mockRefresh.mockReset();
 });
@@ -519,7 +559,7 @@ describe("the settings routes take the screen (#8430)", () => {
 });
 
 describe("one main landmark (#8441)", () => {
-  type Page = (props: { params: Promise<{ locale: string }> }) => Promise<ReactElement>;
+  type Page = (props: { params: Promise<{ locale: string }> }) => Promise<ReactElement | null>;
   // Keyed by the list's own type, so a tab added to `SETTINGS_ROUTES` without
   // its page here fails to compile. Billing loads with `import()`:
   // architecture.yaml bans a static import of a relative billing/ path
@@ -575,3 +615,105 @@ describe("the shell marker (#8337 D4, AC-6)", () => {
     expect(document.querySelector("[data-ailk-shell]")).not.toBeInTheDocument();
   });
 });
+
+describe("the agreements interstitial (#8765 D7)", () => {
+  const PAGE_REFUSAL = (status: number) => ({
+    ok: false,
+    status,
+    body: { ok: false, error: { code: "x", message: "x" } },
+  });
+
+  function expectInterstitialAlone(title: string): void {
+    const page = screen.getByTestId("account-agreements-interstitial");
+    expect(within(page).getByRole("heading", { level: 1 })).toHaveTextContent(title);
+    expect(screen.queryByTestId("account-shell")).not.toBeInTheDocument();
+    expect(screen.queryByTestId("dashboard-shell")).not.toBeInTheDocument();
+    expect(screen.queryByTestId("account-child")).not.toBeInTheDocument();
+    expect(screen.queryByTestId("app-shell-aside")).not.toBeInTheDocument();
+  }
+
+  it("reads the account-level agreements with the session's own init and locale", async () => {
+    await renderLayout("fr");
+    expect(mockAccountAgreements).toHaveBeenCalledWith(
+      { headers: { cookie: "session=abc" } },
+      { locale: "fr" },
+    );
+  });
+
+  it("complete: true → the frame and its children, and no interstitial (AC-3)", async () => {
+    await renderLayout();
+    expect(screen.getByTestId("account-shell")).toBeInTheDocument();
+    expect(screen.getByTestId("account-child")).toBeInTheDocument();
+    expect(screen.queryByTestId("account-agreements-interstitial")).not.toBeInTheDocument();
+  });
+
+  it("complete: false → the interstitial in place of the frame and the page (AC-2)", async () => {
+    mockAccountAgreements.mockResolvedValue(agreementsAnswer({ acceptedVersion: null, current: false }));
+    await renderLayout();
+    expectInterstitialAlone("Please accept our terms");
+  });
+
+  it("Accept calls the action once with every id, then refreshes (AC-2)", async () => {
+    mockAccountAgreements.mockResolvedValue(agreementsAnswer({ acceptedVersion: null, current: false }));
+    mockAcceptAction.mockResolvedValue({ ok: true });
+    await renderLayout();
+    fireEvent.click(screen.getByTestId("account-agreements-accept"));
+    await waitFor(() => expect(mockRefresh).toHaveBeenCalledTimes(1));
+    expect(mockAcceptAction).toHaveBeenCalledTimes(1);
+    expect(mockAcceptAction).toHaveBeenCalledWith(["account_terms"]);
+  });
+
+  it("an older accepted version → 'We've updated our terms' (AC-4)", async () => {
+    mockAccountAgreements.mockResolvedValue(agreementsAnswer({ acceptedVersion: 1, current: false }));
+    await renderLayout();
+    expectInterstitialAlone("We've updated our terms");
+  });
+
+  it("gates the settings routes too — no account page loads behind it", async () => {
+    mockPathname = "/account/general";
+    mockAccountAgreements.mockResolvedValue(agreementsAnswer({ acceptedVersion: null, current: false }));
+    await renderLayout();
+    expectInterstitialAlone("Please accept our terms");
+  });
+
+  describe("fails closed (SEC-8765-C)", () => {
+    let errorSpy: jest.SpyInstance;
+    beforeEach(() => {
+      errorSpy = jest.spyOn(console, "error").mockImplementation(() => undefined);
+    });
+    afterEach(() => errorSpy.mockRestore());
+
+    it.each([
+      ["a 503", () => mockAccountAgreements.mockResolvedValue(PAGE_REFUSAL(503))],
+      ["a 429", () => mockAccountAgreements.mockResolvedValue(PAGE_REFUSAL(429))],
+      ["a 401", () => mockAccountAgreements.mockResolvedValue(PAGE_REFUSAL(401))],
+      ["a 403", () => mockAccountAgreements.mockResolvedValue(PAGE_REFUSAL(403))],
+      ["a thrown read", () => mockAccountAgreements.mockRejectedValue(new Error("down"))],
+    ])("%s → the interstitial from the registry, with no account behind it", async (_label, arrange) => {
+      arrange();
+      await renderLayout();
+      expectInterstitialAlone("Please accept our terms");
+      const statement = screen.getByTestId("account-agreements-statement-account_terms");
+      expect(statement.textContent).toBe(consentStatementText(ACCOUNT_TERMS_STATEMENT));
+      expect(errorSpy).toHaveBeenCalledWith(
+        expect.any(String),
+        { event: "account-agreements", outcome: "read_failed" },
+      );
+    });
+
+    it("an older hub's 404 → the account as today, and no log line", async () => {
+      mockAccountAgreements.mockResolvedValue(PAGE_REFUSAL(404));
+      await renderLayout();
+      expect(screen.getByTestId("account-shell")).toBeInTheDocument();
+      expect(screen.getByTestId("account-child")).toBeInTheDocument();
+      expect(screen.queryByTestId("account-agreements-interstitial")).not.toBeInTheDocument();
+      expect(errorSpy).not.toHaveBeenCalledWith(expect.anything(), expect.objectContaining({ event: "account-agreements" }));
+    });
+  });
+
+  it("with no session there is no read", async () => {
+    mockGetSession.mockResolvedValue(null);
+    await renderLayout();
+    expect(mockAccountAgreements).not.toHaveBeenCalled();
+  });
+});

package/templates/apps/web/app/[locale]/(authed)/account/__tests__/new-menu.test.tsx

@@ -75,6 +75,10 @@ jest.mock("@working-theory/api-client", () => ({
     meetingTypes: (...args: unknown[]) => mockMemberMeetingTypes(...args),
     requestForm: (...args: unknown[]) => mockMemberRequestForm(...args),
   },
+  // #8765 D7 — the layout's agreements read: complete, so the frame renders.
+  consent: {
+    accountAgreements: async () => ({ ok: true, body: { agreements: [], complete: true } }),
+  },
 }));
 
 jest.mock("better-auth/react", () => ({