create-ailk 0.2.0 → 0.4.0

package/templates/apps/api/src/routes/project-listings/__tests__/me.test.ts

@@ -1,3 +1,6 @@
+// Not marked oss: false (D-48/#5366 escalation) — tests the
+// always-shipping project-listings anonymous surface; see
+// routes/project-listings/me.ts's header comment.
 /**
  * @file me.test.ts
  *
@@ -122,6 +125,13 @@ function row(fixture: ListingFixture) {
     windowDays: 30,
     founderName: "A Founder",
     founderEmail: fixture.founderEmail,
+    // #5407 — a row written before the columns existed, and a freshly
+    // started draft on a site that asks for one name line: parts null,
+    // no phone, no verification stamp.
+    founderFirstName: null,
+    founderLastName: null,
+    founderPhone: null,
+    emailVerifiedAt: null,
     founderCompany: null,
     headline: "Atlas",
     logoMarkUrl: null,

package/templates/apps/api/src/routes/project-listings/__tests__/public.test.ts

@@ -1,3 +1,6 @@
+// Not marked oss: false (D-48/#5366 escalation) — tests the
+// always-shipping project-listings anonymous surface; see
+// routes/project-listings/me.ts's header comment.
 /**
  * @file public.test.ts
  *
@@ -34,6 +37,13 @@ import { projectListingPublicSchema } from "@working-theory/validation";
 // `routes/leads/__tests__/index.test.ts`'s discipline.
 jest.mock("@working-theory/email", () => ({
   sendLeadNotification: jest.fn().mockResolvedValue({ ok: true, messageId: "msg-test" }),
+  // #5406 — `start` now reaches the resume email. Declared here for the reason
+  // docs/lessons/project-listings/04 records: a mock factory that omits an
+  // export the code under test calls leaves it `undefined` at the callsite.
+  // These suites configure no `resumeEmail`, so the send short-circuits before
+  // this is reached; it is declared so a future fixture that DOES configure
+  // one fails on its assertion rather than on a missing mock.
+  sendListingResumeEmail: jest.fn().mockResolvedValue({ ok: true, messageId: "msg-resume" }),
 }));
 jest.mock("@working-theory/license", () => ({
   checkLicense: jest.fn().mockResolvedValue({
@@ -108,6 +118,13 @@ function makeRow(overrides: Partial<Record<string, unknown>>) {
     questions: QUESTIONS,
     founderName: "Some Founder",
     founderEmail: "founder@example.com",
+    // #5407 — a row that filled in EVERY new column, which is the shape that
+    // can actually leak. A null phone would pass the public-read tests below
+    // whether or not the strip existed.
+    founderFirstName: "Some",
+    founderLastName: "Founder",
+    founderPhone: "+12015550123",
+    emailVerifiedAt: new Date("2026-08-02T00:00:00.000Z"),
     founderCompany: null,
     headline: null,
     logoMarkUrl: null,
@@ -268,6 +285,27 @@ describe("GET /v1/project-listings/public", () => {
     }
   });
 
+  // #5407 — the phone and the verification stamp join `founderEmail` on the
+  // never-public list, and the fixture above carries a real value for each so
+  // this test can actually fail. Asserted on the SERIALIZED body, not on the
+  // parsed rows: `.strict()` would reject an extra key, but only a string
+  // search proves the VALUE is not riding some other field.
+  it("never carries founderPhone or emailVerifiedAt on any row (#5407)", async () => {
+    const res = await app.inject({
+      method: "GET",
+      url: `/v1/project-listings/public?siteKey=${SITE_KEY}`,
+    });
+
+    const body = JSON.stringify(res.json());
+    expect(body).not.toContain("founderPhone");
+    expect(body).not.toContain("+12015550123");
+    expect(body).not.toContain("emailVerifiedAt");
+    expect(body).not.toContain("2026-08-02");
+    // The two name PARTS do ride the public read, deliberately: they are the
+    // same information as `founderName`, which has always been public.
+    expect(body).toContain("founderFirstName");
+  });
+
   it("400s on a malformed siteKey", async () => {
     const res = await app.inject({ method: "GET", url: "/v1/project-listings/public?siteKey=" });
     expect(res.statusCode).toBe(400);