create-ailk 0.18.0 → 0.19.1

package/templates/apps/web/app/[locale]/(authed)/account/__tests__/settings.test.tsx

@@ -1,407 +1,92 @@
 /**
- * Tests for /[locale]/account/settings — User settings (#7430, spec 7423
- * U4 · D10, D10a; AC-8, plus the operator fold-ins of 2026-10-01).
+ * Tests for /[locale]/account/settings — now a redirect to User settings ›
+ * General (#8232, spec docs/specs/8232-member-settings-account-general-and-spec.md
+ * D8, D15; AC-6).
  *
- * Covers:
- *   1. General, Security, Notifications and Privacy always render; no
- *      Credentials, Scope, Organizations or Credits section exists.
- *   2. Billing renders for `subscription.me()` answering `status: "active"`
- *      or `portalAvailable: true`; it is absent for `status: null` with
- *      `portalAvailable: false`, and for a 404.
- *   3. General lets a member SET and edit their name (an accepted applicant
- *      arrives with none, #7418) — saved through Better Auth's `updateUser`.
- *   4. The color-mode control renders only when the site's theme defines
- *      more than one mode.
- *   5. Security lists the configured sign-in methods; a Password row only
- *      when the password method is on.
- *   6. Privacy links to the cookie settings and files a deletion request.
+ * The one-page, anchored settings of #7430 split into `/account/general`
+ * and `/account/billing`; its General, Security, Notifications, Privacy and
+ * Billing cases moved to `general.test.tsx` and `billing.test.tsx`, rewritten
+ * for D2–D9. A `#billing` fragment never reaches the server, so the server
+ * redirect is to General and `BillingAnchor` forwards the fragment there
+ * (`general.test.tsx` § AC-6).
+ *
+ * #8441 — `SETTINGS_ROUTES` (settings-frame.tsx) is the one list of User
+ * settings' routes: the tabs read it, and so does `isSettingsPath`, the
+ * exact, locale-aware membership test the account frame takes the settings
+ * routes out of its shell with (layout.test.tsx renders each route).
  */
-import { mkdtempSync, rmSync, writeFileSync } from "node:fs";
-import { tmpdir } from "node:os";
-import { join } from "node:path";
-
-import { act, fireEvent, render, screen, waitFor, within } from "@testing-library/react";
-
-jest.mock("next-intl/server", () => {
-  const msgs: unknown = require("../../../../../messages/en.json");
-  const dig = (obj: unknown, path: string): unknown =>
-    path.split(".").reduce<unknown>(
-      (acc, k) => (acc !== null && typeof acc === "object" ? (acc as Record<string, unknown>)[k] : undefined),
-      obj,
-    );
-  return {
-    __esModule: true,
-    getTranslations: async (arg: string | { namespace?: string; locale?: string }) => {
-      const ns = typeof arg === "string" ? arg : (arg.namespace ?? "");
-      const messages = dig(msgs, ns);
-      return (key: string, values?: Record<string, unknown>): string => {
-        const value = dig(messages, key);
-        if (typeof value !== "string") return `${ns}.${key}`;
-        return value.replace(/\{(\w+)\}/g, (m, name: string) =>
-          values && name in values ? String(values[name]) : m,
-        );
-      };
-    },
-  };
-});
-
-jest.mock("next/headers", () => ({
-  __esModule: true,
-  headers: jest.fn().mockResolvedValue(new Headers()),
-  cookies: jest.fn().mockResolvedValue({ toString: () => "session=abc" }),
-}));
-
-const mockGetSession = jest.fn();
-// eslint-disable-next-line no-restricted-syntax -- #507: mock-internal rewrite pending; auth.ts's lazy Better-Auth singleton has no HTTP/DB boundary a unit test of the session fields can mock without standing up Prisma.
-jest.mock("../../../../../auth", () => ({
-  __esModule: true,
-  auth: { api: { getSession: (...args: unknown[]) => mockGetSession(...args) } },
-}));
-
-const mockSubscriptionMe = jest.fn();
-const mockLeadsSubmit = jest.fn();
-jest.mock("@working-theory/api-client", () => ({
-  __esModule: true,
-  waitlistSignups: { me: jest.fn() },
-  flowCheckouts: { me: jest.fn() },
-  subscription: {
-    me: (...args: unknown[]) => mockSubscriptionMe(...args),
-    portalSession: jest.fn(),
-  },
-  leads: { submit: (...args: unknown[]) => mockLeadsSubmit(...args) },
-  visitorForwardHeaders: () => null,
-}));
-
-const mockUpdateUser = jest.fn();
-jest.mock("better-auth/react", () => ({
-  __esModule: true,
-  createAuthClient: () => ({
-    signOut: jest.fn(),
-    updateUser: (...args: unknown[]) => mockUpdateUser(...args),
-  }),
-}));
 
-const mockRefresh = jest.fn();
+const mockRedirect = jest.fn();
 jest.mock("next/navigation", () => ({
   __esModule: true,
-  useRouter: () => ({ push: jest.fn(), refresh: mockRefresh }),
-  usePathname: () => "/account/settings",
-  redirect: jest.fn(),
+  redirect: (...args: unknown[]) => mockRedirect(...args),
 }));
 
-// The colour-mode cases test the theme's modes, so they run against an unpinned
-// chrome: a scaffold whose design pins light mode (minimalism, #7742 D2) would
-// otherwise hide the control in every case. theme-modes.test.ts covers the pin.
-// eslint-disable-next-line no-restricted-syntax -- #507: `site-chrome.ts` is a generated data module with no external boundary to mock instead (as theme-modes.test.ts).
-jest.mock("../../../../../lib/site-chrome", () => {
-  const actual = jest.requireActual("../../../../../lib/site-chrome");
-  const { colorMode, ...unpinned } = actual.siteChrome;
-  return { ...actual, siteChrome: unpinned };
-});
-
 import Page from "../settings/page";
-
-const SESSION = {
-  user: {
-    id: "user_1",
-    name: "Ada Lovelace",
-    email: "ada@example.com",
-    emailVerified: true,
-    createdAt: new Date("2026-09-01T00:00:00.000Z"),
-  },
-};
-
-const subscriptionBody = (body: Record<string, unknown>) => ({
-  ok: true,
-  body: { actionRequired: false, status: null, accessRevokesAt: null, portalAvailable: false, ...body },
-});
-
-// ── The site's theme, as `_site.mdx` declares it ──────────────────────────────
-
-let contentRoot: string;
-
-function writeSite(frontmatter: string): void {
-  writeFileSync(join(contentRoot, "_site.mdx"), `---\n${frontmatter}\n---\n`);
-}
-
-const ENV_KEYS = [
-  "AILK_CONTENT_ROOT",
-  "GOOGLE_CLIENT_ID",
-  "GOOGLE_CLIENT_SECRET",
-  "GITHUB_CLIENT_ID",
-  "GITHUB_CLIENT_SECRET",
-  "AUTH_EMAIL_SERVER",
-  "AUTH_EMAIL_FROM",
-  "AUTH_EMAIL_WEBHOOK_SECRET",
-  "BETTER_AUTH_URL",
-  "BETTER_AUTH_SECRET",
-] as const;
-const savedEnv: Partial<Record<(typeof ENV_KEYS)[number], string>> = {};
-
-beforeAll(() => {
-  for (const key of ENV_KEYS) {
-    const value = process.env[key];
-    if (value !== undefined) savedEnv[key] = value;
-  }
-});
-
-afterAll(() => {
-  for (const key of ENV_KEYS) {
-    const value = savedEnv[key];
-    if (value === undefined) delete process.env[key];
-    else process.env[key] = value;
-  }
-});
+import { isSettingsPath, memberSettingsFrame, SETTINGS_ROUTES, type Translate } from "../settings-frame";
 
 beforeEach(() => {
-  for (const key of ENV_KEYS) delete process.env[key];
-  contentRoot = mkdtempSync(join(tmpdir(), "ailk-settings-"));
-  process.env.AILK_CONTENT_ROOT = contentRoot;
-  writeSite('siteName: "Test"');
-  mockGetSession.mockReset().mockResolvedValue(SESSION);
-  mockSubscriptionMe.mockReset().mockResolvedValue(subscriptionBody({}));
-  mockLeadsSubmit.mockReset().mockResolvedValue({ ok: true, body: { id: "lead_1", persisted: "db" } });
-  mockUpdateUser.mockReset().mockResolvedValue({ data: { status: true }, error: null });
-  mockRefresh.mockReset();
+  mockRedirect.mockReset();
 });
 
-afterEach(() => {
-  rmSync(contentRoot, { recursive: true, force: true });
-});
-
-async function renderPage(): Promise<void> {
-  const element = await Page({ params: Promise.resolve({ locale: "en" }) });
-  render(element);
-}
-
-function sectionTitles(): string[] {
-  return screen
-    .getAllByRole("heading", { level: 2 })
-    .map((heading) => heading.textContent ?? "");
-}
-
-describe("the base sections (AC-8)", () => {
-  it("renders General, Security, Notifications and Privacy — and no admin-only section", async () => {
-    await renderPage();
-    expect(screen.getByRole("heading", { level: 1 })).toHaveTextContent("Settings");
-    expect(sectionTitles()).toEqual(["General", "Security", "Notifications", "Privacy"]);
-    for (const absent of [/credentials/i, /scope/i, /organizations/i, /credits/i]) {
-      expect(screen.queryByRole("heading", { name: absent })).not.toBeInTheDocument();
-    }
+describe("AC-6 — /account/settings redirects to /account/general (D8)", () => {
+  it("redirects the default locale to /account/general", async () => {
+    await Page({ params: Promise.resolve({ locale: "en" }) });
+    expect(mockRedirect).toHaveBeenCalledTimes(1);
+    expect(mockRedirect).toHaveBeenCalledWith("/account/general");
   });
 
-  it("each section is an anchor the For-you items link to", async () => {
-    await renderPage();
-    for (const id of ["general", "security", "notifications", "privacy"]) {
-      expect(document.getElementById(id)).toBeInTheDocument();
-    }
+  it("keeps a non-default locale", async () => {
+    await Page({ params: Promise.resolve({ locale: "fr" }) });
+    expect(mockRedirect).toHaveBeenCalledWith("/fr/account/general");
   });
 });
 
-describe("Billing (AC-8, D10)", () => {
-  it('renders for status: "active", with the status', async () => {
-    mockSubscriptionMe.mockResolvedValue(subscriptionBody({ status: "active" }));
-    await renderPage();
-    const billing = document.getElementById("billing")!;
-    expect(within(billing).getByRole("heading", { level: 2 })).toHaveTextContent("Billing");
-    expect(billing).toHaveTextContent("Active");
-    expect(within(billing).queryByTestId("account-billing-manage")).not.toBeInTheDocument();
-  });
-
-  it("renders for portalAvailable: true, with Manage billing", async () => {
-    mockSubscriptionMe.mockResolvedValue(subscriptionBody({ portalAvailable: true }));
-    await renderPage();
-    const billing = document.getElementById("billing")!;
-    expect(within(billing).getByTestId("account-billing-manage")).toHaveTextContent(
-      "Manage billing",
-    );
-  });
-
-  it("shows when access ends, when set", async () => {
-    mockSubscriptionMe.mockResolvedValue(
-      subscriptionBody({ status: "canceled", accessRevokesAt: "2026-10-20T00:00:00.000Z" }),
-    );
-    await renderPage();
-    const billing = document.getElementById("billing")!;
-    expect(billing).toHaveTextContent("Canceled");
-    expect(billing).toHaveTextContent("Access ends");
-  });
-
-  it("is absent for status: null with portalAvailable: false", async () => {
-    await renderPage();
-    expect(document.getElementById("billing")).not.toBeInTheDocument();
-    expect(sectionTitles()).not.toContain("Billing");
-  });
-
-  it("is absent for a 404 (the commerce-disabled build)", async () => {
-    mockSubscriptionMe.mockResolvedValue({ ok: false, status: 404, body: {} });
-    await renderPage();
-    expect(document.getElementById("billing")).not.toBeInTheDocument();
-  });
-
-  it.each([401, 403])("is absent for a %i", async (status) => {
-    mockSubscriptionMe.mockResolvedValue({ ok: false, status, body: {} });
-    await renderPage();
-    expect(document.getElementById("billing")).not.toBeInTheDocument();
-  });
-});
-
-describe("General — the member's name (operator fold-in, #7418)", () => {
-  it("shows the email read-only and the name in an editable field", async () => {
-    await renderPage();
-    const general = document.getElementById("general")!;
-    expect(within(general).getByTestId("account-settings-email")).toHaveTextContent(
-      "ada@example.com",
-    );
-    expect(within(general).getByLabelText("Name")).toHaveValue("Ada Lovelace");
-  });
-
-  it("a member with no name can set one: Save is disabled until the field changes, then saves through updateUser", async () => {
-    mockGetSession.mockResolvedValue({ user: { ...SESSION.user, name: "" } });
-    await renderPage();
-    const input = screen.getByLabelText("Name");
-    expect(input).toHaveValue("");
-    const save = screen.getByTestId("account-name-save");
-    expect(save).toBeDisabled();
-    fireEvent.change(input, { target: { value: "  Grace Hopper " } });
-    expect(save).toBeEnabled();
-    expect(screen.getByTestId("account-name-status")).toHaveTextContent("Unsaved changes");
-    await act(async () => {
-      fireEvent.click(save);
-    });
-    expect(mockUpdateUser).toHaveBeenCalledWith({ name: "Grace Hopper" });
-    await waitFor(() => expect(mockRefresh).toHaveBeenCalledTimes(1));
-    expect(screen.getByTestId("account-name-status")).toHaveTextContent("Saved.");
-  });
-
-  it("a blank name is refused without a call", async () => {
-    await renderPage();
-    const input = screen.getByLabelText("Name");
-    fireEvent.change(input, { target: { value: "   " } });
-    await act(async () => {
-      fireEvent.click(screen.getByTestId("account-name-save"));
-    });
-    expect(mockUpdateUser).not.toHaveBeenCalled();
-    expect(screen.getByRole("alert")).toHaveTextContent("Enter your name.");
-  });
-
-  it("a failed save says so and keeps the edit", async () => {
-    mockUpdateUser.mockResolvedValue({ data: null, error: { message: "nope" } });
-    await renderPage();
-    const input = screen.getByLabelText("Name");
-    fireEvent.change(input, { target: { value: "Ada King" } });
-    await act(async () => {
-      fireEvent.click(screen.getByTestId("account-name-save"));
-    });
-    expect(screen.getByRole("alert")).toHaveTextContent("We couldn't save your name.");
-    expect(input).toHaveValue("Ada King");
-    expect(mockRefresh).not.toHaveBeenCalled();
-  });
-});
-
-describe("General — a save that throws", () => {
-  it("a network failure says so and re-enables Save", async () => {
-    mockUpdateUser.mockRejectedValue(new TypeError("Failed to fetch"));
-    await renderPage();
-    fireEvent.change(screen.getByLabelText("Name"), { target: { value: "Ada King" } });
-    await act(async () => {
-      fireEvent.click(screen.getByTestId("account-name-save"));
-    });
-    expect(screen.getByRole("alert")).toHaveTextContent("We couldn't save your name.");
-    expect(screen.getByTestId("account-name-save")).toBeEnabled();
-  });
-});
-
-describe("General — color mode only on a multi-mode theme (operator fold-in)", () => {
-  it("a site with no theme block (the default light + dark palette) shows Light · Auto · Dark", async () => {
-    await renderPage();
-    const control = screen.getByTestId("account-color-mode");
-    expect(within(control).getAllByRole("radio").map((r) => r.textContent)).toEqual([
-      "Light",
-      "Auto",
-      "Dark",
+describe("the one list of User settings' routes (#8441)", () => {
+  it("names the four tabs, in the reference's order", () => {
+    expect(SETTINGS_ROUTES.map(({ key, path }) => [key, path])).toEqual([
+      ["general", "/account/general"],
+      ["security", "/account/security"],
+      ["notifications", "/account/notifications"],
+      ["billing", "/account/billing"],
     ]);
   });
 
-  it("a theme declaring both modes shows the control", async () => {
-    writeSite('theme:\n  colors:\n    light:\n      bg: "#ffffff"\n    dark:\n      bg: "#000000"');
-    await renderPage();
-    expect(screen.getByTestId("account-color-mode")).toBeInTheDocument();
-  });
-
-  it("a light-only theme shows no control", async () => {
-    writeSite('theme:\n  colors:\n    light:\n      bg: "#fdfcfa"\n      text: "#1c1917"');
-    await renderPage();
-    expect(screen.queryByTestId("account-color-mode")).not.toBeInTheDocument();
-  });
-
-  it("choosing Dark writes the theme cookie and the root's data-theme", async () => {
-    await renderPage();
-    const control = screen.getByTestId("account-color-mode");
-    fireEvent.click(within(control).getByRole("radio", { name: "Dark" }));
-    expect(document.documentElement.getAttribute("data-theme")).toBe("dark");
-    expect(document.cookie).toContain("ailk-theme=dark");
-  });
-});
-
-describe("Security — the configured sign-in methods (D10)", () => {
-  it("lists each configured method; no Password row without the password method", async () => {
-    process.env.GOOGLE_CLIENT_ID = "id";
-    process.env.GOOGLE_CLIENT_SECRET = "secret";
-    await renderPage();
-    const security = document.getElementById("security")!;
-    expect(within(security).getByText("Google")).toBeInTheDocument();
-    expect(within(security).queryByText("GitHub")).not.toBeInTheDocument();
-    expect(within(security).queryByText("Password")).not.toBeInTheDocument();
-  });
-
-  it("the password method adds a Password row", async () => {
-    process.env.AUTH_EMAIL_SERVER = "smtp://x";
-    process.env.AUTH_EMAIL_FROM = "site@example.com";
-    await renderPage();
-    const security = document.getElementById("security")!;
-    expect(within(security).getByText("Password")).toBeInTheDocument();
-  });
-
-  it("no configured method says so", async () => {
-    await renderPage();
-    expect(document.getElementById("security")).toHaveTextContent(
-      "No sign-in method is configured.",
+  it.each(["en", "fr"])("the settings frame's tabs are that list, in %s", (locale) => {
+    const t: Translate = (key) => key;
+    const { tabs } = memberSettingsFrame(locale, t, "security");
+    expect(tabs.map(({ key, href, label }) => [key, href, label])).toEqual(
+      SETTINGS_ROUTES.map(({ key, path, titleKey }) => [
+        key,
+        locale === "en" ? path : `/${locale}${path}`,
+        titleKey,
+      ]),
     );
   });
 });
 
-describe("Privacy (D10)", () => {
-  it("links to the cookie settings", async () => {
-    await renderPage();
-    const privacy = document.getElementById("privacy")!;
-    expect(within(privacy).getByText("Cookie settings").closest("a")).toHaveAttribute(
-      "href",
-      "/privacy#cookie-settings",
-    );
-  });
-
-  it("Request account deletion files a support request of kind deletion", async () => {
-    await renderPage();
-    const privacy = document.getElementById("privacy")!;
-    await act(async () => {
-      fireEvent.click(within(privacy).getByTestId("account-deletion-request"));
-    });
-    await waitFor(() => expect(mockLeadsSubmit).toHaveBeenCalledTimes(1));
-    const [body] = mockLeadsSubmit.mock.calls[0] as [Record<string, unknown>];
-    expect(body).toEqual({
-      source: "web",
-      email: "ada@example.com",
-      payload: {
-        kind: "deletion",
-        subject: "Account deletion request",
-        message: "Please delete my account and its data.",
-      },
-    });
-    await waitFor(() =>
-      expect(within(privacy).getByRole("status")).toHaveTextContent(
-        "Your deletion request is on its way.",
-      ),
-    );
+describe("isSettingsPath — an exact, locale-aware match (#8441)", () => {
+  it.each(SETTINGS_ROUTES.map(({ path }) => path))("%s is a settings route, bare or prefixed", (path) => {
+    expect(isSettingsPath(path, "en")).toBe(true);
+    expect(isSettingsPath(`/fr${path}`, "fr")).toBe(true);
+  });
+
+  it.each([
+    ["/account", "en"],
+    ["/account/settings", "en"],
+    ["/account/support", "en"],
+    ["/account/artifacts", "en"],
+    // A sub-route stays inside the shell unless it is listed.
+    ["/account/billing/history", "en"],
+    ["/fr/account/billing/history", "fr"],
+    ["/account/general/", "en"],
+    ["/account/generalx", "en"],
+    // Only the request's own locale is a prefix.
+    ["/fr/account/general", "en"],
+    ["/de/account/general", "fr"],
+    ["/frx/account/general", "fr"],
+    ["", "en"],
+  ])("%s (locale %s) is not", (path, locale) => {
+    expect(isSettingsPath(path, locale)).toBe(false);
   });
 });

package/templates/apps/web/app/[locale]/(authed)/account/__tests__/support.test.tsx

@@ -189,15 +189,20 @@ describe("submitSupportRequest — the Server Action's own guards", () => {
     expect(mockLeadsSubmit).not.toHaveBeenCalled();
   });
 
-  it("any kind other than deletion files as support; the email is always the session's", async () => {
-    await submitSupportRequest(
-      { kind: "idle" },
-      form({ kind: "refund", subject: "Hi", message: "Help", email: "someone@else.com" }),
-    );
-    expect(mockLeadsSubmit).toHaveBeenCalledWith({
-      source: "web",
-      email: "ada@example.com",
-      payload: { kind: "support", subject: "Hi", message: "Help" },
-    });
-  });
+  // #8232 D12 — a deletion request goes through `member.requestDeletion`
+  // (`profile-actions.ts`), so Support files support only.
+  it.each(["refund", "deletion"])(
+    "every request files as support, a posted kind=%s included; the email is always the session's",
+    async (kind) => {
+      await submitSupportRequest(
+        { kind: "idle" },
+        form({ kind, subject: "Hi", message: "Help", email: "someone@else.com" }),
+      );
+      expect(mockLeadsSubmit).toHaveBeenCalledWith({
+        source: "web",
+        email: "ada@example.com",
+        payload: { kind: "support", subject: "Hi", message: "Help" },
+      });
+    },
+  );
 });

package/templates/apps/web/app/[locale]/(authed)/account/account-data.ts

@@ -150,7 +150,7 @@ function addNameItem(session: AccountSession, now: string): ForYouItem[] {
       },
       title: ctx.t("forYou.addName"),
       time: { kind: "waiting", at: session.createdAt ?? now },
-      action: { kind: "open", href: localeHref(ctx.locale, "/account/settings#general") },
+      action: { kind: "open", href: localeHref(ctx.locale, "/account/general") },
       dismissible: true,
     },
   ];