create-agdf 0.1.2 → 0.1.4
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/README.md +23 -4
- package/bin/create-agdf.js +58 -9
- package/generated/.agdf/control/README.md +39 -0
- package/generated/.agdf/control/templates/AGDF_RUN.md +84 -0
- package/generated/.agdf/control/templates/AGENT_QUALITY_CONTRACTS.json +78 -0
- package/generated/.agdf/control/templates/CONTEXT_GRAPH.md +51 -0
- package/generated/.agdf/control/templates/MASTER_BACKLOG.md +29 -0
- package/generated/.agdf/control/templates/SOT_REGISTRY.md +25 -0
- package/generated/.agents/plugins/marketplace.json +17 -0
- package/generated/.github/skills/agdf-runtime-contract.md +12 -0
- package/generated/AGENTS.md +12 -0
- package/generated/plugins/agdf/.codex-plugin/plugin.json +30 -0
- package/generated/plugins/agdf/control/README.md +39 -0
- package/generated/plugins/agdf/control/templates/AGDF_RUN.md +84 -0
- package/generated/plugins/agdf/control/templates/AGENT_QUALITY_CONTRACTS.json +78 -0
- package/generated/plugins/agdf/control/templates/CONTEXT_GRAPH.md +51 -0
- package/generated/plugins/agdf/control/templates/MASTER_BACKLOG.md +29 -0
- package/generated/plugins/agdf/control/templates/SOT_REGISTRY.md +25 -0
- package/generated/plugins/agdf/meta/agdf-constitution.md +312 -0
- package/generated/plugins/agdf/meta/agdf-copilot-agents.md +77 -0
- package/generated/plugins/agdf/meta/agdf-runtime-contract.md +85 -0
- package/generated/plugins/agdf/meta/agdf-tenets.md +191 -0
- package/generated/plugins/agdf/skills/agdf-brownfield-analysis/SKILL.md +116 -0
- package/generated/plugins/agdf/skills/agdf-brownfield-analysis/help.md +23 -0
- package/generated/plugins/agdf/skills/agdf-clean-implementation-review/SKILL.md +100 -0
- package/generated/plugins/agdf/skills/agdf-clean-implementation-review/help.md +23 -0
- package/generated/plugins/agdf/skills/agdf-code-review/SKILL.md +94 -0
- package/generated/plugins/agdf/skills/agdf-code-review/help.md +23 -0
- package/generated/plugins/agdf/skills/agdf-delivery-closeout/SKILL.md +109 -0
- package/generated/plugins/agdf/skills/agdf-delivery-closeout/help.md +23 -0
- package/generated/plugins/agdf/skills/agdf-gate-check/SKILL.md +92 -0
- package/generated/plugins/agdf/skills/agdf-gate-check/help.md +23 -0
- package/generated/plugins/agdf/skills/agdf-qa-gate/SKILL.md +110 -0
- package/generated/plugins/agdf/skills/agdf-qa-gate/help.md +23 -0
- package/generated/plugins/agdf/skills/agdf-release-or/SKILL.md +124 -0
- package/generated/plugins/agdf/skills/agdf-release-or/help.md +23 -0
- package/generated/plugins/agdf/skills/agdf-task-plan-review/SKILL.md +115 -0
- package/generated/plugins/agdf/skills/agdf-task-plan-review/help.md +23 -0
- package/package.json +4 -2
|
@@ -0,0 +1,85 @@
|
|
|
1
|
+
# AGDF Runtime Contract
|
|
2
|
+
|
|
3
|
+
This contract centralizes recurring runtime rules for AGDF skills.
|
|
4
|
+
It is the operational reference for skill outputs, but it is not a second copy of the framework documentation.
|
|
5
|
+
|
|
6
|
+
## Mode Selection
|
|
7
|
+
|
|
8
|
+
| Mode | Default | Escalate When |
|
|
9
|
+
|---|---|---|
|
|
10
|
+
| Quick Task Mode | small questions, reviews, debugging, local fixes without new product semantics | a new user capability, architecture/policy/persistence impact, formal artefacts, or approvals are involved |
|
|
11
|
+
| Structured Delivery Mode | formal delivery runs, gate-relevant work, release-critical changes | always use gate discipline, internal reviews, and OR |
|
|
12
|
+
|
|
13
|
+
Quick Task Mode must not become ritual gate overhead.
|
|
14
|
+
Structured Delivery must not bypass missing approvals.
|
|
15
|
+
|
|
16
|
+
## Gate Rules
|
|
17
|
+
|
|
18
|
+
- User gates: `UR -> PRD -> SD -> TP -> QA -> UAT`
|
|
19
|
+
- Internal mandatory steps: `Brownfield Analysis -> CD+Tests -> CR -> OR`
|
|
20
|
+
- Exact approval formula: `Approval: <GateName>`
|
|
21
|
+
- Legacy alias: `Freigabe: <GateName>` may be accepted when reviewing older German runs, but all new outputs must use `Approval: <GateName>`.
|
|
22
|
+
- Implicit consent is not approval.
|
|
23
|
+
- The earliest blocking gate wins.
|
|
24
|
+
- `CD+Tests` is implementation and test status only, not a delivery signal.
|
|
25
|
+
- `agdf-code-review` standardizes the mandatory `CR` step, but does not replace QA.
|
|
26
|
+
- `agdf-qa-gate` decides final `pass | revise | block`.
|
|
27
|
+
- `agdf-release-or` reports the run, but does not replace QA.
|
|
28
|
+
|
|
29
|
+
## Quality Contract Output
|
|
30
|
+
|
|
31
|
+
Structured Delivery skills use this shape when relevant:
|
|
32
|
+
|
|
33
|
+
- `decision`: `pass | revise | block | not_applicable`
|
|
34
|
+
- `evidence`: concrete artefacts, files, tests, logs, diffs, or observations
|
|
35
|
+
- `missing_evidence`: missing proof needed for a stronger claim
|
|
36
|
+
- `risks`: remaining risks, assumptions, fallbacks, drift, or blockers
|
|
37
|
+
- `required_next_step`: exactly the next clean step
|
|
38
|
+
- `impact_codes`: affected Quality Contract codes, if the target repo has a registry
|
|
39
|
+
|
|
40
|
+
A skill may briefly remind this shape, but must not duplicate a complete code or rule matrix.
|
|
41
|
+
|
|
42
|
+
## Context Graph Output
|
|
43
|
+
|
|
44
|
+
When a run affects project memory or a Context Graph, use:
|
|
45
|
+
|
|
46
|
+
- `Situation:` short plain-language summary when the impact is non-trivial
|
|
47
|
+
- `context_graph_impact`: `none | link_only | update_existing_node | new_node_required | sot_drift`
|
|
48
|
+
- `context_graph_refs`
|
|
49
|
+
- `context_graph_required_action`: `none | link | update | create | resolve_drift`
|
|
50
|
+
- `context_graph_gate_effect`: `none | warning | revise | block`
|
|
51
|
+
- `context_graph_evidence`
|
|
52
|
+
|
|
53
|
+
Do not create a new node for a mere version, a general chat summary, or a local observation without a concrete next clean step.
|
|
54
|
+
`sot_drift` must not pass silently as a warning.
|
|
55
|
+
|
|
56
|
+
## Control Scaffold
|
|
57
|
+
|
|
58
|
+
When a repository needs durable AGDF state, use the plugin-local `control/` scaffold as the starting point.
|
|
59
|
+
|
|
60
|
+
- `AGDF_RUN.md` is the current run dashboard.
|
|
61
|
+
- `MASTER_BACKLOG.md` is the living pointer for active delivery work.
|
|
62
|
+
- `SOT_REGISTRY.md` prevents parallel sources of truth.
|
|
63
|
+
- `CONTEXT_GRAPH.md` stores durable Brownfield findings, decisions, risks, evidence and exit criteria.
|
|
64
|
+
- `AGENT_QUALITY_CONTRACTS.json` stores reusable block, revise and warning conditions.
|
|
65
|
+
|
|
66
|
+
The scaffold is not a second documentation site. Link to authoritative artefacts instead of copying them.
|
|
67
|
+
|
|
68
|
+
## Skill Output
|
|
69
|
+
|
|
70
|
+
Every skill output should be as short as possible and as concrete as needed.
|
|
71
|
+
It must distinguish:
|
|
72
|
+
|
|
73
|
+
- facts
|
|
74
|
+
- evidence
|
|
75
|
+
- assumptions
|
|
76
|
+
- interpretations
|
|
77
|
+
- missing evidence
|
|
78
|
+
- the next permissible step
|
|
79
|
+
|
|
80
|
+
## Do Not Duplicate
|
|
81
|
+
|
|
82
|
+
The explanatory framework lives in `docs/`.
|
|
83
|
+
The operating philosophy lives in `plugin/meta/agdf-constitution.md`.
|
|
84
|
+
The principles live in `plugin/meta/agdf-tenets.md`.
|
|
85
|
+
This contract is only the compact runtime interface for skills.
|
|
@@ -0,0 +1,191 @@
|
|
|
1
|
+
AGDF Tenets
|
|
2
|
+
===========
|
|
3
|
+
|
|
4
|
+
The following are the **AGDF Tenets** — the guiding principles you *MUST*
|
|
5
|
+
internalize for all AGDF-governed work. They are organized into **Generic
|
|
6
|
+
Tenets**, which always apply, and **Operation-Specific Tenets**, which apply
|
|
7
|
+
to particular kinds of operations.
|
|
8
|
+
|
|
9
|
+
GENERIC TENETS
|
|
10
|
+
--------------
|
|
11
|
+
|
|
12
|
+
At any time and for all kinds of operations,
|
|
13
|
+
you *MUST* honor the following **GENERIC TENETS**:
|
|
14
|
+
|
|
15
|
+
- **No Implementation Without Approved Product Contract**:
|
|
16
|
+
Implementation should not be based on vague intent.
|
|
17
|
+
A stable product contract defines accepted scope, acceptance criteria,
|
|
18
|
+
non-goals, constraints and success measurement.
|
|
19
|
+
Without an approved PRD, no implementation may begin.
|
|
20
|
+
|
|
21
|
+
- **Fail Closed**:
|
|
22
|
+
When a necessary approval, input, or quality statement is missing,
|
|
23
|
+
the process must stop or demand revision.
|
|
24
|
+
The standard must never be "best effort" when the next step depends
|
|
25
|
+
on unverified assumptions.
|
|
26
|
+
|
|
27
|
+
- **One Authoritative Source for Product Intent**:
|
|
28
|
+
The product contract is the anchor for all downstream work.
|
|
29
|
+
Design, Task & Test Plan and implementation must not silently
|
|
30
|
+
reinterpret the agreed scope.
|
|
31
|
+
|
|
32
|
+
- **Design and Code Must Stay Separated**:
|
|
33
|
+
Conceptual design and implementation details should not be mixed
|
|
34
|
+
prematurely.
|
|
35
|
+
Design describes architecture, responsibilities, interfaces and flows.
|
|
36
|
+
Code describes executable behaviour, payloads, schemas, migrations
|
|
37
|
+
and implementation logic.
|
|
38
|
+
|
|
39
|
+
- **Tasks Need Business Justification**:
|
|
40
|
+
A task is not just a card on a board.
|
|
41
|
+
A task must make traceable which requirement, acceptance criterion,
|
|
42
|
+
design decision, risk or quality goal it addresses.
|
|
43
|
+
AI agents can produce convincing plans very quickly — work decomposition
|
|
44
|
+
must remain explainable and auditable.
|
|
45
|
+
|
|
46
|
+
- **Traceability Is Not Bureaucracy**:
|
|
47
|
+
Traceability does not mean producing as many documents as possible.
|
|
48
|
+
It means being able to answer fundamental delivery questions:
|
|
49
|
+
Why does this task exist? Which requirement supports this design decision?
|
|
50
|
+
Which acceptance criterion does this test check? Which approved artefact
|
|
51
|
+
permits this implementation? What changed between two versions?
|
|
52
|
+
|
|
53
|
+
- **Quality Needs Evidence**:
|
|
54
|
+
A quality claim is not sufficient.
|
|
55
|
+
The delivery should contain visible evidence: test results, build status,
|
|
56
|
+
review results, known limitations and remaining risks.
|
|
57
|
+
What was not checked must not be presented as if it were checked.
|
|
58
|
+
|
|
59
|
+
- **Changes Must Be Visible**:
|
|
60
|
+
When scope, acceptance criteria, non-goals or security, compliance or
|
|
61
|
+
data-protection aspects change, the change must be documented and reviewed.
|
|
62
|
+
Work with AI agents must not hide changes behind fluent conversation.
|
|
63
|
+
|
|
64
|
+
- **Think Before Acting**:
|
|
65
|
+
*Don't assume. Don't hide confusion. Surface trade-offs.*
|
|
66
|
+
Before implementing:
|
|
67
|
+
- State your assumptions explicitly. If uncertain, ask.
|
|
68
|
+
- If multiple interpretations exist, present them — don't pick silently.
|
|
69
|
+
- If a simpler approach exists, say so. Push back when warranted.
|
|
70
|
+
- If something is unclear, stop. Name what is confusing. Ask.
|
|
71
|
+
|
|
72
|
+
- **Surgical Changes**:
|
|
73
|
+
*Keep changes as small as possible — but as structurally sound as needed.*
|
|
74
|
+
- Touch only what you must. Clean up only your own mess.
|
|
75
|
+
- Don't "improve" adjacent code, comments, or formatting.
|
|
76
|
+
- Match existing style, even if you'd do it differently.
|
|
77
|
+
- The smallest technical diff is not automatically the best solution
|
|
78
|
+
if it creates state confusion, false ownership, or later rework.
|
|
79
|
+
|
|
80
|
+
- **Goal-Driven Execution**:
|
|
81
|
+
*Define success criteria. Loop until verified.*
|
|
82
|
+
Transform tasks into verifiable goals:
|
|
83
|
+
- "Add validation" → "Write tests for invalid inputs, then make them pass"
|
|
84
|
+
- "Fix the bug" → "Write a test that reproduces it, then make it pass"
|
|
85
|
+
- "Refactor X" → "Ensure tests pass before and after"
|
|
86
|
+
|
|
87
|
+
BROWNFIELD TENETS
|
|
88
|
+
-----------------
|
|
89
|
+
|
|
90
|
+
When working in an *existing system* (which is the normal case, not a special
|
|
91
|
+
case), you *MUST* honor the following **BROWNFIELD TENETS**:
|
|
92
|
+
|
|
93
|
+
- **Brownfield First**:
|
|
94
|
+
Before any implementation, the existing codebase must be understood.
|
|
95
|
+
What is not visibly documented does not count as existing.
|
|
96
|
+
|
|
97
|
+
- **Reuse Before Create**:
|
|
98
|
+
Existing modules, services, components, endpoints, tests and
|
|
99
|
+
configurations are preferred over new creation, provided they can be
|
|
100
|
+
cleanly extended.
|
|
101
|
+
|
|
102
|
+
- **Minimal Clean Slice**:
|
|
103
|
+
The recommended change is the smallest clean and durably sound
|
|
104
|
+
intervention that fulfils the task plan.
|
|
105
|
+
A technically small diff is not automatically good if it creates
|
|
106
|
+
state confusion, false ownership, silent parallel structures or
|
|
107
|
+
later rework.
|
|
108
|
+
|
|
109
|
+
- **No Silent Parallel Structures**:
|
|
110
|
+
New artefacts with overlapping responsibility are to be avoided.
|
|
111
|
+
A new service, endpoint, wrapper or state owner may look clean locally
|
|
112
|
+
but create drift, parallel structures and later removal work systemically.
|
|
113
|
+
|
|
114
|
+
- **Existing Architecture Is Binding**:
|
|
115
|
+
Existing architecture, naming, error handling, logging, security and
|
|
116
|
+
test conventions are binding unless an explicit deviation is justified.
|
|
117
|
+
|
|
118
|
+
- **SoT/Runtime/Product-Semantics Drift Must Be Surfaced**:
|
|
119
|
+
If documented target architecture, observable runtime behaviour and
|
|
120
|
+
intended product semantics diverge, this must be explicitly flagged as
|
|
121
|
+
drift — not silently treated as a refactor.
|
|
122
|
+
In such cases, a UR or equivalent product-direction decision is needed
|
|
123
|
+
before implementation.
|
|
124
|
+
|
|
125
|
+
- **Primary Visible Ownership Must Be Checked**:
|
|
126
|
+
For visible chat, render, scroll, recovery or status problems,
|
|
127
|
+
check which existing path holds primary visible ownership.
|
|
128
|
+
Do not recommend a second render, scroll or recovery owner if the
|
|
129
|
+
existing system already has a suitable primary path.
|
|
130
|
+
|
|
131
|
+
QUALITY CONTRACT TENETS
|
|
132
|
+
-----------------------
|
|
133
|
+
|
|
134
|
+
When *producing or reviewing* quality-contract outputs for agent runs,
|
|
135
|
+
you *MUST* honor the following **QUALITY CONTRACT TENETS**:
|
|
136
|
+
|
|
137
|
+
- **Rule Before Outcome**:
|
|
138
|
+
A quality contract describes which rule applies and which evidence
|
|
139
|
+
proves it — not just whether the result looks plausible.
|
|
140
|
+
|
|
141
|
+
- **Agent Run, Not Just Result**:
|
|
142
|
+
Quality contracts check whether the agent worked on a sound foundation,
|
|
143
|
+
not just whether the output is functional.
|
|
144
|
+
"Wurde nach den vereinbarten Regeln gearbeitet?" is as important as
|
|
145
|
+
"Funktioniert es?"
|
|
146
|
+
|
|
147
|
+
- **No Evidence Replacement**:
|
|
148
|
+
Missing evidence may never be replaced by plausibility, assumptions
|
|
149
|
+
or fluent summaries.
|
|
150
|
+
A green build does not prove task completion.
|
|
151
|
+
Partial implementation must remain visible as partial.
|
|
152
|
+
|
|
153
|
+
- **Effect Must Be Visible**:
|
|
154
|
+
When a quality contract triggers, it must be visible whether the effect
|
|
155
|
+
is Stopp (block), Nacharbeit (revise) or Hinweis (warning).
|
|
156
|
+
There should be no silent ignoring.
|
|
157
|
+
|
|
158
|
+
- **Human Responsibility Remains**:
|
|
159
|
+
Quality contracts do not replace product requirements, gates, approvals
|
|
160
|
+
or human judgement.
|
|
161
|
+
They make visible what was checked, what evidence exists, and what
|
|
162
|
+
decision is still open.
|
|
163
|
+
|
|
164
|
+
DELIVERY TENETS
|
|
165
|
+
---------------
|
|
166
|
+
|
|
167
|
+
When *closing a delivery run* with an orchestrierungsreport or delivery
|
|
168
|
+
handoff, you *MUST* honor the following **DELIVERY TENETS**:
|
|
169
|
+
|
|
170
|
+
- **OR Is Always Mandatory**:
|
|
171
|
+
Every relevant run ends with an orchestrierungsreport (OR), even when
|
|
172
|
+
gates are blocking.
|
|
173
|
+
OR is an audit report, not a blocking gate.
|
|
174
|
+
|
|
175
|
+
- **No Leaks From Blocked Gates**:
|
|
176
|
+
The OR must not disclose content from artefacts that are not yet
|
|
177
|
+
allowed in the current gate.
|
|
178
|
+
|
|
179
|
+
- **Status, Not Sugarcoating**:
|
|
180
|
+
The OR is an audit and control report, not a marketing text.
|
|
181
|
+
Missing approvals, partial implementation, risks, fallbacks, brownfield
|
|
182
|
+
problems and open defects must be visible.
|
|
183
|
+
|
|
184
|
+
- **Next Step Must Be Operative**:
|
|
185
|
+
The OR ends with the immediate next permissible step and the exact
|
|
186
|
+
approval formula needed.
|
|
187
|
+
|
|
188
|
+
- **CD+Tests Is Not Completion**:
|
|
189
|
+
After CD+Tests, the OR reports only implementation and test status.
|
|
190
|
+
Without reviews, TP-coverage check and QA gate, formulations like
|
|
191
|
+
"fertig", "freigabefähig" or "delivery-ready" are not permitted.
|
|
@@ -0,0 +1,116 @@
|
|
|
1
|
+
---
|
|
2
|
+
name: agdf-brownfield-analysis
|
|
3
|
+
description: Use this skill before implementation in an existing codebase, especially for feature extensions, bug fixes, refactorings, or changes to existing modules. It analyzes existing artefacts, current coverage, reuse strategy, risks, and the minimal clean implementation path. Use it before CD+Tests.
|
|
4
|
+
---
|
|
5
|
+
|
|
6
|
+
# brownfield-analysis
|
|
7
|
+
|
|
8
|
+
## Purpose
|
|
9
|
+
Ensure implementation in an existing system is Brownfield-oriented, not Greenfield-style.
|
|
10
|
+
|
|
11
|
+
The skill answers:
|
|
12
|
+
|
|
13
|
+
- which existing artefacts matter
|
|
14
|
+
- what already exists fully or partially
|
|
15
|
+
- what can be reused, extended, or refactored
|
|
16
|
+
- whether new artefacts are really needed
|
|
17
|
+
- architecture, compatibility, migration, and regression impact
|
|
18
|
+
- the minimal clean implementation path
|
|
19
|
+
- whether Context Graph impact exists without automatically creating a node
|
|
20
|
+
|
|
21
|
+
## Runtime Contract
|
|
22
|
+
Use `../../meta/agdf-runtime-contract.md` for Quality Contract output, Context Graph fields, gate terms, and non-duplication rules.
|
|
23
|
+
|
|
24
|
+
Brownfield-specific output must make evidence, missing existing-system view, parallel-structure risk, reuse strategy, and the minimal next step visible.
|
|
25
|
+
|
|
26
|
+
## Rules
|
|
27
|
+
1. Brownfield first: understand the existing codebase before implementation.
|
|
28
|
+
2. Reuse-before-create: prefer existing modules, services, components, tables, endpoints, tests, and configuration.
|
|
29
|
+
3. Minimal clean slice: choose the smallest durable intervention, not merely the smallest technical diff.
|
|
30
|
+
4. No silent parallel structures.
|
|
31
|
+
5. Existing architecture, naming, error handling, logging, security, and test conventions are binding unless deviation is justified.
|
|
32
|
+
6. What is not visibly evidenced does not count as existing.
|
|
33
|
+
7. Async execute paths must not become a second product-policy decision point.
|
|
34
|
+
8. Visible state ownership must be checked for chat, rendering, scrolling, recovery, and status problems.
|
|
35
|
+
9. SoT/runtime/product-semantics drift must be named; if official behaviour must be decided first, recommend UR or equivalent product direction.
|
|
36
|
+
10. Large UI surfaces and state hooks must be checked for mixed render, view-model, derived state, orchestration, persistence, and recovery ownership.
|
|
37
|
+
11. Context Graph impact must be curated; it is not a review log or version index.
|
|
38
|
+
12. Specification archive migrations must follow the archive index if present.
|
|
39
|
+
|
|
40
|
+
## When To Use
|
|
41
|
+
- before `CD+Tests`
|
|
42
|
+
- before changes to an existing repository
|
|
43
|
+
- bug fixes in existing modules
|
|
44
|
+
- feature extensions in existing architecture
|
|
45
|
+
- refactorings
|
|
46
|
+
- unclear existing coverage
|
|
47
|
+
- risk of new parallel structures
|
|
48
|
+
- a TP is clear but its connection to the existing system is not
|
|
49
|
+
|
|
50
|
+
## Inputs
|
|
51
|
+
Use what is available:
|
|
52
|
+
|
|
53
|
+
- Task Plan, `task_id`, `story_id`
|
|
54
|
+
- project structure
|
|
55
|
+
- affected files, modules, services, APIs, data models
|
|
56
|
+
- existing tests
|
|
57
|
+
- architecture notes from PRD or SD
|
|
58
|
+
- repository conventions
|
|
59
|
+
|
|
60
|
+
If inputs are missing, work only from observable evidence and mark gaps explicitly.
|
|
61
|
+
|
|
62
|
+
## Workflow
|
|
63
|
+
1. Identify affected tasks and scope.
|
|
64
|
+
2. Find relevant existing artefacts.
|
|
65
|
+
3. Assess current coverage before new implementation:
|
|
66
|
+
- `fully_done`
|
|
67
|
+
- `partially_done`
|
|
68
|
+
- `not_done`
|
|
69
|
+
4. Choose reuse strategy:
|
|
70
|
+
- `extend`
|
|
71
|
+
- `refactor`
|
|
72
|
+
- `replace`
|
|
73
|
+
- `new`
|
|
74
|
+
5. Assess change impact:
|
|
75
|
+
- files/modules
|
|
76
|
+
- interfaces
|
|
77
|
+
- data model/migrations
|
|
78
|
+
- backwards compatibility
|
|
79
|
+
- regression tests
|
|
80
|
+
- side effects
|
|
81
|
+
6. Check parallel-structure risk.
|
|
82
|
+
7. Check SoT/runtime/product-semantics drift.
|
|
83
|
+
8. Check primary visible ownership for UI/status/recovery paths.
|
|
84
|
+
9. Check UI monolith risk for large surfaces or central hooks.
|
|
85
|
+
10. Check Context Graph impact according to `../../meta/agdf-runtime-contract.md`.
|
|
86
|
+
11. Recommend the minimal clean implementation path.
|
|
87
|
+
|
|
88
|
+
## Output
|
|
89
|
+
Use a concise structure:
|
|
90
|
+
|
|
91
|
+
```text
|
|
92
|
+
## Brownfield Analysis
|
|
93
|
+
- decision: pass | revise | block | not_applicable
|
|
94
|
+
- scope:
|
|
95
|
+
- evidence:
|
|
96
|
+
- missing_evidence:
|
|
97
|
+
- current_coverage:
|
|
98
|
+
- reuse_strategy:
|
|
99
|
+
- risks:
|
|
100
|
+
- context_graph_impact:
|
|
101
|
+
- required_next_step:
|
|
102
|
+
```
|
|
103
|
+
|
|
104
|
+
## Pass / Revise / Block Guidance
|
|
105
|
+
- `pass`: existing owners are understood, reuse path is clear, and no blocking drift or parallel structure risk remains.
|
|
106
|
+
- `revise`: relevant evidence, tests, ownership, or reuse path is incomplete.
|
|
107
|
+
- `block`: implementation would create a second SoT, second owner, unresolved product semantics, or hard unmitigated risk.
|
|
108
|
+
|
|
109
|
+
## Forbidden
|
|
110
|
+
This skill must not:
|
|
111
|
+
|
|
112
|
+
- propose a Greenfield replacement without evidence
|
|
113
|
+
- silently accept overlapping ownership
|
|
114
|
+
- convert product-semantics drift into a mere refactor
|
|
115
|
+
- create Context Graph nodes automatically
|
|
116
|
+
- treat archive links as active current specification signals
|
|
@@ -0,0 +1,23 @@
|
|
|
1
|
+
## NAME
|
|
2
|
+
|
|
3
|
+
`agdf-brownfield-analysis` - brownfield analysis
|
|
4
|
+
|
|
5
|
+
## SYNOPSIS
|
|
6
|
+
|
|
7
|
+
`/agdf-brownfield-analysis` [`--help`|`-h`]
|
|
8
|
+
|
|
9
|
+
## DESCRIPTION
|
|
10
|
+
|
|
11
|
+
Ensures implementation in an existing system is Brownfield-oriented rather than Greenfield-style. Analyzes existing artefacts, current coverage, reuse strategy, risks, and the minimal clean implementation path.
|
|
12
|
+
|
|
13
|
+
## EXAMPLES
|
|
14
|
+
|
|
15
|
+
Trigger the skill:
|
|
16
|
+
|
|
17
|
+
```text
|
|
18
|
+
> /agdf-brownfield-analysis
|
|
19
|
+
```
|
|
20
|
+
|
|
21
|
+
## SEE ALSO
|
|
22
|
+
|
|
23
|
+
See the full SKILL.md for detailed workflow, output format, and decision logic.
|
|
@@ -0,0 +1,100 @@
|
|
|
1
|
+
---
|
|
2
|
+
name: agdf-clean-implementation-review
|
|
3
|
+
description: Use this skill to determine whether an implementation is a clean primary solution or whether fallbacks, workarounds, guards, defaults, shims, or parallel structures have made it unnecessarily complex. Use it after code changes, before QA, or whenever symptom treatment is suspected.
|
|
4
|
+
---
|
|
5
|
+
|
|
6
|
+
# clean-implementation-review
|
|
7
|
+
|
|
8
|
+
## Purpose
|
|
9
|
+
Evaluate implementation integrity.
|
|
10
|
+
|
|
11
|
+
This skill answers:
|
|
12
|
+
|
|
13
|
+
- was the task solved with a clean primary solution
|
|
14
|
+
- was the root cause fixed or only masked
|
|
15
|
+
- were unnecessary fallbacks, workarounds, guards, defaults, or shims introduced
|
|
16
|
+
- were unnecessary parallel structures introduced
|
|
17
|
+
- does the solution fit the existing architecture
|
|
18
|
+
- is it maintainable or workaround-heavy
|
|
19
|
+
|
|
20
|
+
## Runtime Contract
|
|
21
|
+
Use `../../meta/agdf-runtime-contract.md` for Quality Contract output, Context Graph fields, gate terms, and non-duplication rules.
|
|
22
|
+
|
|
23
|
+
Clean-review-specific output must make the primary solution, fallbacks, workarounds, parallel structures, exit criteria, and next cleanup/review step visible.
|
|
24
|
+
|
|
25
|
+
## Rules
|
|
26
|
+
1. Clean primary solution before fallback.
|
|
27
|
+
2. Root cause before symptom masking.
|
|
28
|
+
3. Fallbacks are exceptions, not target architecture.
|
|
29
|
+
4. Every retained fallback needs rationale, target state, and exit condition.
|
|
30
|
+
5. No silent parallel structures.
|
|
31
|
+
6. Brownfield fit is mandatory.
|
|
32
|
+
7. Maintainability matters; "works somehow" is not enough.
|
|
33
|
+
8. Async execute paths must not decide product rules again.
|
|
34
|
+
9. Shared finalization or merge rules belong in one owner.
|
|
35
|
+
|
|
36
|
+
## When To Use
|
|
37
|
+
- after `CD+Tests`
|
|
38
|
+
- before QA
|
|
39
|
+
- when a solution contains many guards, defaults, or special paths
|
|
40
|
+
- when wrappers or helper layers were introduced
|
|
41
|
+
- when symptom treatment is suspected
|
|
42
|
+
- when fallback, retry, or compatibility-shim logic was added
|
|
43
|
+
- when code works but the architecture looks questionable
|
|
44
|
+
|
|
45
|
+
## Inputs
|
|
46
|
+
Use what is available:
|
|
47
|
+
|
|
48
|
+
- Task Plan
|
|
49
|
+
- Code Deliverables
|
|
50
|
+
- changed files
|
|
51
|
+
- tests and test results
|
|
52
|
+
- `agdf-code-review` or Code Review Report
|
|
53
|
+
- QA Report
|
|
54
|
+
- Brownfield Analysis findings
|
|
55
|
+
- PRD or SD architecture notes
|
|
56
|
+
|
|
57
|
+
If evidence is missing, mark it explicitly.
|
|
58
|
+
|
|
59
|
+
## Workflow
|
|
60
|
+
1. Understand the intended change.
|
|
61
|
+
2. Identify the primary implementation path.
|
|
62
|
+
3. Identify fallbacks, guards, defaults, shims, retries, wrappers, and catch-all branches.
|
|
63
|
+
4. Decide whether each is justified.
|
|
64
|
+
5. Check for parallel ownership.
|
|
65
|
+
6. Check Brownfield fit.
|
|
66
|
+
7. Assess whether the implementation fixes the root cause.
|
|
67
|
+
8. Assign a decision:
|
|
68
|
+
- `pass`
|
|
69
|
+
- `revise`
|
|
70
|
+
- `block`
|
|
71
|
+
- `not_applicable`
|
|
72
|
+
|
|
73
|
+
## Output
|
|
74
|
+
Use this compact structure:
|
|
75
|
+
|
|
76
|
+
```text
|
|
77
|
+
## Clean Implementation Review
|
|
78
|
+
- decision:
|
|
79
|
+
- primary_solution:
|
|
80
|
+
- evidence:
|
|
81
|
+
- fallbacks_retained:
|
|
82
|
+
- workaround_or_shim_risk:
|
|
83
|
+
- parallel_structure_risk:
|
|
84
|
+
- brownfield_fit:
|
|
85
|
+
- missing_evidence:
|
|
86
|
+
- required_next_step:
|
|
87
|
+
```
|
|
88
|
+
|
|
89
|
+
## Pass / Revise / Block Guidance
|
|
90
|
+
- `pass`: primary solution is clean, tested, and integrated with existing owners.
|
|
91
|
+
- `revise`: solution works but contains avoidable fallback, unclear ownership, or missing evidence.
|
|
92
|
+
- `block`: solution creates a second SoT, a second owner, unbounded fallback, or masks unresolved product semantics.
|
|
93
|
+
|
|
94
|
+
## Forbidden
|
|
95
|
+
This skill must not:
|
|
96
|
+
|
|
97
|
+
- accept fallback-heavy logic as target architecture
|
|
98
|
+
- hide unjustified workarounds
|
|
99
|
+
- treat green tests as proof of solution integrity
|
|
100
|
+
- decide final QA
|
|
@@ -0,0 +1,23 @@
|
|
|
1
|
+
## NAME
|
|
2
|
+
|
|
3
|
+
`agdf-clean-implementation-review` - clean implementation review
|
|
4
|
+
|
|
5
|
+
## SYNOPSIS
|
|
6
|
+
|
|
7
|
+
`/agdf-clean-implementation-review` [`--help`|`-h`]
|
|
8
|
+
|
|
9
|
+
## DESCRIPTION
|
|
10
|
+
|
|
11
|
+
Evaluates solution integrity: whether the implementation is a clean primary solution or has become unnecessarily complex through fallbacks, workarounds, guards, defaults, shims, or parallel structures.
|
|
12
|
+
|
|
13
|
+
## EXAMPLES
|
|
14
|
+
|
|
15
|
+
Trigger the skill:
|
|
16
|
+
|
|
17
|
+
```text
|
|
18
|
+
> /agdf-clean-implementation-review
|
|
19
|
+
```
|
|
20
|
+
|
|
21
|
+
## SEE ALSO
|
|
22
|
+
|
|
23
|
+
See the full SKILL.md for detailed workflow, output format, and decision logic.
|
|
@@ -0,0 +1,94 @@
|
|
|
1
|
+
---
|
|
2
|
+
name: agdf-code-review
|
|
3
|
+
description: Use this skill after code changes and before QA to produce the mandatory Code Review Report for correctness, regression, security, and maintainability findings in the actual diff. It standardizes the CR step without replacing TP review, clean review, or QA.
|
|
4
|
+
---
|
|
5
|
+
|
|
6
|
+
# code-review
|
|
7
|
+
|
|
8
|
+
## Purpose
|
|
9
|
+
Produce the mandatory Code Review Report (CR) for a relevant run.
|
|
10
|
+
|
|
11
|
+
It answers:
|
|
12
|
+
|
|
13
|
+
- whether the changed code shows functional defects, security issues, regression risks, or maintainability problems that matter
|
|
14
|
+
- whether findings are blocking, revisable, or advisory
|
|
15
|
+
- which concrete evidence in files, diffs, tests, or runtime observations supports each finding
|
|
16
|
+
- which issues must be fixed before QA
|
|
17
|
+
- whether Brownfield, TP, or clean-review follow-up remains open
|
|
18
|
+
|
|
19
|
+
## Runtime Contract
|
|
20
|
+
Use `../../meta/agdf-runtime-contract.md` for Quality Contract output, Context Graph fields, gate terms, and non-duplication rules.
|
|
21
|
+
|
|
22
|
+
Code-review-specific output must make actual findings, missing review scope, evidence strength, and the next required step visible.
|
|
23
|
+
|
|
24
|
+
## Rules
|
|
25
|
+
1. Review the actual diff and impacted code, not intent alone.
|
|
26
|
+
2. Findings require concrete evidence.
|
|
27
|
+
3. Prioritize correctness, safety, data integrity, compatibility, and maintainability over style.
|
|
28
|
+
4. Do not generate style-only noise.
|
|
29
|
+
5. Missing review scope or evidence must stay visible.
|
|
30
|
+
6. Brownfield owners and existing conventions are binding unless deviation is justified.
|
|
31
|
+
7. Distinguish blocking defects from fixable review findings.
|
|
32
|
+
8. CR does not grant QA pass.
|
|
33
|
+
|
|
34
|
+
## When To Use
|
|
35
|
+
- after `CD+Tests`
|
|
36
|
+
- before `QA`
|
|
37
|
+
- when code changes exist
|
|
38
|
+
- when multiple agents or contributors touched the same area
|
|
39
|
+
- when a commit-near change needs explicit review evidence
|
|
40
|
+
|
|
41
|
+
## Inputs
|
|
42
|
+
Use what is available:
|
|
43
|
+
|
|
44
|
+
- changed files and diff
|
|
45
|
+
- affected neighbouring code
|
|
46
|
+
- test/build results
|
|
47
|
+
- Brownfield Analysis
|
|
48
|
+
- Task Plan and TP Review
|
|
49
|
+
- Clean Implementation Review
|
|
50
|
+
- runtime or UI evidence
|
|
51
|
+
- known risks or follow-up decisions
|
|
52
|
+
|
|
53
|
+
If no code changes are present, do not invent a CR result.
|
|
54
|
+
|
|
55
|
+
## Workflow
|
|
56
|
+
1. Inspect the changed files and directly impacted neighbours.
|
|
57
|
+
2. Check correctness, edge cases, and error paths.
|
|
58
|
+
3. Check security, data handling, and state ownership risks.
|
|
59
|
+
4. Check regression and compatibility risks.
|
|
60
|
+
5. Check maintainability only where it creates real defect or change-risk exposure.
|
|
61
|
+
6. Classify the overall result:
|
|
62
|
+
- `pass`
|
|
63
|
+
- `revise`
|
|
64
|
+
- `block`
|
|
65
|
+
- `not_applicable`
|
|
66
|
+
7. Set exactly one required next step.
|
|
67
|
+
|
|
68
|
+
## Output
|
|
69
|
+
Use this compact structure:
|
|
70
|
+
|
|
71
|
+
```text
|
|
72
|
+
## Code Review
|
|
73
|
+
- decision: pass | revise | block | not_applicable
|
|
74
|
+
- findings:
|
|
75
|
+
- [severity] file/path - issue - evidence
|
|
76
|
+
- missing_evidence:
|
|
77
|
+
- risks:
|
|
78
|
+
- required_next_step:
|
|
79
|
+
```
|
|
80
|
+
|
|
81
|
+
## Decision Guidance
|
|
82
|
+
- `pass`: no meaningful review finding remains evident in reviewed scope.
|
|
83
|
+
- `revise`: fixable correctness, regression, or maintainability issues remain.
|
|
84
|
+
- `block`: a hard defect, security risk, data-integrity risk, or unresolved critical uncertainty remains.
|
|
85
|
+
- `not_applicable`: no code changes were present for review.
|
|
86
|
+
|
|
87
|
+
## Forbidden
|
|
88
|
+
This skill must not:
|
|
89
|
+
|
|
90
|
+
- decide final QA
|
|
91
|
+
- accept a green build as sufficient review evidence
|
|
92
|
+
- hide missing review scope
|
|
93
|
+
- generate style-only findings
|
|
94
|
+
- duplicate TP Review or QA as if they were the same step
|
|
@@ -0,0 +1,23 @@
|
|
|
1
|
+
## NAME
|
|
2
|
+
|
|
3
|
+
`agdf-code-review` - code review
|
|
4
|
+
|
|
5
|
+
## SYNOPSIS
|
|
6
|
+
|
|
7
|
+
`/agdf-code-review` [`--help`|`-h`]
|
|
8
|
+
|
|
9
|
+
## DESCRIPTION
|
|
10
|
+
|
|
11
|
+
Produces the mandatory Code Review Report for changed code and focuses on correctness, regression, security, and other materially relevant findings before QA.
|
|
12
|
+
|
|
13
|
+
## EXAMPLES
|
|
14
|
+
|
|
15
|
+
Trigger the skill:
|
|
16
|
+
|
|
17
|
+
```text
|
|
18
|
+
> /agdf-code-review
|
|
19
|
+
```
|
|
20
|
+
|
|
21
|
+
## SEE ALSO
|
|
22
|
+
|
|
23
|
+
See the full SKILL.md for workflow, output format, and review boundaries.
|