create-agdf 0.1.0 → 0.1.2
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/README.md +19 -5
- package/bin/create-agdf.js +37 -18
- package/generated/.github/skills/README.md +18 -0
- package/generated/.github/skills/agdf-brownfield-analysis/SKILL.md +116 -0
- package/generated/.github/skills/agdf-clean-implementation-review/SKILL.md +100 -0
- package/generated/.github/skills/agdf-code-review/SKILL.md +94 -0
- package/generated/.github/skills/agdf-delivery-closeout/SKILL.md +109 -0
- package/generated/.github/skills/agdf-gate-check/SKILL.md +92 -0
- package/generated/.github/skills/agdf-qa-gate/SKILL.md +110 -0
- package/generated/.github/skills/agdf-release-or/SKILL.md +124 -0
- package/generated/.github/skills/agdf-runtime-contract.md +73 -0
- package/generated/.github/skills/agdf-task-plan-review/SKILL.md +115 -0
- package/{templates → generated}/AGENTS.md +2 -1
- package/package.json +5 -3
- package/templates/.github/copilot-instructions.md +0 -31
package/README.md
CHANGED
|
@@ -6,7 +6,6 @@ Bootstrap AGDF for one repository.
|
|
|
6
6
|
|
|
7
7
|
```bash
|
|
8
8
|
npm create agdf@latest copilot
|
|
9
|
-
npm create agdf@latest claude
|
|
10
9
|
npm create agdf@latest both
|
|
11
10
|
```
|
|
12
11
|
|
|
@@ -15,11 +14,26 @@ Optional flags:
|
|
|
15
14
|
- `--dir <path>` write into a specific directory
|
|
16
15
|
- `--force` overwrite existing generated files
|
|
17
16
|
|
|
18
|
-
## Targets
|
|
17
|
+
## Targets and existing AGENTS.md
|
|
19
18
|
|
|
20
|
-
- `copilot` writes `AGENTS.md` and `.github/
|
|
21
|
-
- `
|
|
22
|
-
|
|
19
|
+
- `copilot` writes `AGENTS.md` and visible repository skills under `.github/skills/`
|
|
20
|
+
- `both` writes the same Copilot-facing files and reminds you to install the Claude plugin separately
|
|
21
|
+
|
|
22
|
+
If the target repository already has an `AGENTS.md`, `create-agdf` preserves it and writes `AGENTS.agdf.md` instead of replacing your existing instructions. Merge the AGDF fragment into your current `AGENTS.md` when you want Copilot to load both instruction sets. Use `--force` only when you explicitly want to overwrite generated files.
|
|
23
|
+
|
|
24
|
+
## Single source of truth
|
|
25
|
+
|
|
26
|
+
The repository-facing AGDF sources are maintained in:
|
|
27
|
+
|
|
28
|
+
- `AGENTS.md`
|
|
29
|
+
- `plugin/skills/`
|
|
30
|
+
- `plugin/meta/agdf-runtime-contract.md`
|
|
31
|
+
|
|
32
|
+
The published package assets are generated from these repository sources only at pack/publish time. The package does not keep a second manually maintained template tree.
|
|
33
|
+
|
|
34
|
+
```bash
|
|
35
|
+
npm run sync-package-assets
|
|
36
|
+
```
|
|
23
37
|
|
|
24
38
|
## Publishing
|
|
25
39
|
|
package/bin/create-agdf.js
CHANGED
|
@@ -7,16 +7,28 @@ import process from "node:process";
|
|
|
7
7
|
|
|
8
8
|
const __dirname = dirname(fileURLToPath(import.meta.url));
|
|
9
9
|
const packageRoot = resolve(__dirname, "..");
|
|
10
|
-
const
|
|
10
|
+
const generatedRoot = join(packageRoot, "generated");
|
|
11
11
|
const pluginInstallCommand = "claude plugin add arndtgold/ai-native-governance-delivery-framework";
|
|
12
|
-
const allowedTargets = new Set(["copilot", "
|
|
12
|
+
const allowedTargets = new Set(["copilot", "both"]);
|
|
13
|
+
const agdfFragmentPath = "AGENTS.agdf.md";
|
|
14
|
+
const copilotSkillFiles = [
|
|
15
|
+
join(".github", "skills", "README.md"),
|
|
16
|
+
join(".github", "skills", "agdf-runtime-contract.md"),
|
|
17
|
+
join(".github", "skills", "agdf-gate-check", "SKILL.md"),
|
|
18
|
+
join(".github", "skills", "agdf-brownfield-analysis", "SKILL.md"),
|
|
19
|
+
join(".github", "skills", "agdf-task-plan-review", "SKILL.md"),
|
|
20
|
+
join(".github", "skills", "agdf-clean-implementation-review", "SKILL.md"),
|
|
21
|
+
join(".github", "skills", "agdf-code-review", "SKILL.md"),
|
|
22
|
+
join(".github", "skills", "agdf-qa-gate", "SKILL.md"),
|
|
23
|
+
join(".github", "skills", "agdf-release-or", "SKILL.md"),
|
|
24
|
+
join(".github", "skills", "agdf-delivery-closeout", "SKILL.md"),
|
|
25
|
+
];
|
|
13
26
|
|
|
14
27
|
function printUsage() {
|
|
15
28
|
console.log(`create-agdf
|
|
16
29
|
|
|
17
30
|
Usage:
|
|
18
31
|
npm create agdf@latest copilot
|
|
19
|
-
npm create agdf@latest claude
|
|
20
32
|
npm create agdf@latest both
|
|
21
33
|
|
|
22
34
|
Options:
|
|
@@ -78,7 +90,7 @@ function parseArgs(argv) {
|
|
|
78
90
|
}
|
|
79
91
|
|
|
80
92
|
if (!target || !allowedTargets.has(target)) {
|
|
81
|
-
console.error("Please choose one target: copilot
|
|
93
|
+
console.error("Please choose one target: copilot or both.");
|
|
82
94
|
printUsage();
|
|
83
95
|
process.exit(1);
|
|
84
96
|
}
|
|
@@ -90,8 +102,8 @@ function parseArgs(argv) {
|
|
|
90
102
|
};
|
|
91
103
|
}
|
|
92
104
|
|
|
93
|
-
function
|
|
94
|
-
return readFileSync(join(
|
|
105
|
+
function loadAsset(relativePath) {
|
|
106
|
+
return readFileSync(join(generatedRoot, relativePath), "utf8");
|
|
95
107
|
}
|
|
96
108
|
|
|
97
109
|
function writeGeneratedFile(targetDir, relativePath, content, force) {
|
|
@@ -105,25 +117,28 @@ function writeGeneratedFile(targetDir, relativePath, content, force) {
|
|
|
105
117
|
writeFileSync(outputPath, content, "utf8");
|
|
106
118
|
}
|
|
107
119
|
|
|
108
|
-
function generatedFilesForTarget(target) {
|
|
120
|
+
function generatedFilesForTarget(target, targetDir, force) {
|
|
121
|
+
const agentsTargetPath = existsSync(join(targetDir, "AGENTS.md")) && !force ? agdfFragmentPath : "AGENTS.md";
|
|
109
122
|
const files = [
|
|
110
123
|
{
|
|
111
|
-
path:
|
|
112
|
-
content:
|
|
124
|
+
path: agentsTargetPath,
|
|
125
|
+
content: loadAsset("AGENTS.md"),
|
|
113
126
|
},
|
|
114
127
|
];
|
|
115
128
|
|
|
116
129
|
if (target === "copilot" || target === "both") {
|
|
117
|
-
|
|
118
|
-
|
|
119
|
-
|
|
120
|
-
|
|
130
|
+
for (const skillPath of copilotSkillFiles) {
|
|
131
|
+
files.push({
|
|
132
|
+
path: skillPath,
|
|
133
|
+
content: loadAsset(skillPath),
|
|
134
|
+
});
|
|
135
|
+
}
|
|
121
136
|
}
|
|
122
137
|
|
|
123
138
|
return files;
|
|
124
139
|
}
|
|
125
140
|
|
|
126
|
-
function printNextSteps(target, destination, files) {
|
|
141
|
+
function printNextSteps(target, destination, files, wroteAgentsFragment) {
|
|
127
142
|
console.log("");
|
|
128
143
|
console.log(`AGDF bootstrap complete in ${destination}`);
|
|
129
144
|
console.log("");
|
|
@@ -134,18 +149,22 @@ function printNextSteps(target, destination, files) {
|
|
|
134
149
|
|
|
135
150
|
console.log("");
|
|
136
151
|
console.log("Next steps:");
|
|
137
|
-
if (
|
|
152
|
+
if (wroteAgentsFragment) {
|
|
153
|
+
console.log(`- Existing AGENTS.md detected. Merge ${agdfFragmentPath} into your current AGENTS.md before using Copilot with AGDF.`);
|
|
154
|
+
}
|
|
155
|
+
if (target === "both") {
|
|
138
156
|
console.log(`- Install the Claude Code plugin: ${pluginInstallCommand}`);
|
|
139
157
|
}
|
|
140
158
|
if (target === "copilot" || target === "both") {
|
|
141
|
-
console.log("- In GitHub Copilot CLI, run /instructions to confirm that the repository
|
|
159
|
+
console.log("- In GitHub Copilot CLI, run /instructions after the AGENTS.md step is complete to confirm that AGDF instructions and the repository skills are visible.");
|
|
142
160
|
}
|
|
143
161
|
console.log("- Commit the generated files so the repository becomes the source of truth.");
|
|
144
162
|
}
|
|
145
163
|
|
|
146
164
|
function main() {
|
|
147
165
|
const options = parseArgs(process.argv.slice(2));
|
|
148
|
-
const files = generatedFilesForTarget(options.target);
|
|
166
|
+
const files = generatedFilesForTarget(options.target, options.dir, options.force);
|
|
167
|
+
const wroteAgentsFragment = files.some(file => file.path === agdfFragmentPath);
|
|
149
168
|
|
|
150
169
|
try {
|
|
151
170
|
for (const file of files) {
|
|
@@ -156,7 +175,7 @@ function main() {
|
|
|
156
175
|
process.exit(1);
|
|
157
176
|
}
|
|
158
177
|
|
|
159
|
-
printNextSteps(options.target, options.dir, files);
|
|
178
|
+
printNextSteps(options.target, options.dir, files, wroteAgentsFragment);
|
|
160
179
|
}
|
|
161
180
|
|
|
162
181
|
main();
|
|
@@ -0,0 +1,18 @@
|
|
|
1
|
+
# AGDF repository skills
|
|
2
|
+
|
|
3
|
+
These repository skills were generated from the AGDF source repository and are intended to be checked into this repository.
|
|
4
|
+
|
|
5
|
+
## Skills
|
|
6
|
+
|
|
7
|
+
- `agdf-brownfield-analysis`
|
|
8
|
+
- `agdf-clean-implementation-review`
|
|
9
|
+
- `agdf-code-review`
|
|
10
|
+
- `agdf-delivery-closeout`
|
|
11
|
+
- `agdf-gate-check`
|
|
12
|
+
- `agdf-qa-gate`
|
|
13
|
+
- `agdf-release-or`
|
|
14
|
+
- `agdf-task-plan-review`
|
|
15
|
+
|
|
16
|
+
## Runtime contract
|
|
17
|
+
|
|
18
|
+
Shared output and gate rules for this checkout live in `agdf-runtime-contract.md`.
|
|
@@ -0,0 +1,116 @@
|
|
|
1
|
+
---
|
|
2
|
+
name: agdf-brownfield-analysis
|
|
3
|
+
description: Use this skill before implementation in an existing codebase, especially for feature extensions, bug fixes, refactorings, or changes to existing modules. It analyzes existing artefacts, current coverage, reuse strategy, risks, and the minimal clean implementation path. Use it before CD+Tests.
|
|
4
|
+
---
|
|
5
|
+
|
|
6
|
+
# brownfield-analysis
|
|
7
|
+
|
|
8
|
+
## Purpose
|
|
9
|
+
Ensure implementation in an existing system is Brownfield-oriented, not Greenfield-style.
|
|
10
|
+
|
|
11
|
+
The skill answers:
|
|
12
|
+
|
|
13
|
+
- which existing artefacts matter
|
|
14
|
+
- what already exists fully or partially
|
|
15
|
+
- what can be reused, extended, or refactored
|
|
16
|
+
- whether new artefacts are really needed
|
|
17
|
+
- architecture, compatibility, migration, and regression impact
|
|
18
|
+
- the minimal clean implementation path
|
|
19
|
+
- whether Context Graph impact exists without automatically creating a node
|
|
20
|
+
|
|
21
|
+
## Runtime Contract
|
|
22
|
+
Use `../agdf-runtime-contract.md` for Quality Contract output, Context Graph fields, gate terms, and non-duplication rules.
|
|
23
|
+
|
|
24
|
+
Brownfield-specific output must make evidence, missing existing-system view, parallel-structure risk, reuse strategy, and the minimal next step visible.
|
|
25
|
+
|
|
26
|
+
## Rules
|
|
27
|
+
1. Brownfield first: understand the existing codebase before implementation.
|
|
28
|
+
2. Reuse-before-create: prefer existing modules, services, components, tables, endpoints, tests, and configuration.
|
|
29
|
+
3. Minimal clean slice: choose the smallest durable intervention, not merely the smallest technical diff.
|
|
30
|
+
4. No silent parallel structures.
|
|
31
|
+
5. Existing architecture, naming, error handling, logging, security, and test conventions are binding unless deviation is justified.
|
|
32
|
+
6. What is not visibly evidenced does not count as existing.
|
|
33
|
+
7. Async execute paths must not become a second product-policy decision point.
|
|
34
|
+
8. Visible state ownership must be checked for chat, rendering, scrolling, recovery, and status problems.
|
|
35
|
+
9. SoT/runtime/product-semantics drift must be named; if official behaviour must be decided first, recommend UR or equivalent product direction.
|
|
36
|
+
10. Large UI surfaces and state hooks must be checked for mixed render, view-model, derived state, orchestration, persistence, and recovery ownership.
|
|
37
|
+
11. Context Graph impact must be curated; it is not a review log or version index.
|
|
38
|
+
12. Specification archive migrations must follow the archive index if present.
|
|
39
|
+
|
|
40
|
+
## When To Use
|
|
41
|
+
- before `CD+Tests`
|
|
42
|
+
- before changes to an existing repository
|
|
43
|
+
- bug fixes in existing modules
|
|
44
|
+
- feature extensions in existing architecture
|
|
45
|
+
- refactorings
|
|
46
|
+
- unclear existing coverage
|
|
47
|
+
- risk of new parallel structures
|
|
48
|
+
- a TP is clear but its connection to the existing system is not
|
|
49
|
+
|
|
50
|
+
## Inputs
|
|
51
|
+
Use what is available:
|
|
52
|
+
|
|
53
|
+
- Task Plan, `task_id`, `story_id`
|
|
54
|
+
- project structure
|
|
55
|
+
- affected files, modules, services, APIs, data models
|
|
56
|
+
- existing tests
|
|
57
|
+
- architecture notes from PRD or SD
|
|
58
|
+
- repository conventions
|
|
59
|
+
|
|
60
|
+
If inputs are missing, work only from observable evidence and mark gaps explicitly.
|
|
61
|
+
|
|
62
|
+
## Workflow
|
|
63
|
+
1. Identify affected tasks and scope.
|
|
64
|
+
2. Find relevant existing artefacts.
|
|
65
|
+
3. Assess current coverage before new implementation:
|
|
66
|
+
- `fully_done`
|
|
67
|
+
- `partially_done`
|
|
68
|
+
- `not_done`
|
|
69
|
+
4. Choose reuse strategy:
|
|
70
|
+
- `extend`
|
|
71
|
+
- `refactor`
|
|
72
|
+
- `replace`
|
|
73
|
+
- `new`
|
|
74
|
+
5. Assess change impact:
|
|
75
|
+
- files/modules
|
|
76
|
+
- interfaces
|
|
77
|
+
- data model/migrations
|
|
78
|
+
- backwards compatibility
|
|
79
|
+
- regression tests
|
|
80
|
+
- side effects
|
|
81
|
+
6. Check parallel-structure risk.
|
|
82
|
+
7. Check SoT/runtime/product-semantics drift.
|
|
83
|
+
8. Check primary visible ownership for UI/status/recovery paths.
|
|
84
|
+
9. Check UI monolith risk for large surfaces or central hooks.
|
|
85
|
+
10. Check Context Graph impact according to `../agdf-runtime-contract.md`.
|
|
86
|
+
11. Recommend the minimal clean implementation path.
|
|
87
|
+
|
|
88
|
+
## Output
|
|
89
|
+
Use a concise structure:
|
|
90
|
+
|
|
91
|
+
```text
|
|
92
|
+
## Brownfield Analysis
|
|
93
|
+
- decision: pass | revise | block | not_applicable
|
|
94
|
+
- scope:
|
|
95
|
+
- evidence:
|
|
96
|
+
- missing_evidence:
|
|
97
|
+
- current_coverage:
|
|
98
|
+
- reuse_strategy:
|
|
99
|
+
- risks:
|
|
100
|
+
- context_graph_impact:
|
|
101
|
+
- required_next_step:
|
|
102
|
+
```
|
|
103
|
+
|
|
104
|
+
## Pass / Revise / Block Guidance
|
|
105
|
+
- `pass`: existing owners are understood, reuse path is clear, and no blocking drift or parallel structure risk remains.
|
|
106
|
+
- `revise`: relevant evidence, tests, ownership, or reuse path is incomplete.
|
|
107
|
+
- `block`: implementation would create a second SoT, second owner, unresolved product semantics, or hard unmitigated risk.
|
|
108
|
+
|
|
109
|
+
## Forbidden
|
|
110
|
+
This skill must not:
|
|
111
|
+
|
|
112
|
+
- propose a Greenfield replacement without evidence
|
|
113
|
+
- silently accept overlapping ownership
|
|
114
|
+
- convert product-semantics drift into a mere refactor
|
|
115
|
+
- create Context Graph nodes automatically
|
|
116
|
+
- treat archive links as active current specification signals
|
|
@@ -0,0 +1,100 @@
|
|
|
1
|
+
---
|
|
2
|
+
name: agdf-clean-implementation-review
|
|
3
|
+
description: Use this skill to determine whether an implementation is a clean primary solution or whether fallbacks, workarounds, guards, defaults, shims, or parallel structures have made it unnecessarily complex. Use it after code changes, before QA, or whenever symptom treatment is suspected.
|
|
4
|
+
---
|
|
5
|
+
|
|
6
|
+
# clean-implementation-review
|
|
7
|
+
|
|
8
|
+
## Purpose
|
|
9
|
+
Evaluate implementation integrity.
|
|
10
|
+
|
|
11
|
+
This skill answers:
|
|
12
|
+
|
|
13
|
+
- was the task solved with a clean primary solution
|
|
14
|
+
- was the root cause fixed or only masked
|
|
15
|
+
- were unnecessary fallbacks, workarounds, guards, defaults, or shims introduced
|
|
16
|
+
- were unnecessary parallel structures introduced
|
|
17
|
+
- does the solution fit the existing architecture
|
|
18
|
+
- is it maintainable or workaround-heavy
|
|
19
|
+
|
|
20
|
+
## Runtime Contract
|
|
21
|
+
Use `../agdf-runtime-contract.md` for Quality Contract output, Context Graph fields, gate terms, and non-duplication rules.
|
|
22
|
+
|
|
23
|
+
Clean-review-specific output must make the primary solution, fallbacks, workarounds, parallel structures, exit criteria, and next cleanup/review step visible.
|
|
24
|
+
|
|
25
|
+
## Rules
|
|
26
|
+
1. Clean primary solution before fallback.
|
|
27
|
+
2. Root cause before symptom masking.
|
|
28
|
+
3. Fallbacks are exceptions, not target architecture.
|
|
29
|
+
4. Every retained fallback needs rationale, target state, and exit condition.
|
|
30
|
+
5. No silent parallel structures.
|
|
31
|
+
6. Brownfield fit is mandatory.
|
|
32
|
+
7. Maintainability matters; "works somehow" is not enough.
|
|
33
|
+
8. Async execute paths must not decide product rules again.
|
|
34
|
+
9. Shared finalization or merge rules belong in one owner.
|
|
35
|
+
|
|
36
|
+
## When To Use
|
|
37
|
+
- after `CD+Tests`
|
|
38
|
+
- before QA
|
|
39
|
+
- when a solution contains many guards, defaults, or special paths
|
|
40
|
+
- when wrappers or helper layers were introduced
|
|
41
|
+
- when symptom treatment is suspected
|
|
42
|
+
- when fallback, retry, or compatibility-shim logic was added
|
|
43
|
+
- when code works but the architecture looks questionable
|
|
44
|
+
|
|
45
|
+
## Inputs
|
|
46
|
+
Use what is available:
|
|
47
|
+
|
|
48
|
+
- Task Plan
|
|
49
|
+
- Code Deliverables
|
|
50
|
+
- changed files
|
|
51
|
+
- tests and test results
|
|
52
|
+
- `agdf-code-review` or Code Review Report
|
|
53
|
+
- QA Report
|
|
54
|
+
- Brownfield Analysis findings
|
|
55
|
+
- PRD or SD architecture notes
|
|
56
|
+
|
|
57
|
+
If evidence is missing, mark it explicitly.
|
|
58
|
+
|
|
59
|
+
## Workflow
|
|
60
|
+
1. Understand the intended change.
|
|
61
|
+
2. Identify the primary implementation path.
|
|
62
|
+
3. Identify fallbacks, guards, defaults, shims, retries, wrappers, and catch-all branches.
|
|
63
|
+
4. Decide whether each is justified.
|
|
64
|
+
5. Check for parallel ownership.
|
|
65
|
+
6. Check Brownfield fit.
|
|
66
|
+
7. Assess whether the implementation fixes the root cause.
|
|
67
|
+
8. Assign a decision:
|
|
68
|
+
- `pass`
|
|
69
|
+
- `revise`
|
|
70
|
+
- `block`
|
|
71
|
+
- `not_applicable`
|
|
72
|
+
|
|
73
|
+
## Output
|
|
74
|
+
Use this compact structure:
|
|
75
|
+
|
|
76
|
+
```text
|
|
77
|
+
## Clean Implementation Review
|
|
78
|
+
- decision:
|
|
79
|
+
- primary_solution:
|
|
80
|
+
- evidence:
|
|
81
|
+
- fallbacks_retained:
|
|
82
|
+
- workaround_or_shim_risk:
|
|
83
|
+
- parallel_structure_risk:
|
|
84
|
+
- brownfield_fit:
|
|
85
|
+
- missing_evidence:
|
|
86
|
+
- required_next_step:
|
|
87
|
+
```
|
|
88
|
+
|
|
89
|
+
## Pass / Revise / Block Guidance
|
|
90
|
+
- `pass`: primary solution is clean, tested, and integrated with existing owners.
|
|
91
|
+
- `revise`: solution works but contains avoidable fallback, unclear ownership, or missing evidence.
|
|
92
|
+
- `block`: solution creates a second SoT, a second owner, unbounded fallback, or masks unresolved product semantics.
|
|
93
|
+
|
|
94
|
+
## Forbidden
|
|
95
|
+
This skill must not:
|
|
96
|
+
|
|
97
|
+
- accept fallback-heavy logic as target architecture
|
|
98
|
+
- hide unjustified workarounds
|
|
99
|
+
- treat green tests as proof of solution integrity
|
|
100
|
+
- decide final QA
|
|
@@ -0,0 +1,94 @@
|
|
|
1
|
+
---
|
|
2
|
+
name: agdf-code-review
|
|
3
|
+
description: Use this skill after code changes and before QA to produce the mandatory Code Review Report for correctness, regression, security, and maintainability findings in the actual diff. It standardizes the CR step without replacing TP review, clean review, or QA.
|
|
4
|
+
---
|
|
5
|
+
|
|
6
|
+
# code-review
|
|
7
|
+
|
|
8
|
+
## Purpose
|
|
9
|
+
Produce the mandatory Code Review Report (CR) for a relevant run.
|
|
10
|
+
|
|
11
|
+
It answers:
|
|
12
|
+
|
|
13
|
+
- whether the changed code shows functional defects, security issues, regression risks, or maintainability problems that matter
|
|
14
|
+
- whether findings are blocking, revisable, or advisory
|
|
15
|
+
- which concrete evidence in files, diffs, tests, or runtime observations supports each finding
|
|
16
|
+
- which issues must be fixed before QA
|
|
17
|
+
- whether Brownfield, TP, or clean-review follow-up remains open
|
|
18
|
+
|
|
19
|
+
## Runtime Contract
|
|
20
|
+
Use `../agdf-runtime-contract.md` for Quality Contract output, Context Graph fields, gate terms, and non-duplication rules.
|
|
21
|
+
|
|
22
|
+
Code-review-specific output must make actual findings, missing review scope, evidence strength, and the next required step visible.
|
|
23
|
+
|
|
24
|
+
## Rules
|
|
25
|
+
1. Review the actual diff and impacted code, not intent alone.
|
|
26
|
+
2. Findings require concrete evidence.
|
|
27
|
+
3. Prioritize correctness, safety, data integrity, compatibility, and maintainability over style.
|
|
28
|
+
4. Do not generate style-only noise.
|
|
29
|
+
5. Missing review scope or evidence must stay visible.
|
|
30
|
+
6. Brownfield owners and existing conventions are binding unless deviation is justified.
|
|
31
|
+
7. Distinguish blocking defects from fixable review findings.
|
|
32
|
+
8. CR does not grant QA pass.
|
|
33
|
+
|
|
34
|
+
## When To Use
|
|
35
|
+
- after `CD+Tests`
|
|
36
|
+
- before `QA`
|
|
37
|
+
- when code changes exist
|
|
38
|
+
- when multiple agents or contributors touched the same area
|
|
39
|
+
- when a commit-near change needs explicit review evidence
|
|
40
|
+
|
|
41
|
+
## Inputs
|
|
42
|
+
Use what is available:
|
|
43
|
+
|
|
44
|
+
- changed files and diff
|
|
45
|
+
- affected neighbouring code
|
|
46
|
+
- test/build results
|
|
47
|
+
- Brownfield Analysis
|
|
48
|
+
- Task Plan and TP Review
|
|
49
|
+
- Clean Implementation Review
|
|
50
|
+
- runtime or UI evidence
|
|
51
|
+
- known risks or follow-up decisions
|
|
52
|
+
|
|
53
|
+
If no code changes are present, do not invent a CR result.
|
|
54
|
+
|
|
55
|
+
## Workflow
|
|
56
|
+
1. Inspect the changed files and directly impacted neighbours.
|
|
57
|
+
2. Check correctness, edge cases, and error paths.
|
|
58
|
+
3. Check security, data handling, and state ownership risks.
|
|
59
|
+
4. Check regression and compatibility risks.
|
|
60
|
+
5. Check maintainability only where it creates real defect or change-risk exposure.
|
|
61
|
+
6. Classify the overall result:
|
|
62
|
+
- `pass`
|
|
63
|
+
- `revise`
|
|
64
|
+
- `block`
|
|
65
|
+
- `not_applicable`
|
|
66
|
+
7. Set exactly one required next step.
|
|
67
|
+
|
|
68
|
+
## Output
|
|
69
|
+
Use this compact structure:
|
|
70
|
+
|
|
71
|
+
```text
|
|
72
|
+
## Code Review
|
|
73
|
+
- decision: pass | revise | block | not_applicable
|
|
74
|
+
- findings:
|
|
75
|
+
- [severity] file/path - issue - evidence
|
|
76
|
+
- missing_evidence:
|
|
77
|
+
- risks:
|
|
78
|
+
- required_next_step:
|
|
79
|
+
```
|
|
80
|
+
|
|
81
|
+
## Decision Guidance
|
|
82
|
+
- `pass`: no meaningful review finding remains evident in reviewed scope.
|
|
83
|
+
- `revise`: fixable correctness, regression, or maintainability issues remain.
|
|
84
|
+
- `block`: a hard defect, security risk, data-integrity risk, or unresolved critical uncertainty remains.
|
|
85
|
+
- `not_applicable`: no code changes were present for review.
|
|
86
|
+
|
|
87
|
+
## Forbidden
|
|
88
|
+
This skill must not:
|
|
89
|
+
|
|
90
|
+
- decide final QA
|
|
91
|
+
- accept a green build as sufficient review evidence
|
|
92
|
+
- hide missing review scope
|
|
93
|
+
- generate style-only findings
|
|
94
|
+
- duplicate TP Review or QA as if they were the same step
|
|
@@ -0,0 +1,109 @@
|
|
|
1
|
+
---
|
|
2
|
+
name: agdf-delivery-closeout
|
|
3
|
+
description: Use this skill for the final delivery handoff after QA, OR, or UAT when a run should move toward commit, push, or PR. It standardizes commit-ready summaries, UAT-gated commit offers, and the next delivery step without replacing QA or OR decisions.
|
|
4
|
+
---
|
|
5
|
+
|
|
6
|
+
# delivery-closeout
|
|
7
|
+
|
|
8
|
+
## Purpose
|
|
9
|
+
Standardize the operational delivery closeout.
|
|
10
|
+
|
|
11
|
+
It answers:
|
|
12
|
+
|
|
13
|
+
- what operational delivery status applies after QA, OR, or UAT
|
|
14
|
+
- whether a commit-ready Git summary should be provided
|
|
15
|
+
- whether a commit should be actively offered after `Approval: UAT`
|
|
16
|
+
- which next delivery step makes sense: commit, push, PR, rollout, or none
|
|
17
|
+
- whether evidence-based technical follow-up remains useful
|
|
18
|
+
- whether Context Graph follow-up from OR/QA remains open
|
|
19
|
+
|
|
20
|
+
This skill does not replace `agdf-qa-gate`, `agdf-release-or`, user approvals, or gate decisions.
|
|
21
|
+
|
|
22
|
+
## Runtime Contract
|
|
23
|
+
Use `../agdf-runtime-contract.md` for closeout discipline, gate terms, Context Graph fields, and non-duplication rules.
|
|
24
|
+
|
|
25
|
+
## Rules
|
|
26
|
+
1. Delivery follows gate clarity.
|
|
27
|
+
2. Never perform commit, push, or PR automatically.
|
|
28
|
+
3. Use one handoff format:
|
|
29
|
+
- `Commit title`
|
|
30
|
+
- `Commit body`
|
|
31
|
+
- optional `Migration/Rollout note`
|
|
32
|
+
4. `Approval: UAT` unlocks an active commit offer when code changes exist.
|
|
33
|
+
5. No commit handoff for runs without code changes.
|
|
34
|
+
6. Always include exactly one next step and one quality outlook.
|
|
35
|
+
|
|
36
|
+
## When To Use
|
|
37
|
+
- after `QA pass` with code changes
|
|
38
|
+
- after OR when delivery handoff should be clean
|
|
39
|
+
- after `Approval: UAT`
|
|
40
|
+
- when the user asks for commit, push, or PR handoff
|
|
41
|
+
|
|
42
|
+
Do not use as a substitute for `agdf-qa-gate`, `agdf-release-or`, or `agdf-gate-check`.
|
|
43
|
+
|
|
44
|
+
## Inputs
|
|
45
|
+
Use what is available:
|
|
46
|
+
|
|
47
|
+
- QA Report
|
|
48
|
+
- OR
|
|
49
|
+
- current gate status
|
|
50
|
+
- whether code changes exist
|
|
51
|
+
- existing commit-ready summary
|
|
52
|
+
- rollout or migration notes
|
|
53
|
+
- open technical risks or documentation gaps
|
|
54
|
+
- Context Graph impact from OR/QA/review
|
|
55
|
+
|
|
56
|
+
If code-change status is unclear, do not claim a commit handoff.
|
|
57
|
+
|
|
58
|
+
## Workflow
|
|
59
|
+
1. Classify the closeout:
|
|
60
|
+
- `qa_pass_with_code`
|
|
61
|
+
- `qa_pass_without_code`
|
|
62
|
+
- `uat_approved_with_code`
|
|
63
|
+
- `uat_approved_without_code`
|
|
64
|
+
- `non_delivery_closeout`
|
|
65
|
+
2. Derive Git handoff only when code changes exist.
|
|
66
|
+
3. Set exactly one next delivery step:
|
|
67
|
+
- offer commit
|
|
68
|
+
- offer push
|
|
69
|
+
- offer PR
|
|
70
|
+
- no further delivery step
|
|
71
|
+
- run QA/review
|
|
72
|
+
- obtain UAT/approval
|
|
73
|
+
- perform documentation follow-up
|
|
74
|
+
4. Set quality outlook:
|
|
75
|
+
- no further technical follow-up
|
|
76
|
+
- more tests
|
|
77
|
+
- refactoring
|
|
78
|
+
- documentation sharpening
|
|
79
|
+
- monitoring/runtime verification
|
|
80
|
+
5. If `Approval: UAT` exists and code changes were delivered, actively offer the commit but do not run it.
|
|
81
|
+
|
|
82
|
+
## Output
|
|
83
|
+
For code-changing runs:
|
|
84
|
+
|
|
85
|
+
```text
|
|
86
|
+
Delivery status:
|
|
87
|
+
Next step:
|
|
88
|
+
Quality outlook:
|
|
89
|
+
Commit title:
|
|
90
|
+
Commit body:
|
|
91
|
+
Migration/Rollout note:
|
|
92
|
+
```
|
|
93
|
+
|
|
94
|
+
For non-code runs:
|
|
95
|
+
|
|
96
|
+
```text
|
|
97
|
+
Delivery status:
|
|
98
|
+
Next step:
|
|
99
|
+
Quality outlook:
|
|
100
|
+
```
|
|
101
|
+
|
|
102
|
+
## Forbidden
|
|
103
|
+
This skill must not:
|
|
104
|
+
|
|
105
|
+
- decide QA pass
|
|
106
|
+
- replace OR
|
|
107
|
+
- execute commit, push, or PR
|
|
108
|
+
- invent a commit handoff for non-code runs
|
|
109
|
+
- imply new gate approvals
|
|
@@ -0,0 +1,92 @@
|
|
|
1
|
+
---
|
|
2
|
+
name: agdf-gate-check
|
|
3
|
+
description: Use this skill when the active gate is unclear, when a later-gate artefact is requested, when an exact approval may be missing, or when the next permissible step must be determined. Use it before creating formal artefacts in Structured Delivery and whenever implicit consent might be mistaken for approval.
|
|
4
|
+
---
|
|
5
|
+
|
|
6
|
+
# gate-check
|
|
7
|
+
|
|
8
|
+
## Purpose
|
|
9
|
+
Determine the earliest blocking user approval gate and derive:
|
|
10
|
+
|
|
11
|
+
- the active or blocking gate
|
|
12
|
+
- whether the process is open or blocked
|
|
13
|
+
- currently allowed outputs
|
|
14
|
+
- currently forbidden outputs
|
|
15
|
+
- the exact missing approval
|
|
16
|
+
- the next permissible step
|
|
17
|
+
|
|
18
|
+
This skill must not create later artefacts such as PRD, SD, TP, CD, CR, QA, or UAT when the gate does not allow them.
|
|
19
|
+
|
|
20
|
+
## Runtime Contract
|
|
21
|
+
Use `../agdf-runtime-contract.md` for gate terms, closeout discipline, and non-duplication rules.
|
|
22
|
+
|
|
23
|
+
## Rules
|
|
24
|
+
1. Fail closed when a required approval or artefact status is missing.
|
|
25
|
+
2. The earliest blocking gate wins.
|
|
26
|
+
3. A user approval is valid only as `Approval: <GateName>`.
|
|
27
|
+
4. Treat `Freigabe: <GateName>` as a legacy alias only when reviewing older German runs.
|
|
28
|
+
5. Implicit consent is not approval.
|
|
29
|
+
6. Do not preview later artefacts while a gate blocks.
|
|
30
|
+
7. Internal process steps are not user approval gates.
|
|
31
|
+
8. OR-lite is allowed if it does not leak blocked content.
|
|
32
|
+
9. SoT/runtime/product-semantics drift can trigger an early product gate, usually `UR`.
|
|
33
|
+
|
|
34
|
+
## Gate Order
|
|
35
|
+
User gates:
|
|
36
|
+
|
|
37
|
+
`UR -> PRD -> SD -> TP -> QA -> UAT`
|
|
38
|
+
|
|
39
|
+
Internal mandatory steps:
|
|
40
|
+
|
|
41
|
+
`Brownfield Analysis -> CD+Tests -> CR -> OR`
|
|
42
|
+
|
|
43
|
+
## When To Use
|
|
44
|
+
- Structured Delivery before first artefact creation
|
|
45
|
+
- unclear current gate
|
|
46
|
+
- user says "continue" or similar without exact approval
|
|
47
|
+
- code or a later-gate artefact is requested
|
|
48
|
+
- implementation permission is unclear
|
|
49
|
+
- QA, UAT, or release permission is unclear
|
|
50
|
+
|
|
51
|
+
Not required for simple Quick Tasks without new product scope and without formal artefacts.
|
|
52
|
+
|
|
53
|
+
## Inputs
|
|
54
|
+
Use what is available:
|
|
55
|
+
|
|
56
|
+
- current user request
|
|
57
|
+
- existing exact approvals
|
|
58
|
+
- status of UR, PRD, SD, TP
|
|
59
|
+
- Brownfield Analysis status
|
|
60
|
+
- CD+Tests, CR, QA, UAT status
|
|
61
|
+
- signs of documentation/runtime/product-semantics drift
|
|
62
|
+
|
|
63
|
+
If a status is not explicit, do not assume it is satisfied.
|
|
64
|
+
|
|
65
|
+
## Workflow
|
|
66
|
+
1. Check exact approvals.
|
|
67
|
+
2. Check artefact status.
|
|
68
|
+
3. Determine the earliest blocking user gate or internal mandatory step.
|
|
69
|
+
4. Derive allowed and forbidden outputs.
|
|
70
|
+
5. Name the exact missing approval, if any.
|
|
71
|
+
6. If consent was only implicit, say it is not yet approval and provide the exact formula.
|
|
72
|
+
|
|
73
|
+
## Output
|
|
74
|
+
Keep the result short and operational:
|
|
75
|
+
|
|
76
|
+
- **Current gate:** `<GateName or internal step>`
|
|
77
|
+
- **Status:** `open | blocked`
|
|
78
|
+
- **Allowed:** `<allowed outputs>`
|
|
79
|
+
- **Forbidden:** `<forbidden outputs>`
|
|
80
|
+
- **Missing approval:** `Approval: <GateName> | none`
|
|
81
|
+
- **Next step:** `<single permissible next step>`
|
|
82
|
+
|
|
83
|
+
## Forbidden
|
|
84
|
+
This skill must not:
|
|
85
|
+
|
|
86
|
+
- create PRD before UR approval
|
|
87
|
+
- create SD before PRD approval
|
|
88
|
+
- create TP while earlier gates block
|
|
89
|
+
- perform full Brownfield Analysis unless explicitly requested
|
|
90
|
+
- provide implementation snippets while implementation is gated
|
|
91
|
+
- present QA or UAT as passed without evidence
|
|
92
|
+
- present release as allowed without QA pass and UAT approval where required
|
|
@@ -0,0 +1,110 @@
|
|
|
1
|
+
---
|
|
2
|
+
name: agdf-qa-gate
|
|
3
|
+
description: Use this skill before any QA decision to determine whether implementation can be classified as pass, revise, or block based on TP coverage, Brownfield fit, solution integrity, evidence, and open blockers. Use it after CD+Tests, after reviews, and before UAT or release decisions.
|
|
4
|
+
---
|
|
5
|
+
|
|
6
|
+
# qa-gate
|
|
7
|
+
|
|
8
|
+
## Purpose
|
|
9
|
+
Make the formal QA gate decision.
|
|
10
|
+
|
|
11
|
+
This skill is the only final QA decision point for `pass | revise | block`.
|
|
12
|
+
|
|
13
|
+
It answers:
|
|
14
|
+
|
|
15
|
+
- whether `QA pass` is allowed
|
|
16
|
+
- whether the implementation must be revised
|
|
17
|
+
- whether a hard blocker remains
|
|
18
|
+
- whether relevant TP tasks are sufficiently verified
|
|
19
|
+
- whether P0/P1 tasks are complete
|
|
20
|
+
- whether Brownfield fit is sufficient
|
|
21
|
+
- whether solution integrity is sufficient
|
|
22
|
+
- whether blockers, critical risks, or missing evidence remain
|
|
23
|
+
|
|
24
|
+
## Runtime Contract
|
|
25
|
+
Use `../agdf-runtime-contract.md` for Quality Contract output, Context Graph fields, gate terms, and non-duplication rules.
|
|
26
|
+
|
|
27
|
+
QA-specific `decision` is exactly `pass | revise | block`.
|
|
28
|
+
`pass` is allowed only when TP coverage, Brownfield fit, solution integrity, and relevant documentation/Context Graph impact are sufficiently evidenced.
|
|
29
|
+
`sot_drift` must not pass silently as a warning.
|
|
30
|
+
|
|
31
|
+
## Rules
|
|
32
|
+
1. No QA pass without strong evidence.
|
|
33
|
+
2. TP is the reference, not merely working code.
|
|
34
|
+
3. P0/P1 gaps block `pass`.
|
|
35
|
+
4. Brownfield fit is mandatory.
|
|
36
|
+
5. UI surface integrity is mandatory for UI-impacting changes.
|
|
37
|
+
6. Solution integrity is mandatory.
|
|
38
|
+
7. Always output exactly one decision: `pass`, `revise`, or `block`.
|
|
39
|
+
8. Open risks, missing tests, partial TP coverage, or side effects must be visible.
|
|
40
|
+
|
|
41
|
+
## When To Use
|
|
42
|
+
- after `CD+Tests`
|
|
43
|
+
- after `agdf-code-review`
|
|
44
|
+
- after `agdf-task-plan-review`
|
|
45
|
+
- after `agdf-clean-implementation-review`
|
|
46
|
+
- before UAT
|
|
47
|
+
- before any claim that implementation is done, releasable, or QA-ready
|
|
48
|
+
- when evidence from Brownfield, TP, or clean-review skills exists
|
|
49
|
+
|
|
50
|
+
Important:
|
|
51
|
+
|
|
52
|
+
- `CD+Tests` is implementation and test status only.
|
|
53
|
+
- Without review evidence and TP coverage, `QA pass` is not allowed.
|
|
54
|
+
|
|
55
|
+
## Inputs
|
|
56
|
+
Use what is available:
|
|
57
|
+
|
|
58
|
+
- approved TP and TP Review
|
|
59
|
+
- Brownfield Analysis
|
|
60
|
+
- Clean Implementation Review
|
|
61
|
+
- `agdf-code-review` or Code Review Report
|
|
62
|
+
- test/build results
|
|
63
|
+
- documentation impact review
|
|
64
|
+
- runtime or UI evidence
|
|
65
|
+
- known blockers and risks
|
|
66
|
+
|
|
67
|
+
If evidence is missing, lower the decision accordingly.
|
|
68
|
+
|
|
69
|
+
## Workflow
|
|
70
|
+
1. Confirm the relevant gate context.
|
|
71
|
+
2. Verify TP coverage.
|
|
72
|
+
3. Verify P0/P1 completion.
|
|
73
|
+
4. Verify Brownfield fit.
|
|
74
|
+
5. Verify solution integrity.
|
|
75
|
+
6. Verify tests and evidence strength.
|
|
76
|
+
7. Verify documentation and Context Graph impact if relevant.
|
|
77
|
+
8. Decide:
|
|
78
|
+
- `pass`
|
|
79
|
+
- `revise`
|
|
80
|
+
- `block`
|
|
81
|
+
9. State the single required next step.
|
|
82
|
+
|
|
83
|
+
## Output
|
|
84
|
+
Use this shape:
|
|
85
|
+
|
|
86
|
+
```text
|
|
87
|
+
## QA Gate
|
|
88
|
+
- decision: pass | revise | block
|
|
89
|
+
- evidence:
|
|
90
|
+
- missing_evidence:
|
|
91
|
+
- risks:
|
|
92
|
+
- required_next_step:
|
|
93
|
+
- impact_codes:
|
|
94
|
+
```
|
|
95
|
+
|
|
96
|
+
If Context Graph impact is relevant, include the fields from `../agdf-runtime-contract.md`.
|
|
97
|
+
|
|
98
|
+
## Decision Guidance
|
|
99
|
+
- `pass`: required TP tasks are done, evidence is strong, no blocking Brownfield or solution-integrity risk remains.
|
|
100
|
+
- `revise`: implementation is plausible but missing evidence, partial tasks, UX gaps, or fixable integrity issues remain.
|
|
101
|
+
- `block`: hard prerequisite, approval, product semantics, security/compliance, SoT drift, or critical behaviour is unresolved.
|
|
102
|
+
|
|
103
|
+
## Forbidden
|
|
104
|
+
This skill must not:
|
|
105
|
+
|
|
106
|
+
- grant QA pass from a green build alone
|
|
107
|
+
- hide partial task completion
|
|
108
|
+
- replace UAT
|
|
109
|
+
- treat missing reviews as completed
|
|
110
|
+
- downgrade SoT drift to harmless warning
|
|
@@ -0,0 +1,124 @@
|
|
|
1
|
+
---
|
|
2
|
+
name: agdf-release-or
|
|
3
|
+
description: Use this skill at the end of every relevant run to produce a compact, auditable Orchestration Report. It summarizes gate status, delivered and intentionally not delivered work, TP coverage, Brownfield fit, solution integrity, open risks, and the next permissible step.
|
|
4
|
+
---
|
|
5
|
+
|
|
6
|
+
# release-or
|
|
7
|
+
|
|
8
|
+
## Purpose
|
|
9
|
+
Produce the Orchestration Report (OR) as the mandatory closeout for a relevant run.
|
|
10
|
+
|
|
11
|
+
It reports:
|
|
12
|
+
|
|
13
|
+
- current user gate
|
|
14
|
+
- whether the run is `pass`, `revise`, `block`, or not yet QA-decided
|
|
15
|
+
- what was delivered
|
|
16
|
+
- what was intentionally not delivered
|
|
17
|
+
- missing approvals
|
|
18
|
+
- TP coverage status
|
|
19
|
+
- Brownfield fit
|
|
20
|
+
- solution integrity
|
|
21
|
+
- documentation impact
|
|
22
|
+
- Context Graph impact
|
|
23
|
+
- open risks, blockers, retained fallbacks, and exit criteria
|
|
24
|
+
- next permissible step
|
|
25
|
+
- whether further quality follow-up is useful
|
|
26
|
+
|
|
27
|
+
## Runtime Contract
|
|
28
|
+
Use `../agdf-runtime-contract.md` for Quality Contract output, Context Graph fields, gate terms, and non-duplication rules.
|
|
29
|
+
|
|
30
|
+
OR-specific output must make gate status, delivered and intentionally not delivered content, missing approvals, missing evidence, risks, retained fallbacks, and the next permissible step visible.
|
|
31
|
+
|
|
32
|
+
## Rules
|
|
33
|
+
1. OR is always allowed and mandatory for relevant runs.
|
|
34
|
+
2. OR is an audit report, not a blocking gate.
|
|
35
|
+
3. Do not leak artefacts from blocked later gates.
|
|
36
|
+
4. Use OR-lite when early gates block.
|
|
37
|
+
5. Use OR-full only within the allowed scope.
|
|
38
|
+
6. Report status, not marketing language.
|
|
39
|
+
7. Name missing approvals, partial implementation, risks, fallbacks, Brownfield issues, and open defects.
|
|
40
|
+
8. Retained fallbacks require visible exit criteria and cleanup path.
|
|
41
|
+
9. End with the immediately permissible next step.
|
|
42
|
+
10. `CD+Tests` is not completion.
|
|
43
|
+
|
|
44
|
+
## When To Use
|
|
45
|
+
- at the end of every relevant run
|
|
46
|
+
- after artefact creation
|
|
47
|
+
- when a gate blocks
|
|
48
|
+
- after `CD+Tests`
|
|
49
|
+
- after `agdf-code-review`
|
|
50
|
+
- after QA
|
|
51
|
+
- after UAT
|
|
52
|
+
- whenever a compact audit closeout is needed
|
|
53
|
+
|
|
54
|
+
## Inputs
|
|
55
|
+
Use what is available:
|
|
56
|
+
|
|
57
|
+
- current gate
|
|
58
|
+
- existing approvals
|
|
59
|
+
- artefacts created in this run
|
|
60
|
+
- intentionally not delivered content
|
|
61
|
+
- Task Plan
|
|
62
|
+
- `agdf-task-plan-review`
|
|
63
|
+
- `agdf-brownfield-analysis`
|
|
64
|
+
- `agdf-clean-implementation-review`
|
|
65
|
+
- `agdf-code-review`
|
|
66
|
+
- QA Report
|
|
67
|
+
- UAT Report
|
|
68
|
+
- documentation impact review
|
|
69
|
+
- Context Graph impact
|
|
70
|
+
- known risks, defects, fallbacks, and open questions
|
|
71
|
+
- test/build status and relevant metrics
|
|
72
|
+
|
|
73
|
+
If information is missing, state the gap instead of guessing.
|
|
74
|
+
|
|
75
|
+
## Workflow
|
|
76
|
+
1. Determine the current gate and earliest blocker.
|
|
77
|
+
2. Determine report depth:
|
|
78
|
+
- `OR-lite`: gate status, allowed/forbidden outputs, missing approval, next step
|
|
79
|
+
- `OR-full`: also delivered artefacts, TP coverage, Brownfield fit, solution integrity, risks, fallbacks, QA/UAT status
|
|
80
|
+
3. Record delivered vs intentionally not delivered content.
|
|
81
|
+
4. Summarize TP coverage if a TP exists.
|
|
82
|
+
5. Summarize Brownfield fit and solution integrity if reviewed.
|
|
83
|
+
6. Summarize tests and verification.
|
|
84
|
+
7. Summarize documentation and Context Graph impact if relevant.
|
|
85
|
+
8. Name retained fallbacks and exit criteria.
|
|
86
|
+
9. Set exactly one next permissible step.
|
|
87
|
+
10. Set exactly one quality outlook.
|
|
88
|
+
11. Add a commit-ready handoff only when code changes exist and the delivery state allows it.
|
|
89
|
+
|
|
90
|
+
## Output
|
|
91
|
+
Use a compact structure:
|
|
92
|
+
|
|
93
|
+
```text
|
|
94
|
+
## OR
|
|
95
|
+
- gate:
|
|
96
|
+
- status:
|
|
97
|
+
- delivered:
|
|
98
|
+
- intentionally_not_delivered:
|
|
99
|
+
- evidence:
|
|
100
|
+
- missing_evidence:
|
|
101
|
+
- risks:
|
|
102
|
+
- retained_fallbacks:
|
|
103
|
+
- required_next_step:
|
|
104
|
+
- quality_outlook:
|
|
105
|
+
```
|
|
106
|
+
|
|
107
|
+
When Context Graph impact is relevant, include the fields from `../agdf-runtime-contract.md`.
|
|
108
|
+
|
|
109
|
+
For code-changing closeouts that are commit-near, append:
|
|
110
|
+
|
|
111
|
+
```text
|
|
112
|
+
Commit title:
|
|
113
|
+
Commit body:
|
|
114
|
+
Migration/Rollout note:
|
|
115
|
+
```
|
|
116
|
+
|
|
117
|
+
## Forbidden
|
|
118
|
+
This skill must not:
|
|
119
|
+
|
|
120
|
+
- decide QA in place of `agdf-qa-gate`
|
|
121
|
+
- call `CD+Tests` complete, QA-ready, or release-ready
|
|
122
|
+
- hide missing approvals
|
|
123
|
+
- provide later-gate content while an earlier gate blocks
|
|
124
|
+
- execute commit, push, or PR actions
|
|
@@ -0,0 +1,73 @@
|
|
|
1
|
+
# AGDF Runtime Contract
|
|
2
|
+
|
|
3
|
+
This contract centralizes recurring runtime rules for AGDF skills.
|
|
4
|
+
It is the operational reference for skill outputs, but it is not a second copy of the framework documentation.
|
|
5
|
+
|
|
6
|
+
## Mode Selection
|
|
7
|
+
|
|
8
|
+
| Mode | Default | Escalate When |
|
|
9
|
+
|---|---|---|
|
|
10
|
+
| Quick Task Mode | small questions, reviews, debugging, local fixes without new product semantics | a new user capability, architecture/policy/persistence impact, formal artefacts, or approvals are involved |
|
|
11
|
+
| Structured Delivery Mode | formal delivery runs, gate-relevant work, release-critical changes | always use gate discipline, internal reviews, and OR |
|
|
12
|
+
|
|
13
|
+
Quick Task Mode must not become ritual gate overhead.
|
|
14
|
+
Structured Delivery must not bypass missing approvals.
|
|
15
|
+
|
|
16
|
+
## Gate Rules
|
|
17
|
+
|
|
18
|
+
- User gates: `UR -> PRD -> SD -> TP -> QA -> UAT`
|
|
19
|
+
- Internal mandatory steps: `Brownfield Analysis -> CD+Tests -> CR -> OR`
|
|
20
|
+
- Exact approval formula: `Approval: <GateName>`
|
|
21
|
+
- Legacy alias: `Freigabe: <GateName>` may be accepted when reviewing older German runs, but all new outputs must use `Approval: <GateName>`.
|
|
22
|
+
- Implicit consent is not approval.
|
|
23
|
+
- The earliest blocking gate wins.
|
|
24
|
+
- `CD+Tests` is implementation and test status only, not a delivery signal.
|
|
25
|
+
- `agdf-code-review` standardizes the mandatory `CR` step, but does not replace QA.
|
|
26
|
+
- `agdf-qa-gate` decides final `pass | revise | block`.
|
|
27
|
+
- `agdf-release-or` reports the run, but does not replace QA.
|
|
28
|
+
|
|
29
|
+
## Quality Contract Output
|
|
30
|
+
|
|
31
|
+
Structured Delivery skills use this shape when relevant:
|
|
32
|
+
|
|
33
|
+
- `decision`: `pass | revise | block | not_applicable`
|
|
34
|
+
- `evidence`: concrete artefacts, files, tests, logs, diffs, or observations
|
|
35
|
+
- `missing_evidence`: missing proof needed for a stronger claim
|
|
36
|
+
- `risks`: remaining risks, assumptions, fallbacks, drift, or blockers
|
|
37
|
+
- `required_next_step`: exactly the next clean step
|
|
38
|
+
- `impact_codes`: affected Quality Contract codes, if the target repo has a registry
|
|
39
|
+
|
|
40
|
+
A skill may briefly remind this shape, but must not duplicate a complete code or rule matrix.
|
|
41
|
+
|
|
42
|
+
## Context Graph Output
|
|
43
|
+
|
|
44
|
+
When a run affects project memory or a Context Graph, use:
|
|
45
|
+
|
|
46
|
+
- `Situation:` short plain-language summary when the impact is non-trivial
|
|
47
|
+
- `context_graph_impact`: `none | link_only | update_existing_node | new_node_required | sot_drift`
|
|
48
|
+
- `context_graph_refs`
|
|
49
|
+
- `context_graph_required_action`: `none | link | update | create | resolve_drift`
|
|
50
|
+
- `context_graph_gate_effect`: `none | warning | revise | block`
|
|
51
|
+
- `context_graph_evidence`
|
|
52
|
+
|
|
53
|
+
Do not create a new node for a mere version, a general chat summary, or a local observation without a concrete next clean step.
|
|
54
|
+
`sot_drift` must not pass silently as a warning.
|
|
55
|
+
|
|
56
|
+
## Skill Output
|
|
57
|
+
|
|
58
|
+
Every skill output should be as short as possible and as concrete as needed.
|
|
59
|
+
It must distinguish:
|
|
60
|
+
|
|
61
|
+
- facts
|
|
62
|
+
- evidence
|
|
63
|
+
- assumptions
|
|
64
|
+
- interpretations
|
|
65
|
+
- missing evidence
|
|
66
|
+
- the next permissible step
|
|
67
|
+
|
|
68
|
+
## Do Not Duplicate
|
|
69
|
+
|
|
70
|
+
The explanatory framework lives in `docs/`.
|
|
71
|
+
The operating philosophy lives in `plugin/meta/agdf-constitution.md`.
|
|
72
|
+
The principles live in `plugin/meta/agdf-tenets.md`.
|
|
73
|
+
This contract is only the compact runtime interface for skills.
|
|
@@ -0,0 +1,115 @@
|
|
|
1
|
+
---
|
|
2
|
+
name: agdf-task-plan-review
|
|
3
|
+
description: Use this skill after code changes and before QA to verify whether the approved Task Plan was actually fulfilled. It checks each task_id against implementation, acceptance criteria, tests, visible evidence, and deviations, and provides TP coverage for QA.
|
|
4
|
+
---
|
|
5
|
+
|
|
6
|
+
# task-plan-review
|
|
7
|
+
|
|
8
|
+
## Purpose
|
|
9
|
+
Verify whether implementation actually satisfies the approved Task Plan.
|
|
10
|
+
|
|
11
|
+
For each relevant task, this skill determines:
|
|
12
|
+
|
|
13
|
+
- whether the task is fully, partially, or not completed
|
|
14
|
+
- which acceptance criteria are done, partial, missing, or not verifiable
|
|
15
|
+
- which files, tests, runtime evidence, or UI evidence support the finding
|
|
16
|
+
- evidence strength
|
|
17
|
+
- which gaps must be handed to `agdf-qa-gate`
|
|
18
|
+
|
|
19
|
+
This skill provides TP coverage. It is not the final QA decision.
|
|
20
|
+
|
|
21
|
+
## Runtime Contract
|
|
22
|
+
Use `../agdf-runtime-contract.md` for Quality Contract output, Context Graph fields, gate terms, and non-duplication rules.
|
|
23
|
+
|
|
24
|
+
TP-specific output must evaluate every relevant `task_id` with completion status, AC coverage, evidence, missing evidence, and QA-relevant gaps.
|
|
25
|
+
If `context_graph_required_action` is not `none`, the affected task is complete only if follow-up, evidence, or an intentionally open gap is visible.
|
|
26
|
+
|
|
27
|
+
## Rules
|
|
28
|
+
1. The Task Plan is the reference, not plausible code.
|
|
29
|
+
2. No assumptions without evidence.
|
|
30
|
+
3. Evaluate each relevant `task_id` individually.
|
|
31
|
+
4. `fully_done` requires strong evidence.
|
|
32
|
+
5. A green build alone does not prove TP completion.
|
|
33
|
+
6. UI/state/render/recovery tasks need visible evidence, not only code.
|
|
34
|
+
7. Partial implementation must be marked `partially_done`.
|
|
35
|
+
8. P0/P1 gaps must be handed to QA.
|
|
36
|
+
9. Out-of-scope changes must be reported.
|
|
37
|
+
10. When evidence is unclear, fail closed to at least `partially_done`.
|
|
38
|
+
|
|
39
|
+
## Clarifications
|
|
40
|
+
### TP Slice Before Target State
|
|
41
|
+
If the TP explicitly defines a preparatory, additive, or limited slice, evaluate that exact scope.
|
|
42
|
+
`fully_done` is allowed for a completed slice even if the larger target state remains open.
|
|
43
|
+
|
|
44
|
+
### Missing Priorities
|
|
45
|
+
If no priorities are defined, do not invent them. Mark the gap and treat QA relevance conservatively.
|
|
46
|
+
|
|
47
|
+
### Missing Acceptance Criteria
|
|
48
|
+
If ACs are unclear, derive only obvious expectations from title, goal, and scope. Mark AC basis as incomplete and lower evidence confidence as needed.
|
|
49
|
+
|
|
50
|
+
## When To Use
|
|
51
|
+
- after `CD+Tests`
|
|
52
|
+
- before `QA`
|
|
53
|
+
- when TP completion is unclear
|
|
54
|
+
- when the user asks for TP fulfilment
|
|
55
|
+
- when UI/state/runtime invariants are affected
|
|
56
|
+
- when several agents or work steps touched the same TP
|
|
57
|
+
|
|
58
|
+
## Inputs
|
|
59
|
+
Use what is available:
|
|
60
|
+
|
|
61
|
+
- Task Plan
|
|
62
|
+
- `task_id`, `story_id`, priorities
|
|
63
|
+
- acceptance criteria or success goals
|
|
64
|
+
- changed files
|
|
65
|
+
- tests and test results
|
|
66
|
+
- build results
|
|
67
|
+
- runtime/UI evidence
|
|
68
|
+
- known deviations and scope decisions
|
|
69
|
+
|
|
70
|
+
If TP or relevant tasks are missing, do not claim reliable TP coverage.
|
|
71
|
+
|
|
72
|
+
## Output
|
|
73
|
+
Use this compact structure:
|
|
74
|
+
|
|
75
|
+
```text
|
|
76
|
+
## TP Coverage
|
|
77
|
+
| task_id | status | evidence | missing_evidence | QA impact |
|
|
78
|
+
|---|---|---|---|---|
|
|
79
|
+
|
|
80
|
+
## Summary
|
|
81
|
+
- fully_done:
|
|
82
|
+
- partially_done:
|
|
83
|
+
- not_done:
|
|
84
|
+
- out_of_scope_changes:
|
|
85
|
+
- risks:
|
|
86
|
+
- required_next_step:
|
|
87
|
+
```
|
|
88
|
+
|
|
89
|
+
Completion status:
|
|
90
|
+
|
|
91
|
+
- `fully_done`
|
|
92
|
+
- `partially_done`
|
|
93
|
+
- `not_done`
|
|
94
|
+
|
|
95
|
+
AC status:
|
|
96
|
+
|
|
97
|
+
- `done`
|
|
98
|
+
- `partial`
|
|
99
|
+
- `missing`
|
|
100
|
+
- `not_verifiable`
|
|
101
|
+
|
|
102
|
+
Evidence confidence:
|
|
103
|
+
|
|
104
|
+
- `high`
|
|
105
|
+
- `medium`
|
|
106
|
+
- `low`
|
|
107
|
+
|
|
108
|
+
## Forbidden
|
|
109
|
+
This skill must not:
|
|
110
|
+
|
|
111
|
+
- decide final QA
|
|
112
|
+
- mark tasks fully done from code existence alone
|
|
113
|
+
- hide partial work
|
|
114
|
+
- upgrade missing evidence into confidence
|
|
115
|
+
- reinterpret the TP scope
|
|
@@ -44,6 +44,7 @@ Evidence overrides assumptions and memory. If evidence is missing, state the unc
|
|
|
44
44
|
| `agdf-brownfield-analysis` | before non-trivial implementation in existing systems | clarifies reuse, owners, risks |
|
|
45
45
|
| `agdf-task-plan-review` | after implementation and before QA, verify TP coverage | no final QA decision |
|
|
46
46
|
| `agdf-clean-implementation-review` | inspect workarounds, fallbacks, parallel structures, or symptom fixes | not a TP or QA substitute |
|
|
47
|
+
| `agdf-code-review` | mandatory CR step after code changes, focused on defects, regression, and security findings | does not replace TP review, clean review, or QA |
|
|
47
48
|
| `agdf-qa-gate` | final QA decision | only instance for `pass | revise | block` |
|
|
48
49
|
| `agdf-release-or` | auditable closeout for every relevant run | not a QA substitute |
|
|
49
50
|
| `agdf-delivery-closeout` | commit/PR-near handoff after QA/OR/UAT | never performs VCS actions automatically |
|
|
@@ -52,7 +53,7 @@ Select exactly one primary skill first. Add more only when they cover a distinct
|
|
|
52
53
|
|
|
53
54
|
## Skill Contract
|
|
54
55
|
For repeated output, gate, Quality Contract, and Context Graph rules, use:
|
|
55
|
-
`
|
|
56
|
+
the repository-local `agdf-runtime-contract.md` artifact.
|
|
56
57
|
|
|
57
58
|
Skills may include short runtime reminders, but must not carry a second complete rule or code table.
|
|
58
59
|
|
package/package.json
CHANGED
|
@@ -1,18 +1,20 @@
|
|
|
1
1
|
{
|
|
2
2
|
"name": "create-agdf",
|
|
3
|
-
"version": "0.1.
|
|
3
|
+
"version": "0.1.2",
|
|
4
4
|
"description": "Bootstrap AGDF for GitHub Copilot, Claude Code, or both.",
|
|
5
5
|
"type": "module",
|
|
6
6
|
"files": [
|
|
7
7
|
"bin",
|
|
8
|
-
"
|
|
8
|
+
"generated",
|
|
9
9
|
"README.md"
|
|
10
10
|
],
|
|
11
11
|
"bin": {
|
|
12
12
|
"create-agdf": "./bin/create-agdf.js"
|
|
13
13
|
},
|
|
14
14
|
"scripts": {
|
|
15
|
-
"
|
|
15
|
+
"sync-package-assets": "node ./scripts/sync-package-assets.js",
|
|
16
|
+
"smoke-test": "npm run sync-package-assets && node ./scripts/smoke-test.js",
|
|
17
|
+
"prepack": "npm run sync-package-assets"
|
|
16
18
|
},
|
|
17
19
|
"keywords": [
|
|
18
20
|
"agdf",
|
|
@@ -1,31 +0,0 @@
|
|
|
1
|
-
# AGDF for GitHub Copilot
|
|
2
|
-
|
|
3
|
-
This repository supports GitHub Copilot CLI and the Copilot Coding Agent through checked-in repository instructions.
|
|
4
|
-
|
|
5
|
-
## Primary instruction sources
|
|
6
|
-
|
|
7
|
-
1. Follow `AGENTS.md` as the main operating model.
|
|
8
|
-
2. Use `plugin/meta/agdf-runtime-contract.md` for repeated gate, quality-contract, and closeout output rules when this repository also contains the AGDF runtime files.
|
|
9
|
-
3. Reuse the AGDF skill names as prompt entrypoints: `agdf-gate-check`, `agdf-brownfield-analysis`, `agdf-task-plan-review`, `agdf-clean-implementation-review`, `agdf-qa-gate`, `agdf-release-or`, `agdf-delivery-closeout`.
|
|
10
|
-
|
|
11
|
-
## Working mode
|
|
12
|
-
|
|
13
|
-
- Default to **Quick Task Mode** for small questions, reviews, debugging, and local fixes without new product semantics.
|
|
14
|
-
- Escalate to **Structured Delivery Mode** for new capabilities, architecture or policy changes, persistence changes, release-critical work, or formal artefacts.
|
|
15
|
-
|
|
16
|
-
## Copilot prompt entrypoints
|
|
17
|
-
|
|
18
|
-
Use natural-language prompts such as:
|
|
19
|
-
|
|
20
|
-
- `Run an AGDF gate check for this request.`
|
|
21
|
-
- `Perform an AGDF brownfield analysis before implementation.`
|
|
22
|
-
- `Review the completed work against the AGDF task plan expectations.`
|
|
23
|
-
- `Make the AGDF QA gate decision from the available evidence.`
|
|
24
|
-
|
|
25
|
-
## Rules
|
|
26
|
-
|
|
27
|
-
- Respect the gate order and exact approval formula from `AGENTS.md`.
|
|
28
|
-
- Do not treat implicit consent as approval.
|
|
29
|
-
- Prefer evidence over assumptions.
|
|
30
|
-
- In brownfield work, reuse before create and avoid silent parallel structures.
|
|
31
|
-
- After relevant work, include exactly one `Next step:` and exactly one `Quality outlook:`.
|