crbro-memory 2.9.0 → 2.10.0

package/dist/engine/cortex.js

@@ -12,8 +12,10 @@ const fs_js_1 = require("../utils/fs.js");
 const ids_js_1 = require("../utils/ids.js");
 const hash_js_1 = require("../utils/hash.js");
 const ops_js_1 = require("../sync/ops.js");
+const materialize_js_1 = require("../sync/materialize.js");
 const secrets_js_1 = require("./secrets.js");
 const shelf_js_1 = require("./shelf.js");
+const evidence_js_1 = require("./evidence.js");
 const TYPE_PREFIX_RE = /^(project_|tech_|lang_|person_|domain_|process_|protocol_)/;
 /**
  * Similarity above which a new fact is flagged as a near-duplicate of one
@@ -290,6 +292,10 @@ function earliestOf(a, b) {
 }
 function copyFact(f) {
     const out = { ...f };
+    if (f.reference)
+        out.reference = { ...f.reference };
+    if (f.verification)
+        out.verification = { ...f.verification, ...(f.verification.reference ? { reference: { ...f.verification.reference } } : {}) };
     if (f.keys)
         out.keys = [...f.keys];
     if (f.supersedes)
@@ -363,9 +369,7 @@ function unionNeuron(target, source) {
             delete hit.keys;
         // The later check is the newer evidence; the more volatile explicit class
         // wins, as in a team space (a needless warning is cheaper than a missing one).
-        const verificado = (0, shelf_js_1.latestOf)(hit.verified, sf.verified);
-        if (verificado)
-            hit.verified = verificado;
+        (0, evidence_js_1.mergeFactEvidence)(hit, sf);
         const vida = (0, shelf_js_1.mostVolatile)(hit.shelf_life, sf.shelf_life);
         if (vida)
             hit.shelf_life = vida;
@@ -444,22 +448,10 @@ function unionNeuron(target, source) {
         neuron.entry_status = estadosVivos;
     else
         delete neuron.entry_status;
-    const verificadas = { ...(source.entry_verified || {}) };
-    for (const [k, v] of Object.entries(target.entry_verified || {})) {
-        const l = (0, shelf_js_1.latestOf)(verificadas[k], v);
-        if (l)
-            verificadas[k] = l;
-        else if (!verificadas[k])
-            verificadas[k] = v;
-    }
-    const verificadasVivas = {};
-    for (const k of Object.keys(verificadas).sort())
-        if (vivos.has(k))
-            verificadasVivas[k] = verificadas[k];
-    if (Object.keys(verificadasVivas).length)
-        neuron.entry_verified = verificadasVivas;
-    else
-        delete neuron.entry_verified;
+    // Usar ambos pares originales: una fecha nueva y una fuente vieja no se mezclan.
+    neuron.entry_verified = target.entry_verified;
+    neuron.entry_verification = target.entry_verification;
+    (0, evidence_js_1.mergeEntryEvidence)(neuron, source, vivos);
     const origenes = { ...(source.entry_source || {}), ...(target.entry_source || {}) };
     const origenesVivos = {};
     for (const k of Object.keys(origenes).sort())
@@ -578,33 +570,28 @@ class Cortex {
             await this.emitter(neuronId, change);
         }
         catch {
-            // Sharing must never break a local write. The note can be re-emitted
-            // later; a lost fact cannot be recovered.
+            // El emisor solo falla si no logró registrar la entrega persistente.
+            // La nota local sigue guardada, pero no se puede confirmar éxito total.
+            throw new Error('Local change saved, but shared delivery could not be recorded. Check local storage before retrying.');
         }
     }
     /**
-     * Overwrite a neuron with the result of merging the team's notes.
-     * Only the sync layer calls this, and only with a neuron that already
-     * contains everything local plus whatever arrived.
+     * Fusionar contra la versión leída dentro del mismo bloqueo de escritura.
+     * Un snapshot calculado antes del bloqueo puede borrar un learn o retiro.
      */
-    async replaceFromSync(neuron) {
-        const saved = await (0, fs_js_1.updateJSON)(this.brain.paths.neuron(neuron.id), current => {
-            // Local-only observations stay local: they describe this machine's use
-            // of the memory, not the knowledge itself.
-            if (current) {
-                neuron.heat = current.heat;
-                neuron.access_count = current.access_count;
-                neuron.last_accessed = current.last_accessed;
-                neuron.summary = current.summary || neuron.summary;
-                neuron.preferences = current.preferences;
-                neuron.connections = current.connections;
-                neuron.created = current.created;
-            }
+    async mergeFromSync(nid, ops) {
+        let report;
+        let created = false;
+        const saved = await (0, fs_js_1.updateJSON)(this.brain.paths.neuron(nid), current => {
+            created = current === null;
+            const merged = (0, materialize_js_1.applyOps)(current, ops, { id: nid });
+            report = merged.report;
+            const neuron = merged.neuron;
             return neuron;
         });
-        const final = (saved || neuron);
-        await this.reindex(final);
-        return final;
+        if (saved)
+            await this.reindex(saved);
+        return { report, created };
     }
     async reindex(neuron) {
         if (!this.indexer)
@@ -739,6 +726,8 @@ class Cortex {
      * Creates the neuron if it does not exist.
      */
     async learn(topic, type, content, options) {
+        const reference = options?.reference === undefined ? undefined : (0, evidence_js_1.sanitizeReference)(options.reference);
+        const temporal = (0, evidence_js_1.sanitizeTemporal)(options?.temporal);
         // Credentials never make it to disk. The sentence around them survives, so
         // "the deploy token is [REDACTED: npm token]" still records that a token
         // exists and what kind — the knowledge without the liability.
@@ -776,9 +765,7 @@ class Cortex {
         let updatedInPlace = false;
         let confirmations;
         let shelf;
-        let reconfirmed = false;
         let shelfLengthened = false;
-        let verificar = null;
         const vidaPedida = (0, shelf_js_1.isShelfLife)(options?.shelfLife) ? options.shelfLife : undefined;
         let skippedRetired = null;
         // A retired decision, pattern, error or debt must not come back through
@@ -883,23 +870,21 @@ class Cortex {
                                 cambiado = true;
                             }
                         }
-                        // Saying the same line again, and nothing else, is a check
-                        // (shelf life): the clock restarts. Not when the call also
-                        // brings keywords, a confidence or a class — that is editing the
-                        // line, and the server itself asks for exactly that re-learn to
-                        // add keywords, so counting it would mark an unchecked line as
-                        // checked. Not for the miner either: re-reading an old
-                        // transcript is not looking at the source.
-                        if (options?.source !== 'miner' && !cambiado) {
-                            existente.verified = (0, fs_js_1.now)();
-                            reconfirmed = true;
-                            // One op per line per session: a retry or the re-save after a
-                            // compaction must not add a line to the team's log each time.
-                            const yaVerificadas = (this.tally.verifiedEmitted ??= new Set());
-                            if (!yaVerificadas.has(testigo)) {
-                                yaVerificadas.add(testigo);
-                                verificar = { eid: existente.id || (0, hash_js_1.factId)(existente.text), at: existente.verified };
-                            }
+                        const referenceChanged = reference && JSON.stringify(reference) !== JSON.stringify(existente.reference);
+                        const temporalChanged = temporal && temporal !== existente.temporal;
+                        if (referenceChanged || temporalChanged) {
+                            const previous = (0, evidence_js_1.mergeCheck)(existente, {});
+                            existente.verification_invalidated_at = new Date(Math.max(Date.now(), Date.parse(previous.verified || '') || 0, Date.parse(previous.verification_invalidated_at || '') || 0)).toISOString();
+                            delete existente.verified;
+                            delete existente.verification;
+                        }
+                        if (referenceChanged) {
+                            existente.reference = reference;
+                            cambiado = true;
+                        }
+                        if (temporalChanged) {
+                            existente.temporal = temporal;
+                            cambiado = true;
                         }
                         if (cambiado) {
                             // Note for shared neurons: materialize takes max(conf) and
@@ -907,10 +892,17 @@ class Cortex {
                             // stays local. Documented, not fought — the log is append-only.
                             updatedInPlace = true;
                             this.tally.topics.add(n.id);
-                            emitir = { kind: 'fact', text: existente.text, fid: existente.id || id,
-                                conf: existente.confidence ?? 1, at: existente.added, src: existente.source, keys: existente.keys,
-                                ...(existente.shelf_life ? { shelf: existente.shelf_life } : {}) };
                         }
+                        // Un intento anterior pudo guardar la neurona pero fallar antes
+                        // de persistir su entrega. Reemitir permite recuperarla incluso
+                        // tras reiniciar; applyOps deduplica por fid. No es verificación
+                        // nueva y conserva la fecha original, no la del reintento.
+                        emitir = { kind: 'fact', text: existente.text, fid: existente.id || id,
+                            conf: existente.confidence ?? 1, at: existente.added, src: existente.source, keys: existente.keys,
+                            ...(existente.reference ? { reference: existente.reference } : {}),
+                            ...(existente.temporal ? { temporal: existente.temporal } : {}),
+                            ...(existente.verification_invalidated_at ? { verification_invalidated_at: existente.verification_invalidated_at } : {}),
+                            ...(existente.shelf_life ? { shelf: existente.shelf_life } : {}) };
                         const sv = (0, shelf_js_1.shelfOfFact)(existente);
                         shelf = { shelf_life: sv.shelf, inferred: sv.inferred, ...(sv.reason ? { reason: sv.reason } : {}) };
                     }
@@ -939,6 +931,10 @@ class Cortex {
                             fact.keys = keys;
                         if (vidaPedida)
                             fact.shelf_life = vidaPedida;
+                        if (reference)
+                            fact.reference = reference;
+                        if (temporal)
+                            fact.temporal = temporal;
                         const sv = (0, shelf_js_1.shelfOfFact)(fact);
                         shelf = { shelf_life: sv.shelf, inferred: sv.inferred, ...(sv.reason ? { reason: sv.reason } : {}) };
                         n.facts.push(fact);
@@ -948,6 +944,8 @@ class Cortex {
                         this.tally.topics.add(n.id);
                         emitir = { kind: 'fact', text: content, fid: id,
                             conf: fact.confidence, at: fact.added, src: fact.source, keys: fact.keys,
+                            ...(fact.reference ? { reference: fact.reference } : {}),
+                            ...(fact.temporal ? { temporal: fact.temporal } : {}),
                             ...(fact.shelf_life ? { shelf: fact.shelf_life } : {}) };
                     }
                     break;
@@ -975,8 +973,8 @@ class Cortex {
                         n.patterns.push(content);
                         fechar(n, content);
                         origen(n, content);
-                        emitir = { kind: 'pattern', text: content, at: (0, fs_js_1.now)() };
                     }
+                    emitir = { kind: 'pattern', text: content, at: n.entry_dates?.[(0, ops_js_1.entryId)(content)] || (0, fs_js_1.now)() };
                     break;
                 }
                 case 'preference': {
@@ -996,8 +994,8 @@ class Cortex {
                         fechar(n, content);
                         origen(n, content);
                         this.tally.topics.add(n.id);
-                        emitir = { kind: 'error', text: content, at: (0, fs_js_1.now)() };
                     }
+                    emitir = { kind: 'error', text: content, at: n.entry_dates?.[(0, ops_js_1.entryId)(content)] || (0, fs_js_1.now)() };
                     break;
                 }
                 case 'debt': {
@@ -1010,8 +1008,8 @@ class Cortex {
                         fechar(n, content);
                         origen(n, content);
                         this.tally.topics.add(n.id);
-                        emitir = { kind: 'debt', text: content, at: (0, fs_js_1.now)() };
                     }
+                    emitir = { kind: 'debt', text: content, at: n.entry_dates?.[(0, ops_js_1.entryId)(content)] || (0, fs_js_1.now)() };
                     break;
                 }
             }
@@ -1036,17 +1034,12 @@ class Cortex {
         // key and the least likely to be worth sharing.
         if (emitir)
             await this.emit(final.id, emitir);
-        // A reconfirming re-learn reaches the team as a check: the latest wins.
-        const v = verificar;
-        if (v)
-            await this.emit(final.id, { kind: 'verify', eid: v.eid, ekind: 'fact', at: v.at });
         return {
             neuron: final, action, superseded, supersedes_unmatched: supersedesUnmatched,
             near_duplicates: nearDuplicates, redacted: limpio.found,
             duplicate, updated_in_place: updatedInPlace, skipped_retired: null,
             ...(confirmations !== undefined ? { confirmations } : {}),
             ...(shelf ? { shelf } : {}),
-            ...(reconfirmed ? { reconfirmed } : {}),
             ...(shelfLengthened ? { shelf_lengthened: true } : {}),
         };
     }
@@ -1114,6 +1107,8 @@ class Cortex {
      * clock restarts too: the fact is shared, and so is the world it describes.
      */
     async verify(neuronRef, targets) {
+        // Validar antes de cualquier escritura, incluida la creación de neuronas.
+        const evidence = (0, evidence_js_1.makeVerification)(targets.evidence, (0, fs_js_1.now)());
         const facts = (targets.facts || []).filter(t => typeof t === 'string');
         const entries = (targets.entries || []).filter(t => typeof t === 'string');
         const neuron = (await this.peek(neuronRef)) || (await this.findByName(neuronRef));
@@ -1143,10 +1138,13 @@ class Cortex {
                 }
                 for (const f of vivos) {
                     f.id = f.id || (0, hash_js_1.factId)(f.text);
-                    f.verified = cuando;
+                    // Un check explícito posterior al cambio debe sobrevivir incluso
+                    // cuando ambas llamadas caben en el mismo milisegundo.
+                    f.verified = new Date(Math.max(Date.parse(cuando), (Date.parse(f.verification_invalidated_at || '') || 0) + 1)).toISOString();
+                    f.verification = { ...evidence, at: f.verified };
                     if (!verified.includes(f.id))
                         verified.push(f.id);
-                    emitir.push({ eid: f.id, ekind: 'fact', at: cuando });
+                    emitir.push({ eid: f.id, ekind: 'fact', at: f.verified, verification: f.verification });
                 }
             }
             const candidatas = [
@@ -1168,9 +1166,10 @@ class Cortex {
                 for (const c of vivas) {
                     const k = (0, ops_js_1.entryId)(c.text);
                     (n.entry_verified ||= {})[k] = cuando;
+                    (n.entry_verification ||= {})[k] = { ...evidence, at: cuando };
                     if (!verified.includes(k))
                         verified.push(k);
-                    emitir.push({ eid: k, ekind: 'entry', at: cuando });
+                    emitir.push({ eid: k, ekind: 'entry', at: cuando, verification: n.entry_verification[k] });
                 }
             }
             if (verified.length === 0)
@@ -1539,6 +1538,17 @@ class Cortex {
         const backup = await this.quarantine(found);
         let removed = 0;
         const wanted = targets.map(t => t.trim().toLowerCase());
+        // An entry goes when a target names its text or its id: the entryId the
+        // neuron index and recall show, or a decision's own id. Until 2.9.1 only
+        // facts matched by id, so taking a credential out of a preference meant
+        // pasting the credential back into the conversation to name it.
+        const matches = (text, ownId) => {
+            const t = (text || '').trim().toLowerCase();
+            if (!t)
+                return false;
+            return wanted.includes(t) || wanted.includes((0, ops_js_1.entryId)(text).toLowerCase())
+                || (!!ownId && wanted.includes(ownId.toLowerCase()));
+        };
         const after = await (0, fs_js_1.updateJSON)(this.brain.paths.neuron(found.id), current => {
             if (!current)
                 return null;
@@ -1555,16 +1565,16 @@ class Cortex {
             });
             // Decisions, patterns and preferences too. A credential is no less
             // exposed for sitting in one of those, and nothing else could remove it.
-            current.decisions = current.decisions.filter(d => !wanted.includes((d.text || '').trim().toLowerCase()));
-            current.patterns = current.patterns.filter(p => !wanted.includes((p || '').trim().toLowerCase()));
-            current.preferences = current.preferences.filter(p => !wanted.includes((p || '').trim().toLowerCase()));
+            current.decisions = current.decisions.filter(d => !matches(d.text, d.id));
+            current.patterns = current.patterns.filter(p => !matches(p));
+            current.preferences = current.preferences.filter(p => !matches(p));
             const erroresAntes = (current.errors || []).length;
             if (current.errors) {
-                current.errors = current.errors.filter(e => !wanted.includes((e || '').trim().toLowerCase()));
+                current.errors = current.errors.filter(e => !matches(e));
             }
             const deudasAntes = (current.debts || []).length;
             if (current.debts) {
-                current.debts = current.debts.filter(d => !wanted.includes((d || '').trim().toLowerCase()));
+                current.debts = current.debts.filter(d => !matches(d));
             }
             let mapaBorrado = 0;
             if (current.map && wanted.includes(current.map.text.trim().toLowerCase())) {
@@ -1608,6 +1618,15 @@ class Cortex {
                 if (Object.keys(current.entry_verified).length === 0)
                     delete current.entry_verified;
             }
+            if (current.entry_verification) {
+                const vivos = liveEntryKeys(current);
+                for (const k of Object.keys(current.entry_verification)) {
+                    if (!vivos.has(k))
+                        delete current.entry_verification[k];
+                }
+                if (Object.keys(current.entry_verification).length === 0)
+                    delete current.entry_verification;
+            }
             // And for provenance: a forgotten teammate line that comes back through
             // a sync replay must be labelled by that replay, not by a stale key.
             if (current.entry_source) {
@@ -1637,22 +1656,22 @@ class Cortex {
                 }
             }
             for (const d of found.decisions || []) {
-                if (wanted.includes((d.text || '').trim().toLowerCase())) {
+                if (matches(d.text, d.id)) {
                     await this.emit(found.id, { kind: 'decision_purge', key: (0, ops_js_1.entryId)(d.text), at: cuando });
                 }
             }
             for (const p of found.patterns || []) {
-                if (wanted.includes((p || '').trim().toLowerCase())) {
+                if (matches(p)) {
                     await this.emit(found.id, { kind: 'pattern_purge', key: (0, ops_js_1.entryId)(p), at: cuando });
                 }
             }
             for (const e of found.errors || []) {
-                if (wanted.includes((e || '').trim().toLowerCase())) {
+                if (matches(e)) {
                     await this.emit(found.id, { kind: 'error_purge', key: (0, ops_js_1.entryId)(e), at: cuando });
                 }
             }
             for (const d of found.debts || []) {
-                if (wanted.includes((d || '').trim().toLowerCase())) {
+                if (matches(d)) {
                     await this.emit(found.id, { kind: 'debt_purge', key: (0, ops_js_1.entryId)(d), at: cuando });
                 }
             }
@@ -1792,18 +1811,24 @@ class Cortex {
      */
     async emitAdded(antes, final) {
         const cuando = (0, fs_js_1.now)();
-        const teniaFact = new Set(antes.facts.map(f => f.id || (0, hash_js_1.factId)(f.text)));
+        const teniaFact = new Map(antes.facts.map(f => [f.id || (0, hash_js_1.factId)(f.text), f]));
         for (const f of final.facts) {
             const fid = f.id || (0, hash_js_1.factId)(f.text);
-            if (teniaFact.has(fid))
-                continue;
-            await this.emit(final.id, { kind: 'fact', text: f.text, fid, conf: f.confidence ?? 1, at: f.added, src: f.source, keys: f.keys,
-                ...(f.shelf_life ? { shelf: f.shelf_life } : {}) });
-            if (f.verified)
-                await this.emit(final.id, { kind: 'verify', eid: fid, ekind: 'fact', at: f.verified });
+            const previo = teniaFact.get(fid) || antes.facts.find(p => (0, ops_js_1.normalizeText)(p.text) === (0, ops_js_1.normalizeText)(f.text));
+            const metadata = (v) => JSON.stringify([v.keys, v.shelf_life, v.reference, v.temporal, v.verification_invalidated_at]);
+            if (!previo || metadata(previo) !== metadata(f)) {
+                await this.emit(final.id, { kind: 'fact', text: f.text, fid, conf: f.confidence ?? 1, at: f.added, src: f.source, keys: f.keys,
+                    ...(f.reference ? { reference: f.reference } : {}), ...(f.temporal ? { temporal: f.temporal } : {}),
+                    ...(f.verification_invalidated_at ? { verification_invalidated_at: f.verification_invalidated_at } : {}),
+                    ...(f.shelf_life ? { shelf: f.shelf_life } : {}) });
+            }
+            if (f.verified && (previo?.verified !== f.verified || JSON.stringify(previo?.verification) !== JSON.stringify(f.verification))) {
+                await this.emit(final.id, { kind: 'verify', eid: fid, ekind: 'fact', at: f.verified,
+                    ...(f.verification ? { verification: f.verification } : {}) });
+            }
             // A moved fact that was already retired must arrive retired, or the
             // teammates would see as current what the source had superseded.
-            if (f.status === 'superseded' || f.status === 'retracted') {
+            if (previo?.status !== f.status && (f.status === 'superseded' || f.status === 'retracted')) {
                 await this.emit(final.id, { kind: 'status', fid, to: f.status, at: f.revised || cuando, why: f.revision_note });
             }
         }
@@ -1831,9 +1856,10 @@ class Cortex {
         }
         // Checks of decisions and patterns that arrived with them, or are newer than the target's.
         for (const [k, at] of Object.entries(final.entry_verified || {})) {
-            if (antes.entry_verified?.[k] === at)
+            if (antes.entry_verified?.[k] === at && JSON.stringify(antes.entry_verification?.[k]) === JSON.stringify(final.entry_verification?.[k]))
                 continue;
-            await this.emit(final.id, { kind: 'verify', eid: k, ekind: 'entry', at });
+            await this.emit(final.id, { kind: 'verify', eid: k, ekind: 'entry', at,
+                ...(final.entry_verification?.[k] ? { verification: final.entry_verification[k] } : {}) });
         }
         // Preferences are never emitted, here as in learn.
     }
@@ -1880,6 +1906,7 @@ class Cortex {
             entry_dates: { ...(from.entry_dates || {}) },
             entry_status: { ...(from.entry_status || {}) },
             entry_verified: { ...(from.entry_verified || {}) },
+            entry_verification: structuredClone(from.entry_verification || {}),
         };
         delete parte.map;
         const textos = [