craft-native 0.0.175 → 0.0.177

package/dist/ios/templates/CraftHybrid.swift

@@ -421,6 +421,16 @@ final class CraftHybrid: NSObject {
         #endif
     }
 
+    #if DEBUG
+    /// The crash reporter's debug-only test (`-CraftCrashTest js`): an
+    /// uncaught error thrown in the app script, as a real one would be.
+    func debugThrowInAppScript(_ message: String) {
+        if appScript == nil { startAppScript() }
+        let literal = (try? JSONSerialization.data(withJSONObject: [message])).flatMap { String(data: $0, encoding: .utf8) } ?? "[\"test\"]"
+        appScript?.evaluateScript("(function crashReporterTest() { throw new TypeError(\(literal)[0]); })()")
+    }
+    #endif
+
     /// The shell is up: what waited for it.
     func shellReady() {
         guard let controller else { return }

package/dist/ios/templates/CraftNativeActions.swift

@@ -82,6 +82,8 @@ enum CraftNativeActions {
         // which the native Video element plays in place of the address.
         values.append("media")
         if config.enableCamera { values.append("camera") }
+        // craft.crashReporter: the app's crash and error reporter (bughq).
+        if config.crashReporting?.key.isEmpty == false { values.append("crashReporter") }
         return values
     }
 
@@ -108,6 +110,32 @@ enum CraftNativeActions {
         case "clipboardRead":
             guard config.enableClipboard else { return failure("CAPABILITY_DISABLED", "Clipboard is disabled") }
             return .success(UIPasteboard.general.string ?? "")
+        // Crash reporting (CraftCrashReporter.swift): on when the config names
+        // a bughq key. Each answers at once; delivery is the outbox's job.
+        case "crashReporterCapture":
+            guard CraftCrashReporter.shared.enabled else { return failure("CAPABILITY_DISABLED", "Crash reporting is not configured") }
+            guard let event = body["event"] as? [String: Any] else {
+                return failure("INVALID_ARGUMENT", "crashReporterCapture was called without the values it needs")
+            }
+            CraftCrashReporter.shared.capture(event)
+            return .success(true)
+        case "crashReporterSetUser":
+            guard CraftCrashReporter.shared.enabled else { return failure("CAPABILITY_DISABLED", "Crash reporting is not configured") }
+            CraftCrashReporter.shared.setUser(body["id"] as? String)
+            return .success(true)
+        case "crashReporterAddBreadcrumb":
+            guard CraftCrashReporter.shared.enabled else { return failure("CAPABILITY_DISABLED", "Crash reporting is not configured") }
+            guard let crumb = body["breadcrumb"] as? [String: Any] else {
+                return failure("INVALID_ARGUMENT", "crashReporterAddBreadcrumb was called without the values it needs")
+            }
+            CraftCrashReporter.shared.addBreadcrumb(crumb)
+            return .success(true)
+        case "crashReporterFlush":
+            guard CraftCrashReporter.shared.enabled else { return failure("CAPABILITY_DISABLED", "Crash reporting is not configured") }
+            CraftCrashReporter.shared.requestFlush()
+            return .success(true)
+        case "crashReporterContext":
+            return .success(CraftCrashReporter.shared.context())
         default:
             return nil
         }
@@ -134,6 +162,16 @@ enum CraftNativeActions {
         switch (module, method) {
         case ("Device", "getInfo"):
             sync = perform(action: "getDeviceInfo", body: [:], config: config)
+        case ("CrashReporter", "capture"):
+            sync = perform(action: "crashReporterCapture", body: ["event": args.first ?? NSNull()], config: config)
+        case ("CrashReporter", "setUser"):
+            sync = perform(action: "crashReporterSetUser", body: ["id": args.first ?? NSNull()], config: config)
+        case ("CrashReporter", "addBreadcrumb"):
+            sync = perform(action: "crashReporterAddBreadcrumb", body: ["breadcrumb": args.first ?? NSNull()], config: config)
+        case ("CrashReporter", "flush"):
+            sync = perform(action: "crashReporterFlush", body: [:], config: config)
+        case ("CrashReporter", "context"):
+            sync = perform(action: "crashReporterContext", body: [:], config: config)
         case ("Haptics", "impact"):
             sync = perform(action: "haptic", body: ["style": args.first ?? NSNull()], config: config)
         case ("Haptics", "notification"):
@@ -575,9 +613,15 @@ enum CraftNativeActions {
             cancellationLock.unlock()
             if let error = error {
                 let code = (error as? URLError)?.code == .timedOut ? "TIMEOUT" : "NETWORK_ERROR"
+                if (error as? URLError)?.code != .cancelled {
+                    CraftCrashReporter.shared.requestFailed(method: method, url: url, status: nil, error: code)
+                }
                 complete(requestToken, failure(code, error.localizedDescription), completion)
                 return
             }
+            if let http = response as? HTTPURLResponse, http.statusCode >= 400 {
+                CraftCrashReporter.shared.requestFailed(method: method, url: url, status: http.statusCode, error: nil)
+            }
             guard let http = response as? HTTPURLResponse else {
                 complete(requestToken, failure("NETWORK_ERROR", "fetch received a response that is not HTTP"), completion)
                 return
@@ -1236,13 +1280,17 @@ final class CraftNativePasskeys: NSObject, ASAuthorizationControllerDelegate, AS
         guard let request = pending.removeValue(forKey: key) else { return }
         controllers.removeValue(forKey: request.requestToken)
         if let registration = authorization.credential as? ASAuthorizationPlatformPublicKeyCredentialRegistration {
+            guard let attestationObject = registration.rawAttestationObject else {
+                request.completion(.failure(CraftNativeActionError(code: "PASSKEY_FAILED", message: "Apple returned a registration without an attestation object")))
+                return
+            }
             request.completion(.success([
                 "id": Self.base64url(registration.credentialID),
                 "rawId": Self.base64url(registration.credentialID),
                 "type": "public-key",
                 "response": [
                     "clientDataJSON": Self.base64url(registration.rawClientDataJSON),
-                    "attestationObject": Self.base64url(registration.rawAttestationObject),
+                    "attestationObject": Self.base64url(attestationObject),
                 ],
             ]))
             return

package/dist/ios/templates/CraftNativeFlatList.swift

@@ -219,15 +219,20 @@ final class CraftNativeFlatList: UICollectionView, UICollectionViewDelegateFlowL
     }
 
     func setContentContainerStyle(_ raw: [String: Any]?) {
-        func number(_ value: Any?) -> CGFloat? { (value as? NSNumber).map { CGFloat(truncating: $0) } }
-        let padding = number(raw?["padding"]) ?? 0
-        let horizontal = number(raw?["paddingHorizontal"]) ?? padding
-        let vertical = number(raw?["paddingVertical"]) ?? padding
+        func nonNegative(_ value: Any?) -> CGFloat? {
+            guard let number = value as? NSNumber else { return nil }
+            let points = CGFloat(truncating: number)
+            guard points.isFinite, points >= 0 else { return nil }
+            return points
+        }
+        let padding = nonNegative(raw?["padding"]) ?? 0
+        let horizontal = nonNegative(raw?["paddingHorizontal"]) ?? padding
+        let vertical = nonNegative(raw?["paddingVertical"]) ?? padding
         contentInset = UIEdgeInsets(
-            top: number(raw?["paddingTop"]) ?? vertical,
-            left: number(raw?["paddingLeft"]) ?? horizontal,
-            bottom: number(raw?["paddingBottom"]) ?? vertical,
-            right: number(raw?["paddingRight"]) ?? horizontal
+            top: nonNegative(raw?["paddingTop"]) ?? vertical,
+            left: nonNegative(raw?["paddingLeft"]) ?? horizontal,
+            bottom: nonNegative(raw?["paddingBottom"]) ?? vertical,
+            right: nonNegative(raw?["paddingRight"]) ?? horizontal
         )
         scrollIndicatorInsets = contentInset
         collectionViewLayout.invalidateLayout()
@@ -265,14 +270,24 @@ final class CraftNativeFlatList: UICollectionView, UICollectionViewDelegateFlowL
 
     @objc private func keyboardTap() {
         guard keyboardShouldPersistTaps != "always" else { return }
-        if keyboardShouldPersistTaps == "handled" {
-            let point = keyboardTapGesture.location(in: self)
-            var hit = hitTest(point, with: nil)
-            while let view = hit, view !== self {
-                if view is UIControl || !(view.gestureRecognizers ?? []).isEmpty { return }
-                hit = view.superview
-            }
+        let point = keyboardTapGesture.location(in: self)
+        var hit = hitTest(point, with: nil)
+        var onControl = false
+        var onButton = false
+        while let view = hit, view !== self {
+            if view is UIButton { onButton = true }
+            if view is UIControl || !(view.gestureRecognizers ?? []).isEmpty { onControl = true; break }
+            hit = view.superview
         }
+        if keyboardShouldPersistTaps == "handled", onControl { return }
+        // A button keeps the keyboard: its press gives the focus straight
+        // back. Ending editing first only let the keyboard's inset go while
+        // the finger was down, the button moved out from under it, and the
+        // press was lost.
+        if onButton { return }
+        // Otherwise the keyboard goes; after a tap on nothing, for good (the
+        // next render must not bring the last input back).
+        if !onControl { craftScreenController?.forgetFocusedInput() }
         window?.endEditing(true)
     }
 
@@ -443,19 +458,6 @@ final class CraftNativeFlatList: UICollectionView, UICollectionViewDelegateFlowL
         onMomentumScrollEnd?(scrollView)
     }
 
-    func collectionView(
-        _ collectionView: UICollectionView,
-        layout collectionViewLayout: UICollectionViewLayout,
-        sizeForItemAt indexPath: IndexPath
-    ) -> CGSize {
-        guard items.indices.contains(indexPath.item) else { return CGSize(width: bounds.width, height: 44) }
-        let item = items[indexPath.item]
-        if flowLayout.scrollDirection == .horizontal {
-            return CGSize(width: 44, height: itemExtent(isChrome: item.isChrome))
-        }
-        return CGSize(width: itemExtent(isChrome: item.isChrome), height: 44)
-    }
-
     private func evaluateEndReached() {
         guard !isApplyingSnapshot, pendingApply == nil,
               let endReached = endReached,

package/dist/ios/templates/CraftNativeMutation.swift

@@ -305,7 +305,7 @@ final class CraftNativeMutationDocument {
     static let containerTypes: Set<String> = [
         "View", "SafeAreaView", "ScrollView", "KeyboardAvoidingView", "Modal", "Pressable",
         "TouchableOpacity", "TouchableHighlight", "ImageBackground", "FlatList", "SectionList",
-        "Fragment", "Svg", "G",
+        "Fragment", "Svg", "G", "Map",
     ]
     private static let containerTypeKeys = Set(containerTypes.map { $0.lowercased() })