cozy-ui 130.6.0 → 130.6.1

package/CHANGELOG.md

@@ -1,3 +1,10 @@
+## [130.6.1](https://github.com/cozy/cozy-ui/compare/v130.6.0...v130.6.1) (2025-10-06)
+
+
+### Bug Fixes
+
+* **AddModal/ContactForm:** Custom label now display correctly unsupported label ([8f81a8a](https://github.com/cozy/cozy-ui/commit/8f81a8a))
+
 # [130.6.0](https://github.com/cozy/cozy-ui/compare/v130.5.0...v130.6.0) (2025-10-02)
 
 

package/CODEOWNERS

@@ -1,2 +1,2 @@
 # General code owners
-*       @JF-Cozy @Merkur39 @Ldoppea @zatteo
+*       @JF-Cozy @rezk2ll @zatteo

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "cozy-ui",
-  "version": "130.6.0",
+  "version": "130.6.1",
   "description": "Cozy apps UI SDK",
   "main": "./index.js",
   "bin": {

package/react/Contacts/AddModal/ContactForm/formValuesToContact.spec.js

@@ -117,6 +117,12 @@ describe('formValuesToContact', () => {
           primary: false,
           type: undefined,
           label: undefined
+        },
+        {
+          label: 'Mobile',
+          number: '0876467998',
+          primary: false,
+          type: 'mobile'
         }
       ],
       relationships: {

package/react/Contacts/AddModal/ContactForm/helpers.js

@@ -271,12 +271,17 @@ export const removeField = (fields, index) => {
 export const makeCustomLabel = (value, t) => {
   const { type, label } = JSON.parse(value)
 
+  const isSupportedLabel = ['home', 'work'].includes(label)
+
   const firstString = type || ''
-  const secondString = label
-    ? type
-      ? ` (${t(`Contacts.AddModal.ContactForm.label.${label}`)})`.toLowerCase()
-      : `label.${label}`
-    : ''
+  const secondString =
+    label && isSupportedLabel
+      ? type
+        ? ` (${t(
+            `Contacts.AddModal.ContactForm.label.${label}`
+          )})`.toLowerCase()
+        : `label.${label}`
+      : ''
 
   return firstString + secondString || null
 }

package/react/Contacts/AddModal/ContactForm/helpers.spec.js

@@ -1,10 +1,45 @@
+import get from 'lodash/get'
+
 import {
   moveToHead,
   makeItemLabel,
   makeTypeAndLabel,
   makeImppValues,
+  makeCustomLabel,
   makeInitialCustomValue
 } from './helpers'
+import { locales } from './locales'
+
+const t = x => get(locales.en, x)
+
+describe('makeCustomLabel', () => {
+  it('should return custom type and supported label', () => {
+    const resForWork = makeCustomLabel('{"type":"someType","label":"work"}', t)
+    expect(resForWork).toBe('someType (pro)')
+
+    const resForHome = makeCustomLabel('{"type":"someType","label":"home"}', t)
+    expect(resForHome).toBe('someType (personal)')
+  })
+
+  it('should return label if no type', () => {
+    const resForWork = makeCustomLabel('{"label":"work"}', t)
+    expect(resForWork).toBe('label.work')
+
+    const resForHome = makeCustomLabel('{"label":"home"}', t)
+    expect(resForHome).toBe('label.home')
+  })
+
+  it('should return only custom type if label is not supported or undefined', () => {
+    const resForNotSupported = makeCustomLabel(
+      '{"type":"someType","label":"someLabel"}',
+      t
+    )
+    expect(resForNotSupported).toBe('someType')
+
+    const resForUndefined = makeCustomLabel('{"type":"someType"}', t)
+    expect(resForUndefined).toBe('someType')
+  })
+})
 
 describe('moveToHead function', () => {
   it('should move an item to head of the array', () => {

package/react/Contacts/AddModal/mocks.js

@@ -86,6 +86,12 @@ export const johnDoeContact = {
     {
       number: '+33 6 77 11 22 33',
       primary: false
+    },
+    {
+      label: 'Mobile', // could be this when importing from other sources i.e. google
+      number: '0876467998',
+      primary: false,
+      type: 'mobile'
     }
   ]
 }
@@ -156,6 +162,11 @@ export const johnDoeFormValues = {
       fieldId: 'fieldId_6',
       phone: '+33 6 77 11 22 33',
       phoneLabel: undefined
+    },
+    {
+      fieldId: 'fieldId_7',
+      phone: '0876467998',
+      phoneLabel: '{"type":"mobile","label":"Mobile"}'
     }
   ],
   givenName: 'John',

package/transpiled/react/Contacts/AddModal/ContactForm/helpers.js

@@ -278,8 +278,9 @@ export var makeCustomLabel = function makeCustomLabel(value, t) {
       type = _JSON$parse.type,
       label = _JSON$parse.label;
 
+  var isSupportedLabel = ['home', 'work'].includes(label);
   var firstString = type || '';
-  var secondString = label ? type ? " (".concat(t("Contacts.AddModal.ContactForm.label.".concat(label)), ")").toLowerCase() : "label.".concat(label) : '';
+  var secondString = label && isSupportedLabel ? type ? " (".concat(t("Contacts.AddModal.ContactForm.label.".concat(label)), ")").toLowerCase() : "label.".concat(label) : '';
   return firstString + secondString || null;
 };
 /**

package/transpiled/react/Contacts/AddModal/mocks.d.ts

@@ -66,10 +66,17 @@ export namespace johnDoeContact {
         export const version: number;
     }
     const note: string;
-    const phone: {
+    const phone: ({
         number: string;
         primary: boolean;
-    }[];
+        label?: undefined;
+        type?: undefined;
+    } | {
+        label: string;
+        number: string;
+        primary: boolean;
+        type: string;
+    })[];
 }
 export namespace johnDoeFormValues {
     const birthday_1: string;
@@ -126,11 +133,15 @@ export namespace johnDoeFormValues {
         emailLabel: string;
     })[];
     export { email_1 as email };
-    const phone_1: {
+    const phone_1: ({
         fieldId: string;
         phone: string;
         phoneLabel: undefined;
-    }[];
+    } | {
+        fieldId: string;
+        phone: string;
+        phoneLabel: string;
+    })[];
     export { phone_1 as phone };
     const givenName_1: string;
     export { givenName_1 as givenName };

package/transpiled/react/Contacts/AddModal/mocks.js

@@ -71,6 +71,12 @@ export var johnDoeContact = {
   }, {
     number: '+33 6 77 11 22 33',
     primary: false
+  }, {
+    label: 'Mobile',
+    // could be this when importing from other sources i.e. google
+    number: '0876467998',
+    primary: false,
+    type: 'mobile'
   }]
 };
 export var johnDoeFormValues = {
@@ -130,6 +136,10 @@ export var johnDoeFormValues = {
     fieldId: 'fieldId_6',
     phone: '+33 6 77 11 22 33',
     phoneLabel: undefined
+  }, {
+    fieldId: 'fieldId_7',
+    phone: '0876467998',
+    phoneLabel: '{"type":"mobile","label":"Mobile"}'
   }],
   givenName: 'John',
   additionalName: 'J.',