cozy-sharing 6.0.6 → 7.0.1

package/src/components/WhoHasAccess.jsx

@@ -1,13 +1,14 @@
-import React from 'react'
 import PropTypes from 'prop-types'
-import Recipient from './Recipient/Recipient'
-import LinkRecipient from './Recipient/LinkRecipient'
+import React from 'react'
+
 import { useI18n } from 'cozy-ui/transpiled/react/I18n'
 import List from 'cozy-ui/transpiled/react/MuiCozyTheme/List'
 
-import { filterAndReworkRecipients } from '../helpers/recipients'
-import { usePrevious } from '../helpers/hooks'
+import LinkRecipient from './Recipient/LinkRecipient'
 import OwnerRecipient from './Recipient/OwnerRecipient'
+import Recipient from './Recipient/Recipient'
+import { usePrevious } from '../helpers/hooks'
+import { filterAndReworkRecipients } from '../helpers/recipients'
 
 /**
  * Displays a warning if some contacts are waiting for confirmation of their sharing

package/src/components/WhoHasAccessLight.jsx

@@ -1,8 +1,8 @@
-import React from 'react'
 import cx from 'classnames'
-import RecipientWithoutStatus from './Recipient/RecipientWithoutStatus'
-import RecipientPlusX from './Recipient/RecipientPlusX'
+import React from 'react'
 
+import RecipientPlusX from './Recipient/RecipientPlusX'
+import RecipientWithoutStatus from './Recipient/RecipientWithoutStatus'
 import styles from './recipient.styl'
 
 const MAX_DISPLAYED_RECIPIENTS = 2

package/src/components/useFetchDocumentPath.jsx

@@ -1,4 +1,5 @@
 import { useState, useEffect } from 'react'
+
 import { fetchFilesPaths } from '../helpers/files'
 
 export const useFetchDocumentPath = (client, document) => {

package/src/getSharedDocument.js

@@ -1,15 +1,23 @@
-import get from 'lodash/get'
+import { isReadOnly } from 'cozy-client/dist/models/permission'
 
+/**
+ * Get the first shared document for the current shared token
+ *
+ * @param {CozyClient} client
+ * @returns {{id, isReadOnly}} id of the document and the readOnly status
+ */
 const getSharedDocument = async client => {
   const { data: permissionsData } = await client
     .collection('io.cozy.permissions')
     .getOwnPermissions()
 
-  const permissions = permissionsData.attributes.permissions
+  const permissions = Object.values(permissionsData.attributes.permissions)
   // permissions contains several named keys, but the one to use depends on the situation. Using the first one is what we want in all known cases.
-  const sharedDocumentId = get(Object.values(permissions), '0.values.0')
-
-  return sharedDocumentId
+  const perm = permissions[0]
+  return {
+    id: perm.values[0],
+    isReadOnly: isReadOnly(perm)
+  }
 }
 
 export default getSharedDocument

package/src/getSharedDocument.spec.js

@@ -1,7 +1,7 @@
 import getSharedDocument from './getSharedDocument'
 
-describe('Getting the shared document id', () => {
-  const mockClient = {
+function setupClient(verbs = []) {
+  return {
     collection: () => ({
       getOwnPermissions: jest.fn().mockReturnValue({
         data: {
@@ -9,14 +9,14 @@ describe('Getting the shared document id', () => {
             permissions: {
               collection: {
                 type: 'io.cozy.photos.albums',
-                verbs: ['GET'],
+                verbs,
                 values: ['myshareid']
               },
               files: {
                 selector: 'referenced_by',
                 type: 'io.cozy.files',
                 values: ['io.cozy.photos.albums/myshareid'],
-                verbs: ['GET']
+                verbs
               }
             }
           }
@@ -24,9 +24,30 @@ describe('Getting the shared document id', () => {
       })
     })
   }
+}
 
+describe('Getting the shared document', () => {
   it('should get the id', async () => {
-    const id = await getSharedDocument(mockClient)
+    const client = setupClient(['GET'])
+    const { id } = await getSharedDocument(client)
     expect(id).toEqual('myshareid')
   })
+
+  it('should return isReadOnly is true when we have only a GET permission', async () => {
+    const client = setupClient(['GET'])
+    const { isReadOnly } = await getSharedDocument(client)
+    expect(isReadOnly).toBeTruthy()
+  })
+
+  it('should return isReadOnly is false when we have an ALL permission', async () => {
+    const client = setupClient(['ALL'])
+    const { isReadOnly } = await getSharedDocument(client)
+    expect(isReadOnly).toBeFalsy()
+  })
+
+  it('should return isReadOnly is false when we have a PATCH permission', async () => {
+    const client = setupClient(['GET', 'PATCH', 'PUT'])
+    const { isReadOnly } = await getSharedDocument(client)
+    expect(isReadOnly).toBeFalsy()
+  })
 })

package/src/helpers/permissions.js

@@ -1,4 +1,5 @@
 import get from 'lodash/get'
+
 import { models } from 'cozy-client'
 
 export const checkIsReadOnlyPermissions = permissions => {

package/src/helpers/sharings.js

@@ -1,12 +1,11 @@
 import { Q } from 'cozy-client'
 
+import { fetchFilesPaths } from './files'
 import {
   updateInternalObjectFromRealtime,
   normalizeDocFromRealtime
 } from './realtime'
-
 import { addSharing, updateSharing } from '../state'
-import { fetchFilesPaths } from './files'
 
 export const getSharingObject = (internalSharing, sharing) => {
   if (internalSharing) {

package/src/helpers/successMessage.js

@@ -1,5 +1,6 @@
-import { Contact } from '../models'
 import { models } from 'cozy-client'
+
+import { Contact } from '../models'
 export const countNewRecipients = (currentRecipients, newRecipients) => {
   return newRecipients.filter(contact => {
     const email = models.contact.getPrimaryEmail(contact)

package/src/index.jsx

@@ -1,6 +1,6 @@
+import SharingProvider from './SharingProvider'
 import SharingContext from './context'
 import withLocales from './withLocales'
-import SharingProvider from './SharingProvider'
 
 export default SharingProvider
 

package/src/state.js

@@ -349,18 +349,14 @@ const getApps = state => state.apps
 
 export const hasSharedParent = (state, documentPath) => {
   if (!state.sharedPaths) {
-    // eslint-disable-next-line
-    console.log('hasSharedParent should not occur', state, documentPath)
-    return false
+    return false // hasSharedParent should not occur
   }
   return state.sharedPaths.some(path => documentPath.indexOf(`${path}/`) === 0)
 }
 
 export const hasSharedChild = (state, documentPath) => {
   if (!state.sharedPaths) {
-    // eslint-disable-next-line
-    console.log('hasSharedChild should not occur', state, documentPath)
-    return false
+    return false // hasSharedChild should not occur
   }
   const ret = state.sharedPaths.some(
     path => path.indexOf(`${documentPath}/`) === 0

package/src/state.spec.js

@@ -16,7 +16,6 @@ import reducer, {
   getPermissionDocIds,
   getDocumentSharingType
 } from './state'
-
 import {
   SHARING_1,
   SHARING_2,

package/src/withLocales.jsx

@@ -1,4 +1,5 @@
 import React from 'react'
+
 import { I18n, translate } from 'cozy-ui/transpiled/react/I18n'
 
 const locales = {

package/test/AppLike.jsx

@@ -1,8 +1,8 @@
 import React from 'react'
 
-import { BreakpointsProvider } from 'cozy-ui/transpiled/react/hooks/useBreakpoints'
-import { I18n } from 'cozy-ui/transpiled/react/I18n'
 import { CozyProvider, createMockClient } from 'cozy-client'
+import { I18n } from 'cozy-ui/transpiled/react/I18n'
+import { BreakpointsProvider } from 'cozy-ui/transpiled/react/hooks/useBreakpoints'
 
 import langEn from '../locales/en.json'